Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 442012 - Allocating more than 2GB of memory in mozilla is never a good idea. On 64-bit systems PRSize and size_t are 64-bit and so truncation from PRSize to PRUint32 could cause weird behavior errors. Prevent these huge allocations. r=wtc sr+a=dveditz for 1.9.0

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@255713 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
benjamin%smedbergs.us 2009-01-05 21:08:08 +00:00
parent 8575d7b1f7
commit fb151b04b6
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mozilla/xpcom/base/nsMemoryImpl.cpp
View File

@ -278,6 +278,9 @@ nsMemoryImpl::sFlushEvent;
XPCOM_API(void*)
NS_Alloc(PRSize size)
{
if (size > PR_INT32_MAX)
return nsnull;
void* result = MALLOC1(size);
if (! result) {
// Request an asynchronous flush
@ -289,6 +292,9 @@ NS_Alloc(PRSize size)
XPCOM_API(void*)
NS_Realloc(void* ptr, PRSize size)
{
if (size > PR_INT32_MAX)
return nsnull;
void* result = REALLOC1(ptr, size);
if (! result && size != 0) {
// Request an asynchronous flush