Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 376049: Remove validateCanChangeAttachment() from attachment.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=LpSolit

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@222662 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
lpsolit%gmail.com 2007-03-30 22:42:22 +00:00
parent 8b871e75df
commit fe58db6798
1 changed files with 2 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
mozilla/webtools/bugzilla/attachment.cgi
View File

@ -205,22 +205,6 @@ sub validateContext
return $context;
}
sub validateCanChangeAttachment
{
my ($attachid) = @_;
my $dbh = Bugzilla->dbh;
my ($productid) = $dbh->selectrow_array(
"SELECT product_id
FROM attachments
INNER JOIN bugs
ON bugs.bug_id = attachments.bug_id
WHERE attach_id = ?", undef, $attachid);
Bugzilla->user->can_edit_product($productid)
|| ThrowUserError("illegal_attachment_edit",
{ attach_id => $attachid });
}
sub validateCanChangeBug
{
my ($bugid) = @_;
@ -600,7 +584,7 @@ sub update
my $bug = new Bugzilla::Bug($bugid);
my $attachment = Bugzilla::Attachment->get($attach_id);
$attachment->validate_can_edit($bug->product_id);
validateCanChangeAttachment($attach_id);
validateCanChangeBug($bugid);
Bugzilla::Attachment->validate_description(THROW_ERROR);
Bugzilla::Attachment->validate_is_patch(THROW_ERROR);
Bugzilla::Attachment->validate_content_type(THROW_ERROR) unless $cgi->param('ispatch');
@ -775,7 +759,7 @@ sub delete_attachment {
# Make sure the administrator is allowed to edit this attachment.
my ($attach_id, $bug_id) = validateID();
my $attachment = Bugzilla::Attachment->get($attach_id);
validateCanChangeAttachment($attach_id);
validateCanChangeBug($bug_id);
$attachment->datasize || ThrowUserError('attachment_removed');