Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing tree blocker. nsInstallFolder did not return an error code when

Browse Source 
it could not initialize itself.  This caused crashes and return values which
were not correct.  I also fixed a huge about of memory leaks for allocation
of strings that were never freed.  r=dveditz, a=leaf.


git-svn-id: svn://10.0.0.236/trunk@67001 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
dougt%netscape.com
2000-04-24 22:23:44 +00:00
parent 8237a54fdd
commit ff1dd2ab65
10 changed files with 244 additions and 179 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
mozilla/xpinstall/src/nsJSFile.cpp
View File

@@ -1040,15 +1040,15 @@ InstallFileOpFileWindowsShortcut(JSContext *cx, JSObject *obj, uintN argc, jsval
ConvertJSValToStr(b0, cx, argv[0]);
NS_NewLocalFile(b0.ToNewCString(), getter_AddRefs(nsfsB0));
NS_NewLocalFile(nsAutoCString(b0), getter_AddRefs(nsfsB0));
ConvertJSValToStr(b1, cx, argv[1]);
NS_NewLocalFile(b1.ToNewCString(), getter_AddRefs(nsfsB1));
NS_NewLocalFile(nsAutoCString(b1), getter_AddRefs(nsfsB1));
ConvertJSValToStr(b2, cx, argv[2]);
ConvertJSValToStr(b3, cx, argv[3]);
NS_NewLocalFile(b3.ToNewCString(), getter_AddRefs(nsfsB3));
NS_NewLocalFile(nsAutoCString(b3), getter_AddRefs(nsfsB3));
ConvertJSValToStr(b4, cx, argv[4]);
ConvertJSValToStr(b5, cx, argv[5]);
NS_NewLocalFile(b5.ToNewCString(), getter_AddRefs(nsfsB5));
NS_NewLocalFile(nsAutoCString(b5), getter_AddRefs(nsfsB5));
if(JSVAL_IS_NULL(argv[6]))
{