From ff3fecd26fcda9e68fa32a306fb417e1f5edb955 Mon Sep 17 00:00:00 2001 From: "dbaron%dbaron.org" Date: Mon, 29 Dec 2003 16:39:50 +0000 Subject: [PATCH] Add a correct comment. git-svn-id: svn://10.0.0.236/trunk@150767 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/content/html/style/src/nsHTMLStyleSheet.cpp | 5 +++++ mozilla/layout/style/nsHTMLStyleSheet.cpp | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/mozilla/content/html/style/src/nsHTMLStyleSheet.cpp b/mozilla/content/html/style/src/nsHTMLStyleSheet.cpp index cbfc383bafc..c277792eec2 100644 --- a/mozilla/content/html/style/src/nsHTMLStyleSheet.cpp +++ b/mozilla/content/html/style/src/nsHTMLStyleSheet.cpp @@ -251,6 +251,11 @@ ProcessTableRulesAttribute(nsStyleStruct* aStyleStruct, // XXX It appears that the style system erronously applies the custom style rule after css style, // consequently it does not properly fit into the casade. For now, assume that a border style of none // implies that the style has not been set. + // XXXldb No, there's nothing wrong with the style system. The problem + // is that the author of all these table rules made them work as + // post-resolve callbacks, which is an override mechanism that was meant + // to be used for other things. They should instead map their rule data + // normally (see nsIStyleRule.h). if (NS_STYLE_BORDER_STYLE_NONE == borderStyle) { // use the table's border style if it is dashed or dotted, otherwise use solid PRUint8 bStyle = ((NS_STYLE_BORDER_STYLE_NONE != tableBorderStyle) && diff --git a/mozilla/layout/style/nsHTMLStyleSheet.cpp b/mozilla/layout/style/nsHTMLStyleSheet.cpp index cbfc383bafc..c277792eec2 100644 --- a/mozilla/layout/style/nsHTMLStyleSheet.cpp +++ b/mozilla/layout/style/nsHTMLStyleSheet.cpp @@ -251,6 +251,11 @@ ProcessTableRulesAttribute(nsStyleStruct* aStyleStruct, // XXX It appears that the style system erronously applies the custom style rule after css style, // consequently it does not properly fit into the casade. For now, assume that a border style of none // implies that the style has not been set. + // XXXldb No, there's nothing wrong with the style system. The problem + // is that the author of all these table rules made them work as + // post-resolve callbacks, which is an override mechanism that was meant + // to be used for other things. They should instead map their rule data + // normally (see nsIStyleRule.h). if (NS_STYLE_BORDER_STYLE_NONE == borderStyle) { // use the table's border style if it is dashed or dotted, otherwise use solid PRUint8 bStyle = ((NS_STYLE_BORDER_STYLE_NONE != tableBorderStyle) &&