141 Commits

Author SHA1 Message Date
sspitzer%mozilla.org
c4c466714a fix for bug #409301: Visiting bookmark is recorded as link transition instead of bookmark transition
additionally, make it so visits from any history UI (url bar, history menu,
history queries in the history sidebar, personal toolbar folder and
places organizer) are recorded as "typed" transitions.

r=dietrich a=this-bug-blocks-a-firefox-3-+ blocker


git-svn-id: svn://10.0.0.236/trunk@242136 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-28 01:54:00 +00:00
dietrich%mozilla.com
02259f2d26 Bug 398914 Creating an additional bookmark with "Add a keyword for this search" overwrites the POST_DATA of existing bookmark(s) with the same location (r=sspitzer)
git-svn-id: svn://10.0.0.236/trunk@240479 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-05 01:56:56 +00:00
sspitzer%mozilla.org
4bd64f3a25 relanding fix for bug #406094, as it was not the cause of the Ts / Txul regression.
git-svn-id: svn://10.0.0.236/trunk@240447 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-04 22:04:51 +00:00
sspitzer%mozilla.org
9d265b882f backing out fix for bug #406094 until dietrich's backout clears so that we can clearly measure that this change did not impact Ts / Txul. s=dmose
git-svn-id: svn://10.0.0.236/trunk@240440 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-04 20:09:53 +00:00
dietrich%mozilla.com
a65d8ef011 Backing out bug 398914
git-svn-id: svn://10.0.0.236/trunk@240439 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-04 19:44:47 +00:00
sspitzer%mozilla.org
eb5375f1ae fix for bug #406094: removing places.sqlite manually (or having it corrupted) and restarting leaves me without a personal toolbar, without a bookmarks menu, and with a blank organize
relanding with changes that impact Ts / Txul

patch=Marco Bonardo <mak77@supereva.it>
r=sspitzer
a=schrep for 1.9


git-svn-id: svn://10.0.0.236/trunk@240437 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-04 19:26:56 +00:00
dietrich%mozilla.com
4b1664b02d Bug 398914 Creating an additional bookmark with "Add a keyword for this search" overwrites the POST_DATA of existing bookmark(s) with the same location (r=sspitzer)
git-svn-id: svn://10.0.0.236/trunk@240426 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-04 18:34:48 +00:00
reed%reedloden.com
c70a80b9e1 Backing out patch from bug 406094 due to perf regression.
git-svn-id: svn://10.0.0.236/trunk@240407 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-04 11:22:14 +00:00
sspitzer%mozilla.org
e02996aa9b fix for bug #406094: removing places.sqlite manually (or having it corrupted) and restarting leaves me without a personal toolbar, without a bookmarks menu, and with a blank organize
patch=Marco Bonardo <mak77@supereva.it>
r=sspitzer
a=schrep for 1.9


git-svn-id: svn://10.0.0.236/trunk@240398 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-04 08:08:37 +00:00
sspitzer%mozilla.org
f3e0f4249e backing out.
git-svn-id: svn://10.0.0.236/trunk@240397 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-04 08:07:15 +00:00
sspitzer%mozilla.org
c9f6f834da *** empty log message ***
git-svn-id: svn://10.0.0.236/trunk@240396 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-04 08:03:27 +00:00
mozilla.mano%sent.com
51ee60d957 Bug 390739 - Redo menu item is greyed out in Bookmarks Organizer (was: doesn't work when deleting items and undoing in Bookmarks Manager). r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@240249 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-02 20:08:25 +00:00
mozilla.mano%sent.com
724572bb22 Bug 404884 (along with bug 399800) - Add "Show All History" command to the history menu. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@239934 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-26 19:04:23 +00:00
bugzilla%standard8.plus.com
62b4183f4d Bug 374347 nsIClipboard uses the deprecated nsISupportsArray interface. r=roc,Neil,sspitzer,sr=roc,a=mtschrep
git-svn-id: svn://10.0.0.236/trunk@239735 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-20 19:06:32 +00:00
mozilla.mano%sent.com
0ea7e72b56 Bug 387746 - New Left Pane for Places Organizer, along with other places back-end and front-end changes; also fixes bugs 393547, 395994, 401075, 403141. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@239684 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-20 02:01:57 +00:00
reed%reedloden.com
3d7c64b900 Bug 385273 - "add bookmark button disabled in the "Add Bookmark" dialog if there is no scheme on the url" [p=florian r=Mano a=blocking-firefox3+]
git-svn-id: svn://10.0.0.236/trunk@239262 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-13 05:24:55 +00:00
mozilla.mano%sent.com
9ab84a82ef Bug 399729 - Reduce places viewa performance overhead. This also fixes bugs 397117, 399472, 400738 and likely also 399476. r=sspitzer, a=blocking-m9/beltzner.
git-svn-id: svn://10.0.0.236/trunk@238124 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-25 02:02:29 +00:00
mozilla.mano%sent.com
09777fb442 Bug 399930 - Optimize PlacesUtils getters. r+a=mconnor.
git-svn-id: svn://10.0.0.236/trunk@237962 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-20 20:40:16 +00:00
mozilla.mano%sent.com
9d6f9079de Backing out bug 399930.
git-svn-id: svn://10.0.0.236/trunk@237836 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-17 00:14:46 +00:00
mozilla.mano%sent.com
d64c49e4d5 Bug 399930 - Optimize PlacesUtils. r+a=mconnor.
git-svn-id: svn://10.0.0.236/trunk@237805 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-16 01:05:56 +00:00
sspitzer%mozilla.org
d80cf82d80 fix for bug #387996: add a "Places" folder to the bookmarks menu, populated with smart folders
fix for bug #387734:  add a "Places" folder to the bookmarks toolbar, populated with smart folders
fix for bug #385826:  pre-populated places queries
fix for bug #396807:  have "top 10 most visited sites" as a pre-populated smart folder
fix for bug #385831:  Investigate dependencies for Most Used Tags query
fix for bug #378799:  GROUP_BY_FOLDER only works in simple bookmark-folder queries

thanks to dietrich for the initial GROUP_BY_FOLDER patch.

r=dietrich,mano  a=blocking-firefox-3+


git-svn-id: svn://10.0.0.236/trunk@237575 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-11 06:42:42 +00:00
sayrer%gmail.com
0f7cef883d Bug 398398. Unable to Reload Live Bookmarks. r=dietrich, a=mconnor
git-svn-id: svn://10.0.0.236/trunk@237213 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-03 21:46:16 +00:00
sayrer%gmail.com
bd406981e5 Bug 398300. Places utils.js instantiates livemark service on startup, but could avoid it. r=mano, a=beltzner
git-svn-id: svn://10.0.0.236/trunk@237169 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-03 07:12:40 +00:00
mozilla.mano%sent.com
d2f2277947 Bug 387749 - add an item detail pane to the organizer. r=dietrich (r=gavin for editable-menulist changes). a=mconnor.
git-svn-id: svn://10.0.0.236/trunk@236478 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-21 22:57:19 +00:00
dietrich%mozilla.com
961a027bb6 Bug 395082 Assertion when right clicking in the Bookmarks Manager, open in tabs disabled for folders in the left hand pane of the organizer (r=sspitzer)
git-svn-id: svn://10.0.0.236/trunk@236477 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-21 22:48:23 +00:00
sspitzer%mozilla.org
1746b52594 fix for bug #390747: POST keyword bookmarks stop working after a restart
r=dietrich


git-svn-id: svn://10.0.0.236/trunk@236386 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-20 19:17:11 +00:00
mozilla.mano%sent.com
1235618fb4 Improve places command updating performance, part 1. Bug 394695, r=dietrich, a=mconnor.
git-svn-id: svn://10.0.0.236/trunk@236300 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-19 08:13:20 +00:00
mozilla.mano%sent.com
3aac9752c2 Bug 396300 - Put unfiled-bookmarks under their own root. r=dietirch, a=mconnor.
git-svn-id: svn://10.0.0.236/trunk@236075 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-17 01:42:16 +00:00
sspitzer%mozilla.org
0ed805b687 fix for bug #394527: livemark feed URIs should show up as "bookmarked" (gold star on) in the url bar and in url bar autocomplete search results
for performance:

when searching previous autocomplete results, we don't need to regenerate the hash tables (of livemark item ids and livemark feed URIs).

when searching previous autocomplete results, if we find any, tell the front end immediately, instead of waiting for our first db query to return.

r=dietrich, a=mconnor for m8


git-svn-id: svn://10.0.0.236/trunk@235388 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-07 21:47:22 +00:00
mozilla.mano%sent.com
b01ca48ed7 Bug 175124 - improve open in tabs behaviour (see comment 26), this also enables 'Open All in Tabs' for host nodes in the history sidebar (bug 369919) and for saved searches (queries), patch by mconnor and me.
git-svn-id: svn://10.0.0.236/trunk@233749 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-02 19:03:24 +00:00
sspitzer%mozilla.org
cc7ee030a2 fix for bug #393887: Star icon shouldn't be set for items in RSS / Live Bookmarks.
r=dietrich


git-svn-id: svn://10.0.0.236/trunk@233527 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-01 00:04:23 +00:00
mozilla.mano%sent.com
f8270d4e58 Bug 385266 - New starring, bookmarking and tagging UI, changes noted in comment 333. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@233242 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-28 21:47:44 +00:00
mozilla.mano%sent.com
5c952a118d Bug 393924 - Stop setting the bookmarkFeedURI annotation on livemark children. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@233175 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-28 00:35:58 +00:00
dietrich%mozilla.com
23172e5083 Bug 382639 bookmark toolbar change not reflected in UI (for stevewon@gmail.com, r=dietrich)
git-svn-id: svn://10.0.0.236/trunk@232983 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-23 22:24:34 +00:00
gavin%gavinsharp.com
3eef6c31df Bug 386789: create JSON utilities module and use it for search suggest/sessionstore/Places, patch by Simon Bünzli <zeniko@gmail.com>, r=sspitzer, sr+a=brendan
git-svn-id: svn://10.0.0.236/trunk@232853 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-22 14:49:34 +00:00
mozilla.mano%sent.com
cdfb1c7ab4 Bug 385266 - New starring, bookmarking and tagging UI, further work. Make Bookmark This Page/Frame/Link use the new panel. r=dietirch.
git-svn-id: svn://10.0.0.236/trunk@232257 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-17 07:22:13 +00:00
mozilla.mano%sent.com
e375b3f374 Bug 385266 - New starring, bookmarking and tagging UI. This is work-in-progress and not yet enabled for anything but the star button itself. Smart folders are not yet hooked up either. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@232193 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-16 01:15:54 +00:00
sspitzer%mozilla.org
fa56ff36c1 fix for bug #388111: copy and paste from bookmarks into notepad.exe, and we lose newlines
patch=Christine Yen <christineyen+bugs@gmail.com>
r=sspitzer


git-svn-id: svn://10.0.0.236/trunk@231803 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-10 15:50:15 +00:00
mozilla.mano%sent.com
c3341133ab Bug 382877 - dynamic containers implementation, part 1. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@231344 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-02 20:19:45 +00:00
mozilla.mano%sent.com
3273adeb35 Bug 388337 - Pasting a folder which contains sub-folders fails. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@230236 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-18 21:39:23 +00:00
mozilla.mano%sent.com
c1f7c6e654 Bug 376004 - Places Transactions must not live in the window global scope. patch by Steve Won and me.
git-svn-id: svn://10.0.0.236/trunk@229991 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-15 09:44:58 +00:00
sspitzer%mozilla.org
e0348197a8 fix for bug #378558: Organize Bookmarks - paste doesn't work after cut
includes fixes for:

bug #341953:  unable to paste links into the organize bookmarks dialog
bug #383044:  Drag-and-drop bookmark creation should support meta-data
bug #385381:  Paste doesn't work in the bookmarks Manager during copy if item is modified between copy and paste

r=sspitzer


git-svn-id: svn://10.0.0.236/trunk@229933 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-14 00:25:26 +00:00
philringnalda%gmail.com
76f9b5f5dc Bug 387833 - Cannot add keyword bookmark (because (get|set)PageAnnotationString is noscript now), r=mano
git-svn-id: svn://10.0.0.236/trunk@229791 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-12 06:05:15 +00:00
sspitzer%mozilla.org
abb38fb8cd code cleanup for bug #387203: getFolderContents() returns the root result node instead of the result itself.
r=mano


git-svn-id: svn://10.0.0.236/trunk@229779 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-12 01:18:20 +00:00
mozilla.mano%sent.com
664937a8c7 Bug 331654 - Provide a way to handle annotations values in a type-agnostic way. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@229693 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-11 09:58:00 +00:00
sspitzer%mozilla.org
03df119a57 fix for bug #386705: Description field of new bookmark is not populated even though it has <META name="description" content="...">
fix by=Marco Bonardo <mak77@supereva.it>

r=sspitzer


git-svn-id: svn://10.0.0.236/trunk@229247 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-03 15:39:33 +00:00
mozilla.mano%sent.com
729e8cd6fe Bug 382888 - BM menu not working when DM is focused. r=gavin.
git-svn-id: svn://10.0.0.236/trunk@227845 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-12 05:24:58 +00:00
mozilla.mano%sent.com
57b8e2ccb4 Bug 381534 - cannot drag and drop url from location bar to bookmarks toolbar. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@227565 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-05 23:24:39 +00:00
mozilla.mano%sent.com
ae0c91963c Bug 374613 - the context menu of places bookmarks with live titles is missing the 'reload' option. patch from Steve Won <swon@mozilla.com>, r=me, a=mconnor.
git-svn-id: svn://10.0.0.236/trunk@227358 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-01 00:39:10 +00:00
dietrich%mozilla.com
0f12467f54 Bug 380232 occasionally not able to open the bookmarks dialog or subscribe to a feed url (using live bookmarks) [Remote chrome not allowed] (r=mano)
git-svn-id: svn://10.0.0.236/trunk@227343 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-31 19:13:15 +00:00