180 Commits

Author SHA1 Message Date
wtc%google.com
025fac7cf1 Bug 742162: Allow CertificateRequest to have an empty
certificate_authorities list.  The patch is contributed by Eric Rescorla
<ekr@rtfm.com>.  r=wtc,bsmith,rrelyea.
Modified Files:
	ssl3con.c sslerr.h


git-svn-id: svn://10.0.0.236/trunk@263794 18797224-902f-48f8-a5cc-f745e15eee43
2012-05-08 00:10:56 +00:00
wtc%google.com
078da745a4 Bug 749841: Reject Diffie-Hellman generators and public values equal to
zero or one.  The bug was reported by Nikos Mavrogiannopoulos.  The patch
was contributed by Adam Langley <agl@chromium.org>.  r=wtc.


git-svn-id: svn://10.0.0.236/trunk@263762 18797224-902f-48f8-a5cc-f745e15eee43
2012-04-27 23:38:13 +00:00
gerv%gerv.net
f465fa7d7e Bug 716563 - update license to MPL 2. r=rrelyea.
git-svn-id: svn://10.0.0.236/trunk@263750 18797224-902f-48f8-a5cc-f745e15eee43
2012-04-25 14:50:19 +00:00
wtc%google.com
f218517d65 Bug 540535: Don't call ss->sec.uncache() if the SSL_NO_CACHE option is
enabled.  Patch contributed by Alexei Volkov <alvolkov.bgs@gmail.com> and
Eric Rescorla <ekr@rtfm.com>.  r=wtc.


git-svn-id: svn://10.0.0.236/trunk@263646 18797224-902f-48f8-a5cc-f745e15eee43
2012-04-06 01:30:35 +00:00
wtc%google.com
39e8820abe Bug 681065: Implement DTLS (Datagram TLS) 1.0. The patch is contributed by
Eric Rescorla <ekr@rtfm.com>.  r=wtc.
Modified Files:
	SSLerrs.h derive.c manifest.mn ssl.def ssl.h ssl3con.c
	ssl3gthr.c ssl3prot.h sslcon.c ssldef.c sslerr.h sslgathr.c
	sslimpl.h sslproto.h sslsecur.c sslsock.c sslt.h
Added Files:
	dtls1con.c


git-svn-id: svn://10.0.0.236/trunk@263637 18797224-902f-48f8-a5cc-f745e15eee43
2012-04-04 03:37:07 +00:00
wtc%google.com
1d16428221 Bug 565047: Block export cipher suites when TLS 1.1 is negotiated. The
patch is contributed by Brian Smith <bsmith@mozilla.com>.  r=wtc.
Modified Files:
	SSLerrs.h ssl3con.c sslerr.h


git-svn-id: svn://10.0.0.236/trunk@263634 18797224-902f-48f8-a5cc-f745e15eee43
2012-04-03 02:30:54 +00:00
wtc%google.com
352352e81e Bug 697910: ssl3_HandleHandshake should handle SECWouldBlock from
ssl3_HandleHandshakeMessage when the handshake message spans multiple TLS
records.  Patch by Brian Smith <bsmith@mozilla.com>.  r=wtc.


git-svn-id: svn://10.0.0.236/trunk@263633 18797224-902f-48f8-a5cc-f745e15eee43
2012-04-03 02:00:14 +00:00
wtc%google.com
ca681fddad Bug 571722: merge with the "Implement SSL Version Range API [v5]" patch by
Brian Smith <bsmith@mozilla.com>.  Comment changes only.  Export
SSL_VersionRangeGetDefault, SSL_VersionRangeGetSupported, and
SSL_VersionRangeSetDefault.  r=wtc.
Modified Files:
	ssl.def ssl.h ssl3con.c sslcon.c sslimpl.h sslsock.c


git-svn-id: svn://10.0.0.236/trunk@263579 18797224-902f-48f8-a5cc-f745e15eee43
2012-03-18 00:31:20 +00:00
wtc%google.com
e32a1aeb5a Bug 571722: add the SSLProtocolVariant enum type to indicate the byte
stream and datagram variants of SSL/TLS.  Add an SSLProtocolVariant
argument to the version range functions that don't take an fd.  The patch
is written by Brian Smith <bsmith@mozilla.com> and Eric Rescorla
<ekr@rtfm.com>.  r=wtc.
Modified Files:
	ssl.h ssl3con.c sslimpl.h sslsock.c sslt.h


git-svn-id: svn://10.0.0.236/trunk@263575 18797224-902f-48f8-a5cc-f745e15eee43
2012-03-16 01:23:55 +00:00
wtc%google.com
ca327be5b5 Bug 565047: have ssl3_HandleRecord send a bad_record_mac alert instead of
decode_error when the cipher text is shorter than an IV block.  Reduce
MAX_IV_LENGTH to 24 to match the size of IVs in ssl3SidKeys.  r=rrelyea.
Modified Files:
	ssl3con.c sslimpl.h


git-svn-id: svn://10.0.0.236/trunk@263570 18797224-902f-48f8-a5cc-f745e15eee43
2012-03-14 23:02:01 +00:00
wtc%google.com
55b2d61236 Bug 565047: Implement TLS 1.1, except for restrictions on export cipher
suites.  The patch is written by Brian Smith <bsmith@mozilla.com>.  r=wtc.
Modified Files:
	ssl3con.c sslimpl.h sslproto.h


git-svn-id: svn://10.0.0.236/trunk@263561 18797224-902f-48f8-a5cc-f745e15eee43
2012-03-13 02:39:11 +00:00
wtc%google.com
c40d150f71 Bug 571722: Implement SSL Version Range API. The patch is written by
Brian Smith <bsmith@mozilla.com>.  r=wtc.
Modified Files:
	SSLerrs.h ssl.def ssl.h ssl3con.c sslcon.c sslerr.h sslgathr.c
	sslimpl.h sslproto.h sslsock.c sslt.h


git-svn-id: svn://10.0.0.236/trunk@263554 18797224-902f-48f8-a5cc-f745e15eee43
2012-03-11 04:32:35 +00:00
wtc%google.com
ade9335c30 Bug 507359: Implement TLS keying material exporters. The patch is written
by Douglas Stebila <douglas@stebila.ca> and improved by Adam Langley
<agl@chromium.org>.  r=wtc.
Modified Files:
	ssl.def ssl.h ssl3con.c sslimpl.h sslinfo.c


git-svn-id: svn://10.0.0.236/trunk@263533 18797224-902f-48f8-a5cc-f745e15eee43
2012-03-07 01:27:40 +00:00
wtc%google.com
35ee8cc42f Bug 732258: ssl3_FinishHandshake cleanup. Fix the unused variable compiler
warning about 'rv' and simplify the conditional expression around the
ss->sec.cache call.  r=bsmith.


git-svn-id: svn://10.0.0.236/trunk@263520 18797224-902f-48f8-a5cc-f745e15eee43
2012-03-06 02:23:25 +00:00
wtc%google.com
eae9177a84 Bug 732630: Prefer SSL_RSA_WITH_RC4_128_SHA over SSL_RSA_WITH_RC4_128_MD5.
The change to the suiteInfo table in sslinfo.c is not necessary but is
made to keep that table in roughly the same order as the other two tables
in ssl3con.c and sslenum.c.  r=rrelyea.
Modified Files:
	ssl3con.c sslenum.c sslinfo.c


git-svn-id: svn://10.0.0.236/trunk@263519 18797224-902f-48f8-a5cc-f745e15eee43
2012-03-06 00:26:31 +00:00
wtc%google.com
c4ffa157f5 Bug 729380: add an emacs mode line to make mxr.mozilla.org display tabs
correctly.  Fix variable declarations in lib/ssl/ssl3con.c to not start
from column 0, which would confuse cvs diff -p.  r=kaie.


git-svn-id: svn://10.0.0.236/trunk@263475 18797224-902f-48f8-a5cc-f745e15eee43
2012-02-23 00:13:23 +00:00
kaie%kuix.de
8684f22723 Bug 713410, move variable declaration, r=jst, r=rrelyea
git-svn-id: svn://10.0.0.236/trunk@263438 18797224-902f-48f8-a5cc-f745e15eee43
2012-02-17 09:50:04 +00:00
kaie%kuix.de
6c980c7018 Bug 726315, followup from bug 542832, Patch contributed by Brian Smith, r=kaie
git-svn-id: svn://10.0.0.236/trunk@263415 18797224-902f-48f8-a5cc-f745e15eee43
2012-02-15 21:52:08 +00:00
kaie%kuix.de
f1f6b33c41 Bug 542832 - SSL_RestartHandshakeAfterServerCert is broken, patch by Brian Smith, r=rrelyea
git-svn-id: svn://10.0.0.236/trunk@263386 18797224-902f-48f8-a5cc-f745e15eee43
2012-02-11 13:03:08 +00:00
kaie%kuix.de
a80bdaa107 Bug 542832 - SSL_RestartHandshakeAfterServerCert is broken, patch by Brian Smith, r=rrelyea
git-svn-id: svn://10.0.0.236/trunk@263385 18797224-902f-48f8-a5cc-f745e15eee43
2012-02-11 12:58:48 +00:00
kaie%kuix.de
f0bd270bae Bug 542832 - SSL_RestartHandshakeAfterServerCert is broken, patch by Brian Smith, r=rrelyea
git-svn-id: svn://10.0.0.236/trunk@263384 18797224-902f-48f8-a5cc-f745e15eee43
2012-02-11 12:58:47 +00:00
kaie%kuix.de
9d33576904 Bug 542832 - SSL_RestartHandshakeAfterServerCert is broken, patch by Brian Smith, r=rrelyea
git-svn-id: svn://10.0.0.236/trunk@263382 18797224-902f-48f8-a5cc-f745e15eee43
2012-02-11 12:55:58 +00:00
bsmith%mozilla.com
9b720db9f7 Bug 700516: Remove SSL2 support for SSL_RestartHandshakeAfterServerCert and SSL_RestartHandshakeAfterCertReq, r=rrelyea
git-svn-id: svn://10.0.0.236/trunk@263089 18797224-902f-48f8-a5cc-f745e15eee43
2011-11-19 21:58:21 +00:00
bsmith%mozilla.com
24363aa2e6 Bug 651523: Remove step-up code, v4, removing EXPORT_VERSION build option, r=rrelyea
git-svn-id: svn://10.0.0.236/trunk@263080 18797224-902f-48f8-a5cc-f745e15eee43
2011-11-17 00:20:22 +00:00
kaie%kuix.de
51ddd562f1 Fix Tinderbox bustage, backout all patches from 2011-11-11
git-svn-id: svn://10.0.0.236/trunk@263077 18797224-902f-48f8-a5cc-f745e15eee43
2011-11-16 19:12:36 +00:00
bsmith%mozilla.com
4778bbc800 Bug 700516: Remove SSL2 support for SSL_RestartHandshakeAfterServerCert and SSL_RestartHandshakeAfterCertReq, r=rrelyea
git-svn-id: svn://10.0.0.236/trunk@263067 18797224-902f-48f8-a5cc-f745e15eee43
2011-11-11 19:06:52 +00:00
bsmith%mozilla.com
7a0edbfd6a Bug 651523 - Remove SSL step-up code from libssl and remove step-up extended key usage support, r=rrelyea
git-svn-id: svn://10.0.0.236/trunk@263066 18797224-902f-48f8-a5cc-f745e15eee43
2011-11-11 18:47:20 +00:00
bsmith%mozilla.com
0601ca68ad Bug 547312: Implement client-side support for NPN; original patch by agl r=wtc; changes by bsmith r=agl
git-svn-id: svn://10.0.0.236/trunk@263024 18797224-902f-48f8-a5cc-f745e15eee43
2011-10-29 00:29:11 +00:00
bsmith%mozilla.com
2e2793892a Bug 665814: Prevent chosen plaintext attacks on SSL 3.0 and TLS 1.0 connections, r=wtc, sr=rrelyea
git-svn-id: svn://10.0.0.236/trunk@262945 18797224-902f-48f8-a5cc-f745e15eee43
2011-10-01 03:59:54 +00:00
wtc%google.com
638601ef20 Bug 673477: Expose the error code set by CERT_ExtractPublicKey in
ssl3_VerifySignedHashes and ssl3_SendClientKeyExchange.  r=wtc.


git-svn-id: svn://10.0.0.236/trunk@262531 18797224-902f-48f8-a5cc-f745e15eee43
2011-07-26 02:13:37 +00:00
wtc%google.com
0f73ee0fe1 Bug 616757: in ssl3_SendCertificateVerify, we must destroy
ss->ssl3.clientPrivateKey for all key exchange algorithms, otherwise we
will send a Certificate message in renegotiation even if the renegotiation
doesn't request client auth.  Move the cleanup of clientCertChain and
clientPrivateKey from ssl3_HandleCertificateRequest to
ssl3_HandleServerHello as a second defense.  The patch is contributed by
Ryan Sleevi <ryan.sleevi@gmail.com>.  r=wtc.


git-svn-id: svn://10.0.0.236/trunk@261791 18797224-902f-48f8-a5cc-f745e15eee43
2011-01-22 02:25:06 +00:00
wtc%google.com
b41a67ad55 Bug 606049: Add the SSL peer's CA certificates to ss->ssl3.peerCertChain in
the correct order.  r=nelson.


git-svn-id: svn://10.0.0.236/trunk@261441 18797224-902f-48f8-a5cc-f745e15eee43
2010-10-21 17:31:36 +00:00
wtc%google.com
e1d2b6d850 Bug 587234: SSL_ERROR_WEAK_SERVER_KEY is renamed
SSL_ERROR_WEAK_SERVER_EPHEMERAL_DH_KEY to be specific about key type.
TBR=kaie.
Modified Files:
	cmd/lib/SSLerrs.h lib/ssl/ssl3con.c lib/ssl/sslerr.h


git-svn-id: svn://10.0.0.236/trunk@261157 18797224-902f-48f8-a5cc-f745e15eee43
2010-09-01 19:43:48 +00:00
nelson%bolyard.com
d36b5e1607 Bug 586697 - ssl3_DeriveMasterSecret must not request pVersion when it does
Master key derivation for Diffie-Hellman through pkcs11.
Patch contributed by Alexei Volkov <alexei.volkov.bugs@sun.com>, r=nelson


git-svn-id: svn://10.0.0.236/trunk@261124 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-28 18:22:07 +00:00
wtc%google.com
dc58ba1b0e Bug 588698: Add assertions to discover and enforce current locking order.
Based on patch contributed by Adam Langley of Google <agl@chromium.org>.
r=agl,nelson.
Modified Files:
	notes.txt ssl3con.c sslcon.c sslimpl.h sslsecur.c


git-svn-id: svn://10.0.0.236/trunk@261113 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-28 00:56:10 +00:00
wtc%google.com
07feacb99e Bug 587234: Better error reporting for tiny DH keys in Server Key Exchange.
Add a new error code SSL_ERROR_WEAK_SERVER_KEY for the dh_p size check in
ssl3_HandleServerKeyExchange.  r=nelson.
Modified Files:
	cmd/lib/SSLerrs.h lib/ssl/ssl3con.c lib/ssl/sslerr.h


git-svn-id: svn://10.0.0.236/trunk@261049 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-16 18:19:02 +00:00
wtc%google.com
2dc38c772f Bug 586470: Add 'const' to SEC_DerSignData and ssl3_UpdateHandshakeHashes.
Remove PK11_ImportPrivateKey.  r=emaldona.
Modified Files:
	cryptohi/cryptohi.h cryptohi/secsign.c pk11wrap/pk11pk12.c
	ssl/ssl3con.c


git-svn-id: svn://10.0.0.236/trunk@261027 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-12 01:15:38 +00:00
wtc%google.com
1e99b8cb20 Bug 525092: Support TLS false start. The patch is contributed by Adam
Langley of Google <agl@chromium.org>.  r=wtc.
Modified Files:
	cmd/strsclnt/strsclnt.c cmd/tstclnt/tstclnt.c lib/ssl/ssl.h
	lib/ssl/ssl3con.c lib/ssl/ssl3gthr.c lib/ssl/sslimpl.h
	lib/ssl/sslsecur.c lib/ssl/sslsock.c tests/ssl/sslstress.txt


git-svn-id: svn://10.0.0.236/trunk@260919 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-30 03:00:17 +00:00
wtc%google.com
2be3505cb6 Bug 571797: do not check block cipher padding if decryption failed. The
patch is contributed by Brian Smith <brian@briansmith.org>.  r=wtc.


git-svn-id: svn://10.0.0.236/trunk@260569 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-24 19:53:20 +00:00
nelson%bolyard.com
4cf2a89eea Bug 571797: NSS should not send the decryption_failed alert
Patch contributed by Brian Smith <brian@briansmith.org>, r=nelson


git-svn-id: svn://10.0.0.236/trunk@260550 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-24 09:24:18 +00:00
nelson%bolyard.com
536cc6effe Bug 571796: ssl3_HandleRecord should check all the padding bytes
Patch contributed by Brian Smith <brian@briansmith.org>, r=nelson


git-svn-id: svn://10.0.0.236/trunk@260486 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-18 06:25:42 +00:00
nelson%bolyard.com
7286c7e079 Bug 562434: SSL_ForceHandshake returns SECSuccess if the peer sends us an application data record
git-svn-id: svn://10.0.0.236/trunk@260432 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-06 22:30:02 +00:00
nelson%bolyard.com
a04e310e21 Bug 554354: SSL client doesn't validate ECDH params from server, r=rrelyea
git-svn-id: svn://10.0.0.236/trunk@260138 18797224-902f-48f8-a5cc-f745e15eee43
2010-04-03 19:06:23 +00:00
nelson%bolyard.com
c0b5e7332d Bug 415565: Use new NSPR atomic macros in NSS
Patch contributed by Steve Snyder <swsnyder@snydernet.net>, r=wtc


git-svn-id: svn://10.0.0.236/trunk@260135 18797224-902f-48f8-a5cc-f745e15eee43
2010-04-03 18:27:33 +00:00
wtc%google.com
88282f31d8 Bug 537356: Redefine SSL_RENEGOTIATE_CLIENT_ONLY as
SSL_RENEGOTIATE_TRANSITIONAL, changing its meaning for server sockets,  and
make it the default.  r=rrelyea.
Modified Files:
	ssl.h ssl3con.c sslsock.c


git-svn-id: svn://10.0.0.236/trunk@259722 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-17 02:29:08 +00:00
wtc%google.com
7438b8e95a Bug 537356: Rename SCSV. In the final RFC, the symbolic name of the SCSV
changed to TLS_EMPTY_RENEGOTIATION_INFO_SCSV.  r=christophe,rrelyea.
Modified Files:
	cmd/ssltap/ssltap.c lib/ssl/ssl.h lib/ssl/ssl3con.c
	lib/ssl/sslproto.h


git-svn-id: svn://10.0.0.236/trunk@259715 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-16 18:56:48 +00:00
wtc%google.com
13cd60e59c Bug 275744: Add new error code SSL_ERROR_RX_UNEXPECTED_UNCOMPRESSED_RECORD
when we detect missing compression.  The patch is contributed by Adam
Langley <agl@chromium.org>.  r=nelson,wtc.
Modified Files:
	cmd/lib/SSLerrs.h lib/ssl/ssl3con.c lib/ssl/sslerr.h


git-svn-id: svn://10.0.0.236/trunk@259586 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-03 03:44:29 +00:00
wtc%google.com
d49496f0ff Bug 537356: Disable the ECC cipher suites for SSL 3.0 renegotiations
because we don't send the elliptic_curves and ec_point_format extensions
in SSL 3.0 client hello.  r=nelson.


git-svn-id: svn://10.0.0.236/trunk@259579 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-03 02:46:15 +00:00
wtc%google.com
3f6d220c28 Bug 537356: server-side SSL_RENEGOTIATE_REQUIRES_XTN code should handle
both client-initiated (ss->ssl3.hs.ws == idle_handshake) and
server-initiated (ss->ssl3.hs.ws == wait_client_hello) renegotiations.
r=kaie,nelson.


git-svn-id: svn://10.0.0.236/trunk@259506 18797224-902f-48f8-a5cc-f745e15eee43
2010-01-29 19:55:42 +00:00
wtc%google.com
fa46d39e9d Bug 537356: In SSL 3.0, send and handle the renegotiation_info extension
but not any other extension.  r=rrelyea.
Modified Files:
	ssl3con.c ssl3ext.c


git-svn-id: svn://10.0.0.236/trunk@259505 18797224-902f-48f8-a5cc-f745e15eee43
2010-01-29 19:20:28 +00:00