50 Commits

Author SHA1 Message Date
mkanat%kerio.com
02aa35925a Bug 287138: INSERT IGNORE is not ANSI SQL
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170976 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-22 09:01:22 +00:00
travis%sedsystems.ca
7351a5b76b Bug 283581 : Move UserInGroup out of globals.pl
Patch by Colin Ogilvie <colin.ogilvie@gmail.com>   r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170734 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 22:10:14 +00:00
erik%dasbistro.com
670b6254a0 Bug 253721: Add group-based lists to whining
Patch by Erik Stambaugh <erik@dasbistro.com>
r=joel, r,a=justdave


git-svn-id: svn://10.0.0.236/trunk@169438 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 22:42:07 +00:00
bugzilla%glob.com.au
3ff37133f6 Bug 282510: Argument "" isn't numeric when modifying group
Patch by Byron Jones <bugzilla@glob.com.au> r,a=justdave


git-svn-id: svn://10.0.0.236/trunk@169393 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 16:38:42 +00:00
mkanat%kerio.com
c8f7e44c64 Bug 280494: Replace "SELECT LAST_INSERT_ID()" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@169387 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 16:01:48 +00:00
mkanat%kerio.com
a88c76e484 Bug 280503: Replace "LOCK/UNLOCK TABLES" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=myk


git-svn-id: svn://10.0.0.236/trunk@169333 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 21:57:27 +00:00
travis%sedsystems.ca
a5e2487330 Bug 277768 : Some validations are missing when editing groups
Patch by Frederic Buclin <LpSolit@gmail.com>  r=wurblzap  a=justdave


git-svn-id: svn://10.0.0.236/trunk@169254 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-16 16:26:43 +00:00
jocuri%softhome.net
6e30566dcd Patch for bug 265898: edit*.cgi files should all use ThrowUserError(); patch by Frédéric Buclin <LpSolit@gmail.com>, r=vladd, a=myk.
git-svn-id: svn://10.0.0.236/trunk@167820 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 14:07:31 +00:00
jocuri%softhome.net
9b7827dd9b Patch for bug 180879: Implement privs for bug flags modification; patch by Frédéric Buclin <LpSolit@netscape.net>, r=joel, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@165677 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-23 22:41:44 +00:00
bugreport%peshkin.net
12e5e8c5f9 Bug 244239: Add group-based pronouns to query
r=erik,justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160666 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-11 14:00:34 +00:00
jocuri%softhome.net
23204eca2d Patch for bug 253360: replace IF() with CASE WHEN for database compatibility; patch by Tomas Kopal <Tomas.Kopal@altap.cz>; r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@160170 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-31 09:36:18 +00:00
bugreport%peshkin.net
1b0c07d9df Bug 251837: Extend group_group_map to control which groups can see each other
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159914 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-27 16:33:41 +00:00
jocuri%softhome.net
70284e3089 Patch for bug 190222: templatize editgroups.cgi; r=joel, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@159122 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-13 05:12:33 +00:00
bugreport%peshkin.net
4c42de310e Bug 250080: Fix regression causing blank regexp to make all users group members
r=erik, justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@158826 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-07 05:10:55 +00:00
jocuri%softhome.net
227f7186fb Patch for bug 248001: Conversion of boolean conditions in SQL statements for better DB independence; patch by David Lawrence <dkl@redhat.com>; r=joel, vladd; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@158711 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-03 00:26:29 +00:00
bugreport%peshkin.net
5fe78bc59c Bug 240325: Keep regexp-based groups up-to-date
git-svn-id: svn://10.0.0.236/trunk@157940 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-16 05:04:48 +00:00
jouni%heikniemi.net
6a3903cfce Bug 208847: Fix taint issues in editgroups.cgi
Patch by byron jones <bugzilla@glob.com.au>,
r=jouni, a=justdave


git-svn-id: svn://10.0.0.236/trunk@156793 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-23 07:07:50 +00:00
justdave%syndicomm.com
62d042aa7a Bug 235265: Getting rid of some unwanted form value dumps.
Patch by Jouni Heikniemi <jouni@heikniemi.net>
r= justdave, kiko; a= justdave


git-svn-id: svn://10.0.0.236/trunk@154332 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 04:35:37 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
bugreport%peshkin.net
86bcf7c2ba Bug 181589: Add mass-remove to editgroups
r=justdave, a=justdave


git-svn-id: svn://10.0.0.236/trunk@154304 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-26 15:18:07 +00:00
jouni%heikniemi.net
1f02d8657e Bug 226119: The template admin/add-group.html.tmpl moved to admin/groups/create.html.tmpl to better match with admin template naming consensus discussed in reviewers@.
r=myk, a=justdave


git-svn-id: svn://10.0.0.236/trunk@149544 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-19 06:42:09 +00:00
caillon%returnzero.com
ea63ffa0e7 226061 - someone forgot to tell editgroups that regexps are applied at runtime, not on account creation.
r=joel,a=justdave


git-svn-id: svn://10.0.0.236/trunk@149501 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-18 18:55:44 +00:00
jocuri%softhome.net
9aa27336fa Bug 207211: Editgroups.cgi - template for add a group page; r=myk; a=myk.
git-svn-id: svn://10.0.0.236/trunk@149075 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-09 21:07:26 +00:00
kiko%async.com.br
ad61d77b76 Bug 65316: Typos on edit*.cgi. Change use of PutTrailer() (and the
default output, in certain cases) in the edit pages. Patch by Vlad
Dascalu <jocuri@softhome.net>, r=kiko, a=justdave


git-svn-id: svn://10.0.0.236/trunk@147351 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-26 23:47:07 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-27 00:07:02 +00:00
zach%zachlipton.com
70edadec69 Fix for bug 166481 ("Spellcheck is borked"). Part one of this fix fixes
the spelling errors so tinderbox doesn't barf, part two fixes
t/006spellcheck.t and adds some more new words to check for.

Part 1 patch by myself, r=timeless
Part 2 patch by MattyT. r=zach (myself)
a=justdave


git-svn-id: svn://10.0.0.236/trunk@136179 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-10 23:51:38 +00:00
bugreport%peshkin.net
1c221514d7 Bug 181951 Cannot delete groups
Patch by joel
r=burnus,bbaetz
a=justdave


git-svn-id: svn://10.0.0.236/trunk@134591 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-30 03:46:03 +00:00
bugreport%peshkin.net
8bd91adeeb Bug 147275 Rearchitect product groups
Patch by joel
r=bbaetz,justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@134383 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-24 19:56:34 +00:00
bugreport%peshkin.net
050fe637e1 Bug 171440 editgroups shows system groups as usable for bugs even though they are not
2xr=justdave


git-svn-id: svn://10.0.0.236/trunk@130691 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-28 22:54:44 +00:00
bugreport%peshkin.net
2194da2336 bug 157756 - Groups_20020716_Branch Tracking : > 55 groups now supported
r=bbaetz, gerv


git-svn-id: svn://10.0.0.236/trunk@130217 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-22 17:15:13 +00:00
jake%bugzilla.org
b7a53c11ec Updating my e-mail address as jake@acutex.net is no longer valid.
* NO CODE CHANGES *


git-svn-id: svn://10.0.0.236/trunk@128230 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-27 04:28:05 +00:00
bbaetz%student.usyd.edu.au
71381b40ed Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
r=joel x2


git-svn-id: svn://10.0.0.236/trunk@128080 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-26 06:17:26 +00:00
bbaetz%student.usyd.edu.au
1c2ecdc9c2 Bug 43600 - Convert products/components to use ids instead of names.
Initial attempt by jake@bugzilla.org, updated by me
r=joel, preed


git-svn-id: svn://10.0.0.236/trunk@127057 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-12 05:43:05 +00:00
bbaetz%student.usyd.edu.au
4403bbe04e Bug 151053, ConnectToDatabase/quietly_check_login sometimes not called
early enough
r=mattyt, jouni


git-svn-id: svn://10.0.0.236/trunk@123428 18797224-902f-48f8-a5cc-f745e15eee43
2002-06-17 09:39:48 +00:00
gerv%gerv.net
33a5971d2a Bug 140784 - edit*.cgi need a use lib "." on Win32/IIS w/ taint. Patch by jouni@heikniemi.net; r=bbaetz, gerv.
git-svn-id: svn://10.0.0.236/trunk@120207 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-29 19:32:29 +00:00
bbaetz%student.usyd.edu.au
b503102b3d Bug 106377 - processmail rescanall should use lastdiffed
r=justdave, ddkilzer@theracingworld.com


git-svn-id: svn://10.0.0.236/trunk@115685 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-03 22:06:20 +00:00
justdave%syndicomm.com
c4c291a120 Fix for bug 119005: The instructions in editgroups.cgi incorrectly state that you can't use spaces in a group name. You in
fact can.
Patch by Christian Reis <kiko@async.com.br>
r= bbaetz x 2


git-svn-id: svn://10.0.0.236/trunk@113741 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-06 02:54:08 +00:00
justdave%syndicomm.com
d27f46ad1e Fix for bug 104516: No code changes in this patch, all this checkin does is remove all tabs from the bugzilla source and replace it with the appropriate number of spaces (in most cases 8) to line up with existing code. This is part of the effort to bring the existing codebase up to par with our style guidelines.
Patch by Jake Steehagen <jake@acutex.net>
r= justdave x2


git-svn-id: svn://10.0.0.236/trunk@105335 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-13 01:36:17 +00:00
justdave%syndicomm.com
8928aa2555 Fix for bug 75482: adding the capability to deactivate a group without deleting it (prevent new bugs from being placed into that group, but don't remove the group restriction from bugs already in it).
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96488 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-06 03:16:52 +00:00
justdave%syndicomm.com
4ee90b5c9c Dummy commit so I can put the attributions I forgot in the previous one.
Patch from bug 65290 was by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96008 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-29 21:27:12 +00:00
justdave%syndicomm.com
31f34d9a60 Fix for bug 65290: can now edit user-regexps for system groups
git-svn-id: svn://10.0.0.236/trunk@96007 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-29 21:25:02 +00:00
justdave%syndicomm.com
f539fe27ee Correcting my email address in the comments
git-svn-id: svn://10.0.0.236/trunk@92493 18797224-902f-48f8-a5cc-f745e15eee43
2001-04-17 02:26:16 +00:00
cyeh%bluemartini.com
1bd2b94ad6 fix for 47561:Incorrect group bit used for new group.
patch by dave@intrec.com


git-svn-id: svn://10.0.0.236/trunk@79233 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-14 23:53:24 +00:00
dave%intrec.com
9cf0aa1b59 Fix for bug 51519: Links to index are too specific. Patch by
john.beranek@pace.co.uk (John Beranek)


git-svn-id: svn://10.0.0.236/trunk@78352 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-07 06:31:12 +00:00
dave%intrec.com
e1cf1a1b66 Fix for bug 47561. Thanks to tengel@fluid.com (Troy Engel) for catching
this one.


git-svn-id: svn://10.0.0.236/trunk@75670 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-06 05:42:30 +00:00
cyeh%bluemartini.com
97fb8ee283 checkin to fix Bug 25010 "Need a way to edit the list of available groups".
Patches and work contributed by dave@intrec.com (Dave Miller).
Some cleanup work needs to be done with regards to permissions and bit-twiddling
see other bugs that are dependent on 25010 for details.


git-svn-id: svn://10.0.0.236/trunk@73080 18797224-902f-48f8-a5cc-f745e15eee43
2000-06-23 18:03:47 +00:00
donm%bluemartini.com
3bfbf244d5 bug 25010 need a way to edit groups
git-svn-id: svn://10.0.0.236/trunk@67252 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-26 19:35:51 +00:00
endico%mozilla.org
8823ce2547 backing out because this has broken bugzilla.mozilla.org. the choice is no longer given in show_bug.cgi to make bugs confidential. I need to change lounge so it no longer automatically updates.
git-svn-id: svn://10.0.0.236/trunk@66391 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-19 02:14:41 +00:00
donm%bluemartini.com
861e3e08fb bug 25010 add ability to easily edit groups
git-svn-id: svn://10.0.0.236/trunk@66353 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-18 23:12:00 +00:00