2204 Commits

Author SHA1 Message Date
mkanat%bugzilla.org
844f51805e The changes to accept positional parameters in XML-RPC meant that sometimes
$params wouldn't just be undef, but actually missing, so validate() was
getting @keys where $params should have been.


git-svn-id: svn://10.0.0.236/trunk@260766 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 04:04:43 +00:00
mkanat%bugzilla.org
2d0ddb344e Bug 578531: Move the chfield stuff out of init, and make
the changedbefore/after charts include the date specified
(they previously did exclusive searches)
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260764 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 02:16:34 +00:00
mkanat%bugzilla.org
4f6d79db10 Bug 578323: Remove the special parsing of "changedin" from Search.pm.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260759 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 23:46:36 +00:00
mkanat%bugzilla.org
3f376a9401 Bug 577765: Allow XML-RPC to accept multiple positional parameters
r=ghendricks, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260758 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 23:27:05 +00:00
mkanat%bugzilla.org
51d426d529 Remove some errors from WS_ERROR_CODE that don't exist on trunk.
git-svn-id: svn://10.0.0.236/trunk@260755 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 23:16:45 +00:00
mkanat%bugzilla.org
1e9ece0681 Bug 578324: The "Hours Worked" field in show_bug.cgi rejects all values passed to it if it would make the Remaining Time negative
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260750 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 23:05:56 +00:00
mkanat%bugzilla.org
4d8362abd8 Bug 412074: Ability to add attachments to a bug via the WebService
(Bug.add_attachment)
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260748 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 22:48:31 +00:00
mkanat%bugzilla.org
d00170cc62 Bug 578316: Search.pm: Move the parsing of email* fields into a method
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260744 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 11:02:11 +00:00
mkanat%bugzilla.org
9cf3dc10b0 Bug 578313: Search.pm: Move the parsing of basic fields (ones that map to
fielddefs) into methods
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260743 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 10:31:53 +00:00
mkanat%bugzilla.org
3084e8d1d5 Bug 578310: Search.pm: Move the special parsing of bug_status and resolution
out of init and into some _special_parse_* functions.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260742 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 10:16:45 +00:00
mkanat%bugzilla.org
38529a9513 Bug 578299: Search.pm: Generate the GROUP BY clause in a method
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260741 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 09:31:48 +00:00
mkanat%bugzilla.org
6a6d6ed46b Bug 578275: Search.pm: Fully generate the ORDER BY clause inside of an
accessor
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260736 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 06:02:02 +00:00
mkanat%bugzilla.org
dd8741db43 Bug 578278: Search.pm: Fully generate the SELECT clause inside of an accessor
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260735 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 05:50:30 +00:00
mkanat%bugzilla.org
48ca940e07 Bug 578266: Clean up the SPECIAL_ORDER code and make it into an accessor,
in Search.pm
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260734 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 04:01:55 +00:00
mkanat%bugzilla.org
fe97848dd8 alias_not_allowed should be multiple_alias_not_allowed
git-svn-id: svn://10.0.0.236/trunk@260727 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 02:23:04 +00:00
mkanat%bugzilla.org
ffd9f09c9d Bug 415813: Implement Bug.update() as an API for WebServices
r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260726 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 01:51:32 +00:00
mkanat%bugzilla.org
5886523d89 Bug 578197: [PostgreSQL] When associating sequences with columns, also
fix the default of the columns so that it's identical to what a new
checksetup run would create.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260721 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 00:46:37 +00:00
mkanat%bugzilla.org
1bc2c64b47 Bug 578197: [PostgreSQL] Properly associate sequences that had no
column association
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260718 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-12 23:31:36 +00:00
mkanat%bugzilla.org
9b87c64225 Bug 577807: Convert the hard-coded stuff that adds map_* tables to @supptables
in Search.pm into a data structure and a series of functions that parse the
data structure.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260710 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 12:46:46 +00:00
mkanat%bugzilla.org
2850470be9 Bug 577805: Make chart_fields into an accessor in Search.pm
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260709 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 11:01:47 +00:00
mkanat%bugzilla.org
08abde2503 Bug 577803 - Make multi_select_fields into an accessor in Search.pm
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260708 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 10:34:02 +00:00
mkanat%bugzilla.org
7c5c6eb8e7 Bug 577754: Make updating bugs_fulltext during checksetup.pl WAY faster
for MySQL.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260707 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 05:36:00 +00:00
mkanat%bugzilla.org
a54682ffe0 Bug 577602: Don't put multi-select fields into the GROUP BY in Search.pm,
because they are created by an aggregate. (This fixes multi-select buglist
columns on Pg.)
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260706 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 05:17:04 +00:00
mkanat%bugzilla.org
f38eeae1ef Bug 451219: Allow altering from one SERIAL type to another on PostgreSQL,
for people upgrading Testopia from 1.3 to 2.0+.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260703 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 04:23:40 +00:00
mkanat%bugzilla.org
91679ae846 Bug 577793: Improve the Pg SERIAL-altering code now that we require 8.3
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260702 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 04:17:08 +00:00
mkanat%bugzilla.org
0b5e02b469 Bug 576670: Optimize Search.pm's "init" method for being called many times
in a loop
r=glob, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260692 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-09 02:16:39 +00:00
mkanat%bugzilla.org
9e50634048 Bug 577582: longdescs.isprivate "changedfrom" and "changedto" weren't
working on PostgreSQL, because Search.pm always converted the value
into 1 or 0 and passed that as a number to the database, and Pg didn't
support numeric comparison with a text column.
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260689 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-09 00:16:55 +00:00
mkanat%bugzilla.org
970784abc3 Bug 577577: Make bz_drop_fk be tolerant of SQL failure
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260688 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 23:50:06 +00:00
mkanat%bugzilla.org
db394fa150 Bug 577575: If percentage_complete is a column in the buglist, remaining_time
must also be selected from the database for PostgreSQL.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260687 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 23:31:50 +00:00
mkanat%bugzilla.org
a982e4fad4 Bug 577569: [PostgreSQL] Make sql_position explicitly cast both its arguments
to text, to avoid an error when searching "longdescs.isprivate" with the
"casesubstring" operator in Search.pm.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260686 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 23:03:46 +00:00
mkanat%bugzilla.org
9824d60b39 Bug 305412: Update the minimum Pg requirement to 8.3, to allow casting
bytea to text in Search.pm.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260683 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 21:16:48 +00:00
mkanat%bugzilla.org
07ae0611ea Bug 577415: Allow positional parameters for XML-RPC, because Testopia
uses them.
r=ghendricks, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260682 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 20:35:21 +00:00
mkanat%bugzilla.org
7ac03c8662 Bug 575021: Make the anyexact operator in Search.pm properly trim its
input values
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260678 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 19:03:40 +00:00
mkanat%bugzilla.org
f78ee5803d Fix a template and POD bustage from the $$some_var Search.pm checkin.
git-svn-id: svn://10.0.0.236/trunk@260677 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 19:01:58 +00:00
mkanat%bugzilla.org
ac502cce7f Bug 574556: Refactor Search.pm so that we're not doing $$some_var everywhere.
Instead, we pass around a hashref and update the hashref. This patch also
includes some cleanup for bugs surrounding percentage_complete,
attachments.isobsolete, attachments.ispatch, and owner_idle_time.
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260676 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 18:31:53 +00:00
mkanat%bugzilla.org
31fb7ecfb2 Bug 577520: Make the "Adding new table..." message not appear during
xt/search.t
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260675 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 18:18:29 +00:00
mkanat%bugzilla.org
f7fcd61887 Bug 490930: Always store attachments locally if they are over X size (and below some threshold!), don't ever display "Big File" checkbox
r=mkanat a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260674 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 17:03:37 +00:00
mkanat%bugzilla.org
01f0845197 Bump the version number to 4.1 on trunk.
git-svn-id: svn://10.0.0.236/trunk@260673 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 17:01:51 +00:00
mkanat%bugzilla.org
0b4ee35ebe Bug 452761: Make the Date header of bugmail and requestmail always be
equal to the delta_ts of the bug. This makes emails have the right Date
even when they are sent much later by jobqueue.pl.
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260669 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 06:31:47 +00:00
mkanat%bugzilla.org
841718a241 Bug 577089: Make convert-workflow fix the query values for series
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260665 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 00:33:57 +00:00
mkanat%bugzilla.org
1bc3eea6ca Bug 577149: Make convert-workflow rename values in saved searches
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260664 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 00:32:01 +00:00
mkanat%bugzilla.org
c35963979d Bug 574879: Create a test that assures the correctness of Search.pm's
boolean charts
r=glob, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260658 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-07 21:47:00 +00:00
mkanat%bugzilla.org
782a4a185f Bug 519835: Remove Bugzilla::Product::check_product() in favor of Bugzilla::Product->check()
r=mkanat a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260656 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-07 02:01:50 +00:00
mkanat%bugzilla.org
a079ad7712 Bug 552919: Sort group_concat results so that they sort correctly for buglists
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260654 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-07 00:16:41 +00:00
mkanat%bugzilla.org
7b163c4a83 Bug 574995: Make the WebService return reporter, attachment submitter, and
commenter all as "creator"
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260653 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-06 22:16:34 +00:00
mkanat%bugzilla.org
d275436852 Bug 577049: POD must mention Bugzilla 4.0 instead of 3.8
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260649 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-06 17:31:55 +00:00
mkanat%bugzilla.org
00d84e46ec Bug 577053: When upgrading from a version earlier than 4.0,
change the logic on how we check to see if we need to populate
the status_workflow table for an upgrading installation, because
it was broken for upgrades from 2.18 and earlier.


git-svn-id: svn://10.0.0.236/trunk@260647 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-06 04:01:49 +00:00
mkanat%bugzilla.org
ad7209dc25 Bump the version number post-release.
git-svn-id: svn://10.0.0.236/trunk@260646 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-06 03:46:48 +00:00
mkanat%bugzilla.org
593e614ff9 Bump the version number for 3.7.2.
git-svn-id: svn://10.0.0.236/trunk@260644 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-06 02:46:48 +00:00
mkanat%bugzilla.org
1a4d14c903 Bug 574892: [SECURITY] Add EXTRA_REQUIRED_FIELDS to Bugzilla::Object, which
allows specifying that certain fields have validator defaults even if they
also have a database default or are in another table.
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260643 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-06 02:31:41 +00:00