605 Commits

Author SHA1 Message Date
kiko%async.com.br
65618d4b65 Whitespace fixes. r=ssdbot
git-svn-id: svn://10.0.0.236/trunk@160402 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-05 13:51:23 +00:00
kiko%async.com.br
77e2765fbe Fix for bug 253562: Hours Worked (actual_time) is being listed as 1.
Cleans up Bugzilla::Bug::actual_time to do things the right way (dbi,
Bugzilla->user) and apparently fixes a problem limited to some
platforms. r=joel, a=justdave.


git-svn-id: svn://10.0.0.236/trunk@160399 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-05 13:43:48 +00:00
bugreport%peshkin.net
fb03b26b17 Bug 254374: Fix regression in qacontact from bug 186093
git-svn-id: svn://10.0.0.236/trunk@160385 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-05 03:18:42 +00:00
bugreport%peshkin.net
259f1f03b2 Bug 185090: Add revamped whining system
patch by: Erik
r=joel
r=jouni
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160377 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-04 21:36:27 +00:00
bugreport%peshkin.net
673c562fce Bug 186093: Move CanSeeBug to User.pm and make User.pm usable by templates
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160361 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-04 18:08:21 +00:00
bugreport%peshkin.net
cd65dc04d7 Bug 186093: Move CanSeeBug to User.pm and make User.pm usable by templates
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160350 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-04 16:17:10 +00:00
jocuri%softhome.net
ac35b43d57 Patch for bug 253357: replace IFNULL with COALESCE for increased database compatibility; patch by Tomas Kopal <Tomas.Kopal@altap.cz>; r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@160169 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-31 08:59:16 +00:00
bugreport%peshkin.net
9f826706c4 Bug 253588: Change Bugzilla->user to be usable even for a logged-out user
patch by erik,joel
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160163 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-31 02:27:26 +00:00
kiko%async.com.br
6196d928d3 Missing bits of fix for bug 236678: Clean up access to COOKIE global.
Murder the last remaining places in the tree where COOKIE is used;
includes a rather thorough cleanup of Bugzilla::Bug->user and a minor
doc update. r=joel, a=justdave.


git-svn-id: svn://10.0.0.236/trunk@160018 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-29 03:02:05 +00:00
kiko%async.com.br
f5b1cdca19 Fix for bug 236678: Clean up access to COOKIE global. Murder the last
remaining places in the tree where COOKIE is used; includes a rather
thorough cleanup of Bugzilla::Bug->user and a minor doc update. r=joel, a=justdave.


git-svn-id: svn://10.0.0.236/trunk@160015 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-29 02:45:38 +00:00
bugreport%peshkin.net
4d039a4c95 Bug 204903: Enable searches to match NULL aliases, missing qa_contact, and search on CC even when cc-list is empty
r=jouni
a=myk


git-svn-id: svn://10.0.0.236/trunk@160009 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-29 00:46:57 +00:00
bugreport%peshkin.net
1b0c07d9df Bug 251837: Extend group_group_map to control which groups can see each other
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159914 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-27 16:33:41 +00:00
kiko%async.com.br
6f8401de6a Updating POD documentation for Bugzilla/Error to suggest the use of
'abort' after passing a few minutes looking for it. rs=joel


git-svn-id: svn://10.0.0.236/trunk@159687 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-22 20:15:38 +00:00
kiko%async.com.br
f670ca783b Using "abort" instead of 1 to make the unlock_tables request consistent
with the rest of Bugzilla.


git-svn-id: svn://10.0.0.236/trunk@159667 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-22 17:51:19 +00:00
kiko%async.com.br
ce412f90e2 Fix for bug 252159: centralize time validation. Adds a ValidateTime
function to Bugzilla::Bug and uses it in relevant callsites. Patch by
Alexandre Michetti Manduca <michetti@grad.icmc.usp.br>. r=kiko, a=justdave.


git-svn-id: svn://10.0.0.236/trunk@159666 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-22 17:48:37 +00:00
bugreport%peshkin.net
f766db8ca5 Bug 252388: Fix undef warning when Bugzilla->cgi->header() is called twice
r=jouni
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159640 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-22 07:08:46 +00:00
bugreport%peshkin.net
418761147e Bug 238544: Emit appropriate error if content and matches are used in
invalid search combinations.
r=jouni
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159636 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-22 06:48:59 +00:00
bugreport%peshkin.net
ba7b83aa6f Bug 241900: Allow Bugzilla::Auth to have multiple login and validation styles
patch by erik
r=joel, kiko
a=myk


git-svn-id: svn://10.0.0.236/trunk@159556 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-20 22:41:22 +00:00
bugreport%peshkin.net
0ed8232524 Bug 245272: Add per-chart negation to boolean searches
r=justdave,myk,timeless
a=myk


git-svn-id: svn://10.0.0.236/trunk@159555 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-20 21:46:47 +00:00
bugreport%peshkin.net
3728858e5e Bug 165589 Add data/errorlog logging support to bugzilla
r=jouni
a=myk


git-svn-id: svn://10.0.0.236/trunk@159554 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-20 21:34:41 +00:00
jouni%heikniemi.net
8a54f912e5 Bug 250547: Make FlagTypes use INNER JOIN instead of comma operator.
Patch by Tomas Kopal <Tomas.Kopal@altap.cz>
r=jouni, a=justdave


git-svn-id: svn://10.0.0.236/trunk@159530 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-20 05:08:26 +00:00
bugreport%peshkin.net
26e1d25123 Bug 251567: Make sure "find a specific bug" doesn't miss exact matches in summary
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159377 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-17 01:33:51 +00:00
bugreport%peshkin.net
9b86bfce63 Bug 250967: Fix spurious updates to requesteeless flags
patch by jouni
r=kiko,joel
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159165 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-14 02:40:21 +00:00
bugreport%peshkin.net
3e8fa8cd6c Bug 226434: Add %reporter%, %user%, and %assignee% pronouns to boolean charts
r=jouni
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159119 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-13 01:52:06 +00:00
bugreport%peshkin.net
dd7434d263 Backing out bug 241900
git-svn-id: svn://10.0.0.236/trunk@159043 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-12 03:48:48 +00:00
bugreport%peshkin.net
864d1bce45 Bug 241900: Allow Bugzilla::Auth to have multiple login and validation styles
patch by erik
r=joel
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159037 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-11 23:36:53 +00:00
bugreport%peshkin.net
b95653cb87 Bug 245158: Combine multiple redundant LEFT JOINs into a single LEFT JOIN in Search.pm
r=zach,justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159036 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-11 23:08:39 +00:00
jouni%heikniemi.net
beac461756 Bumping trunk versions to 2.19. r,a=justdave (on irc)
git-svn-id: svn://10.0.0.236/trunk@159025 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-11 17:53:28 +00:00
justdave%bugzilla.org
6be14913b2 Bump version number for release
git-svn-id: svn://10.0.0.236/trunk@159000 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-10 15:01:37 +00:00
justdave%bugzilla.org
6245fb7059 Bug 238797: minor adjustment to javascript filters to prevent tags inserted in product, component, and flag names from causing problems.
r=gerv, a=justdave


git-svn-id: svn://10.0.0.236/trunk@158998 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-10 14:51:25 +00:00
bugreport%peshkin.net
34ea9b14ae Bug 227191: Change DBI->connect syntax so database password will not be revealed if connect fails
r=bbaetz
a=justdave


git-svn-id: svn://10.0.0.236/trunk@158978 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-10 07:35:35 +00:00
timeless%mozdev.org
bfc495857e Bug 242405 Turning on QA contact causes taint error in Bugzilla/Series.pm when adding a component
patch by bugzilla@glob.com.au r=joel a=justdave


git-svn-id: svn://10.0.0.236/trunk@158939 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-09 03:33:58 +00:00
jouni%heikniemi.net
7fd5078c36 Bug 223878: Flag system dies when changing a deleted flag.
r=joel, justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@158788 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-06 07:08:02 +00:00
jocuri%softhome.net
227f7186fb Patch for bug 248001: Conversion of boolean conditions in SQL statements for better DB independence; patch by David Lawrence <dkl@redhat.com>; r=joel, vladd; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@158711 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-03 00:26:29 +00:00
bugreport%peshkin.net
5fe78bc59c Bug 240325: Keep regexp-based groups up-to-date
git-svn-id: svn://10.0.0.236/trunk@157940 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-16 05:04:48 +00:00
bugreport%peshkin.net
6800dd8a15 Bug 244927: Add search on time owner has left the bug idle
r=jouni
a=myk


git-svn-id: svn://10.0.0.236/trunk@157259 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-01 20:29:05 +00:00
bugreport%peshkin.net
6d9c9459a7 Bug 243351: Fix mysql version sensitivity in case-sensitive search
r=jouni
a=justdave


git-svn-id: svn://10.0.0.236/trunk@157000 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-27 02:40:18 +00:00
justdave%bugzilla.org
c480e3ca9f Bug 227172: Deal with race condition between a user being removed from the CC on a bug and changing their email address before the bugmail is sent.
r=jouni, a=justdave


git-svn-id: svn://10.0.0.236/trunk@156951 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-26 07:21:43 +00:00
bugreport%peshkin.net
162f54a027 Bug 244650: Fix query on commentor in combination with other email-based criteria
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@156950 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-26 06:51:52 +00:00
jouni%heikniemi.net
69b0eabf44 Remove stray resid from BugMail.pm. r,a=justdave
git-svn-id: svn://10.0.0.236/trunk@156907 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-25 05:53:53 +00:00
jocuri%softhome.net
5a0765d00b Patch for bug 217627: fix Bugzilla internal error message that appears if bug alias starts with zero; patch by Alexey Gladkov <legion@altlinux.org>; r=justdave; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@156600 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-19 19:48:11 +00:00
bugreport%peshkin.net
322d0aefce Bug 239263: Avoid hazard in User->groups by switching to main DB for rederive
r=jouni
a=justdave


git-svn-id: svn://10.0.0.236/trunk@156409 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-14 13:55:45 +00:00
bugreport%peshkin.net
76d31317ba Bug 226477: Fix undefined method call in Bugzilla::User->in_group
r=timeless,a=justdave


git-svn-id: svn://10.0.0.236/trunk@156287 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-12 05:11:27 +00:00
myk%mozilla.org
89be897808 Fix for bug 237176: allows power users to display relevance values as a column in the search results for a fulltext search
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@154526 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-06 00:11:26 +00:00
jocuri%softhome.net
966983881d Patch for bug 232554: fix SQL queries in Flag.pm in order to fix a bug that causes flags to remain set but inaccessible when product changes; patch by Max K-A <mkanat@kerio.com>; r=bbaetz,myk; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@154426 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-01 08:57:59 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
kiko%async.com.br
93e2995ef4 Fix for bug 226754: Move InvalidateLogins into Bugzilla::Auth::CGI. Consolidates the logout code into Bugzilla::Auth::CGI, and provides
simple front-end wrappers in Bugzilla.pm for use in the CGIs we have.
r=bbaetz, joel; a=justdave.

Adds a set of constants to the logout() API which allow specifying "how
much" we should log out -- all sessions, the current session, or all
sessions but the current one.

Fixes callsites to use this new API; cleans and documents things a
bit while we're at it. Part I in the great COOKIE apocalypse.


git-svn-id: svn://10.0.0.236/trunk@154328 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 01:31:00 +00:00
kiko%async.com.br
36171a62bf Fix for bug 226764: Move InvalidateLogins into Bugzilla::Auth::CGI.
Consolidates the logout code into Bugzilla::Auth::CGI, and provides
simple front-end wrappers in Bugzilla.pm for use in the CGIs we have.
r=bbaetz, joel; a=justdave.

Adds a set of constants to the logout() API which allow specifying "how
much" we should log out -- all sessions, the current session, or all
sessions but the current one.

Fixes callsites to use this new API; cleans and documents things a
bit while we're at it. Part I in the great COOKIE apocalypse.


git-svn-id: svn://10.0.0.236/trunk@154327 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 01:28:29 +00:00
jocuri%softhome.net
2ffa344c24 Patch for bug 238683: fix for usage of uninitialized value in concatenation in Bugzilla/CGI.pm: remove extra $ char; patch by corporate_gadfly@hotmail.com; r=vlad; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@154290 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-26 02:07:44 +00:00
jocuri%softhome.net
4237d91027 Patch for bug 179351: improve variable scoping issues in order to fix a bug causing oddly formatted dependency emails; patch by Teemu Mannermaa <wicked@etlicon.fi> revised slightly by justdave; r=joel; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@154122 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-19 22:03:52 +00:00