32 Commits

Author SHA1 Message Date
lpsolit%gmail.com
529ea73dda Bug 304696: Replace UserInGroup() by $user->in_group() when checking user privs in edit*.cgi files - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@180314 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-15 22:01:56 +00:00
lpsolit%gmail.com
268e3be166 Bug 303705: Eliminate deprecated Bugzilla::DB routines from editkeywords.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=jouni a=justdave
git-svn-id: svn://10.0.0.236/trunk@179632 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-04 18:35:05 +00:00
mkanat%kerio.com
0cbbdcfee7 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177695 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-13 12:27:04 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
bugreport%peshkin.net
9778732be8 Backout of bug 303669 which broke AppendComment and possibly a number
of other items.


git-svn-id: svn://10.0.0.236/trunk@177419 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 11:23:43 +00:00
mkanat%kerio.com
7bbde62ad3 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177413 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 05:59:02 +00:00
mkanat%kerio.com
fda3b0dd8f Bug 174295: ANSI SQL requires all columns in SELECT to be in GROUP BY, unless they are in "aggregate" functions
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@170751 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-16 00:27:15 +00:00
travis%sedsystems.ca
7351a5b76b Bug 283581 : Move UserInGroup out of globals.pl
Patch by Colin Ogilvie <colin.ogilvie@gmail.com>   r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170734 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 22:10:14 +00:00
mkanat%kerio.com
64adf228bd Bug 284975: Any code after Throw*Error is a dead code.
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@170414 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-09 00:26:39 +00:00
jocuri%softhome.net
6e30566dcd Patch for bug 265898: edit*.cgi files should all use ThrowUserError(); patch by Frédéric Buclin <LpSolit@gmail.com>, r=vladd, a=myk.
git-svn-id: svn://10.0.0.236/trunk@167820 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 14:07:31 +00:00
jocuri%softhome.net
c8e5c19ce5 Patch for bug 239576: make sure detaint_natural is always called with a defined value in editkeywords.cgi; r=timeless; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@154505 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-05 01:32:43 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
jocuri%softhome.net
6d77a5b9f2 Patch for bug 234879: remove %FORM from editkeywords.cgi; r=kiko, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@153615 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-06 09:04:33 +00:00
jocuri%softhome.net
93c36a6260 Bug 190223: Complete templatization for editkeywords.cgi; reviewed by kiko, jth, gerv; r/a=justdave.
git-svn-id: svn://10.0.0.236/trunk@150181 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-09 23:12:40 +00:00
bbaetz%acm.org
8fabd677ea Bug 208604 - Make data/template dir locations configurable
git-svn-id: svn://10.0.0.236/trunk@149624 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-22 03:50:42 +00:00
jocuri%softhome.net
89c38b83fc Bug 225703: Partial templatization for editkeywords.cgi; r=jouni; r=gerv; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@149610 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-21 10:00:54 +00:00
justdave%syndicomm.com
80801cd4e8 [SECURITY] Bug 219044: A user with 'editkeywords' privileges (i.e. usually an administrator) can inject arbitrary SQL via the URL used to edit an existing keyword.
Patch by Joel Peshkin <bugreport@peshkin.net>
r= justdave, zach  a= justdave


git-svn-id: svn://10.0.0.236/trunk@148737 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-03 03:31:30 +00:00
kiko%async.com.br
ad61d77b76 Bug 65316: Typos on edit*.cgi. Change use of PutTrailer() (and the
default output, in certain cases) in the edit pages. Patch by Vlad
Dascalu <jocuri@softhome.net>, r=kiko, a=justdave


git-svn-id: svn://10.0.0.236/trunk@147351 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-26 23:47:07 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-27 00:07:02 +00:00
bbaetz%student.usyd.edu.au
71381b40ed Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
r=joel x2


git-svn-id: svn://10.0.0.236/trunk@128080 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-26 06:17:26 +00:00
gerv%gerv.net
d81b80bc41 Bug 95426 - remove $onebug cruft. Patch by gerv; 2xr=timeless.
git-svn-id: svn://10.0.0.236/trunk@125554 18797224-902f-48f8-a5cc-f745e15eee43
2002-07-21 21:47:43 +00:00
bbaetz%student.usyd.edu.au
4403bbe04e Bug 151053, ConnectToDatabase/quietly_check_login sometimes not called
early enough
r=mattyt, jouni


git-svn-id: svn://10.0.0.236/trunk@123428 18797224-902f-48f8-a5cc-f745e15eee43
2002-06-17 09:39:48 +00:00
dkl%redhat.com
a0a2dde0c5 Bug 141326 - broken hyperlink in editkeywords.cgi. Fix by dkl@redhat.com. 2xr=Gerv
git-svn-id: svn://10.0.0.236/trunk@120340 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-30 22:15:52 +00:00
gerv%gerv.net
33a5971d2a Bug 140784 - edit*.cgi need a use lib "." on Win32/IIS w/ taint. Patch by jouni@heikniemi.net; r=bbaetz, gerv.
git-svn-id: svn://10.0.0.236/trunk@120207 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-29 19:32:29 +00:00
cyeh%bluemartini.com
1eb8f5b435 stupid lamo fix for 69621: Keyword cache not updated on keyword rename/delete.
now give warning to admin that keyword cache should be rebuilt after any keyword
edit or deletion.


git-svn-id: svn://10.0.0.236/trunk@88026 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-26 23:25:22 +00:00
tara%tequilarista.org
260f66bb3f Landing Jon Robertson's for bug #41913
git-svn-id: svn://10.0.0.236/trunk@74764 18797224-902f-48f8-a5cc-f745e15eee43
2000-07-25 22:09:20 +00:00
terry%mozilla.org
44682785ae Patch by Klaas Freitag <freitag@suse.de>, with modifications by me --
don't generate HTML tables with more than 50 lines, as browsers generally
can't cope with huge tables.


git-svn-id: svn://10.0.0.236/trunk@58402 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-22 16:51:49 +00:00
terry%mozilla.org
ba523f0ca7 Let's outlaw whitespace in keywords.
git-svn-id: svn://10.0.0.236/trunk@58252 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-19 19:26:37 +00:00
terry%mozilla.org
b541dc2d83 Patch by Ramon Felciano <felciano@ingenuity.com>, with many tweaks by
me.  Added a footer to every page.  Add some options to do things like
display checkboxes instead of scrolling lists, and a new formatting
for email diffs, and show list items capitalized instead of all upper
case.


git-svn-id: svn://10.0.0.236/trunk@57846 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-14 22:35:49 +00:00
terry%mozilla.org
ca31e66d94 Worked around bug in older versions of MySQL that caused a report of
one bug matching a keyword when there really are zero.


git-svn-id: svn://10.0.0.236/trunk@57309 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-11 00:26:22 +00:00
terry%mozilla.org
afb8532267 Add support for a new "keywords" feature. This lets some central
authority maintain a list of keywords, and users can associate any
keyword with any bug.

The new functionality won't appear until at least one keyword is
defined.

Note that you *must* run the "checksetup.pl" script after updating
this change, in order to create the new required tables "keywords" and
"keyworddefs".


git-svn-id: svn://10.0.0.236/trunk@56992 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-06 21:16:15 +00:00