43 Commits

Author SHA1 Message Date
lpsolit%gmail.com
529ea73dda Bug 304696: Replace UserInGroup() by $user->in_group() when checking user privs in edit*.cgi files - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@180314 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-15 22:01:56 +00:00
lpsolit%gmail.com
0ae6032660 Bug 302955: Remove the "delete" link for the default milestone - Patch by Gavin Shelley <bugzilla@chimpychompy.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@179161 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-28 17:41:53 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
lpsolit%gmail.com
83a5c11c27 Bug 300952: Change the editmilestones.cgi code to use Milestone.pm and Product.pm - Patch by Tiago R. Mello <timello@gmail.com> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@176719 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-28 00:35:50 +00:00
lpsolit%gmail.com
7d9ef54063 Bug 301440: Move LogActivityEntry out of CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@176334 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-20 15:58:45 +00:00
lpsolit%gmail.com
ed2d1d2aa6 Bug 279303: Negative numbers are rejected as invalid sortkeys for milestones - Patch by Peter D. Stout <pds@edgedynamics.com> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@173006 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-03 19:44:59 +00:00
lpsolit%gmail.com
9e4a52fdf0 Bug 86328: Deleting bugs doesn't delete dependent records properly - Patch by Frederic Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@171752 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-06 00:19:56 +00:00
mkanat%kerio.com
833b2e61f6 Bug 286235: Implicit joins should be replaced by explicit joins - installment A
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@171610 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-04 21:52:06 +00:00
mkanat%kerio.com
fda3b0dd8f Bug 174295: ANSI SQL requires all columns in SELECT to be in GROUP BY, unless they are in "aggregate" functions
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@170751 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-16 00:27:15 +00:00
travis%sedsystems.ca
7351a5b76b Bug 283581 : Move UserInGroup out of globals.pl
Patch by Colin Ogilvie <colin.ogilvie@gmail.com>   r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170734 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 22:10:14 +00:00
mkanat%kerio.com
64adf228bd Bug 284975: Any code after Throw*Error is a dead code.
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@170414 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-09 00:26:39 +00:00
mkanat%kerio.com
7f1a179da7 Bug 277782: _throw_error should unlock tables when tables are locked, automatically
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=travis, r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170180 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-05 00:18:48 +00:00
mkanat%kerio.com
a88c76e484 Bug 280503: Replace "LOCK/UNLOCK TABLES" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=myk


git-svn-id: svn://10.0.0.236/trunk@169333 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 21:57:27 +00:00
travis%sedsystems.ca
34a792676d Bug 281574 : Combine version_/milestone_/component_no_action errors into one.
Patch by Shane H. W. Travis <travis@sedsystems.ca>   r=LpSolit  a=myk


git-svn-id: svn://10.0.0.236/trunk@169255 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-16 16:35:54 +00:00
travis%sedsystems.ca
81f64817cf Bug 257315 : type of delta_ts in bugs table should not be timestamp
Patch by Tomas Kopal <Tomas.Kopal@altap.cz>  r=mkanat, LpSolit   a=justdave


git-svn-id: svn://10.0.0.236/trunk@168981 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-08 16:51:03 +00:00
justdave%bugzilla.org
2541fed321 Backing out the checking from bug 257315 until it gets corrected. It prevents new bugs from being filed.
a=justdave


git-svn-id: svn://10.0.0.236/trunk@168520 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-30 04:22:28 +00:00
travis%sedsystems.ca
e652a2da94 Bug 257315 : type of delta_ts in bugs table should not be timestamp
Patch by Tomas Kopal <Tomas.Kopal@altap.cz>   r=vladd, LpSolit  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168456 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-28 19:01:28 +00:00
jocuri%softhome.net
6e30566dcd Patch for bug 265898: edit*.cgi files should all use ThrowUserError(); patch by Frédéric Buclin <LpSolit@gmail.com>, r=vladd, a=myk.
git-svn-id: svn://10.0.0.236/trunk@167820 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 14:07:31 +00:00
justdave%bugzilla.org
3a2a77f17f Bug 190224: templatize editmilestones.cgi
Patch by GavinS <bugzilla@chimpychompy.org>
r=jouni, a=justdave


git-svn-id: svn://10.0.0.236/trunk@162137 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-11 06:48:14 +00:00
bugreport%peshkin.net
3f5ac54b70 Bug 252450: Unlock tables in edit*.cgi before sending trailer
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159908 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-27 15:13:48 +00:00
jocuri%softhome.net
db81c64307 Patch for bug 246328: make editmilestone check for invalid sortkeys; patch by Byron Jones (glob) <bugzilla@glob.com.au>; r=vladd; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@157962 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-16 13:45:37 +00:00
jocuri%softhome.net
87bbc5f58d Patch for bug 245976: fix software error caused by taint issue when trying to add a milestone; patch by Byron Jones (glob) <bugzilla@glob.com.au>; r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@157788 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-11 17:03:50 +00:00
jouni%heikniemi.net
02eb0122e5 Bug 141006: Run edit*.cgis in taint mode.
Patch by byron jones <bugzilla@glob.com.au>
r=jouni, a=justdave


git-svn-id: svn://10.0.0.236/trunk@156794 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-23 07:22:32 +00:00
justdave%syndicomm.com
62d042aa7a Bug 235265: Getting rid of some unwanted form value dumps.
Patch by Jouni Heikniemi <jouni@heikniemi.net>
r= justdave, kiko; a= justdave


git-svn-id: svn://10.0.0.236/trunk@154332 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 04:35:37 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
bbaetz%acm.org
8fabd677ea Bug 208604 - Make data/template dir locations configurable
git-svn-id: svn://10.0.0.236/trunk@149624 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-22 03:50:42 +00:00
justdave%syndicomm.com
cc02c583c8 Bug 76157: Give proper error message on non-numeric sortkey when editing milestones.
Patch by jocuri@softhome.net (Vlad Dascalu)
r=kiko, a=justdave


git-svn-id: svn://10.0.0.236/trunk@147305 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-25 19:59:44 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
timeless%mozdev.org
54125fd66d Bug 65319 editmilestones & editversions don't have extra add.
r=justdave a=justdave


git-svn-id: svn://10.0.0.236/trunk@140437 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-30 02:46:21 +00:00
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-27 00:07:02 +00:00
jouni%heikniemi.net
43ad36f698 Bug 148093: editmilestones.cgi shows 'xyzzy' as product bug count. r=bbaetz, a=justdave
git-svn-id: svn://10.0.0.236/trunk@136357 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-15 06:26:25 +00:00
gerv%gerv.net
ba1cc2d33d Bug 173581 - Changing milestone sortkeys is broken. Patch by gerv; r=bbaetz.
git-svn-id: svn://10.0.0.236/trunk@131680 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-10 06:54:58 +00:00
bbaetz%student.usyd.edu.au
71381b40ed Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
r=joel x2


git-svn-id: svn://10.0.0.236/trunk@128080 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-26 06:17:26 +00:00
bbaetz%student.usyd.edu.au
1c2ecdc9c2 Bug 43600 - Convert products/components to use ids instead of names.
Initial attempt by jake@bugzilla.org, updated by me
r=joel, preed


git-svn-id: svn://10.0.0.236/trunk@127057 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-12 05:43:05 +00:00
bbaetz%student.usyd.edu.au
4403bbe04e Bug 151053, ConnectToDatabase/quietly_check_login sometimes not called
early enough
r=mattyt, jouni


git-svn-id: svn://10.0.0.236/trunk@123428 18797224-902f-48f8-a5cc-f745e15eee43
2002-06-17 09:39:48 +00:00
gerv%gerv.net
33a5971d2a Bug 140784 - edit*.cgi need a use lib "." on Win32/IIS w/ taint. Patch by jouni@heikniemi.net; r=bbaetz, gerv.
git-svn-id: svn://10.0.0.236/trunk@120207 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-29 19:32:29 +00:00
bbaetz%student.usyd.edu.au
b503102b3d Bug 106377 - processmail rescanall should use lastdiffed
r=justdave, ddkilzer@theracingworld.com


git-svn-id: svn://10.0.0.236/trunk@115685 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-03 22:06:20 +00:00
justdave%syndicomm.com
d27f46ad1e Fix for bug 104516: No code changes in this patch, all this checkin does is remove all tabs from the bugzilla source and replace it with the appropriate number of spaces (in most cases 8) to line up with existing code. This is part of the effort to bring the existing codebase up to par with our style guidelines.
Patch by Jake Steehagen <jake@acutex.net>
r= justdave x2


git-svn-id: svn://10.0.0.236/trunk@105335 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-13 01:36:17 +00:00
jake%acutex.net
c88b002e96 Fix for bug 71396 - $::db->do isn't needed anymore
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@97282 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-16 14:51:16 +00:00
justdave%syndicomm.com
d7eedf0b29 Fix for bug 74394: editmilestones.cgi can't edit the name and sortkey at the same time
Patch by slee@uk.bnsmc.com (Stephen Lee)


git-svn-id: svn://10.0.0.236/trunk@91581 18797224-902f-48f8-a5cc-f745e15eee43
2001-04-06 16:47:49 +00:00
cyeh%bluemartini.com
53b0e2dfbe fix for 44617: edit*.cgi: Should show which product you're working on
patches by mtakacs@pacbell.net (Tak)


git-svn-id: svn://10.0.0.236/trunk@77688 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-30 23:44:36 +00:00
terry%mozilla.org
0b585584c0 Added the concept of a "default milstone" for products, and make sure
that all products have at least that milestone defined.


git-svn-id: svn://10.0.0.236/trunk@63866 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-23 18:23:14 +00:00
terry%mozilla.org
3c786fb189 Patch by "Matt Masson" <matthew@zeroknowledge.com> -- allow definition
of different target milestones by product.


git-svn-id: svn://10.0.0.236/trunk@63597 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-21 16:47:06 +00:00