103 Commits

Author SHA1 Message Date
bugreport%peshkin.net
205c3f3402 Bug 304583: Remove all remaining need to rederive inherited groups
Patch by Joel Peshkin <bugreport@peshkin.net>
r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@178200 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-18 20:09:37 +00:00
mkanat%kerio.com
0cbbdcfee7 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177695 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-13 12:27:04 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
bugreport%peshkin.net
9778732be8 Backout of bug 303669 which broke AppendComment and possibly a number
of other items.


git-svn-id: svn://10.0.0.236/trunk@177419 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 11:23:43 +00:00
mkanat%kerio.com
7bbde62ad3 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177413 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 05:59:02 +00:00
lpsolit%gmail.com
3900c1f7e8 Bug 301507: Move PutHeader and PutFooter into Template.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=justdave
git-svn-id: svn://10.0.0.236/trunk@176432 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-22 05:13:36 +00:00
lpsolit%gmail.com
5338250561 Bug 298826: Fixes some spelling errors - Patch by Frank Wein <bugzilla@mcsmurf.de> r=timeless a=myk
git-svn-id: svn://10.0.0.236/trunk@175351 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-29 22:18:21 +00:00
lpsolit%gmail.com
e136cf91c8 Bug 298024: Incorrect group control check in sanitycheck.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel a=myk
git-svn-id: svn://10.0.0.236/trunk@175350 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-29 22:07:31 +00:00
lpsolit%gmail.com
3119add904 Bug 277454: Bugs in inactivated groups don't show padlocks on the buglist - Patch by Marc Schumann <wurblzap@gmail.com> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@175141 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-25 12:15:19 +00:00
mkanat%kerio.com
5c30640687 Bug 293501: Add me to files where I belong and fix kerio.com emails
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=colin, a=myk


git-svn-id: svn://10.0.0.236/trunk@174620 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-15 03:55:00 +00:00
lpsolit%gmail.com
acb5932a28 Bug 288461: sanitycheck.cgi should permit to clean all invalid references to deleted bugs - Patch by Frédéric Buclin <LpSolit@gmail.com> r=glob a=justdave
git-svn-id: svn://10.0.0.236/trunk@172036 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-12 17:24:33 +00:00
mkanat%kerio.com
833b2e61f6 Bug 286235: Implicit joins should be replaced by explicit joins - installment A
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@171610 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-04 21:52:06 +00:00
lpsolit%gmail.com
1508a8a946 Bug 286311: print "Context-type..." is used instead of print $cgi->header() (cookies aren't sent in header) - Patch by Jacob Steenhagen <jake@bugzilla.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@170839 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-17 15:14:58 +00:00
mkanat%kerio.com
fda3b0dd8f Bug 174295: ANSI SQL requires all columns in SELECT to be in GROUP BY, unless they are in "aggregate" functions
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@170751 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-16 00:27:15 +00:00
travis%sedsystems.ca
7351a5b76b Bug 283581 : Move UserInGroup out of globals.pl
Patch by Colin Ogilvie <colin.ogilvie@gmail.com>   r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170734 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 22:10:14 +00:00
mkanat%kerio.com
abc539470f Bug 285534: bugs.qa_contact should allow NULL
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170685 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 05:20:48 +00:00
mkanat%kerio.com
1194a36cb5 Bug 285692: lastdiffed should use NULL instead of the "beginning of time"
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=glob, a=myk


git-svn-id: svn://10.0.0.236/trunk@170574 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-11 19:45:03 +00:00
travis%sedsystems.ca
7f544517dc Bug 282574 : use the new "auth_failure" error message for all authentication failures
Patch by Frederic Buclin <LpSolit@gmail.com>   r=travis, wurblzap  a=myk


git-svn-id: svn://10.0.0.236/trunk@170439 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-09 16:18:03 +00:00
mkanat%kerio.com
d7c4f4e167 Bug: 284244: DATE_SUB and DATE_ADD are not ANSI SQL
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=wicked, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170128 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-03 07:19:10 +00:00
bugreport%peshkin.net
5cf318e2f3 Bug 283031: Sanitycheck can't send un-sent mail (SQL error)
Patch by Joel Peshkin <bugreport@peshkin.net>
r=wurblzap,a=myk


git-svn-id: svn://10.0.0.236/trunk@169889 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-26 06:34:20 +00:00
mkanat%kerio.com
758dc178e5 Bug 17453: Enumerators in Bugzilla are not cross-DB compatible. This removes all 'enum' types in the database from Bugzilla.
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@169792 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-24 22:43:28 +00:00
bugreport%peshkin.net
b06e4c09c4 Bug 282914: Fix broken sanitycheck.cgi due to missing ")"
r,a=justdave


git-svn-id: svn://10.0.0.236/trunk@169536 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-20 17:32:55 +00:00
bugreport%peshkin.net
ebc3a257dd Bug 282835: Fix SQL error in sanitycheck.cgi
patch by LpSolit
r=joel,a=justdave


git-svn-id: svn://10.0.0.236/trunk@169535 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-20 17:18:40 +00:00
mkanat%kerio.com
4366849e89 Bug 280502: Replace "INTERVAL" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@169516 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-20 08:02:07 +00:00
mkanat%kerio.com
fe14d8a2d1 Bug 280497: Replace "LIMIT" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=justdave


git-svn-id: svn://10.0.0.236/trunk@169390 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 16:14:27 +00:00
mkanat%kerio.com
a88c76e484 Bug 280503: Replace "LOCK/UNLOCK TABLES" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=myk


git-svn-id: svn://10.0.0.236/trunk@169333 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 21:57:27 +00:00
travis%sedsystems.ca
81f64817cf Bug 257315 : type of delta_ts in bugs table should not be timestamp
Patch by Tomas Kopal <Tomas.Kopal@altap.cz>  r=mkanat, LpSolit   a=justdave


git-svn-id: svn://10.0.0.236/trunk@168981 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-08 16:51:03 +00:00
travis%sedsystems.ca
8a81a01901 Bug 276838 : Eliminate use of $::unconfirmedstate
Patch by Max Kanat-Alexander <mkanat@kerio.com>  r=wurblzap  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168979 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-08 16:22:26 +00:00
justdave%bugzilla.org
2541fed321 Backing out the checking from bug 257315 until it gets corrected. It prevents new bugs from being filed.
a=justdave


git-svn-id: svn://10.0.0.236/trunk@168520 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-30 04:22:28 +00:00
travis%sedsystems.ca
e652a2da94 Bug 257315 : type of delta_ts in bugs table should not be timestamp
Patch by Tomas Kopal <Tomas.Kopal@altap.cz>   r=vladd, LpSolit  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168456 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-28 19:01:28 +00:00
jocuri%softhome.net
675ba798a6 Patch for bug 266137: Add missing cross checks in sanitycheck.cgi; patch by Marc Schumann <wurblzap@gmail.com>, r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@166483 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-09 09:36:51 +00:00
jocuri%softhome.net
94ec8ecff6 Patch for bug 249798: improve SQL capitalization in sanitycheck.cgi; r=joel, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@158766 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-05 21:19:34 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
bugreport%peshkin.net
989f63c4bf Bug 127862:Have sanitycheck.cgi use perl to evaluate email regexp
r=vlad,a=justdave


git-svn-id: svn://10.0.0.236/trunk@154248 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-25 14:32:18 +00:00
jocuri%softhome.net
90d8fc94e3 Patch for bug 234896; makes sanitycheck.cgi use $cgi->param instead of ::FORM; patch by Teemu Mannermaa <wicked@etlicon.fi>; r=kiko; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@153375 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-29 14:24:06 +00:00
justdave%syndicomm.com
6b0d9c3e42 Bug 190040: sanitycheck now has "view as buglist" links after lists of bugs as well as all listed bugs linked
Patch by GavinS <bugzilla@chimpychompy.org>
r= justdave, a= justdave


git-svn-id: svn://10.0.0.236/trunk@146505 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-02 01:37:55 +00:00
bbaetz%acm.org
726bcd99cc Bug 180635 - Enhance Bugzilla::User to store additional information
r=myk,jake


git-svn-id: svn://10.0.0.236/trunk@143228 18797224-902f-48f8-a5cc-f745e15eee43
2003-06-03 09:48:15 +00:00
bbaetz%acm.org
8d7e3b6e3d Bug 180086 - Rename 'count' column in votes tables
patch by bugzilla@chimpychompy.org (GavinS)
r=bbaetz,justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@141872 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-27 07:20:39 +00:00
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-27 00:07:02 +00:00
justdave%syndicomm.com
b944887bd0 Bug 196101: use ANSI-compliant SQL for group checks in sanitycheck
git-svn-id: svn://10.0.0.236/trunk@139150 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-08 08:29:01 +00:00
preed%sigkill.com
017bee49ea Bug 124174 - make processmail a package (Bugzilla::BugMail), r=gerv, r=jth, a=justdave
git-svn-id: svn://10.0.0.236/trunk@137613 18797224-902f-48f8-a5cc-f745e15eee43
2003-02-09 22:04:25 +00:00
bugreport%peshkin.net
8bd91adeeb Bug 147275 Rearchitect product groups
Patch by joel
r=bbaetz,justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@134383 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-24 19:56:34 +00:00
gerv%gerv.net
d6fe11dfdb Bug 163114 - Templatise all calls to DisplayError. Patch D (the last one). Patch by gerv; r=burnus.
git-svn-id: svn://10.0.0.236/trunk@131264 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-06 11:52:37 +00:00
matty%chariot.net.au
02150d6352 ... and also fix a bug introduced trying to unrot the general bug check rewrite, due to product IDs.
git-svn-id: svn://10.0.0.236/trunk@131240 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 15:29:20 +00:00
matty%chariot.net.au
1c05ab7258 Back out a stupid stupid change I made earlier when fixing the stupid stupid bustage I made even earlier. I need sleep.
git-svn-id: svn://10.0.0.236/trunk@131239 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 15:26:23 +00:00
matty%chariot.net.au
c5399b95da ... oops missed a reviewer checkin condition.
git-svn-id: svn://10.0.0.236/trunk@131238 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 15:08:50 +00:00
matty%chariot.net.au
84277bc1b7 Bug #93667: Minor style fix, uninit var fix, add explanatory comments to CrossCheck/DoubleCrossCheck.
git-svn-id: svn://10.0.0.236/trunk@131237 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 15:07:16 +00:00
matty%chariot.net.au
141d8c1565 Bug #93667: More movement, commenting, and remove an unused variable.
git-svn-id: svn://10.0.0.236/trunk@131236 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 14:37:52 +00:00
matty%chariot.net.au
924bd2581c Bug #93667: Move some code around, add some section heading comments.
git-svn-id: svn://10.0.0.236/trunk@131235 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 14:25:13 +00:00
matty%chariot.net.au
53ca666882 Bug #93667: Rewrite double cross checking.
git-svn-id: svn://10.0.0.236/trunk@131234 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 14:14:47 +00:00