163 Commits

Author SHA1 Message Date
uriber%gmail.com
09e8c4f558 Refactor nsIFrame::PeekOfset to use iteration instead of recursion, and some related refactoring. bug=300131 r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@209685 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-11 06:39:56 +00:00
uriber%gmail.com
bf3c2a0692 Moved mCaretBidiLevel and its accessors from nsPresShell to nsFrameSelection. Also added sBidiKeyboard as a static service to nsContentUtils. bug=346891 r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@206807 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-08 05:14:52 +00:00
uriber%gmail.com
17a6df652a Enable PeekOffset to find the visual beginning/end of a line, and use use it for bidi caret positioning. bug=302051 r=smontagu sr=roc
git-svn-id: svn://10.0.0.236/trunk@206472 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-03 06:24:11 +00:00
sharparrow1%yahoo.com
f7e771c4b2 Bug 345371: add null checks for weak pointers in nsCaret. r+sr=roc.
git-svn-id: svn://10.0.0.236/trunk@203306 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-20 23:26:05 +00:00
smontagu%smontagu.org
eedadb760a Only display a bidirectional caret on platforms that implement nsIBidiKeyboard. Bug 272096, r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@201667 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-06 08:29:53 +00:00
mrbkap%gmail.com
2f57fc6f5e Only recalculate the caret's rect when we're not currently drawn in an attempt to avoid caret turds when we're being notified of the caret movement after the frame has already been marked dirty. bug 335834, r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@195947 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-04 00:05:22 +00:00
mrbkap%gmail.com
64f5c8e34a Update the caret position after reflows to avoid turds. bug 334649, r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@195632 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-28 04:33:41 +00:00
roc+%cs.cmu.edu
0efb95265d Bug 330305. Rename nsSelection to nsFrameSelection, and deCOMtaminate it, removing nsIFrameSelection. patch by Marc Liddell, r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@195411 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-26 01:57:22 +00:00
mrbkap%gmail.com
07437f7122 Make the caret paint in the same color as the foreground so it's not always painted black. bug 334635, r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@195087 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-21 19:13:58 +00:00
mrbkap%gmail.com
b8eef2bbb9 Draw the caret in the normal path of frame painting instead of doing it directly to the current view. bug 287813, r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@194553 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-17 23:16:46 +00:00
dbaron%dbaron.org
f982efe3c6 One-line descriptions of files, partly because they show up in LXR.
git-svn-id: svn://10.0.0.236/trunk@193246 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-30 05:56:38 +00:00
uriber%gmail.com
60d1fa7f53 In nsTextEditRules::CheckBidiLevelForDeletion(), use nsSelection::GetPrevNextBidiLevels to determine bidi levels. bug=330460 r=smontagu sr=roc
git-svn-id: svn://10.0.0.236/trunk@192841 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-23 08:20:29 +00:00
smontagu%smontagu.org
1500b61ab0 Bug 305798: Bidi: After deleting last character of reverse-direction text, arrow keys move caret incorrectly. Patch by Uri Bernstein <uriber@gmail.com, r=smontagu, sr=roc
git-svn-id: svn://10.0.0.236/trunk@184752 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-16 09:37:01 +00:00
mark%moxienet.com
b54efc8cca Bug 311399, Crash [@ SetOrigin] during rendering context destruction. Remove QD save/restore from rendering context, it was placed there as a workaround for scrollbar functional and aesthetic bugs. Add OS event handler to fix aesthetic problems, and check for bad states to work around functional problems. r=josh sr=smfr
git-svn-id: svn://10.0.0.236/trunk@184389 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-10 03:46:52 +00:00
masayuki%d-toybox.com
286962ae64 Bug 313918 IME candidate list is positioned to wrong position if the caret is positioned non-root view r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@183235 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-29 12:43:51 +00:00
roc+%cs.cmu.edu
5e553cf7c6 Bug 311152. Make DOM selection changes repaint the caret in the new position. r=mrbkap,sr=dbaron
git-svn-id: svn://10.0.0.236/trunk@182107 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-12 18:40:38 +00:00
aaronleventhal%moonset.net
3d26c8dcab Bug 193316. Caret not visible in readonly fields (HTML or XUL). r=mrbkap, sr=smfr
git-svn-id: svn://10.0.0.236/trunk@181542 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-04 03:14:03 +00:00
mats.palmgren%bredband.net
2c5ee7ad68 Caret drawn at incorrect position after typing a single LTR character in a blank RTL input field (or vice versa) while caret is visible. b=307533 r=uriber sr=bzbarsky
git-svn-id: svn://10.0.0.236/trunk@179957 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-10 11:14:48 +00:00
mrbkap%gmail.com
210f1d6d3a bug 303399: Bidi: Problems with caret positioning on blank lines. Patch by Uri Bernstein <uriber@gmail.com>. r=mrbkap sr=roc
git-svn-id: svn://10.0.0.236/trunk@178798 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-24 17:44:28 +00:00
mats.palmgren%bredband.net
2750874396 Erase caret if needed when content is removed. b=304383 r=mrbkap sr=bzbarsky
git-svn-id: svn://10.0.0.236/trunk@178577 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-22 00:25:20 +00:00
mats.palmgren%bredband.net
cfa8f92f51 Don't use a Frame pointer to remember where we last painted the caret, instead use Content+offset+hint. b=296464 r=mrbkap sr=roc a=cbeard
git-svn-id: svn://10.0.0.236/trunk@177536 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-11 03:44:16 +00:00
dougt%meer.net
3d7bcc8055 Windows CE build changes. This addresses most of the outstanding Windows
CE compilation issues.

This patch also fixes/removes CheckStackGrowthDirection assertions in
Javscript.  This change is based on bug 242518.  See comment 36.

This patch also removes the unused enum in transformiix .  See bug
292118.

r/sr = dveditz/shaver
b    = 291229
a    = asa


git-svn-id: svn://10.0.0.236/trunk@172870 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-29 13:33:49 +00:00
mats.palmgren%bredband.net
8e0c90b5bf Account for the view's origin not lining up with the widget's. b=190290 r=bzbarsky sr=roc
git-svn-id: svn://10.0.0.236/trunk@171239 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-26 14:50:09 +00:00
bzbarsky%mit.edu
bf4a89a327 Fix crashes in GTK1 builds due to reuse of rendering contexts for the caret.
Bug 254049, patch by Mark Banner <mark@standard8.demon.co.uk>, r=jst, sr=roc


git-svn-id: svn://10.0.0.236/trunk@168663 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-01 21:19:05 +00:00
bryner%brianryner.com
8ed5dd41fb Remove nsIAutoCopy and fold the functionality into nsSelection.cpp (bug 231343). r+sr=roc.
git-svn-id: svn://10.0.0.236/trunk@168595 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-31 23:47:26 +00:00
bmlk%gmx.de
e547c59f49 remove unused prescontext argument from GetOffsetFromView bug 276015 r/sr=dbaron
git-svn-id: svn://10.0.0.236/trunk@167037 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-26 19:48:54 +00:00
smontagu%smontagu.org
6bd2ade893 Prevent the right-to-left directional hook from overlapping the caret and make both directions thinner. Bug 264903, r=mkaply, aaronleventhal, sr=rbs.
git-svn-id: svn://10.0.0.236/trunk@165954 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-30 19:28:00 +00:00
neil%parkwaycc.co.uk
df2668e776 Don't use QueryInterface to get a scrollable view from a view b=258521 r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@165693 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-24 00:19:21 +00:00
scott%scott-macgregor.org
cffb27d629 Try landing the fix for infamous Bug #98564 again -->
caret overlaps the last character in textfield (if positioned after the last char)

r=smontagu
sr=sfraser

We think this patch can land again because the regression it introduced was fixed by
Bug #216101 which does a better job of clearing out caret fragments.


git-svn-id: svn://10.0.0.236/trunk@165192 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-10 07:14:08 +00:00
aaronleventhal%moonset.net
ddfefbb3fc Fixing bustage
git-svn-id: svn://10.0.0.236/trunk@163643 18797224-902f-48f8-a5cc-f745e15eee43
2004-10-13 02:24:38 +00:00
aaronleventhal%moonset.net
2ed5e7dde3 Bug 261054. Make caret consistently the same width throughout Gecko/Mozilla. Configurable through ui.caretWidth. r=glazou, sr=rbs
git-svn-id: svn://10.0.0.236/trunk@163639 18797224-902f-48f8-a5cc-f745e15eee43
2004-10-13 01:12:14 +00:00
neil%parkwaycc.co.uk
7903ea1651 Don't use QueryInterface to get a view from a scrollable view b=258521 r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@162561 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-20 22:25:07 +00:00
bryner%brianryner.com
43628f9edf More nsIPresShell deCOMtamination:
- Made Get/SetAuthorStyleDisabled and ReconstructStyleData non-virtual when called internally.
- Inlined GetFrameSelection and renamed it to FrameSelection.
- Removed non-inline version of GetViewManager.
- Removed unused EnablePrefStyleRules and ArePrefStyleRulesEnabled.

Bug 253889, r+sr=roc.


git-svn-id: svn://10.0.0.236/trunk@161442 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-29 03:08:44 +00:00
bryner%brianryner.com
2dbfb983b1 Remove refcounting version of nsIPresShell::GetPresContext. Bug 253889, r+sr=roc.
git-svn-id: svn://10.0.0.236/trunk@161072 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-20 20:34:37 +00:00
bryner%brianryner.com
865734bf2f Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc
git-svn-id: svn://10.0.0.236/trunk@160184 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-31 23:15:21 +00:00
caillon%redhat.com
51be7e015f Bug 241507
Don't create new rendering contexts for each caret drawn on *nix platforms since there are no known issues with doing so.  If issues crop up, I will undo this change.
r/sr=jst/bryner


git-svn-id: svn://10.0.0.236/trunk@158583 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-29 19:12:19 +00:00
neil%parkwaycc.co.uk
1ac48881d7 Bug 216101 Cleaing frame refs can leave caret fragments p=mnyromyr@tprac.de r/sr=roc
git-svn-id: svn://10.0.0.236/trunk@158466 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-25 09:57:35 +00:00
bryner%brianryner.com
1df9753a77 Get rid of nsILanguageAtom and deCOMtaminate nsILanguageAtomService (bug 230603). Also, fix a bunch of atom double-addref leaks in nsFontMetricsXlib. r+sr=dbaron.
git-svn-id: svn://10.0.0.236/trunk@157620 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-08 23:53:59 +00:00
smontagu%smontagu.org
d1a1c12261 DeCOMtaminate nsIFrame Set/GetProperty and merge Set/GetBidiProperty with it. Bug 117751, r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@157214 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-01 06:20:16 +00:00
sspitzer%mozilla.org
6115060022 bullet proofing (wall paper) fix for top crasher bug #243294
now we just assert, instead of crash. see bug #245055 about the real problem.

Crash [@ nsCaret::GetViewForRendering] when printing a schedule from www.matkahuolto.info

r/sr=roc


git-svn-id: svn://10.0.0.236/trunk@157103 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-29 19:57:00 +00:00
gerv%gerv.net
2ac510b678 Bug 236613: change to MPL/LGPL/GPL tri-license.
git-svn-id: svn://10.0.0.236/trunk@155068 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-18 14:30:37 +00:00
tor%cs.brown.edu
996688b00b Bug 240274 - remove PopState() argument. r=blizzard, sr=bryner
git-svn-id: svn://10.0.0.236/trunk@155061 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-18 13:13:35 +00:00
bryner%brianryner.com
2359d2f7c4 More nsIPresContext deCOMtamination (bug 229371). r+sr=roc.
git-svn-id: svn://10.0.0.236/trunk@154743 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-13 00:28:44 +00:00
bryner%brianryner.com
e6a225b469 Inline getters and setters for scaling factors on nsIDeviceContext. Bug 233103, r+sr=dbaron.
git-svn-id: svn://10.0.0.236/trunk@152326 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-05 01:57:10 +00:00
bryner%brianryner.com
5b5cd321a4 Guarantee that the pres context's device context will be non-null by returning failure from Init() if it's null. Rename inline getter GetDeviceContext() to DeviceContext(), convert all callers to use the inline getter, and remove the virtual/refcounting getter. Bug 229371, r+sr=dbaron.
git-svn-id: svn://10.0.0.236/trunk@152182 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-02 22:17:21 +00:00
bryner%brianryner.com
70bf134ff4 Continuing nsIPresContext deCOMtamination (bug 229371). Remove GetImageLoadFlags (unused). Make failure to fetch the LookAndFeel service cause Init() to fail, don't null check it after that, and inlined the getter. Move IOService caching to nsImageFrame, the only user of it. r+sr=bzbarsky.
git-svn-id: svn://10.0.0.236/trunk@151636 18797224-902f-48f8-a5cc-f745e15eee43
2004-01-21 09:35:59 +00:00
scott%scott-macgregor.org
9b5f51c6ea Bug #226325 --> Back out the fix for Bug #98564 as this opened us up to a regression where trailing stationary caret remnant left after backspace.
a=asa for 1.6b


git-svn-id: svn://10.0.0.236/trunk@149984 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-03 20:32:47 +00:00
scott%scott-macgregor.org
d0644ba3e9 Bug #98564 --> caret overlaps the last character in textfield (if positioned after the last char).
Patch written by kin.


r=smontagu
sr=sfraser


git-svn-id: svn://10.0.0.236/trunk@149398 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-16 07:08:55 +00:00
bryner%brianryner.com
dbbc84bf94 Fix build on gcc 3.4 by removing extra semicolons (bug 218551). r/sr=dbaron, a=brendan.
git-svn-id: svn://10.0.0.236/trunk@146620 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-07 22:37:27 +00:00
jaggernaut%netscape.com
df747d0621 Bug 213602: Switch some users of NS_GetWeakReference over to do_GetWeakReference. r=bzbarsky, sr=dbaron
git-svn-id: svn://10.0.0.236/trunk@145205 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-25 19:06:59 +00:00