roc+%cs.cmu.edu
0b0fa89131
Bug 226439. Convert codebase to use AppendLiteral/AssignLiteral/LowerCaseEqualsLiteral. r+sr=darin
...
git-svn-id: svn://10.0.0.236/trunk@157992 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-17 00:13:25 +00:00
ben%bengoodger.com
2c5f25702a
227640 - password is saved even when the password field has autocomplete="off", patch by Unknown W. Brackets <unknown@simplemachines.org> r=bryner
...
git-svn-id: svn://10.0.0.236/trunk@157383 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-03 20:42:01 +00:00
bryner%brianryner.com
eeb18c5dbc
Bug 242956, only prefill usernames into text inputs and passwords into password inputs.
...
git-svn-id: svn://10.0.0.236/trunk@157004 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-27 05:03:00 +00:00
mconnor%myrealbox.com
ac2d3f342c
firefox part of bug 232691 - replace nsString() nsAutoString() and friends with EmptyC?String(), patch by Charles Fenwick (clf03f@garnet.acns.fsu.edu), r=mconnor
...
git-svn-id: svn://10.0.0.236/trunk@156812 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-23 19:45:17 +00:00
bryner%brianryner.com
ede0c5da8f
One too many nsnulls...
...
git-svn-id: svn://10.0.0.236/trunk@155838 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-02 19:46:08 +00:00
mconnor%myrealbox.com
ac3616cc92
Bug 235815 - Improve button labels for Confirm Password Change dialog, patch by Logan Ingalls <log@plutor.org>, r=bryner
...
git-svn-id: svn://10.0.0.236/trunk@155833 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-02 17:32:55 +00:00
bienvenu%nventure.com
c12e53e60e
make nsILineInputStream take an nsACString ref, 197166, r=darin, sr=mscott, make local msg body search cache open file stream, use nsIFile instead of nsFileSpec to cut down on seeks, improve performance, sr=mscott 240538
...
git-svn-id: svn://10.0.0.236/trunk@155334 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-22 15:32:54 +00:00
bryner%brianryner.com
8a7cdc1d9c
Reapply fix for handling non-ASCII characters in signon file that was lost when migration branch landed. Bug 218405, fix originally r=darin sr=bz
...
git-svn-id: svn://10.0.0.236/trunk@154062 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-17 09:15:55 +00:00
ben%bengoodger.com
8f40f916bb
215094 - add new profile migrator interface, adapt password manager to support api for adding signons with details (235360)
...
git-svn-id: svn://10.0.0.236/trunk@153468 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-03 07:51:09 +00:00
bryner%brianryner.com
94f0619f3f
Guard against empty signon entry confusion by refusing to add new entries with empty user and empty password, fixing removal of these entries, and attempting to discard these entries as they are read in. Bug 231042.
...
git-svn-id: svn://10.0.0.236/trunk@152865 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-18 00:56:29 +00:00
bryner%brianryner.com
6a98f6b2ac
Null-check the document to protect against blur events generated during document teardown. Bug 225889.
...
git-svn-id: svn://10.0.0.236/trunk@152825 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-16 22:58:20 +00:00
ben%bengoodger.com
979a101f57
Migration Branch landing, currently turned off!
...
git-svn-id: svn://10.0.0.236/trunk@152787 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-15 01:49:37 +00:00
jst%mozilla.jstenback.com
172d5470ff
Fixing FireFox bustage.
...
git-svn-id: svn://10.0.0.236/trunk@152664 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-11 08:43:32 +00:00
bryner%brianryner.com
3063484a5e
Bug 228270 - Fix problem where UTF8 sequences in the password file were being re-encoded as UTF8 (as if from UTF16) when the password file is read in. r=darin, sr=bzbarsky
...
git-svn-id: svn://10.0.0.236/trunk@151526 18797224-902f-48f8-a5cc-f745e15eee43
2004-01-18 23:51:27 +00:00
bryner%brianryner.com
aebbd768e7
If encrypting the password fails (such as the user cancelling the master password prompt), then don't store the password entry.
...
git-svn-id: svn://10.0.0.236/trunk@151451 18797224-902f-48f8-a5cc-f745e15eee43
2004-01-17 07:10:07 +00:00
jst%mozilla.jstenback.com
cc17dc64e3
Fixing build bustage.
...
git-svn-id: svn://10.0.0.236/trunk@151132 18797224-902f-48f8-a5cc-f745e15eee43
2004-01-10 03:21:35 +00:00
bryner%brianryner.com
5148b50c81
Don't bother offering to remember a login with an empty username and password. Bug 217439.
...
git-svn-id: svn://10.0.0.236/trunk@150313 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-15 03:44:31 +00:00
bryner%brianryner.com
0ea2cf734a
Create password file with mode 0600 per bug 227100.
...
git-svn-id: svn://10.0.0.236/trunk@150240 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-12 10:04:08 +00:00
bryner%brianryner.com
e7d0e03f62
Fix bug 218927 - check the 'remember' check box initially if the password was already stored, and prevent duplicate entries from being created when using auth dialogs.
...
git-svn-id: svn://10.0.0.236/trunk@150207 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-11 05:47:28 +00:00
bryner%brianryner.com
eeddf02bde
deCOMtaminate nsIDocument by changing methods to use return value instead of out-params, eliminating unused nsresult return values, moving some members to nsIDocument and inlining the getters/setters. Bug 222134, r=bzbarsky, sr=jst.
...
git-svn-id: svn://10.0.0.236/trunk@148257 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-22 06:09:48 +00:00
bryner%brianryner.com
b91b7bf8aa
Check return results from DecryptData so that we don't bring up the master password dialog again if the user cancelled it the first time. Bug 220214.
...
git-svn-id: svn://10.0.0.236/trunk@147282 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-25 04:54:22 +00:00
bryner%brianryner.com
68b9c57d27
bug 217954/216395 - we need to assign to |userField| regardless of whether there is a value, so we don't crash later when trying to attach autocomplete to the field.
...
git-svn-id: svn://10.0.0.236/trunk@146499 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-01 21:11:30 +00:00
bryner%brianryner.com
6b4c4493e0
If the username or password field is pre-populated using the value attribute, then don't prefill either one. Also, remove ^M characters that should not be here.
...
git-svn-id: svn://10.0.0.236/trunk@146479 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-31 03:34:31 +00:00
bryner%brianryner.com
03a45d8fe9
Protect again recursing into DecryptData during autocompletion (due to opening the master password dialog and blurring the username input field).
...
git-svn-id: svn://10.0.0.236/trunk@146462 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-30 05:06:30 +00:00
bryner%brianryner.com
70ce18d57a
If the user has not set a master password and wants to use password manager, initialize the master password to an empty string. (bug 217409)
...
git-svn-id: svn://10.0.0.236/trunk@146408 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-28 05:22:23 +00:00
bryner%brianryner.com
ab01a6727a
Actually add the site to the reject list if the user said "Never for this site." Bug 216542.
...
git-svn-id: svn://10.0.0.236/trunk@146363 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-27 00:34:09 +00:00
bryner%brianryner.com
74b9d50d5e
Make the password manager hold onto the pref branch so that the observers we register with it don't go away. Bug 216219.
...
git-svn-id: svn://10.0.0.236/trunk@146155 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-18 06:09:52 +00:00
ben%bengoodger.com
d92ce84202
Fix for bug 216474 - Browser crashes in password manager. Ensure that we don't crash or overwrite variables used to hold valid password data fields with null. r=bryner
...
git-svn-id: svn://10.0.0.236/trunk@146147 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-17 21:06:36 +00:00
bryner%brianryner.com
05d8de869e
Don't prompt to save passwords, or prefill passwords, if saving passwords is disabled (bug 216219).
...
git-svn-id: svn://10.0.0.236/trunk@146113 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-17 05:52:17 +00:00
bryner%brianryner.com
91a57e9634
Address a couple of potential security problems by ensuring that usernames and passwords that are part of a URL are not included in the realm; don't do any signon storing or prefilling if the URI does not support hostnames.
...
git-svn-id: svn://10.0.0.236/trunk@145891 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-12 03:43:46 +00:00
bryner%brianryner.com
10fcafb2d7
Fix crash if the password field is the first field in a form.
...
git-svn-id: svn://10.0.0.236/trunk@145824 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-09 20:38:09 +00:00
bryner%brianryner.com
69efaa3bdd
Make this loop more correct - voidarray counts are PRInt32.
...
git-svn-id: svn://10.0.0.236/trunk@145788 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-09 03:48:34 +00:00
bryner%brianryner.com
366be79e73
Fix a compiler warning
...
git-svn-id: svn://10.0.0.236/trunk@145736 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-08 09:28:13 +00:00
bryner%brianryner.com
f28f6509e5
Split out nsSingleSignonPrompt into its own source file.
...
git-svn-id: svn://10.0.0.236/trunk@145589 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-05 05:40:14 +00:00
bryner%brianryner.com
27c8ae5e12
- Make the password manager control the autocomplete results for username fields, so that the list exactly matches the stored logins.
...
- Fix major problem where prompts weren't returning the field text.
- Only show the save checkbox in prompts if SAVE_PASSWORD_PERMANENTLY is given
- Only allow prompts to autocomplete if a password realm is given
git-svn-id: svn://10.0.0.236/trunk@145581 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-05 03:26:31 +00:00
bryner%brianryner.com
935bd89278
- Add DOMAutoComplete event, fired on a form input element when the user
...
selects a completion from the popup.
- Listen for DOMAutoComplete and Blur events instead of Change events to
trigger prefilling the password field.
- Fix an off-by-one error in the multi-user password change confirmation
(the stored password was being changed for the wrong entry).
- Fix skipping multiple logins when reading the signon file.
- Add missing license for Makefile.in.
git-svn-id: svn://10.0.0.236/trunk@145522 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-04 00:57:26 +00:00
bryner%brianryner.com
9105310b16
Lots of changes and bugfixes:
...
- Enable multiple username support by listening to change events for the username field when there is more than one stored login for the form.
- Make the signon hashtable store a SignonHashEntry, which has a pointer to the first SignonDataEntry. This lets us adjust the head of the linked list without a hashtable operation, and also fixes a case where we would continue using a deleted entry, leading to a crash.
- Change FindPasswordEntryFromSignonData to FnidPasswordEntryInternal, and refactor it a bit.
- Clean up prefill logic so that multiple forms on a page could be prefilled.
- Fix bug where the last input was used as the username field, instead of the input just before the password.
- Make sure we write out all entries for each realm.
- Make sure we include all entries in each realm when returning an enumerator.
- Remove some form manager cruft I missed in passwordManager.js.
git-svn-id: svn://10.0.0.236/trunk@145507 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-03 04:50:09 +00:00
bryner%brianryner.com
4aa4546bf9
Lazily decrypt username/password in nsIPassword objects so that requesting an enumerator doesn't immediately prompt for the master password.
...
git-svn-id: svn://10.0.0.236/trunk@145482 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-02 07:13:39 +00:00
bryner%brianryner.com
5844c9d8fa
Don't use the username as the password when creating a stored login.
...
git-svn-id: svn://10.0.0.236/trunk@145474 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-02 05:24:34 +00:00
bryner%brianryner.com
1141ad4e16
Fix stdcall bustage on windows
...
git-svn-id: svn://10.0.0.236/trunk@145465 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-01 20:41:41 +00:00
bryner%brianryner.com
abbc944adb
- Keep the user and password values encrypted in memory so that we can defer decryption (and prompting for the master password) until we need to prefill or the user brings up the manager.
...
- Add a comment about the randomness in secret decoder ring encryption.
git-svn-id: svn://10.0.0.236/trunk@145408 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-31 00:17:26 +00:00
bryner%brianryner.com
85272a10b3
If the user has already stored a login and enters the same username but a different password, don't prompt again, just update the stored password. (also fixes a bug where this caused two copies of the login to be stored)
...
git-svn-id: svn://10.0.0.236/trunk@145372 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-30 06:50:28 +00:00
bryner%brianryner.com
d53bc2b146
- Rename 'satchel' variables since this isn't part of satchel
...
- Make ~SignonDataEntry() delete the next entry in the list
- Fix some bustage from nsIFormSubmitObserver API changes
- Handle password change situations (2 or 3 password fields in a form)
- Make the signon file be written out when a reject list entry is added
- Fix the situation where RemoveUser() is called for the first of multiple stored logons for a host
git-svn-id: svn://10.0.0.236/trunk@145369 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-30 03:38:53 +00:00
bzbarsky%mit.edu
92d22dc940
More GetDocument bustage
...
git-svn-id: svn://10.0.0.236/trunk@145320 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-29 05:48:30 +00:00
bryner%brianryner.com
915bc8b228
Fixing windows build - need to use a constructor for initializing reference-type members.
...
git-svn-id: svn://10.0.0.236/trunk@145258 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-27 21:21:45 +00:00
bryner%brianryner.com
001e301e43
passwordmgr.properties, not satchel.properties
...
git-svn-id: svn://10.0.0.236/trunk@145245 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-27 07:06:49 +00:00
bryner%brianryner.com
5696818c75
Initial add of new (work-in-progress) password manager implementation. Not part of the build.
...
git-svn-id: svn://10.0.0.236/trunk@145243 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-27 07:05:27 +00:00