115 Commits

Author SHA1 Message Date
mkanat%bugzilla.org
0b4ee35ebe Bug 452761: Make the Date header of bugmail and requestmail always be
equal to the delta_ts of the bug. This makes emails have the right Date
even when they are sent much later by jobqueue.pl.
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260669 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 06:31:47 +00:00
mkanat%bugzilla.org
1be00a65d9 Bug 572602: Change the way that Bugzilla::Object determines what fields
are required for create(). It now assumes that any column that is NOT NULL
and has not DEFAULT in the database is required. We also shift the burden
of throwing errors about empty values to the validators. This fixes the bug
that Bugzilla::Bug->create() wasn't populating default values for fields
if they weren't specified in the create() parameters.
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260542 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-24 00:47:53 +00:00
mkanat%bugzilla.org
1283f228a8 Bug 565881: 'flag_status_invalid' and 'request_queue_group_invalid' should be user errors, not code errors
a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260303 18797224-902f-48f8-a5cc-f745e15eee43
2010-05-14 13:31:27 +00:00
mkanat%bugzilla.org
5461fab844 Bug 552167: show_bug.cgi loads flagtypes from the database for each attachment
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260110 18797224-902f-48f8-a5cc-f745e15eee43
2010-03-30 21:46:46 +00:00
mkanat%bugzilla.org
b818eef95c Bug 552476: Remove the obsolete Bugzilla::Flag->has_flags method
a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260098 18797224-902f-48f8-a5cc-f745e15eee43
2010-03-29 22:01:37 +00:00
mkanat%bugzilla.org
67256d5204 Bug 551210: Retargetted flags should be deleted if the flag setter has no privs to set the flag in the new product
a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259945 18797224-902f-48f8-a5cc-f745e15eee43
2010-03-11 23:46:16 +00:00
mkanat%bugzilla.org
3584a9ab78 Bug 508823: Make it so that you don't ever have to reset template_inner (like
Bugzilla->template_inner("")).
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259847 18797224-902f-48f8-a5cc-f745e15eee43
2010-03-01 01:46:32 +00:00
mkanat%bugzilla.org
191369bd2c Bug 537887 - "The flag setter should be able to unset a flag even if not in the request group"
[r=LpSolit a=LpSolit]


git-svn-id: svn://10.0.0.236/trunk@259736 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-17 22:16:33 +00:00
mkanat%bugzilla.org
69d853b916 Bug 545541: New Hook: object_columns
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@259683 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-11 01:01:40 +00:00
lpsolit%gmail.com
ee772fc40e Bug 534057: Auto-completion no longer works in email_in.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@259526 18797224-902f-48f8-a5cc-f745e15eee43
2010-01-31 23:33:32 +00:00
mkanat%bugzilla.org
98a5bbf59c Bug 430014: Re-write the code hooks system so that it uses modules instead of individual .pl files
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> (module owner) a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259069 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-24 06:09:55 +00:00
lpsolit%gmail.com
53f8d13314 Bug 524814: Flag requests are resent all the time, even when flags are not updated - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@258811 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-27 23:08:40 +00:00
lpsolit%gmail.com
8872215623 Bug 415541: Implement $bug->set_flags() and $attachment->set_flags() - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@257948 18797224-902f-48f8-a5cc-f745e15eee43
2009-08-05 12:36:22 +00:00
lpsolit%gmail.com
843d034307 Bug 454251: Implement Bugzilla::Attachment->create() and $attachment->update() - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit (module owner)
git-svn-id: svn://10.0.0.236/trunk@256870 18797224-902f-48f8-a5cc-f745e15eee43
2009-04-09 11:38:01 +00:00
lpsolit%gmail.com
5673aa55d4 Fix incorrect regexp for bug 333648 - Patch by me
git-svn-id: svn://10.0.0.236/trunk@256855 18797224-902f-48f8-a5cc-f745e15eee43
2009-04-08 20:47:02 +00:00
wicked%sci.fi
0bc62f2def Bug 333648: Add flag change to activity log and bugmail when only setter is changed - Patch by Teemu Mannermaa <wicked@sci.fi> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@256229 18797224-902f-48f8-a5cc-f745e15eee43
2009-02-14 09:45:44 +00:00
lpsolit%gmail.com
4b7fde17a0 Bug 388251: Implement 'new Bugzilla::Attachment' - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@254105 18797224-902f-48f8-a5cc-f745e15eee43
2008-09-08 17:13:37 +00:00
lpsolit%gmail.com
8a584b1d0c Bug 453743: Decrease the number of calls to the DB about flags when viewing a bug - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@254102 18797224-902f-48f8-a5cc-f745e15eee43
2008-09-08 16:23:46 +00:00
dkl%redhat.com
0639241e6a Bug 449791 – Allow flag notification emails to be threaded similar to normal bug change emails
Patch by Dave Lawrence <dkl@redhat.com> - r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@253900 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-27 20:38:46 +00:00
mkanat%bugzilla.org
4ae65e64a8 Bug 449306: Add a hook after a bug gets saved, and after flags get updated.
Patch By Jesse Clark <jjclark1982@gmail.com> r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@253709 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-19 22:14:02 +00:00
lpsolit%gmail.com
762eaf9db7 Bug 434062: Attachment flags can only be set once per bug (regression) - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit (module owner)
git-svn-id: svn://10.0.0.236/trunk@251684 18797224-902f-48f8-a5cc-f745e15eee43
2008-05-17 13:59:07 +00:00
lpsolit%gmail.com
03b1e7c6dd Bug 405946: Some emails are not sent in the language chosen by the addressee - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@249006 18797224-902f-48f8-a5cc-f745e15eee43
2008-04-02 17:46:56 +00:00
lpsolit%gmail.com
ed5048feb4 Bug 180259: "Requests" (logged out) and "My Requests" (logged in) links appear in footer even if the site doesn't use requests - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@248024 18797224-902f-48f8-a5cc-f745e15eee43
2008-03-17 21:38:29 +00:00
lpsolit%gmail.com
8809496bad Bug 415663: Flag->snapshot() calls Flag->match() with attach_id being undefined when editing bug flags - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@244894 18797224-902f-48f8-a5cc-f745e15eee43
2008-02-04 23:24:20 +00:00
lpsolit%gmail.com
7b21005ba0 Bug 415155: Remove $cgi from the list of arguments when calling Bugzilla::Flag subroutines - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@244865 18797224-902f-48f8-a5cc-f745e15eee43
2008-02-04 13:29:29 +00:00
lpsolit%gmail.com
5c70717ea2 Bug 413772: Eliminate sqlify_criteria() in Bugzilla::Flag and replace match() there with Bugzilla::Object::match() - Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@244862 18797224-902f-48f8-a5cc-f745e15eee43
2008-02-04 12:23:48 +00:00
lpsolit%gmail.com
db48dc1baf Bug 413258: When setting a flag on an attachment on bug creation, an incorrect message is displayed - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@243626 18797224-902f-48f8-a5cc-f745e15eee43
2008-01-20 22:12:50 +00:00
mkanat%bugzilla.org
05d4a78dd9 Bug 408172: [Oracle] Bug lists longer than 1000 bugs fail
Patch By Xiaoou Wu <xiaoou.wu@oracle.com> r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@243446 18797224-902f-48f8-a5cc-f745e15eee43
2008-01-18 15:56:55 +00:00
lpsolit%gmail.com
d4fc24bcbd Midair with product change while adding an attachment silently clears flags - Patch by Tiago R. Mello <timello@gmail.com> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@237452 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-09 13:06:13 +00:00
lpsolit%gmail.com
c01a02d48b Bug 376061: Changing the requestee of a flag should not change the requester if the one doing the change is the requestee himself - Patch by Frédéric Buclin <LpSolit@gmail.com> r=myk a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@231650 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-08 13:07:53 +00:00
lpsolit%gmail.com
dd853e57f3 Bug 279318: Flag notifications are sent even if emails are turned off for the addressee - Patch by Tiago R. Mello <timello@gmail.com> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@231628 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-08 01:53:37 +00:00
lpsolit%gmail.com
aa0d4e3a1a Bug 379787: Flag request mail has a blank requestee when requestee doesn't get the mail - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked r=myk a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@226392 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-14 19:27:16 +00:00
lpsolit%gmail.com
c2e4cb5da9 Bug 371286: Ignore deleted flags - Patch by Frédéric Buclin <LpSolit@gmail.com> r=myk a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@220839 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-23 19:19:24 +00:00
lpsolit%gmail.com
cfa0f0b79e Bug 370926: Incorrect mail sent when unsetting requestee on review request - Patch by Frédéric Buclin <LpSolit@gmail.com> r=myk a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@220608 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-20 22:16:13 +00:00
lpsolit%gmail.com
a2bc326acd Bug 364177: On attachment and bug creation, if *one* requestee cannot see the bug, *all* requests are cancelled - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@219468 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-04 15:36:47 +00:00
lpsolit%gmail.com
206d547364 Bug 364216: Flag::retarget() is broken (again) - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@217732 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-04 17:48:17 +00:00
lpsolit%gmail.com
8d9dd10809 Bug 364216: Flag::retarget() is broken - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@217254 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-20 19:53:58 +00:00
lpsolit%gmail.com
a6d99741d1 Bug 348518: grant / reject options for flag listbox should only appear if user is a member of grantgroup - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@212024 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-19 21:47:49 +00:00
lpsolit%gmail.com
539cb2be98 Bug 350181: Check whether the requestee is allowed to set a flag - Patch by Frédéric Buclin <LpSolit@gmail.com> a=myk
git-svn-id: svn://10.0.0.236/trunk@208454 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-25 20:19:44 +00:00
lpsolit%gmail.com
026a7d2fe2 Bug 345958: Do not throw an error if an inactive flag type is set to "X" while editing a bug - Patch by Frédéric Buclin <LpSolit@gmail.com> a=myk
git-svn-id: svn://10.0.0.236/trunk@208352 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-24 21:41:20 +00:00
lpsolit%gmail.com
4bfb121462 Bug 274802: Save flags having the same name on product change - Patch by Frédéric Buclin <LpSolit@gmail.com> a=myk
git-svn-id: svn://10.0.0.236/trunk@208343 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-24 21:20:09 +00:00
lpsolit%gmail.com
94170053e9 Bug 343809: Merge FlagType::validate() with Flag::validate() - Patch by Frédéric Buclin <LpSolit@gmail.com> a=myk
git-svn-id: svn://10.0.0.236/trunk@208300 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-24 15:56:39 +00:00
mkanat%bugzilla.org
abd2a139c9 Bug 347291: Make Bugzilla::User use Bugzilla::Object
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@207115 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-10 23:44:49 +00:00
lpsolit%gmail.com
5565031285 Bug 348070: An arrayref is always "true" - Patch by Frédéric Buclin <LpSolit@gmail.com> a=myk
git-svn-id: svn://10.0.0.236/trunk@207094 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-10 20:55:09 +00:00
lpsolit%gmail.com
a229e40757 Bug 343810: Remove Bugzilla::FlagType::get() and implement real flagtype objects - Patch by Frédéric Buclin <LpSolit@gmail.com> a=myk
git-svn-id: svn://10.0.0.236/trunk@203590 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-25 00:24:54 +00:00
lpsolit%gmail.com
f9e294a4b5 Bug 345359: Prevent Flag::clear from deleting a deleted flag when checking the inclusion and exclusion lists - Patch by Frédéric Buclin <LpSolit@gmail.com> a=myk
git-svn-id: svn://10.0.0.236/trunk@203586 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-25 00:08:31 +00:00
lpsolit%gmail.com
7956707bf0 Bug 343432: Remove Bugzilla::Flag::get() and implement real flag objects - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@202133 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-14 09:42:12 +00:00
mkanat%bugzilla.org
520fe42625 Bug 338375: Use Bugzilla->params everywhere instead of Param().
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201503 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:42:47 +00:00
mkanat%bugzilla.org
8323e09c40 Bug 342869: Use Bugzilla->params everywhere except templates
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201499 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:26:22 +00:00
lpsolit%gmail.com
9d1b4759b5 Bug 339750: Remove Bugzilla::Flag::GetBug - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@200249 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-18 22:46:50 +00:00