72 Commits

Author SHA1 Message Date
mkanat%kerio.com
0cbbdcfee7 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177695 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-13 12:27:04 +00:00
mkanat%kerio.com
ca722cf142 Back out bug 300231, because it triggers bug 303413.
git-svn-id: svn://10.0.0.236/trunk@177442 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 20:42:25 +00:00
mkanat%kerio.com
f4806ebab9 Bug 300231: Bugzilla::Classification needs a way of returning only Selectable classification objects
Patch By Gabriel Sales de Oliveira <gabriel@async.com.br> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177441 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 20:31:53 +00:00
bugreport%peshkin.net
9778732be8 Backout of bug 303669 which broke AppendComment and possibly a number
of other items.


git-svn-id: svn://10.0.0.236/trunk@177419 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 11:23:43 +00:00
mkanat%kerio.com
7bbde62ad3 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177413 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 05:59:02 +00:00
lpsolit%gmail.com
4fe5766722 Bug 301967: Some .pm files have invalid POD syntax - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@176610 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-26 14:09:48 +00:00
lpsolit%gmail.com
7f20c43d00 Bug 284264: Move canSeeUser from editusers.cgi to User.pm - Patch by Marc Schumann <wurblzap@gmail.com> r=mkanat,joel a=justdave
git-svn-id: svn://10.0.0.236/trunk@176517 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-25 07:56:38 +00:00
lpsolit%gmail.com
a68c2a62b5 Bug 301453: Move CheckEmailSyntax out of CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@176363 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-20 21:24:19 +00:00
lpsolit%gmail.com
98c76b3306 Bug 300709: Avoid the use of SELECT * - Patch by Frédéric Buclin <LpSolit@gmail.com> r=glob a=myk
git-svn-id: svn://10.0.0.236/trunk@176237 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-19 14:40:45 +00:00
mkanat%kerio.com
7e57a969dd Bug 300336: Bugzilla::Auth should not contain any exported subroutines
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175984 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-13 03:57:02 +00:00
mkanat%kerio.com
bee739c329 Bug 300334: Bugzilla::User has no need to "use Bugzilla::BugMail"
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=justdave, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175910 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-11 06:30:05 +00:00
mkanat%kerio.com
114a1de979 Bug 292544: [SECURITY] Can see a security-sensitive bug in buglist.cgi for a short time when there are certain performance problems
Patch By Frederic Buclin <LpSolit@gmail.com> r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175824 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-08 05:36:34 +00:00
mkanat%kerio.com
576962b64a Bug 292119: [PostgreSQL] POSITION(...) clause "must be type boolean, not type integer"
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175811 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-08 02:34:03 +00:00
mkanat%kerio.com
595f9c7816 Bug 285695: [PostgreSQL] Username checks for login, etc. need to be case insensitive
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175810 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-08 02:31:43 +00:00
mkanat%kerio.com
1c86e082c2 Bug 87404: Attachments don't work if you need to use user matching
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175808 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-08 02:18:22 +00:00
lpsolit%gmail.com
c19777a4ef Bug 284273: Move productResponsibilities from editusers.cgi to Bugzilla::User.pm - Patch by Marc Schumann <wurblzap@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@175119 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-24 22:33:05 +00:00
mkanat%kerio.com
5c30640687 Bug 293501: Add me to files where I belong and fix kerio.com emails
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=colin, a=myk


git-svn-id: svn://10.0.0.236/trunk@174620 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-15 03:55:00 +00:00
mkanat%kerio.com
1cc2ffd1c5 Bug 292718: LOCATE is not ANSI SQL (prevents user account creation)
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@173662 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-21 07:30:50 +00:00
lpsolit%gmail.com
e3f63d06a7 Bug 288857: Use of uninitialized value in bitwise and (&) at Bugzilla/User.pm line 984 - Patch by Gervase Markham <gerv@mozilla.org> r=LpSolit a=myk
git-svn-id: svn://10.0.0.236/trunk@171930 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-10 17:49:48 +00:00
lpsolit%gmail.com
a58231e5fb Bug 225818: %FORM, %MFORM, and %COOKIE need to go away, in favor of the CGI methods - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=LpSolit a=myk
git-svn-id: svn://10.0.0.236/trunk@171914 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-09 23:18:18 +00:00
lpsolit%gmail.com
6d78cc1d1b Bug 238878: Make hidden-fields template, User Matching and Flags use direct CGI instead of [% form.foo %] - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@171870 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-07 23:37:56 +00:00
mkanat%kerio.com
a7cc0f9d32 Bug 286686: ORDER BY column needs to be selected or grouped
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@171859 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-07 18:18:53 +00:00
gerv%gerv.net
7b09ffbc80 Bug 73665 - migrate email preferences to their own table, and rearchitect email internals. Patch by gerv; r=jake, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@171337 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-29 21:43:00 +00:00
mkanat%kerio.com
5b16bb5528 Bug 174295: ANSI SQL requires all columns in SELECT to be in GROUP BY, unless they are in "aggregate" functions
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@170811 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-16 23:50:59 +00:00
travis%sedsystems.ca
7351a5b76b Bug 283581 : Move UserInGroup out of globals.pl
Patch by Colin Ogilvie <colin.ogilvie@gmail.com>   r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170734 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 22:10:14 +00:00
mkanat%kerio.com
abc539470f Bug 285534: bugs.qa_contact should allow NULL
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170685 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 05:20:48 +00:00
mkanat%kerio.com
03e4fa616a Bug 285407: User cannot log in on PostgreSQL
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=bugreport, a=myk


git-svn-id: svn://10.0.0.236/trunk@170570 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-11 19:31:36 +00:00
travis%sedsystems.ca
5b98831b40 Bug 98123 : Create a user preferences infrastructure (became 'General Settings')
Patch by Shane H. W. Travis <travis@sedsystems.ca>   r=jouni, mkanat  a=myk


git-svn-id: svn://10.0.0.236/trunk@170515 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-10 15:51:43 +00:00
travis%sedsystems.ca
72f7202d3b Bug 284262 : Bundle of small editusers.cgi post-checkin fixes
Patch by Marc Schumann <wurblzap@gmail.com>   r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170296 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-07 18:11:37 +00:00
mkanat%kerio.com
174b0b2d34 Bug 284598: INSTR function is not supported by postgres
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170201 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-05 07:36:08 +00:00
justdave%bugzilla.org
308ca2dd4f Bug 284547: Fix escaping of > characters inside C<> tags in the pod docs
r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170123 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-03 05:28:42 +00:00
travis%sedsystems.ca
abce7fe4c4 Bug 119485 : Templatise editusers.cgi
Patch by Marc Schumann <wurblzap@gmail.com>   r=GavinS, mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170004 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-28 20:41:45 +00:00
mkanat%kerio.com
ab0b6b7d14 Bug 283562: Insecure dependency in parameter 3 of DBI::db (login_to_id forgets a trick_taint)
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=wurblzap, r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@169915 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-27 01:08:12 +00:00
mkanat%kerio.com
da1c0470db Bug 279693: Move UserCanBlessGroup() into a Bugzilla::User function
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@169815 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-25 03:07:05 +00:00
mkanat%kerio.com
f7471cbb97 Bug 283237: Move DBname_to_id out of globals.pl
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=wurblzap, a=myk


git-svn-id: svn://10.0.0.236/trunk@169799 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-24 23:42:48 +00:00
mkanat%kerio.com
fe14d8a2d1 Bug 280497: Replace "LIMIT" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=justdave


git-svn-id: svn://10.0.0.236/trunk@169390 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 16:14:27 +00:00
mkanat%kerio.com
a88c76e484 Bug 280503: Replace "LOCK/UNLOCK TABLES" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=myk


git-svn-id: svn://10.0.0.236/trunk@169333 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 21:57:27 +00:00
travis%sedsystems.ca
b63354eba2 Bug 280994 : Move ValidateNewUser out of globals.pl
Patch by Max Kanat-Alexander <mkanat@kerio.com>  r=vladd  a=justdave


git-svn-id: svn://10.0.0.236/trunk@169041 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-09 06:42:43 +00:00
travis%sedsystems.ca
eb084eecd7 Fixing burning tinderbox created by checkin of Bug 280124
git-svn-id: svn://10.0.0.236/trunk@168592 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-31 23:33:37 +00:00
travis%sedsystems.ca
0abffd8846 Bug 280124 : Move InsertNewUser to Bugzilla::User
Patch by Max Kanat-Alexander <mkanat@kerio.com>   r=vladd  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168579 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-31 21:04:12 +00:00
travis%sedsystems.ca
b75c9da900 Bug 108870: Bugzilla does not set email prefs for new user until user visits userprefs.cgi
Patch: travis  r=mkanat  a=justdave

Also includes fixes for
Bug 109573: New bugzilla accounts should by default have 'CC field changes' turned off, and
Bug 275599: flag request email prefs not behaving correctly


git-svn-id: svn://10.0.0.236/trunk@167399 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-07 20:56:01 +00:00
jake%bugzilla.org
ac30efc907 Bug 261821 - Bugzilla now properly calls 'finish' on the DBI handle in CanSeeBug()
Patch by GavinS <bugzilla@chimpychompy.org>
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@167018 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-24 09:56:30 +00:00
justdave%bugzilla.org
e8856e8e54 Bug 255913: mailto link on show_bug.cgi wasn't honoring emailsuffix. Bugzilla->user->email now includes emailsuffix in the result.
Patch by Marc Schumann <wurblzap@gmail.com>
r=justdave,tobias, a=justdave


git-svn-id: svn://10.0.0.236/trunk@162138 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-11 07:09:46 +00:00
bugreport%peshkin.net
12e5e8c5f9 Bug 244239: Add group-based pronouns to query
r=erik,justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160666 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-11 14:00:34 +00:00
bugreport%peshkin.net
9d0e5a4575 Bug 241903: Add Environment Variable Authentication for apache auth and SSO
patch by erik
r=joel
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160665 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-11 13:53:46 +00:00
bugreport%peshkin.net
53c6c2c716 Bug 251669: add an option to show users in a drop down menu instead of a text edit field
patch by glob <bugzilla@glob.com.au>
r=joel
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160652 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-11 05:08:13 +00:00
bugreport%peshkin.net
2078808f42 Bug 254430: Fix User.pm so it returns a logged-out user if userid=0
r=erik, kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160423 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-05 22:19:19 +00:00
bugreport%peshkin.net
fb03b26b17 Bug 254374: Fix regression in qacontact from bug 186093
git-svn-id: svn://10.0.0.236/trunk@160385 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-05 03:18:42 +00:00
bugreport%peshkin.net
259f1f03b2 Bug 185090: Add revamped whining system
patch by: Erik
r=joel
r=jouni
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160377 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-04 21:36:27 +00:00
bugreport%peshkin.net
cd65dc04d7 Bug 186093: Move CanSeeBug to User.pm and make User.pm usable by templates
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160350 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-04 16:17:10 +00:00