62 Commits

Author SHA1 Message Date
webmail%kmgerich.com
1a0ff40cde back out firefox sidebar style changes on trunk, bug #251910
git-svn-id: svn://10.0.0.236/trunk@164423 18797224-902f-48f8-a5cc-f745e15eee43
2004-10-26 12:09:38 +00:00
webmail%kmgerich.com
28ed72296d bug #251910, style bookmark and history sidebar items as links
git-svn-id: svn://10.0.0.236/trunk@163869 18797224-902f-48f8-a5cc-f745e15eee43
2004-10-15 23:51:49 +00:00
vladimir%pobox.com
63de84a60f bookmarks fixes merged from aviary branch:
192624 - empty bookmark folder should show "(Empty)"
202798 - customizing toolbar in fullscreen mode breaks menus (bandaid)
221482 - bookmarks toolbar temporarily cleared when clicking restore default set in customize
232089 - bookmarks 'create in' shouldn't persist
234089 - bookmarks toolbar folder shouldn't be deletable with C-x (crasher)
238661 - moving a bookmark folder to itself deletes the folder
250179 - bookmarks toolbar wonky after customization
250820 - toolbar icon state/context menu/etc. broken after returning from fullscreen mode
251988 - livemark menu doesn't work after going to page without livemark and clicking
251335 - bookmarks toolbar folder has different context menu from other bookmark folders
251802 - refresh livemark doesn't work from toolbar/menu
252053 - make bookmarks use SafeOutputStream (dwitte)
252133 - new bookmarks items should be added below selected items, not above
252792 - livemark context menu contains active new folder menu item
252870 - context menu of empty personal toolbar folder has inconsistent items
252875 - bookmarks root name not localizable


git-svn-id: svn://10.0.0.236/trunk@160122 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-30 06:25:41 +00:00
vladimir%pobox.com
544b331624 b=244078, live bookmarks merge from aviary branch.
git-svn-id: svn://10.0.0.236/trunk@160117 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-30 05:29:27 +00:00
ben%bengoodger.com
8d9243fc88 tidy up bookmarks manager, move status bar under both trees
git-svn-id: svn://10.0.0.236/trunk@159024 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-11 11:21:39 +00:00
mconnor%myrealbox.com
1534663a5a bug 245410 - remove dump() call from bookmarks code, patch by steffen.wilberg@web.de, r=me
git-svn-id: svn://10.0.0.236/trunk@158781 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-06 04:02:56 +00:00
jruderman%hmc.edu
addca61bba 246719 - Make link modifiers work consistently throughout Firefox. This fixes 202819, 214816, 224132, and 236864. Also makes middlemouse.contentLoadURL work on Windows by porting the fix for 217090. r=bryner.
git-svn-id: svn://10.0.0.236/trunk@158389 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-23 22:54:12 +00:00
varga%nixcorp.com
ce53bd6ec2 Fix for bug 221619. Tree widget refactoring and enhancement. r=neil sr=bryner
git-svn-id: svn://10.0.0.236/trunk@155017 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-17 05:53:38 +00:00
neil%parkwaycc.co.uk
988028b536 Bug 236756 nsIPrefService contract id is @mozilla.org/preferences-service;1 r=varga sr=bryner
git-svn-id: svn://10.0.0.236/trunk@154692 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-11 20:51:57 +00:00
noririty%jcom.home.ne.jp
a2e864d422 Fix 228844 - Cannot search Japanese via Bookmark Sidebar
git-svn-id: svn://10.0.0.236/trunk@150420 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-18 15:06:39 +00:00
chanial%noos.fr
3aa794c192 fix several glitches, like:
- selecting a folder in the tree selects the menulist selectedItem if it is already in the dropdown
- unselect it if the folder is not in it
- make sure that a row is always selected.
- ensure that the row of a folder selected in the menulist is visible when the tree is expanded.
- cleanup, consolidate logic


git-svn-id: svn://10.0.0.236/trunk@150317 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-15 07:44:11 +00:00
chanial%noos.fr
8180176881 Bug 181033: add a "New Folder" button to the add bookmark dialog
git-svn-id: svn://10.0.0.236/trunk@150290 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-14 10:43:43 +00:00
chanial%noos.fr
9be289ddb4 add a |focus| method to the bookmarks tree widget
git-svn-id: svn://10.0.0.236/trunk@150186 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-10 05:33:56 +00:00
chanial%noos.fr
29b34a142a removing comm.jar dependencies in the bookmarks component. Escape close the window and fix for bug 168412.
Also remove the bookmark edit command (ex: cmd_bm_paste) and use the edit ones instead (ex: cmd_paste)


git-svn-id: svn://10.0.0.236/trunk@147945 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-14 05:20:35 +00:00
chanial%noos.fr
8a748c3787 Undo overzealous commenting (bug 221692)
git-svn-id: svn://10.0.0.236/trunk@147798 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-09 15:04:42 +00:00
chanial%noos.fr
fb4929d722 - fix regression 221118: Can't drag links into bookmark manager or bookmark sidebar.
- logic change: a transaction will not be performed when one of its item can not be acted on. Before, the only the valid items were processed. A LOT of simplifications have come up. I am slowly moving toward the resolution of bug 168411, by simplifying the interface that will be needed to move the transactions to the bookmarks service.
- fix bug 221550: the selection is not retained when performing an invalid transaction
- no need to restore the selection after an action that doesn't touch the datasource.
- during a batch, the bookmarks toolbar observer wasn't notified.
- much faster preUpdateTreeSelection
- various code cleanup
- DND bookmarks in tree is now significantly faster.
- still need to figure out what is the best BATCH_LIMIT value.


git-svn-id: svn://10.0.0.236/trunk@147752 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-08 09:01:48 +00:00
chanial%noos.fr
21d5f7a905 checking in back the fix for bug 172113.
an additional fix is included: if no ...#BookmarksToolbarFolder arc is found, then search for an (obsolete) resource "NC:PersonalToolbarFolder" (221410).
When none of them is found, then a new btf is created (only once!).


git-svn-id: svn://10.0.0.236/trunk@147747 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-08 08:17:23 +00:00
chanial%noos.fr
9ae0c6a598 For the next cycles: backing out the changes for bug 172113 to investigate perf because I landed them just after the tinderbox went down and also because large landings occurred before it went up.
git-svn-id: svn://10.0.0.236/trunk@147740 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-08 04:45:29 +00:00
chanial%noos.fr
25c51f48de - bug 172113: rewrite the way we handle the bookmarks toolbar folder. Now, there is no more 2 ways to characterize the BTF: by an arc to the resource "...#BookmarksToolbarFolder" that points to the literal "true". As a consequence, the resource NC:PersonalToolbarFolder and "...#folderType" are dead.
- remove unused functions. Note that RDF commands were already broken, so deleteBookmarkItem and insertBookmarkItem (that were not used) may come back, but in another form.
- remove the "New Bookmark Folder" and "New Search Folder"
- refactor the "html" serializer to avoid some duplicated code.
- remove the use of the profile name for the bookmarks root.
- enforce synthax "aArgument" in some random places.


git-svn-id: svn://10.0.0.236/trunk@147534 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-03 20:30:14 +00:00
chanial%noos.fr
2c309d455c - adding bookmark/separator in the bookmark manager now calls the property dialog for consistency with the folders.
- fix the use of the immutable bookmarks.
- remove unused methods: GetLastCharset and AddBookmarkImmediately
- porting several small fixes mainly from Jan's work
- more prototyping for BookmarkTransaction


git-svn-id: svn://10.0.0.236/trunk@147445 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-29 21:43:11 +00:00
varga%netscape.com
c1c2acd6b5 Landing bookmarks changes.
Bug 205378 - Meta bug for changes in bookmarks sorting code
r=jag, sr=sspitzer, a=sspitzer,asa

The CloneResource() has been back ported from Firebird, originally
implemented by Pierre Chanial.


git-svn-id: svn://10.0.0.236/trunk@142814 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-23 12:03:40 +00:00
chanial%noos.fr
88582fb263 bug 200480: cut/paste doesn't work on folders and separators
git-svn-id: svn://10.0.0.236/trunk@141763 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-24 21:46:55 +00:00
chanial%noos.fr
08b24718db keep the selection active after a DND in the bookmark manager
git-svn-id: svn://10.0.0.236/trunk@141698 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-23 17:29:05 +00:00
chanial%noos.fr
eaf5d01d31 dropping folder group support
git-svn-id: svn://10.0.0.236/trunk@141695 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-23 15:05:10 +00:00
chanial%noos.fr
92009fc57f Removing 2 extra blank lines
git-svn-id: svn://10.0.0.236/trunk@141526 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-21 20:06:32 +00:00
chanial%noos.fr
7f2e163dd0 some commands were failing. Saving the selection before their execution
git-svn-id: svn://10.0.0.236/trunk@141524 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-21 19:17:43 +00:00
chanial%noos.fr
c7c6082125 getting back phoenix bookmarks in sync with seamonkey
first step to clean the 'add bookmark' mess (removing a flag because we always show the dialog, and moving addBookmarkFor*Browser in browser.js where it belong)


git-svn-id: svn://10.0.0.236/trunk@141506 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-21 05:47:02 +00:00
varga%netscape.com
abd5b6088d Fixing bookmark separators.
I can't believe that bookmark specifix CSS lives in tree.css!


git-svn-id: svn://10.0.0.236/trunk@141337 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-17 21:07:35 +00:00
varga%netscape.com
22a305c75f Fixing bookmarks in Phoenix. They should load at least.
git-svn-id: svn://10.0.0.236/trunk@140355 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-26 19:49:47 +00:00
chanial%noos.fr
78c93446f8 speed up a bit loading a bookmark from the sidebar.
Fix also a regression: CTRL-click and SHIFT-click load only the selected bookmark.


git-svn-id: svn://10.0.0.236/trunk@137024 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-28 08:21:10 +00:00
chanial%noos.fr
f50e9098b8 Fix bug in getIndexOfResourceInContainer and some regressions in the bookmark manager:
- DND should keep the selection
- selection for undo and redo commands


git-svn-id: svn://10.0.0.236/trunk@137022 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-28 07:08:54 +00:00
ben%netscape.com
4b8c92c673 Fix 168415 (selection quirks) and 190678 (js errors when right clicking personal toolbar)
git-svn-id: svn://10.0.0.236/trunk@136977 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-27 11:00:11 +00:00
varga%netscape.com
6c17e32bdd Fixing a typo.
git-svn-id: svn://10.0.0.236/trunk@136723 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-21 12:13:59 +00:00
mkaply%us.ibm.com
f79c21ba74 Bug 176370 folder pane performance regression r=varga sr=bienvenu
git-svn-id: svn://10.0.0.236/trunk@136533 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-17 15:23:48 +00:00
chanial%noos.fr
b3606d14d1 bookmark cleanup. make clear the distinction between target and selection in trees.
now, insertion on a folder doesn't append but inserts before it.
Allow multiple selection of bookmarks and folders for the home pages.


git-svn-id: svn://10.0.0.236/trunk@135268 18797224-902f-48f8-a5cc-f745e15eee43
2002-12-13 23:06:10 +00:00
chanial%noos.fr
11b6b8e87b clicking again on a bookmark in the sidebar does not reload it.
git-svn-id: svn://10.0.0.236/trunk@132810 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-01 02:47:10 +00:00
hyatt%netscape.com
9742eb5a48 Temporary hack fix for bookmark jumping problem.
git-svn-id: svn://10.0.0.236/trunk@132627 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-29 03:34:06 +00:00
chanial%noos.fr
312c643856 fix bookmarks bustage
git-svn-id: svn://10.0.0.236/trunk@131974 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-14 19:09:16 +00:00
blakeross%telocity.com
28165ca156 some fixes.
git-svn-id: svn://10.0.0.236/trunk@131892 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-13 03:24:34 +00:00
blakeross%telocity.com
6529e1b01a fix added col
git-svn-id: svn://10.0.0.236/trunk@131891 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-13 03:18:47 +00:00
blakeross%telocity.com
48491710f6 Fix Added column in bookmarks manager.
git-svn-id: svn://10.0.0.236/trunk@131890 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-13 03:11:35 +00:00
blakeross%telocity.com
94340c125f Strip more licenses.
git-svn-id: svn://10.0.0.236/trunk@131753 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-11 01:27:28 +00:00
chanial%noos.fr
d88c4b409c bug 172504: after clicking on a disabled item, CM does not work anymore
git-svn-id: svn://10.0.0.236/trunk@131265 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-06 14:00:55 +00:00
chanial%noos.fr
3243919ba6 typo correction
git-svn-id: svn://10.0.0.236/trunk@131247 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 20:53:22 +00:00
hyatt%netscape.com
1ccb7e0215 Full favicon support landed. Dependent on some mozilla trunk work, but harmless until i get that checked in.
git-svn-id: svn://10.0.0.236/trunk@131147 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-04 07:38:44 +00:00
chanial%noos.fr
0fab0faba6 bug 171327: implement "Use Bookmark" menubutton in General prefs
git-svn-id: svn://10.0.0.236/trunk@131126 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-04 01:13:49 +00:00
chanial%noos.fr
78e61cae1b fix double click loading folder in bookmark manager
fix file: protocol


git-svn-id: svn://10.0.0.236/trunk@131103 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-03 21:45:05 +00:00
chanial%noos.fr
5ac30a2c20 bug 171330: dropping foldergroup concept.
opening bookmarks in folder via context menu, middle-click and ctrl-click.
saving group of tabs in folder
+ speed optimizations


git-svn-id: svn://10.0.0.236/trunk@131049 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-03 02:54:05 +00:00
chanial%noos.fr
3b7fc57320 some more back
git-svn-id: svn://10.0.0.236/trunk@130902 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-01 18:53:43 +00:00
blakeross%telocity.com
e0e3bb7cdd Move bookmarks sidebar back to one click.
git-svn-id: svn://10.0.0.236/trunk@130897 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-01 18:35:26 +00:00