191 Commits

Author SHA1 Message Date
julien.pierre.bugs%sun.com
b9aa511733 Include nssrwlk.h for NSSRWLock_ funtions
git-svn-id: svn://10.0.0.236/trunk@163348 18797224-902f-48f8-a5cc-f745e15eee43
2004-10-07 04:36:03 +00:00
relyea%netscape.com
778eec1a21 Bugzilla Bug 252702
NSS needs to handle better token insertion and removal.

Applied from patch to NSS 3.9


git-svn-id: svn://10.0.0.236/trunk@160095 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-29 23:38:14 +00:00
relyea%netscape.com
cb8fbb0164 Bug 250687
NSS Crashes or leaks Cert references if bad certs are passed up by PKCS #11 modules.
r=nelson
sr=ian


git-svn-id: svn://10.0.0.236/trunk@159599 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-21 18:18:05 +00:00
ian.mcgreer%sun.com
f7fd7e85b4 bug 180268, reimplement ssl step-up for builtins
git-svn-id: svn://10.0.0.236/trunk@156475 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-17 20:08:38 +00:00
gerv%gerv.net
43cb9e1492 Bug 236613: change to MPL/LGPL/GPL tri-license.
git-svn-id: svn://10.0.0.236/trunk@155484 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-25 15:03:26 +00:00
nelsonb%netscape.com
47bae21d3c Enable a chain to validate when a perm cert has been issued by a
temp cert.  Bug 233038. r=ian,relyea


git-svn-id: svn://10.0.0.236/trunk@152459 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-07 07:17:31 +00:00
wchang0222%aol.com
6d6030f10a Bugzilla bug 228624: we need to call STAN_ForceCERTCertificateUpdate if
the cert's instances changed.  r=relyea.


git-svn-id: svn://10.0.0.236/trunk@150546 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-19 22:33:12 +00:00
wchang0222%aol.com
dba90f3e57 Bugzilla bug 228624: made PK11_ListCertsInSlot reach into the Stan layer
to obtain the correct nicknames of the cert instances (pk11cert.c).  Fixed
the bug that if a cert we want to add the the cache is already in the
cache, we should merge the instances of the cert before destroying the
duplicate cert (tdcache.c).  r=jpierre,relyea.


git-svn-id: svn://10.0.0.236/trunk@150428 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-18 18:23:17 +00:00
wchang0222%aol.com
dc9a3bd0d3 Bugzilla bug 228618: fixed an incorrect use of realloc. Fixed an unused
variable compiler warning.  r=jpierre.


git-svn-id: svn://10.0.0.236/trunk@150352 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-16 04:24:57 +00:00
nelsonb%netscape.com
15b7b08f9e Detect empty emailAddr strings in CERTCertificates. Bugzilla bug 211540.
Modified Files:
    cmd/dbck/dbck.c cmd/signtool/util.c lib/certdb/certdb.c
    lib/certdb/stanpcertdb.c lib/pkcs7/p7decode.c lib/pki/certificate.c
    lib/pki/pki3hack.c lib/smime/cmssiginfo.c lib/softoken/pkcs11u.c


git-svn-id: svn://10.0.0.236/trunk@149330 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-15 00:10:01 +00:00
nelsonb%netscape.com
5bf80de578 Workaround race. Reduce leaks. Not a real fix. Bugzilla bug 225525.
git-svn-id: svn://10.0.0.236/trunk@149230 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-13 03:41:32 +00:00
nelsonb%netscape.com
ee8e542686 Eliminate some leaks in Stan cert code.
Partial fix to bugscape bug 53573.


git-svn-id: svn://10.0.0.236/trunk@149166 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-11 21:46:53 +00:00
wtc%netscape.com
77b52a6e30 Bugzilla bug 217247: improved the memory leak fix for the appData nicknames
returned by PK11_ListCerts.  Instead of allocating them from the heap first
and copying to the arena, allocate them from the arena directly.  r=jpierre
Modified Files: certhigh.c pk11cert.c pki3hack.h pki3hack.c


git-svn-id: svn://10.0.0.236/trunk@146817 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-12 19:38:04 +00:00
wtc%netscape.com
ded3cf2577 Bugzilla bug 72291: have PK11_ListCerts return all the cert instances on
tokens.  The patch is Julien Pierre's, with changes by Wan-Teh Chang.
Modified Files: pk11wrap/pk11cert.c pki/pki3hack.c pki/pki3hack.h


git-svn-id: svn://10.0.0.236/trunk@146306 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-25 19:18:02 +00:00
wtc%netscape.com
1cbc8808cd Bugzilla bug 214695: fixed incorrect use of PR_AtomicDecrement on reference
counts.  The reference count should not be read "naked".  Instead, we
should simply use the return value of PR_AtomicDecrement for the result of
the decrement.
Modified Files: dev/devmod.c dev/devslot.c dev/devtoken.c pki/certificate.c
pki/pkibase.c


git-svn-id: svn://10.0.0.236/trunk@145445 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-01 02:02:47 +00:00
wtc%netscape.com
834368a3fb Bug 212112: we don't need to lock td->cache->lock while calling
STAN_ForceCERTCertificateUpdate.  This fixed a recursive deadlock.
r=mcgreer.


git-svn-id: svn://10.0.0.236/trunk@144669 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-10 01:24:17 +00:00
wtc%netscape.com
17aaaaa628 Bug 204011: fixed the bug that nssPKIObjectCollection_AddInstances frees an
instance twice if add_object_instance fails.  r=mcgreer.


git-svn-id: svn://10.0.0.236/trunk@142038 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-02 03:01:13 +00:00
jpierre%netscape.com
131f7d48f3 Fix for 199227 - keep enumerating certs in tokens even if one token fails. r=relyea
git-svn-id: svn://10.0.0.236/trunk@140472 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-01 00:07:05 +00:00
ian.mcgreer%sun.com
e26258fd38 bug 174200, don't attempt to decode cert when destroying it, handle failure
to decode cert serial number
r=nelsonb


git-svn-id: svn://10.0.0.236/trunk@137945 18797224-902f-48f8-a5cc-f745e15eee43
2003-02-18 20:53:14 +00:00
jpierre%netscape.com
3e4fd60532 Fix for 190424 - don't query CKA_NETSCAPE_EMAIL attribute. r=wtc
git-svn-id: svn://10.0.0.236/trunk@137124 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-30 05:12:10 +00:00
jpierre%netscape.com
4734fd96af Fix for 190424 - don't query CKA_NETSCAPE_EMAIL attribute . r=wtc
git-svn-id: svn://10.0.0.236/trunk@137118 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-30 03:02:55 +00:00
wtc%netscape.com
56a88ba186 Bug 187629: do not refresh a CERTCertificate if the same instance of a
cached cert is added to the collection.


git-svn-id: svn://10.0.0.236/trunk@136051 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-09 04:29:01 +00:00
wtc%netscape.com
ec8de2b7c8 Bug 186586: If at NSS shutdown there are still certs in the cert caches,
cause NSS shutdown and the next NSS initialization to fail but do not
destroy the cert caches (and the crypto context and trust domain containing
them) to avoid a crash if the NSS client destroys the certs later.  New
error codes needed to be added to indicate the failure of NSS shutdown and
NSS initialization due to this cause.


git-svn-id: svn://10.0.0.236/trunk@136016 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-08 21:58:29 +00:00
wtc%netscape.com
83b9358446 Bug 186586: If at NSS shutdown there are still certs in the cert caches,
cause NSS shutdown and the next NSS initialization to fail but do not
destroy the cert caches (and the crypto context and trust domain containing
them) to avoid a crash if the NSS client destroys the certs later.  New
error codes needed to be added to indicate the failure of NSS shutdown and
NSS initialization due to this cause.
Modified Files:
	base/errorval.c nss/nssinit.c pki/pki3hack.c pki/pki3hack.h
	pki/pkistore.c pki/pkistore.h pki/tdcache.c pki/trustdomain.c
	util/secerr.h


git-svn-id: svn://10.0.0.236/trunk@136014 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-08 21:48:47 +00:00
wtc%netscape.com
688bbc9eba Bug 183612: added support for looking up a cert by subject key ID and
creating a CMS recipient info from a subject key ID.  The patch was
contributed by Javi Delgadillo <javi@netscape.com>. r=relyea, wtc.
Modified Files:
	certdb/cert.h certdb/certdb.c certdb/certdb.h certdb/certv3.c
	certdb/stanpcertdb.c nss/nss.def nss/nssinit.c
	pk11wrap/pk11cert.c pk11wrap/pk11func.h pk11wrap/secmod.h
	pki/pki3hack.c smime/cms.h smime/cmslocal.h smime/cmspubkey.c
	smime/cmsrecinfo.c smime/cmssiginfo.c smime/cmst.h
	smime/smime.def


git-svn-id: svn://10.0.0.236/trunk@135377 18797224-902f-48f8-a5cc-f745e15eee43
2002-12-17 01:39:46 +00:00
ian.mcgreer%sun.com
ac48db6445 bug 177366, clean up refcounting
r=relyea


git-svn-id: svn://10.0.0.236/trunk@133173 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-06 18:53:55 +00:00
ian.mcgreer%sun.com
941cca0169 bug 174634, fix handling of authorityCertIssuer in chain construction
git-svn-id: svn://10.0.0.236/trunk@132362 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-22 14:43:08 +00:00
relyea%netscape.com
faa9e5505e Bug 164501. Return a proper error code from PK11_FindCrlByName() so the CRL
code can decide if there is a hw or system failure preventing the reading of a
CRL or if the CRL is just not there.


git-svn-id: svn://10.0.0.236/trunk@131706 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-10 20:30:19 +00:00
ian.mcgreer%sun.com
afc9d90049 bug 171224, changes to path construction
r=nelsonb


git-svn-id: svn://10.0.0.236/trunk@130884 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-01 14:32:15 +00:00
wtc%netscape.com
886a419672 Bug 171422: removed unused (and incorrect) code. r=mcgreer.
git-svn-id: svn://10.0.0.236/trunk@130807 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-30 20:33:44 +00:00
ian.mcgreer%sun.com
c281b854b0 bug 171198, leak moving temp cert to perm; add force parameter
r=wtc,relyea


git-svn-id: svn://10.0.0.236/trunk@130612 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-27 21:23:00 +00:00
relyea%netscape.com
081ac893c4 Bug 166894: Handle changing Trust when cert is in the token.
git-svn-id: svn://10.0.0.236/trunk@130588 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-27 15:55:01 +00:00
wtc%netscape.com
7c882c554b Bug 166894: destroy nssTrust before returning from STAN_ChangeCertTrust.
git-svn-id: svn://10.0.0.236/trunk@130360 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-24 18:47:33 +00:00
nelsonb%netscape.com
ce59d4e445 Change coding style used in nss/lib/pki to one that works with ctags.
Bug 169999.   Modified Files:
  asymmkey.c certdecode.c certificate.c cryptocontext.c pki3hack.c
  pkibase.c pkistore.c symmkey.c tdcache.c trustdomain.c


git-svn-id: svn://10.0.0.236/trunk@130289 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-23 21:32:35 +00:00
jpierre%netscape.com
c58e9e8e95 Fix compiler warnings
git-svn-id: svn://10.0.0.236/trunk@129022 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-07 01:24:27 +00:00
nicolson%netscape.com
4b34ca8158 Fix 164126: makefile build error.
Change the NSS module name from "security" to "nss".


git-svn-id: svn://10.0.0.236/trunk@128961 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-06 16:38:56 +00:00
wtc%netscape.com
16ce983004 Bugs 166734 and 166785: fixed compiler warnings reported by gcc on Linux.
The patch for this checkin is attached to bug 166785.


git-svn-id: svn://10.0.0.236/trunk@128926 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-06 00:27:52 +00:00
ian.mcgreer%sun.com
b2dc5651fc bug 165863, free token on error paths
git-svn-id: svn://10.0.0.236/trunk@128720 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-03 19:42:13 +00:00
wtc%netscape.com
eba7b7a520 Bug 165859: fixed the problem that 'collection' was destroyed twice on
error in nssTrustDomain_FindCertificateByIssuerAndSerialNumber.


git-svn-id: svn://10.0.0.236/trunk@128614 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-31 04:52:46 +00:00
jpierre%netscape.com
10bc1a61c0 Implement the CRL cache . Bug 149854
git-svn-id: svn://10.0.0.236/trunk@128594 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-30 22:57:03 +00:00
relyea%netscape.com
dd234f1f97 Filter on keyID, then run through the best cert check.
git-svn-id: svn://10.0.0.236/trunk@128494 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-29 22:11:06 +00:00
ian.mcgreer%sun.com
a7f0520fb8 fix broken builds
git-svn-id: svn://10.0.0.236/trunk@128337 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-28 13:27:32 +00:00
relyea%netscape.com
2f2fb64005 close hole in trust lookups.
git-svn-id: svn://10.0.0.236/trunk@128309 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-27 23:38:29 +00:00
relyea%netscape.com
fdde256a14 Merge back 3.5 changes to the tip
git-svn-id: svn://10.0.0.236/trunk@126238 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-02 17:43:36 +00:00
ian.mcgreer%sun.com
4043f9706a this was obviously backwards
git-svn-id: svn://10.0.0.236/trunk@126157 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-01 14:23:49 +00:00
wtc%netscape.com
a902a86724 Bug 157730: minor tweak suggested by brendan.
git-svn-id: svn://10.0.0.236/trunk@126150 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-01 05:17:49 +00:00
relyea%netscape.com
71fa9fe43d 1) collections have size values that need to be updated.
2) handle the case where we can't get the encoding from the cert.
3) Check the cert validity when we first extract it.


git-svn-id: svn://10.0.0.236/trunk@126145 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-01 01:21:28 +00:00
relyea%netscape.com
bd00fa6c5f Arg.. version 1.63 was a misapplied patch, (supposed to be checked into the
3.5 branch). The result is 1.63 backs out 1.62, which is not the intent.
restore 1.62.


git-svn-id: svn://10.0.0.236/trunk@126122 18797224-902f-48f8-a5cc-f745e15eee43
2002-07-31 18:55:59 +00:00
relyea%netscape.com
8d6234c7ca Bug 157730. Don't crash on bogus input from a PKCS #11 device.
review = be & wtc.
a = asa


git-svn-id: svn://10.0.0.236/trunk@126121 18797224-902f-48f8-a5cc-f745e15eee43
2002-07-31 18:50:11 +00:00
relyea%netscape.com
089bdc9bb9 Protection against Token misbehaving tokens
git-svn-id: svn://10.0.0.236/trunk@126099 18797224-902f-48f8-a5cc-f745e15eee43
2002-07-31 02:00:13 +00:00