justdave%bugzilla.org
6dc3e61233
[SECURITY] Bug 253544: Changes to the metadata (filename, description, mime type, review flags) on attachments which were flagged as private get displayed to users who are not members of the group allowed to see private attachments when viewing the bug activity log. This only affects sites that use the 'insidergroup' feature.
...
Patch by Joel Peshkin <bugreport@peshkin.net>
r=zach,justdave, a=justdave
git-svn-id: svn://10.0.0.236/trunk@164338 18797224-902f-48f8-a5cc-f745e15eee43
2004-10-25 07:34:30 +00:00
bugreport%peshkin.net
cd65dc04d7
Bug 186093: Move CanSeeBug to User.pm and make User.pm usable by templates
...
r=kiko
a=justdave
git-svn-id: svn://10.0.0.236/trunk@160350 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-04 16:17:10 +00:00
jocuri%softhome.net
ac35b43d57
Patch for bug 253357: replace IFNULL with COALESCE for increased database compatibility; patch by Tomas Kopal <Tomas.Kopal@altap.cz>; r=vladd, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@160169 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-31 08:59:16 +00:00
bugreport%peshkin.net
0e036750a7
Bug 253447: Fix unhelpful error if user enters text in "blocks" field
...
r=kiko
a=justdave
git-svn-id: svn://10.0.0.236/trunk@160129 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-30 10:37:17 +00:00
kiko%async.com.br
f5b1cdca19
Fix for bug 236678: Clean up access to COOKIE global. Murder the last
...
remaining places in the tree where COOKIE is used; includes a rather
thorough cleanup of Bugzilla::Bug->user and a minor doc update. r=joel, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@160015 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-29 02:45:38 +00:00
jocuri%softhome.net
6f20bad256
Fix for bug 248988: On Windows, attachments may fail due to "CGI open of tmpfile"; patch by byron jones (glob) <bugzilla@glob.com.au>; r=jouni; a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@158850 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-07 08:59:44 +00:00
kiko%async.com.br
319f68a68e
Fix for bug 234175: Remove deprecated ConnectToDatabase() and
...
quietly_check_login()/confirm_login() calls. Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.
git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
kiko%async.com.br
07fca020f4
Fix for bug 67663: globals.pl and CGI.pl emit "subroutine redefined"
...
messages. Fudge warnings via sillyness. r=myk, chaduv. a=myk.
git-svn-id: svn://10.0.0.236/trunk@148488 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-30 01:31:58 +00:00
justdave%syndicomm.com
ec2098df1b
Backing out patch from bug 108528 - failed to take i10n concerns into account
...
git-svn-id: svn://10.0.0.236/trunk@148034 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-16 18:26:09 +00:00
timeless%mozdev.org
72f2fe28cc
Bug 108528 - knob is not defined doesn't explain to 2001110503 users what to do
...
patch by caduvall@glue.umd.edu r=timeless a=justdave
git-svn-id: svn://10.0.0.236/trunk@148005 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-15 22:48:12 +00:00
jocuri%softhome.net
de2a56bd48
Bug 213384: shutdownhtml login bypass via editparams.cgi is broken under suexec. r=kiko, a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@147700 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-07 19:15:35 +00:00
bbaetz%acm.org
7d7d7e1532
Bug 208699 - Move Throw{Code,Template}Error into Error.pm
...
r,a=justdave
git-svn-id: svn://10.0.0.236/trunk@146857 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-14 06:05:23 +00:00
bbaetz%acm.org
726bcd99cc
Bug 180635 - Enhance Bugzilla::User to store additional information
...
r=myk,jake
git-svn-id: svn://10.0.0.236/trunk@143228 18797224-902f-48f8-a5cc-f745e15eee43
2003-06-03 09:48:15 +00:00
bbaetz%acm.org
9e1d7096ea
Bug 201816 - use CGI.pm for header output
...
r=joel, a=justdave
git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
bbaetz%acm.org
6ee31579fe
Bug 199813 - Make all users of ThrowUserError pass $vars in explicitly.
...
r=gerv
a=justdave
git-svn-id: svn://10.0.0.236/trunk@140585 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-02 12:35:07 +00:00
bbaetz%acm.org
2b0b42744f
Bug 180642 - Move authentication code into a module
...
r=gerv, justdave
a=justdave
git-svn-id: svn://10.0.0.236/trunk@140041 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-22 04:47:35 +00:00
burnus%gmx.de
60fdcc9738
Bug 135820 - token cancellation message are not user-friendly
...
r=gerv, a=justdave
git-svn-id: svn://10.0.0.236/trunk@137871 18797224-902f-48f8-a5cc-f745e15eee43
2003-02-16 16:11:49 +00:00
preed%sigkill.com
017bee49ea
Bug 124174 - make processmail a package (Bugzilla::BugMail), r=gerv, r=jth, a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@137613 18797224-902f-48f8-a5cc-f745e15eee43
2003-02-09 22:04:25 +00:00
bbaetz%acm.org
53d658acb0
Bug 192393 - $::dbwritesallowed never set
...
r, a=justdave
git-svn-id: svn://10.0.0.236/trunk@137607 18797224-902f-48f8-a5cc-f745e15eee43
2003-02-08 23:26:48 +00:00
bbaetz%acm.org
eaa2d33a5a
Bug 191863 - Clean up Bugzilla.pm
...
r=gerv, justdave
a=justdave
git-svn-id: svn://10.0.0.236/trunk@137528 18797224-902f-48f8-a5cc-f745e15eee43
2003-02-07 07:19:15 +00:00
bbaetz%student.usyd.edu.au
ebae797eae
Bug 173622 - Move template handling into a module. r=justdave, joel, a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@135516 18797224-902f-48f8-a5cc-f745e15eee43
2002-12-20 07:21:43 +00:00
bugreport%peshkin.net
0d15369571
Bug 183843 Query knobs are missing if requirelogin is set
...
r,a=justdave
git-svn-id: svn://10.0.0.236/trunk@134878 18797224-902f-48f8-a5cc-f745e15eee43
2002-12-06 03:37:59 +00:00
jake%bugzilla.org
62306f0779
Bug 67077 - We now include the timezone (as configured in editparams.cgi) on every time we display.
...
r=justdave
a=justdave
git-svn-id: svn://10.0.0.236/trunk@134534 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-27 16:00:44 +00:00
bugreport%peshkin.net
cd1d896b54
Bug 173761 Need ability to always require login
...
patch by joel
r=gerv, a=justdave
git-svn-id: svn://10.0.0.236/trunk@134531 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-27 14:46:06 +00:00
gerv%gerv.net
b3fbaa5983
Bug 114179 - Concentration, improvement, and templatisation of Bugzilla general user help system. Patch by gerv; r,a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@134483 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-26 21:11:23 +00:00
bbaetz%student.usyd.edu.au
25c631b65e
Bug 179290 - login cookie email needs to be escaped
...
r=jake, a=justdave
git-svn-id: svn://10.0.0.236/trunk@133556 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-11 02:23:26 +00:00
bbaetz%student.usyd.edu.au
0945eecdec
Bug 114696 - permission checking in queries not optimal
...
Patch by joel, dkl + me
r=myk, a=justdave
git-svn-id: svn://10.0.0.236/trunk@133450 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-09 01:58:07 +00:00
myk%mozilla.org
1e4cfb771d
Fix for bug 156548: XUL implementation of duplicates report.
...
git-svn-id: svn://10.0.0.236/trunk@132978 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-05 01:54:15 +00:00
bbaetz%student.usyd.edu.au
b8b08c22b9
Bug 147833 - start using CGI.pm
...
r=gerv, justdave
git-svn-id: svn://10.0.0.236/trunk@132553 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-26 01:57:09 +00:00
bugreport%peshkin.net
df3dba60ad
Bug 112373 you should be able to enter bug dependencies/blockers when you enter a bug.
...
patch by jhedlund
r,2xr=joel
git-svn-id: svn://10.0.0.236/trunk@132132 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-17 04:31:56 +00:00
gerv%gerv.net
34c8aac2ba
Bug 172959 - Remove old reporting (most doomed etc.). Patch by gerv; r=bbaetz.
...
git-svn-id: svn://10.0.0.236/trunk@132103 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-16 23:09:31 +00:00
bugreport%peshkin.net
6d78654972
Bug 24789 [E|A|R] Add Estimated, Actual, Remaining Time Fields
...
patch by jeff.hedlund@matrixsi.com
2xr=joel,justdave
git-svn-id: svn://10.0.0.236/trunk@131895 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-13 04:26:24 +00:00
gerv%gerv.net
fb17f6ef2b
Bug 171437 - Enhancements to generic reporting. Reporting menu, 3D tables, rearranged UI, better API for new report types. Patch by gerv; r=joel.
...
git-svn-id: svn://10.0.0.236/trunk@131410 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-08 06:41:28 +00:00
gerv%gerv.net
d6fe11dfdb
Bug 163114 - Templatise all calls to DisplayError. Patch D (the last one). Patch by gerv; r=burnus.
...
git-svn-id: svn://10.0.0.236/trunk@131264 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-06 11:52:37 +00:00
gerv%gerv.net
608e491c4f
Bug 155389 - More <link> elements & templatization of navigation_links. Patch by gerv; r=bbaetz.
...
git-svn-id: svn://10.0.0.236/trunk@131064 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-03 07:04:10 +00:00
bbaetz%student.usyd.edu.au
638bb5c9f3
Bug 20122 - Bugzilla requires new login if IP changes
...
r=joel x2
git-svn-id: svn://10.0.0.236/trunk@130996 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-02 11:57:26 +00:00
bugreport%peshkin.net
65f04a9736
Bug 172010 voting broken on tip
...
Regression from 43600 and 157756
2xr=bbaetz
git-svn-id: svn://10.0.0.236/trunk@130948 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-02 00:46:22 +00:00
gerv%gerv.net
8f18026494
Bug 163114 - Templatise all calls to DisplayError. Patch B. Patch by gerv; r=burnus.
...
git-svn-id: svn://10.0.0.236/trunk@130685 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-28 21:44:27 +00:00
gerv%gerv.net
ffd6464c9e
Bug 170986 - General Summary reports don't work with taint checking. Also fixes Throw*Error's $extra_vars parameter. Patch by gerv; r=bbaetz.
...
git-svn-id: svn://10.0.0.236/trunk@130545 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-26 23:25:12 +00:00
gerv%gerv.net
e8dee5dea2
Bug 170064 - Change error API again to allow vars to be passed in the call. Patch by gerv; r=bbaetz.
...
git-svn-id: svn://10.0.0.236/trunk@130236 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-23 07:12:12 +00:00
bugreport%peshkin.net
2194da2336
bug 157756 - Groups_20020716_Branch Tracking : > 55 groups now supported
...
r=bbaetz, gerv
git-svn-id: svn://10.0.0.236/trunk@130217 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-22 17:15:13 +00:00
gerv%gerv.net
3b4e6f3b9c
Bug 166698 - clean up the error system, which was confused and broken. Patch by gerv; r=bbaetz.
...
git-svn-id: svn://10.0.0.236/trunk@128867 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-05 07:28:33 +00:00
bugreport%peshkin.net
74e1d57bca
Bug 121419 - If multiple cookies exist, the least significant is assigned.
...
2xr = bbaetz
Also fixes Duplicate Bug 165685 When switching from no cookiepath to using cookiepath, old cookie gets in the way
git-svn-id: svn://10.0.0.236/trunk@128604 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-31 01:53:12 +00:00
bbaetz%student.usyd.edu.au
46d483962b
Bug 163829 - move pref code into a separate package
...
r=joel, preed
git-svn-id: svn://10.0.0.236/trunk@128451 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-29 09:25:54 +00:00
bbaetz%student.usyd.edu.au
335b90f826
Bug 161203 - Bug changes with intermediate pages munges fields with
...
multiple values (e.g., CC)
patch by "Randall M! Gee", r=bbaetz, myk
git-svn-id: svn://10.0.0.236/trunk@128242 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-27 09:35:22 +00:00
bbaetz%student.usyd.edu.au
71381b40ed
Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
...
r=joel x2
git-svn-id: svn://10.0.0.236/trunk@128080 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-26 06:17:26 +00:00
gerv%gerv.net
754db3da7e
Bug 163331 - shutdownhtml is broken. Patch by gerv; r=bbaetz.
...
git-svn-id: svn://10.0.0.236/trunk@127656 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-19 22:34:32 +00:00
gerv%gerv.net
12f6d8cb39
Bug 143286 - Add support for Insiders, Private comments, Private Attachments. Patch by bugreport@peshkin.net; r=gerv.
...
git-svn-id: svn://10.0.0.236/trunk@127640 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-19 21:17:28 +00:00
bbaetz%student.usyd.edu.au
d4ca4bbcc4
Big 163291 - Move utility funcs into a module
...
r=preed x2
git-svn-id: svn://10.0.0.236/trunk@127613 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-19 13:59:45 +00:00
gerv%gerv.net
c069c70dfc
Bug 162068 - Fix callers of ThrowUserError to use messages.html.tmpl. Patch by gerv; r=bbaetz.
...
git-svn-id: svn://10.0.0.236/trunk@127416 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-15 22:57:21 +00:00