109 Commits

Author SHA1 Message Date
mkanat%bugzilla.org
160ef05099 Bug 595410: Make it faster to display a bug that has a lot of dependencies.
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@261706 18797224-902f-48f8-a5cc-f745e15eee43
2011-01-04 02:16:57 +00:00
mkanat%bugzilla.org
85209319bc Bug 573195: Make Bug.get return all of a bug's standard and custom field
information
r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@261302 18797224-902f-48f8-a5cc-f745e15eee43
2010-09-30 01:03:22 +00:00
mkanat%bugzilla.org
cb0d08e43d Bug 466968: Remove hardcoded strings from BugMail.pm, and refactor it so that bugmails are 100% localizable
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260996 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-06 10:46:40 +00:00
mkanat%bugzilla.org
1be00a65d9 Bug 572602: Change the way that Bugzilla::Object determines what fields
are required for create(). It now assumes that any column that is NOT NULL
and has not DEFAULT in the database is required. We also shift the burden
of throwing errors about empty values to the validators. This fixes the bug
that Bugzilla::Bug->create() wasn't populating default values for fields
if they weren't specified in the create() parameters.
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260542 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-24 00:47:53 +00:00
mkanat%bugzilla.org
e2c46e0470 A few tinderbox bustage fixes from the checkin of bug 24896.
git-svn-id: svn://10.0.0.236/trunk@260473 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-16 06:31:26 +00:00
mkanat%bugzilla.org
6add188323 Bug 24896: Make the First/Last/Prev/Next navigation on bugs work with
multiple buglists at once
r=glob, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260472 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-16 01:46:23 +00:00
mkanat%bugzilla.org
f7e990146a Bug 560009: Use firstidx from List::MoreUtils instead of lsearch
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260217 18797224-902f-48f8-a5cc-f745e15eee43
2010-04-22 18:16:55 +00:00
mkanat%bugzilla.org
7cc9991a5d Bug 556439: Prevent datetime_from from dying if it gets 0000-00-00 as a
date from the database
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260133 18797224-902f-48f8-a5cc-f745e15eee43
2010-04-02 23:47:51 +00:00
mkanat%bugzilla.org
5754033260 Bug 498309: Speed up show_bug.cgi when there are many comments by caching
field-descs globally for all template calls
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259959 18797224-902f-48f8-a5cc-f745e15eee43
2010-03-14 00:46:13 +00:00
reed%reedloden.com
56f209ba82 Bug 534587 - "Bugmail uses the timezone of the changee instead of the user receiving the mail" [p=reed r=mkanat a=mkanat]
git-svn-id: svn://10.0.0.236/trunk@259334 18797224-902f-48f8-a5cc-f745e15eee43
2010-01-05 07:07:46 +00:00
mkanat%bugzilla.org
0cc827bc54 Bug 527586: Use X-Forwarded-For instead of REMOTE_ADDR for trusted proxies
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259326 18797224-902f-48f8-a5cc-f745e15eee43
2009-12-31 12:53:21 +00:00
lpsolit%gmail.com
bc7a9d7a59 Bug 329638: https login page switches to http on submit if ssl_redirect = false - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@259088 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-25 23:57:53 +00:00
reed%reedloden.com
f092b2d524 Bug 360626 - "ThrowTemplateError() used in Util.pm" [p=reed r=LpSolit a=LpSolit]
git-svn-id: svn://10.0.0.236/trunk@259024 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-18 18:25:45 +00:00
reed%reedloden.com
e52faa4e68 Bug 528872 - "Attachments in attachments table should have CSS classes to help with styling" [p=reed r=LpSolit a=LpSolit]
git-svn-id: svn://10.0.0.236/trunk@258997 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-16 16:33:12 +00:00
mkanat%bugzilla.org
6d95687b90 Bug 472217: Create a Bugzilla::Comment object and eliminate GetComments
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@258951 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-10 01:36:05 +00:00
mkanat%bugzilla.org
17aaca86e7 Bug 523977: Make Bugzilla::Object->check send the trimmed value to new(), and also be more accurate about what's "empty". This also makes detaint_natural and detaint_signed call int() on their return values.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@258774 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-24 05:26:35 +00:00
mkanat%bugzilla.org
bc7313feed Bug 520948: Use Bugzilla->feature and feature_enabled everywhere instead of checking if modules are installed
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@258771 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-24 05:21:11 +00:00
lpsolit%gmail.com
c89b589751 Bug 399073: Remove the 'loginnetmask' parameter - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@258717 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-18 23:35:01 +00:00
mkanat%bugzilla.org
c70c2cf9ff Bug 514913: Eliminate ssl="authenticated sessions"
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@258645 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-09 04:31:13 +00:00
lpsolit%gmail.com
2158ba3c3b Bug 476305: Clean up and merge HTML filtering code - Patch by Vitaly Fedrushkov <vitaly.fedrushkov@gmail.com> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@257714 18797224-902f-48f8-a5cc-f745e15eee43
2009-07-16 01:30:52 +00:00
mkanat%bugzilla.org
48e04ed56d Bug 491630: Make sure DateTime never gets fractional "seconds" in new()
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@257349 18797224-902f-48f8-a5cc-f745e15eee43
2009-06-02 03:47:44 +00:00
ghendricks%novell.com
e7be1a3242 Bug 486006 - importxml.pl must not use format_time() for deadlines
patch by ghendricks r=LpSolit a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@256888 18797224-902f-48f8-a5cc-f745e15eee43
2009-04-10 22:29:59 +00:00
lpsolit%gmail.com
0b09463f19 Bug 487865: Exporting bugs in XML format uses non-unique timezones (they cannot be imported back) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=ghendricks a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@256886 18797224-902f-48f8-a5cc-f745e15eee43
2009-04-10 22:09:40 +00:00
lpsolit%gmail.com
486b50abd3 2nd fix for bug 105960 (xml.cgi and other future xml pages generate invalid XML). Some illegal characters were still not excluded - Patch by David Marshall <dmarshal@yahoo-inc.com> r=LpSolit
git-svn-id: svn://10.0.0.236/trunk@256466 18797224-902f-48f8-a5cc-f745e15eee43
2009-03-06 14:43:40 +00:00
wicked%sci.fi
0bc62f2def Bug 333648: Add flag change to activity log and bugmail when only setter is changed - Patch by Teemu Mannermaa <wicked@sci.fi> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@256229 18797224-902f-48f8-a5cc-f745e15eee43
2009-02-14 09:45:44 +00:00
lpsolit%gmail.com
c4c45cc16c Bug 476889: importxml.pl crashes when importing bugs (Date::Parse::strptime() leave seconds undefined in some cases) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=ghendricks a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@256119 18797224-902f-48f8-a5cc-f745e15eee43
2009-02-05 18:37:19 +00:00
lpsolit%gmail.com
0c29cf31b2 Bug 38862: [SECURITY] attachments should be at a different hostname - Patch by Byron Jones <bugzilla@glob.com.au> and Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@256018 18797224-902f-48f8-a5cc-f745e15eee43
2009-02-02 18:26:26 +00:00
mkanat%bugzilla.org
4088e2081f Bug 219021: Only display email addresses to logged-in users
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@255976 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-29 21:22:39 +00:00
lpsolit%gmail.com
4cebd89bf8 Bug 471613: Replace Bugzilla::Util::is_tainted() by Scalar::Util::tainted() - Patch by Nitish Bezzala <nbezzala@yahoo.com> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@255915 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-24 14:12:20 +00:00
lpsolit%gmail.com
ea5ed455eb Bug 464992: Binary attachments, graphical reports and new charts are not displayed correctly on Windows - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@255819 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-15 01:16:05 +00:00
mkanat%bugzilla.org
36dafcc096 Bug 211006: Make Bugzilla use SHA-256 instead of crypt() to store hashed passwords in the database
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@255694 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-02 09:11:51 +00:00
lpsolit%gmail.com
f3747e3b69 Bug 105960: xml.cgi generates invalid XML - Patch by Kip Hampton <khampton@totalcinema.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@255666 18797224-902f-48f8-a5cc-f745e15eee43
2008-12-30 01:40:36 +00:00
dkl%redhat.com
d2cc34e014 Bug 455584 - Use bz_crypt everywhere instead of the crypt() function
Patch by David Lawrence <dkl@redhat.com> = r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@254732 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-22 21:54:59 +00:00
wurblzap%gmail.com
b489635c17 Bug 459365 - Scrubber should let <fieldset> and <legend> pass.
Patch by Marc Schumann <wurblzap@gmail.com>;
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@254579 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-10 11:16:51 +00:00
dkl%redhat.com
36109e6138 Bug 453767 - Passwords containing wide characters causes system error
Patch by David Lawrence <dkl@redhat.com> - a/r=mkanat


git-svn-id: svn://10.0.0.236/trunk@254181 18797224-902f-48f8-a5cc-f745e15eee43
2008-09-12 15:10:14 +00:00
lpsolit%gmail.com
225cd8cd05 Bug 399070: Remove the 'timezone' parameter - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@253910 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-27 23:26:26 +00:00
lpsolit%gmail.com
8a9a851608 Bug 182238: Allow users to choose what time zone to display times in - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@253854 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-27 02:32:26 +00:00
dkl%redhat.com
f51ff717a8 Bug 428659 – Setting SSL param to 'authenticated sessions' only protects logins and param
doesn't protect WebService calls at all
Patch by David Lawrence <dkl@redhat.com> - r/a=LpSolit/mkanat


git-svn-id: svn://10.0.0.236/trunk@253665 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-18 04:16:14 +00:00
dkl%redhat.com
223ced6261 Backing out these patches as they cause a regression. More information
in the respective bug reports.

Bug 428659 – Setting SSL param to 'authenticated sessions' only
protects logins and param doesn't protect WebService calls at all
Patch by Dave Lawrence <dkl@redhat.com> - r/a=mkanat

Bug 445104: ssl redirects come with a 200 OK HTTP code on mod_perl
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@253320 18797224-902f-48f8-a5cc-f745e15eee43
2008-07-28 20:58:01 +00:00
dkl%redhat.com
fe2838832f Bug 428659 – Setting SSL param to 'authenticated sessions' only protects logins and param doesn't protect WebService calls at all
Patch by Dave Lawrence <dkl@redhat.com> - r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@252948 18797224-902f-48f8-a5cc-f745e15eee43
2008-07-10 04:56:22 +00:00
lpsolit%gmail.com
80f0e8466a Bug 410902: Some characters are mangled in diff and interdiff modes when viewing patches - Patch by Frédéric Buclin <LpSolit@gmail.com> r=shimono, r=mkanat a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@249044 18797224-902f-48f8-a5cc-f745e15eee43
2008-04-03 16:58:29 +00:00
lpsolit%gmail.com
0f6700a459 Bug 423439: show_bug.cgi crashes when wrapping comments which contain Unicode characters and tabs in them - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@248763 18797224-902f-48f8-a5cc-f745e15eee43
2008-03-28 12:33:13 +00:00
mkanat%bugzilla.org
8c686c07fa Bug 405898: Date/Time Fields should accept times like H:MM
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@242133 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-27 22:39:28 +00:00
mkanat%bugzilla.org
d23acf5671 Bug 405444: FormatDouble and FormatTriple mangle multi-byte strings in email
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=himorin, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@241689 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-18 21:22:43 +00:00
mkanat%bugzilla.org
dfcc3ead8a Bug 397099: Date/Time Fields should have a JavaScript widget for picking a date
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, r=glob, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@240082 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-29 02:20:35 +00:00
lpsolit%gmail.com
9bfdcd3d5f Bug 405404: HTML::Scrubber throws "undef error - Wide character in subroutine entry" when a field filtered with html_light contains UTF-8 characters - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@240048 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-28 19:39:29 +00:00
mkanat%bugzilla.org
eff047bd4f Bug 363153: Turn on the utf8 bit on all strings in Bugzilla that contain
non-ASCII data, if the utf8 parameter is on. This means that string functions
like substr() work properly on multi-byte languages, now.
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=wurblzap, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@239856 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-23 06:58:36 +00:00
mkanat%bugzilla.org
d6eb60f7ac Bug 357324: Date/Time Custom Fields
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@238040 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-23 19:36:53 +00:00
lpsolit%gmail.com
984b2394b8 Bug 398838: Remove the obsolete Util::value_quote() routine - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@237388 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-07 22:56:37 +00:00
mkanat%bugzilla.org
666323d4db Bug 357315: Add the ability to create <textarea> fields
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@236083 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-17 04:48:06 +00:00