148 Commits

Author SHA1 Message Date
nelson%bolyard.com
866622494b Bug 472975: crash when deleting user certificates, r=rrelyea
git-svn-id: svn://10.0.0.236/trunk@255883 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-22 01:29:24 +00:00
nelson%bolyard.com
1ac3bab648 Bug 444850: NSS misbehaves badly in the presence of a disabled PKCS#11 slot
This patch commits the difference between v5 and v6 of the patch named
"create token object, even when there is no session". v6 was r=julien


git-svn-id: svn://10.0.0.236/trunk@255145 18797224-902f-48f8-a5cc-f745e15eee43
2008-11-20 04:53:44 +00:00
nelson%bolyard.com
b0b004906e Bug 465270: uninitialised value in devutil.c::create_object()
Bug 465273: dead assignment in devutil.c::nssSlotArray_Clone()
Patch by Constantine A. Murenin <cnst+bmo@bugmail.mojo.ru>
r=nelson.  Found with LLVM/Clang Static Analyser.


git-svn-id: svn://10.0.0.236/trunk@255130 18797224-902f-48f8-a5cc-f745e15eee43
2008-11-19 20:44:35 +00:00
nelson%bolyard.com
f46a3579b5 Stop assuming session pointers are non-NULL for bug 444974. r=rrelyea
git-svn-id: svn://10.0.0.236/trunk@254475 18797224-902f-48f8-a5cc-f745e15eee43
2008-09-30 04:09:04 +00:00
nelson%bolyard.com
9784be0a2e Bug 444850 – NSS misbehaves badly in the presence of a disabled PKCS#11 slot
r=julien.pierre, rrelyea


git-svn-id: svn://10.0.0.236/trunk@253485 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-09 01:26:05 +00:00
nelson%bolyard.com
8b4a89dc0d Bug 444850. Don't ask the module to use an invalid session handle in
find_objects.  r=alexei,julien sr=wtc.


git-svn-id: svn://10.0.0.236/trunk@253184 18797224-902f-48f8-a5cc-f745e15eee43
2008-07-22 04:34:02 +00:00
kaie%kuix.de
4e2b64148d Bug 426886, Use "const" char* in PK11_ImportCertForKey
r=wtc, r=julien.pierre


git-svn-id: svn://10.0.0.236/trunk@251939 18797224-902f-48f8-a5cc-f745e15eee43
2008-05-29 17:24:23 +00:00
wtc%google.com
3ca99be11f Bug 431929: Fixed a memory leak on an error path in
get_token_objects_for_cache .  r=nelson.


git-svn-id: svn://10.0.0.236/trunk@251686 18797224-902f-48f8-a5cc-f745e15eee43
2008-05-18 01:51:45 +00:00
wtc%google.com
4ab3de3dc0 Bug 431929: Refactored duplicate code into common subroutines. 1. Replaced
nssToken_Find{Certificates,TrustObjects,CRLs} by nssToken_FindObjects.
2. Replaced get_token_{certs,trust,crls}_for_cache by
get_token_objects_for_cache.  r=nelson.
Modified Files:
	dev/dev.h dev/devtoken.c dev/devutil.c pk11wrap/pk11cert.c


git-svn-id: svn://10.0.0.236/trunk@251680 18797224-902f-48f8-a5cc-f745e15eee43
2008-05-17 00:13:39 +00:00
nelson%bolyard.com
c16758aa06 Bug 391903: nssSlot object for nssckbi leaked when loaded by PSM.
r=rrelyea


git-svn-id: svn://10.0.0.236/trunk@250834 18797224-902f-48f8-a5cc-f745e15eee43
2008-04-27 02:13:52 +00:00
rrelyea%redhat.com
9bb6a9986d Back out patch to bug 391903.
Windows tinderboxen are failing.


git-svn-id: svn://10.0.0.236/trunk@250704 18797224-902f-48f8-a5cc-f745e15eee43
2008-04-23 16:37:19 +00:00
rrelyea%redhat.com
b5cd881917 Bug 391903 r=nelson.
leak objects from nssSlot_Create


git-svn-id: svn://10.0.0.236/trunk@250586 18797224-902f-48f8-a5cc-f745e15eee43
2008-04-21 23:54:49 +00:00
julien.pierre.boogz%sun.com
7f43dce253 Fix for bug 410226 . Leak in create_object_from_handles. r=nelson
git-svn-id: svn://10.0.0.236/trunk@244914 18797224-902f-48f8-a5cc-f745e15eee43
2008-02-05 03:22:38 +00:00
wtc%google.com
3047e8ce36 Bug 353577 and bug 404610: minor formatting changes. tbr=julien.pierre
Modified Files:
	dev/manifest.mn pki/manifest.mn pki/pkibase.c


git-svn-id: svn://10.0.0.236/trunk@239785 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-21 18:02:13 +00:00
julien.pierre.boogz%sun.com
3b557e654d Fix for bug 353577 . Delete PURE_STAN code and code outside NSS_3_4_CODE . r=wtc,nelson
git-svn-id: svn://10.0.0.236/trunk@239526 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-16 05:29:27 +00:00
slavomir.katuscak%sun.com
a66d8cc0dd Bug 384639 - Adding option to disable library unloading also in optimized build.
r=nelson


git-svn-id: svn://10.0.0.236/trunk@237458 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-09 17:06:25 +00:00
christophe.ravel.bugs%sun.com
01014185ad Bug 389781 NSS should be built size-optimized on Linux, Windows, and Mac
r=julien.pierre.boogz


git-svn-id: svn://10.0.0.236/trunk@232117 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-15 15:30:08 +00:00
rrelyea%redhat.com
557cb6151c Bug 391291 Implement Shared Database Integrity checks.
r=nelson (plus review from kengert)


git-svn-id: svn://10.0.0.236/trunk@231760 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-09 22:36:20 +00:00
slavomir.katuscak%sun.com
0f8db9e5a0 Bug 384639: Added option to disable library unloading. r=nelson
git-svn-id: svn://10.0.0.236/trunk@230739 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-24 08:56:41 +00:00
julien.pierre.bugs%sun.com
b5c661f69d Fix for bug 113323 . Constify some functions. r=nelson
git-svn-id: svn://10.0.0.236/trunk@229672 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-11 04:47:42 +00:00
alexei.volkov.bugs%sun.com
524b9f24a6 additional fix for 353909: klocwork ptr dereference before NULL check in devutil.c. r=nelson
git-svn-id: svn://10.0.0.236/trunk@214446 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-31 00:21:24 +00:00
alexei.volkov.bugs%sun.com
26dcb5afb0 353909: klocwork ptr dereference before NULL check in devutil.c. r=nelson
git-svn-id: svn://10.0.0.236/trunk@214444 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-31 00:05:04 +00:00
alexei.volkov.bugs%sun.com
60d825a9a6 353416: Klocwork 76593 null ptr deref in nssCryptokiPrivateKey_SetCertificate. r=nelson
git-svn-id: svn://10.0.0.236/trunk@213358 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-09 22:11:44 +00:00
wtchang%redhat.com
186a2a5899 Bugzilla Bug 301554: Clear the 'present' flag if slot fails to refresh.
relyea wrote the patch. r=wtc,nelsonb.


git-svn-id: svn://10.0.0.236/trunk@180160 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-14 01:35:02 +00:00
neil.williams%sun.com
54b7280983 This fixes Bugzilla Bug 288227 by initializing the stepUp flag in
nssCryptokiTrust_GetAttributes(). r=nelsonb


git-svn-id: svn://10.0.0.236/trunk@171581 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-04 18:46:23 +00:00
wtchang%redhat.com
075a2f5564 Bugzilla Bug 284839: checked in Bob Relyea's patch to improve the
responsiveness of SECMOD_WaitForAnyTokenEvent. r=wtc,nelsonb.
Modified Files: lib/dev/dev.h lib/dev/devslot.c lib/pk11wrap/pk11util.c


git-svn-id: svn://10.0.0.236/trunk@170319 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-07 21:20:38 +00:00
wtchang%redhat.com
68afcb2227 Bugzilla Bug 267158: removed the $Name$ RCS keyword from our source files.
This keyword adds noise to the output of "ident libnss3.so | grep NSS"
on our debug build, and appears to cause spurious CVS conflicts. r=nelsonb.


git-svn-id: svn://10.0.0.236/trunk@168042 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-20 02:25:51 +00:00
nelsonb%netscape.com
862ad14e78 Initialize 4 variables. Plug UMR reports. Bug 263691. r=wtchang
git-svn-id: svn://10.0.0.236/trunk@167012 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-24 07:13:35 +00:00
nelsonb%netscape.com
9012bc4efb Patch by kinmoz@netscape.net. Fix bug 260882 by clearing the valid
cache flag (named "searchedObjectType") even when the cache was empty.


git-svn-id: svn://10.0.0.236/trunk@162647 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-22 01:45:26 +00:00
ian.mcgreer%sun.com
f7fd7e85b4 bug 180268, reimplement ssl step-up for builtins
git-svn-id: svn://10.0.0.236/trunk@156475 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-17 20:08:38 +00:00
gerv%gerv.net
43cb9e1492 Bug 236613: change to MPL/LGPL/GPL tri-license.
git-svn-id: svn://10.0.0.236/trunk@155484 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-25 15:03:26 +00:00
nelsonb%netscape.com
a764068a58 Fix bug 204549. Properly handle memory allocation failures.
git-svn-id: svn://10.0.0.236/trunk@147193 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-23 20:47:43 +00:00
wtc%netscape.com
e8dd7063dd Bugzilla bug 204549: find_objects_by_template was not setting *statusOpt
before one return statement.  r=nelsonb.


git-svn-id: svn://10.0.0.236/trunk@147192 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-23 20:34:15 +00:00
wtc%netscape.com
c6768f3bcf Bugzilla bug 214535: fixed a recursive dead lock on cache->lock. We must
not call nssSlot_IsTokenPresent while cache->lock is locked because
that function may call nssToken_Remove, which locks cache->lock.  r=mcgreer


git-svn-id: svn://10.0.0.236/trunk@146816 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-12 19:17:15 +00:00
wtc%netscape.com
1cbc8808cd Bugzilla bug 214695: fixed incorrect use of PR_AtomicDecrement on reference
counts.  The reference count should not be read "naked".  Instead, we
should simply use the return value of PR_AtomicDecrement for the result of
the decrement.
Modified Files: dev/devmod.c dev/devslot.c dev/devtoken.c pki/certificate.c
pki/pkibase.c


git-svn-id: svn://10.0.0.236/trunk@145445 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-01 02:02:47 +00:00
wtc%netscape.com
81587a9538 Backed out Bob Relyea's workaround for the deadlock in rev. 1.15. The
correct fix is in rev. 1.36 of tdcache.c (see Bugzilla bug 212112).


git-svn-id: svn://10.0.0.236/trunk@144744 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-11 21:52:04 +00:00
nelsonb%netscape.com
aa6267105e Change the function definitions in dev so that the ctags program will
produce valid tags from these sources.


git-svn-id: svn://10.0.0.236/trunk@144324 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-01 00:32:22 +00:00
relyea%netscape.com
da74328ba9 Fix deadlock bugscape 46733
git-svn-id: svn://10.0.0.236/trunk@144005 18797224-902f-48f8-a5cc-f745e15eee43
2003-06-20 23:34:46 +00:00
wtc%netscape.com
8d0a26b479 Bug 202593: the newly added 'lock' field in the NSSToken structure is not
being used.


git-svn-id: svn://10.0.0.236/trunk@142386 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-13 22:59:20 +00:00
wtc%netscape.com
0fcacee35c Bug 202593 and bug 204980: fixed a recursive deadlock introduced by the
fix for bug 202593. The session returned by nssSlot_CreateSession doesn't
need its own lock.  It is either protected by a higher-level lock (the
slot or module lock) or used by only one thread throughout its lifetime.
Modified Files: dev/devslot.c pk11wrap/dev3hack.c


git-svn-id: svn://10.0.0.236/trunk@142302 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-10 14:21:40 +00:00
wtc%netscape.com
497bcfe6f8 Bug 204797: nssTokenObjectCache_Clear needs to lock the cache, otherwise
multiple threads could clear the cache at the same time after a token is
removed.


git-svn-id: svn://10.0.0.236/trunk@142301 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-10 14:19:04 +00:00
relyea%netscape.com
ce10045446 Bug 202593 NSS does not lock non-threadsafe modules correctly.
Consolidate one lock for non-thread safe modules (not one per slot).


git-svn-id: svn://10.0.0.236/trunk@141421 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-19 00:03:13 +00:00
jpierre%netscape.com
4734fd96af Fix for 190424 - don't query CKA_NETSCAPE_EMAIL attribute . r=wtc
git-svn-id: svn://10.0.0.236/trunk@137118 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-30 03:02:55 +00:00
wtc%netscape.com
4b6932465e Bug 190396.
Don't fail the search if the token returned an error that indicates that it
legitimately couldn't find a CRL


git-svn-id: svn://10.0.0.236/trunk@136929 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-24 06:37:03 +00:00
nelsonb%netscape.com
d36cf9c052 Support SHA256, SHA384, and SHA512 hashes in NSS.
git-svn-id: svn://10.0.0.236/trunk@135163 18797224-902f-48f8-a5cc-f745e15eee43
2002-12-12 06:05:45 +00:00
ian.mcgreer%sun.com
4a6e624c98 bug 172247, don't allow import of duplicate issuer/serial certs
git-svn-id: svn://10.0.0.236/trunk@134280 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-21 20:43:15 +00:00
relyea%netscape.com
f045aece62 Fix optimized build failures
git-svn-id: svn://10.0.0.236/trunk@131718 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-10 21:17:39 +00:00
relyea%netscape.com
faa9e5505e Bug 164501. Return a proper error code from PK11_FindCrlByName() so the CRL
code can decide if there is a hw or system failure preventing the reading of a
CRL or if the CRL is just not there.


git-svn-id: svn://10.0.0.236/trunk@131706 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-10 20:30:19 +00:00
ian.mcgreer%sun.com
599c379a2b bug 166793, uninitialized variables
r=wtc


git-svn-id: svn://10.0.0.236/trunk@130814 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-30 21:15:07 +00:00
ian.mcgreer%sun.com
fe942ec05f bug 166741, fixing bug in previous patches
r=wtc


git-svn-id: svn://10.0.0.236/trunk@129171 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-10 20:30:53 +00:00