This removes all call-sites I can currently fix. Tomorrow I'll try to get someone to checkin my changes to security/ and I'll get some help with the Netscape side of things.
nsString::GetUnicode()'s final death-blow will be dealt soon. Please keep this in mind as you add new code :-)
git-svn-id: svn://10.0.0.236/trunk@235746 18797224-902f-48f8-a5cc-f745e15eee43
Make bookmarks-service open a Navigator window with uri as argument using
WindowWatcher interface.
r=pchen, sr=blake, a=chofmann
git-svn-id: svn://10.0.0.236/trunk@235744 18797224-902f-48f8-a5cc-f745e15eee43
Build Error Summary
c++ -o nsBookmarksService.o -c -DOSTYPE=\"BeOS5.0\" -DOSARCH=\"BeOS\" -DMOZ_REFLOW_PERF -DMOZ_REFLOW_PERF_DSP -DOJI -I../../../../dist/include -I../../../../dist/include -I/boot/home/tinderbox/BeOS_5.0_Depend/mozilla/obj-i686-pc-beos/dist/include/nspr -fPIC -frtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wbad-function-cast -Wcast-align -Woverloaded-virtual -Wsynth -Wno-multichar -Wno-ctor-dtor-privacy -pedantic -Wno-long-long -pipe -DDEBUG -DDEBUG_cltbld -DTRACING -g -DMOZILLA_CLIENT -include ../../../../config-defs.h -Wp,-MD,.deps/nsBookmarksService.pp /boot/home/tinderbox/BeOS_5.0_Depend/mozilla/xpfe/components/bookmarks/src/nsBookmarksService.cpp
/boot/home/tinderbox/BeOS_5.0_Depend/mozilla/xpfe/components/bookmarks/src/nsBookmarksService.cpp: In method `nsresult nsBookmarksService::ReadBookmarks()':
/boot/home/tinderbox/BeOS_5.0_Depend/mozilla/xpfe/components/bookmarks/src/nsBookmarksService.cpp:4112: no matching function for call to `BookmarkParser::SetIEFavoritesRoot (nsCString)'
/boot/home/tinderbox/BeOS_5.0_Depend/mozilla/xpfe/components/bookmarks/src/nsBookmarksService.cpp:403: candidates are: BookmarkParser::SetIEFavoritesRoot(nsCString &) <near match>
make[5]: *** [nsBookmarksService.o] Error 1
picky compiler. i'm amazed that any of the code in there works. this is a bustage fix that will only affect XP_BEOS.
git-svn-id: svn://10.0.0.236/trunk@235743 18797224-902f-48f8-a5cc-f745e15eee43
(implement method exposing BookmarkParser::CreateAnonymousResource)
- allow user to remove Imported IE favorites folder by setting a pref
so that it is not automatically imported on startup.
r=hixie, sr=blake, a=asa
part of 79904, 22642
git-svn-id: svn://10.0.0.236/trunk@235742 18797224-902f-48f8-a5cc-f745e15eee43
r=alecf, sr=waterson
Personal toolbar doesn't migrate on DBCS systems - use NS_ConvertUTF8toUCS2
git-svn-id: svn://10.0.0.236/trunk@235734 18797224-902f-48f8-a5cc-f745e15eee43
cache validation preferences and browsing via history. r=gagan,gordon.
Fixes several bugs that I would mention here if bugzilla weren't down ;-)
git-svn-id: svn://10.0.0.236/trunk@235733 18797224-902f-48f8-a5cc-f745e15eee43
Revising nsIChannel to allow for overlapped i/o. This consists of three parts:
1. Factoring nsIChannel into a protocol specific part, the nsIChannel, and a socket specific, the nsITransport.
2. Derive the nsIChannel from a nsIRequest.
2. Changes the notification system from necko and the URILoader to pass the nsIRequest interface instead of nsIChannel interface.
This goal stems from wanting to be able to have active AsyncRead and AsyncWrite operations on nsSocketTransport.
This is desired because it would greatly simplify the task of maintaining persistent/reusable socket connections
for FTP, HTTP, and Imap (and potentially other protocols). The problem with the existing nsIChannel interface is
that it does not allow one to selectively suspend just one of the read or write operations while keeping the other active.
r=darin@netscape.comsr=rpotts@netscape.com
git-svn-id: svn://10.0.0.236/trunk@235725 18797224-902f-48f8-a5cc-f745e15eee43
1. Factoring nsIChannel into a protocol specific part, the nsIChannel, and a socket specific, the nsITransport.
2. Derive the nsIChannel from a nsIRequest.
2. Changes the notification system from necko and the URILoader to pass the nsIRequest interface instead of nsIChannel interface.
This goal stems from wanting to be able to have active AsyncRead and AsyncWrite operations on nsSocketTransport.
This is desired because it would greatly simplify the task of maintaining persistent/reusable socket connections
for FTP, HTTP, and Imap (and potentially other protocols). The problem with the existing nsIChannel interface is
that it does not allow one to selectively suspend just one of the read or write operations while keeping the other active.
The full details of the change on written up in the netlib newsgroup.
r=darin@netscape.comsr=rpotts@netscape.com
git-svn-id: svn://10.0.0.236/trunk@235720 18797224-902f-48f8-a5cc-f745e15eee43
Thanks to Takashi Toyoshima <toyohim@be-in.org> for the patch.
Bug #65131 r=cls
git-svn-id: svn://10.0.0.236/trunk@235718 18797224-902f-48f8-a5cc-f745e15eee43
sr=waterson
r=valeski
This fix removes the two instances of the unsafe practice of having
static nsCOMPtr instances, either as static data members or or file
static variables. This practice prevents the proper ref-counting of
such instances, and leads to accessing the instances after their
ref-count has gone to 0.
The following files are in this fix:
widget/timer/src/windows/nsTimer.cpp
xpfe/components/bookmarks/src/nsBookmarksService.cpp
xpfe/components/bookmarks/src/nsBookmarksService.h
widget/timer/src/windows/nsWindowsTimer.h
git-svn-id: svn://10.0.0.236/trunk@235710 18797224-902f-48f8-a5cc-f745e15eee43
