57 Commits

Author SHA1 Message Date
lpsolit%gmail.com
8b80993aad Part 4 of bug 182083: add Help for non-admin pages - Patch by me, r=Colin
git-svn-id: svn://10.0.0.236/trunk@239166 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-11 22:03:21 +00:00
mkanat%bugzilla.org
d7e641858a Bug 399954: Make Bugzilla able to hold its dependencies in a local directory
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@237891 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-19 06:46:19 +00:00
timeless%mozdev.org
cf65aca309 Bug 254758 creating an account that doesn't match the create email regexp should not say "New accounts must be created by an administrator."
r=lpsolit a=lpsolit


git-svn-id: svn://10.0.0.236/trunk@230671 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-23 21:52:49 +00:00
mkanat%bugzilla.org
9cd61530a5 Bug 351098: Make Bugzilla::Object able to update objects in the database, and make Bugzilla::Keyword use it
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@209194 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-05 19:18:27 +00:00
mkanat%bugzilla.org
8aa56fc69e Bug 349349: Use ->create from Bugzilla::Object instead of insert_new_user for Bugzilla::User
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@208468 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-25 22:10:39 +00:00
lpsolit%gmail.com
b735434f6f Bug 87795: Creating an account should send token and wait for confirmation (prevent user account abuse) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat r=bkor a=myk
git-svn-id: svn://10.0.0.236/trunk@207935 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-19 18:12:00 +00:00
mkanat%bugzilla.org
520fe42625 Bug 338375: Use Bugzilla->params everywhere instead of Param().
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201503 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:42:47 +00:00
mkanat%bugzilla.org
8323e09c40 Bug 342869: Use Bugzilla->params everywhere except templates
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201499 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:26:22 +00:00
lpsolit%gmail.com
a698e74659 Bug 282121: Remove globals.pl from scripts that no longer use it - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@200489 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-21 00:44:48 +00:00
lpsolit%gmail.com
a4475004a2 Bug 312935: User Account Log should start with a creation date - Patch by Frédéric Buclin <LpSolit@gmail.com> r=bkor, r=wicked a=myk
git-svn-id: svn://10.0.0.236/trunk@199443 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-07 20:31:10 +00:00
mkanat%bugzilla.org
caee2e9858 Bug 300410: Bugzilla::Auth needs to be restructured to not require a BEGIN block
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@196368 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-12 02:41:22 +00:00
lpsolit%gmail.com
4bba466645 Bug 320436: New self-created accounts dont get regexp group memberships - Patch by Joel Peshkin <bugreport@peshkin.net> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@186337 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-20 22:16:09 +00:00
lpsolit%gmail.com
e334b85a95 Bug 312157: Remove $::template and $::vars from globals.pl - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182927 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-24 23:11:56 +00:00
lpsolit%gmail.com
88c468dba1 Bug 304653: remove 'use Bugzilla::Error' from Util.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@177759 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-15 17:43:38 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
lpsolit%gmail.com
b48f197026 Bug 292059: No locking in createaccount.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=myk
git-svn-id: svn://10.0.0.236/trunk@176698 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-27 20:18:20 +00:00
lpsolit%gmail.com
a68c2a62b5 Bug 301453: Move CheckEmailSyntax out of CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@176363 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-20 21:24:19 +00:00
lpsolit%gmail.com
b4feb71d7f Bug 299572: Move MailPassword() from CGI.pl into BugMail.pm (and remove an unused variable) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@175906 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-11 00:40:59 +00:00
lpsolit%gmail.com
6ec52f8b8e Bug 294778: Unable to create new accounts when requirelogin is on - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@173591 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-19 19:40:22 +00:00
lpsolit%gmail.com
85bfb55064 Bug 276543: createaccount.cgi should not be displayed if account creation is disabled - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@171376 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-30 09:57:29 +00:00
mkanat%kerio.com
64adf228bd Bug 284975: Any code after Throw*Error is a dead code.
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@170414 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-09 00:26:39 +00:00
travis%sedsystems.ca
b63354eba2 Bug 280994 : Move ValidateNewUser out of globals.pl
Patch by Max Kanat-Alexander <mkanat@kerio.com>  r=vladd  a=justdave


git-svn-id: svn://10.0.0.236/trunk@169041 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-09 06:42:43 +00:00
travis%sedsystems.ca
0abffd8846 Bug 280124 : Move InsertNewUser to Bugzilla::User
Patch by Max Kanat-Alexander <mkanat@kerio.com>   r=vladd  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168579 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-31 21:04:12 +00:00
bugreport%peshkin.net
ba7b83aa6f Bug 241900: Allow Bugzilla::Auth to have multiple login and validation styles
patch by erik
r=joel, kiko
a=myk


git-svn-id: svn://10.0.0.236/trunk@159556 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-20 22:41:22 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
jocuri%softhome.net
5cc84f2b11 Patch for bug 235175: replaces ::FORM from createaccount.cgi with CGI based methods that are mod_perl compatible; r=gerv; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@153156 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-24 12:25:11 +00:00
kiko%async.com.br
c8c51a1d78 Bug 226324: Move relogin.cgi code to Bugzilla::Auth::CGI. Provide a
logout() method that is proxied through Bugzilla.pm's logout(), and fix
callers to use it.  r=justdave, bbaetz, a=justdave


git-svn-id: svn://10.0.0.236/trunk@149789 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-27 01:01:00 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-27 00:07:02 +00:00
bbaetz%acm.org
2b0b42744f Bug 180642 - Move authentication code into a module
r=gerv, justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140041 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-22 04:47:35 +00:00
bugreport%peshkin.net
a450bd78b1 Bug 86029 create permission restrictions for createaccount.cgi (prevent people from creating accounts)
r=burnus
a=justdave


git-svn-id: svn://10.0.0.236/trunk@134966 18797224-902f-48f8-a5cc-f745e15eee43
2002-12-09 00:24:43 +00:00
gerv%gerv.net
f5ff5cdd26 Bug 163114 - Templatise all calls to DisplayError. Patch C. Patch by gerv; r=burnus.
git-svn-id: svn://10.0.0.236/trunk@130932 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-01 22:41:09 +00:00
preed%sigkill.com
bf699ca6af Bug 165221: Apostrophes not properly handled during account creation. r=joel,r2=bbaetz
git-svn-id: svn://10.0.0.236/trunk@128560 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-30 15:24:12 +00:00
bbaetz%student.usyd.edu.au
71381b40ed Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
r=joel x2


git-svn-id: svn://10.0.0.236/trunk@128080 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-26 06:17:26 +00:00
jouni%heikniemi.net
8e4855ea07 Bug 156680: "Undefined variable warning" in createaccount.cgi
2xr=bbaetz


git-svn-id: svn://10.0.0.236/trunk@125023 18797224-902f-48f8-a5cc-f745e15eee43
2002-07-11 19:25:29 +00:00
bbaetz%student.usyd.edu.au
4403bbe04e Bug 151053, ConnectToDatabase/quietly_check_login sometimes not called
early enough
r=mattyt, jouni


git-svn-id: svn://10.0.0.236/trunk@123428 18797224-902f-48f8-a5cc-f745e15eee43
2002-06-17 09:39:48 +00:00
gerv%gerv.net
bf209bace0 Bug 138588 - missed a DisplayError -> ThrowTemplateError change.
git-svn-id: svn://10.0.0.236/trunk@119696 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-24 07:28:11 +00:00
gerv%gerv.net
c8a771fb68 Bug 138588 - change to use new template structure. Patch by gerv, r=myk, afranke.
git-svn-id: svn://10.0.0.236/trunk@119695 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-24 07:24:50 +00:00
myk%mozilla.org
3553d6e173 Fix for bug 136506: work-around taint error on Perl 5.005.
Patch by Davidy Avery <daa@rm.incc.net>.
2x r=myk


git-svn-id: svn://10.0.0.236/trunk@119201 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-17 02:55:10 +00:00
justdave%syndicomm.com
45f5cf551d Remaining pieces of Bug 23067 from yesterday... no idea why the first commit didn't pick these up.
git-svn-id: svn://10.0.0.236/trunk@117881 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-01 22:52:40 +00:00
bbaetz%student.usyd.edu.au
8018723bcc Bug 100094 - use generic template handling code
r=mattyt, afranke


git-svn-id: svn://10.0.0.236/trunk@114368 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 02:27:24 +00:00
gerv%gerv.net
4c6b3e1925 Bug 117509 - createaccount.cgi templatisation.
git-svn-id: svn://10.0.0.236/trunk@113165 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-29 23:26:37 +00:00
justdave%syndicomm.com
c148fadef8 Fix for bug 108982: enable taint mode for all user-facing CGI files.
Patch by Brad Baetz <bbaetz@student.usyd.edu.au>
r= jake, justdave


git-svn-id: svn://10.0.0.236/trunk@112490 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-20 01:44:52 +00:00
justdave%syndicomm.com
defa1bc955 Fix for bug 19910: Bugzilla installs on the same server would interfere with each others' cookies. Cookies now have a path value that can be set to indicate which bugzilla install they belong to. Browsers will only send the cookie to the appropriate installation. The path can be set in the 'cookiepath' parameter in editparams.cgi.
Patch by Dave Lawrence <dkl@redhat.com>
r= myk, justdave


git-svn-id: svn://10.0.0.236/trunk@105325 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-13 00:40:41 +00:00
jake%acutex.net
c0330c9864 Fix for bug 55630 - email-suffix is not shown in createaccount-page
Patch by kai morich <mail@kai-morich.de>
r= matty@chariot.net.au


git-svn-id: svn://10.0.0.236/trunk@104672 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-05 19:38:26 +00:00
zach%zachlipton.com
dc3c9e0e97 Fix for bug 93388: Full name should be trimmed of whitespace before going
into database.

r1=Zach Lipton <zach@zachlipton.com> r2=Andreas Franke
<afranke@ags.uni-sb.de>. Patch by Christopher Aillon
<caillon@returnzero.com>.


git-svn-id: svn://10.0.0.236/trunk@103587 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-23 17:20:50 +00:00
justdave%syndicomm.com
a32206490b Fix for bug 77473, bug 74032, and bug 85472: Passwords are no longer stored in plaintext in the database. Passwords are no longer encrypted with MySQL's ENCRYPT() function (because it doesn't work on some installs), but with Perl's crypt() function. The crypt-related routines now properly deal with salts so that they work on systems that use methods other than UNIX crypt to crypt the passwords (such as MD5). Checksetup.pl will walk through your database and re-crypt everyone's passwords based on the plaintext password entry, then drop the plaintext password column. As a consequence of no longer having a plaintext password, it is no longer possible to email someone their password, so the login screen has been changed to request a password reset instead. The user is emailed a temporary identifying token, with a link back to Bugzilla. They click on the link or paste it into their browser and Bugzilla allows them to change their password.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@99057 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-11 05:29:21 +00:00
cyeh%bluemartini.com
ea756dc8af refix for 40603: Assumes user is coming from different page
reduce wording


git-svn-id: svn://10.0.0.236/trunk@89151 18797224-902f-48f8-a5cc-f745e15eee43
2001-03-09 21:41:27 +00:00
cyeh%bluemartini.com
813748876f fixes for 51184, 51185, 51186: allow for ldap authentication. patches
by jmrobins@tgix.com (Joe Robins). LDAP sections haven't been
tested yet, but the code is arranged such that it shouldn't disturb
existing user authentication system.


git-svn-id: svn://10.0.0.236/trunk@79347 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-15 18:35:18 +00:00
cyeh%bluemartini.com
64832a8360 fix for 40603: Assumes user is coming from different page
patch by zach@zachlipton.com


git-svn-id: svn://10.0.0.236/trunk@77665 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-30 22:42:44 +00:00