191 Commits

Author SHA1 Message Date
wtchang%redhat.com
f7f11ce486 Bugzilla Bug 294071: removed out-of-date comments and dead code. r=nelsonb.
git-svn-id: svn://10.0.0.236/trunk@173532 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-18 00:03:11 +00:00
julien.pierre.bugs%sun.com
ee8e4eb165 Fix for 280121 - allow encoding simple templates with SEC_ASN1_INLINE and SEC_ASN1_OPTIONAL . r=nelson
git-svn-id: svn://10.0.0.236/trunk@171906 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-09 05:06:34 +00:00
julien.pierre.bugs%sun.com
b896d0b0bc Silence compiler warnings
git-svn-id: svn://10.0.0.236/trunk@171497 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-02 05:33:41 +00:00
wtchang%redhat.com
b1be2b7064 Bugzilla Bug 263779: update the comment to reflect the new code.
Modified Files: secoid.c secoidt.h


git-svn-id: svn://10.0.0.236/trunk@170303 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-07 18:34:48 +00:00
neil.williams%sun.com
66557be85d Bug 263779 r=nelson@bolyard.com
This patch adds a new OID which is needed for the certutil patch which will follow.


git-svn-id: svn://10.0.0.236/trunk@170071 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-02 02:54:54 +00:00
wtchang%redhat.com
45856c0285 Bugzilla Bug 282370: Added OID for PKIX_CA_ISSUERS. The patch is
contributed by Martin v. Löwis <martin@v.loewis.de>. r=nelson,wtc.
Modified Files: secoid.c secoidt.h


git-svn-id: svn://10.0.0.236/trunk@169662 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-23 19:43:02 +00:00
julien.pierre.bugs%sun.com
761d5cc7c7 Fix for 243585 - add the ability to use CRL objects from RAM . r=nelson, neil.williams
git-svn-id: svn://10.0.0.236/trunk@169200 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-15 06:26:43 +00:00
wtchang%redhat.com
68afcb2227 Bugzilla Bug 267158: removed the $Name$ RCS keyword from our source files.
This keyword adds noise to the output of "ident libnss3.so | grep NSS"
on our debug build, and appears to cause spurious CVS conflicts. r=nelsonb.


git-svn-id: svn://10.0.0.236/trunk@168042 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-20 02:25:51 +00:00
nelsonb%netscape.com
7a939cc73e Add end of list marker to SECErrorCodes enum in secerr.h.
Bug  273611, r=Saul.edwards


git-svn-id: svn://10.0.0.236/trunk@167005 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-23 23:42:25 +00:00
nelsonb%netscape.com
7716a66257 Do case-insensitive comparisons of hostnames to wildcarded names.
Bug 266651.  Patch contributed by Ken Key <key+mozilla@ksquared.net>.


git-svn-id: svn://10.0.0.236/trunk@165533 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-19 23:54:10 +00:00
nelsonb%netscape.com
0ce29ee8bb Fix bugzilla bug 261496. Absent OPTIONAL CHOICEs should not cause fatal
errors.  Fix printing code to not crash on missing optional nextUpdate.
r=julien.pierre


git-svn-id: svn://10.0.0.236/trunk@162858 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-27 22:41:41 +00:00
relyea%netscape.com
778eec1a21 Bugzilla Bug 252702
NSS needs to handle better token insertion and removal.

Applied from patch to NSS 3.9


git-svn-id: svn://10.0.0.236/trunk@160095 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-29 23:38:14 +00:00
nelsonb%netscape.com
350330e15f Allow subtemplates to have the SEC_ASN1_DYNAMIC flag without asserting.
Bug 245429. Patch 4 of 5.  r=relyea.


git-svn-id: svn://10.0.0.236/trunk@159128 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-13 06:02:54 +00:00
nelsonb%netscape.com
84eaf700cd Fix some casts. Wrap some long lines. Remove a bogus assert.
Factor a function call out of the arguments of another function call,
which is mostly to make that code more easily debugged.
This is patch 3 of 5 for bug 245429. r=wtc.


git-svn-id: svn://10.0.0.236/trunk@159127 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-13 05:52:24 +00:00
nelsonb%netscape.com
6342fd9761 Function sec_asn1e_write_contents was two functions combined into one,
separated by one huge if-then-else.  They do different things and take
different arguments.  So, I split them into two separate functions:
sec_asn1e_write_contents and sec_asn1e_write_contents_from_buf
the latter of which takes a buf pointer and length argument.
The if statement that chooses between the two is now in the caller.
This is patch 2 of 5 for bug 245429.  r=wtc.


git-svn-id: svn://10.0.0.236/trunk@159126 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-13 05:49:48 +00:00
nelsonb%netscape.com
5586ad953a rename "explicit" to "isExplicit" because MSVC6 thinks explicit is a c
keyword.  rename "ignore_stream" to "disallowStreaming" because it
doesn't merely ignore.  rename "ignoresubstream" to "disallowStreaming"
for the same reason.  Patch 1 of 5 for bug 245429. sr=wtc.


git-svn-id: svn://10.0.0.236/trunk@159125 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-13 05:44:47 +00:00
relyea%netscape.com
01510c097f Bug 244914, 244907 r=nelsonb
Add support for unprotected private keys without requiring authentication.
Add support to access application specific PKCS #11 objects through NSS.


git-svn-id: svn://10.0.0.236/trunk@158274 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-21 23:01:53 +00:00
jpierre%netscape.com
3090294504 Restore comment that got removed accidentally. And fix typo in it.
git-svn-id: svn://10.0.0.236/trunk@158078 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-18 01:34:11 +00:00
jpierre%netscape.com
0f8afbdfc0 Fix for 247406 . r=wchang0222,glen.beasley
git-svn-id: svn://10.0.0.236/trunk@158077 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-18 01:32:31 +00:00
gerv%gerv.net
62b0f34e77 Bug 236613: change to MPL/LGPL/GPL tri-license. Restore Id: lines.
git-svn-id: svn://10.0.0.236/trunk@155606 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-27 23:04:40 +00:00
gerv%gerv.net
43cb9e1492 Bug 236613: change to MPL/LGPL/GPL tri-license.
git-svn-id: svn://10.0.0.236/trunk@155484 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-25 15:03:26 +00:00
wchang0222%aol.com
2bbf8d6a5b Bugzilla bug 237934: in nss_InitLock, nss_InitMonitor, and
NSSRWLock_AtomicCreate, we need to doublecheck the lock/monitor's pointer
after we acquired the spin lock.  r=nelsonb,jpierre.
Modified Files: nsslocks.c nssrwlk.c


git-svn-id: svn://10.0.0.236/trunk@154323 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 01:08:15 +00:00
jpierre%netscape.com
908536cb6c Fix for bug 233605 . Check CRL entry extensions after partial decoding. Also add some new CRL decoding errors. r=nelsonb
git-svn-id: svn://10.0.0.236/trunk@152653 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-11 06:05:18 +00:00
wchang0222%aol.com
6986f24e74 Bugzilla bug 233321: fixed the problem with building utf8.c as a standalone
test program.  Fixed byte-order issue on little-endian architecture.
r=nelsonb.
Modified Files: Makefile utf8.c


git-svn-id: svn://10.0.0.236/trunk@152633 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-11 02:17:24 +00:00
nelsonb%netscape.com
a27747ac5b Change some comments and one variable as suggested in review comments.
r=relyea,wtc.  Bug 124923.


git-svn-id: svn://10.0.0.236/trunk@152043 18797224-902f-48f8-a5cc-f745e15eee43
2004-01-29 21:57:41 +00:00
nelsonb%netscape.com
e67ef64ae6 Make SECOID_AddEntry be thread safe. Export it. Bug 124923. r=relyea.
git-svn-id: svn://10.0.0.236/trunk@152036 18797224-902f-48f8-a5cc-f745e15eee43
2004-01-29 21:23:36 +00:00
jgmyers%speakeasy.net
411a605312 address review comments: bug 231659
git-svn-id: svn://10.0.0.236/trunk@151940 18797224-902f-48f8-a5cc-f745e15eee43
2004-01-28 04:29:14 +00:00
jgmyers%speakeasy.net
94a241181e rewrite utf8 parser for strictness: bug 231659 r=MisterSSL
git-svn-id: svn://10.0.0.236/trunk@151937 18797224-902f-48f8-a5cc-f745e15eee43
2004-01-28 03:48:43 +00:00
jgmyers%speakeasy.net
c92b30b75a fix review comment: bug 53133
git-svn-id: svn://10.0.0.236/trunk@151595 18797224-902f-48f8-a5cc-f745e15eee43
2004-01-20 19:57:17 +00:00
jgmyers%speakeasy.net
1b9009f59e fix comment per review: bug 53133
git-svn-id: svn://10.0.0.236/trunk@151401 18797224-902f-48f8-a5cc-f745e15eee43
2004-01-16 01:04:57 +00:00
relyea%netscape.com
38b88af925 Fix build problems on some platforms.
git-svn-id: svn://10.0.0.236/trunk@151368 18797224-902f-48f8-a5cc-f745e15eee43
2004-01-15 16:27:02 +00:00
jgmyers%speakeasy.net
7c4f0bc6fa Convert T61String-labeled ISO-8859-1 to UTF-8: bug 53133 r=nelsonb a=wtc
git-svn-id: svn://10.0.0.236/trunk@151360 18797224-902f-48f8-a5cc-f745e15eee43
2004-01-15 06:23:14 +00:00
jpierre%netscape.com
b259ebb507 Rename CERT_DecodeTimeChoice/CERT_EncodeTimeChoice to DER_DecodeTimeChoice/DER_EncodeTimeChoice
git-svn-id: svn://10.0.0.236/trunk@151001 18797224-902f-48f8-a5cc-f745e15eee43
2004-01-07 23:07:24 +00:00
wchang0222%aol.com
ea1452940c Return a value of the correct type.
git-svn-id: svn://10.0.0.236/trunk@150652 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-23 01:03:39 +00:00
wchang0222%aol.com
01bd384553 Declare the 'input' argument to CERT_DecodeTimeChoice as 'const'. Removed
an extraneous semicolon (;) after the SEC_ASN1_CHOOSER_IMPLEMENT macro.
Modified Files: secder.h sectime.c


git-svn-id: svn://10.0.0.236/trunk@150646 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-22 23:33:39 +00:00
relyea%netscape.com
110f62d211 Add keydb lock type. keydb should be locked like the certdb.
git-svn-id: svn://10.0.0.236/trunk@150548 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-19 23:24:00 +00:00
wchang0222%aol.com
3881a53ae1 Bugzilla bug 227296: fixed the bug that NSS_CMSAttribute_AddValue adds the
address of a stack variable to the attr->values array.  Added a new
function SECITEM_ArenaDupItem.  r=nelsonb.
Modified Files:
	nss/nss.def util/secitem.c util/secitem.h smime/cmsarray.c
	smime/cmsattr.c


git-svn-id: svn://10.0.0.236/trunk@150095 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-06 01:16:50 +00:00
nelsonb%netscape.com
065c8f1c67 Further simplification and improvement of the parsing of UTCTime
and GeneralizedTime to avoid UMRs.  Bugscape bug 54198. r=wtc


git-svn-id: svn://10.0.0.236/trunk@150074 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-05 04:53:28 +00:00
nelsonb%netscape.com
42b7fba800 Avoid UMRs in dertime.c. Bugscape bug 54198. r=wtc.
git-svn-id: svn://10.0.0.236/trunk@149958 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-03 04:03:40 +00:00
nelsonb%netscape.com
d3315879ce Detect invalid input buffer lengths, and return error instead of UMR>
Bugscape bug 54021.  r=wchang0222


git-svn-id: svn://10.0.0.236/trunk@149808 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-27 05:08:20 +00:00
nelsonb%netscape.com
7edce8a0fb Don't accept ASN.1 items whose length is 2GB or more.
Bugscape bug 53875.  r=wchang0222 and r=relyea.


git-svn-id: svn://10.0.0.236/trunk@149574 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-20 02:08:34 +00:00
nelsonb%netscape.com
83da8efc61 Dont attempt to allocate 2GB or more from an arenapool.
Bugscape bug 53875. r=relyea.


git-svn-id: svn://10.0.0.236/trunk@149573 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-20 02:06:16 +00:00
nelsonb%netscape.com
f8e9fea1e2 Fix unnecessary assertion failures occuring in SMIME testing in
debug builds only.  Partial fix for bugscape bug 53775. r=wchang0222


git-svn-id: svn://10.0.0.236/trunk@149486 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-18 06:16:26 +00:00
nelsonb%netscape.com
cc3be11c3e Correct the validity checks on certain ASN.1 objects, allowing some that
were previous disallowed, and vice versa.  Bug 53339.


git-svn-id: svn://10.0.0.236/trunk@148937 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-07 01:41:22 +00:00
relyea%netscape.com
4bbbf7ee2c Incorporate WTC's review comments..
git-svn-id: svn://10.0.0.236/trunk@148068 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-17 17:56:56 +00:00
relyea%netscape.com
d93fbe9713 Bug 156770 When we do a file import and give a bad password we get wrong errors back
When we fail to decode based on a bad password, don't continue.

So once we've tried failed to decode a ANS.1 stream, don't continue collecting
more data.

On microsoft.pfx files, we would wind up decoding to the end of the encrypted
stream, then fail in the padding in PKCS #7. This code bypasses this problem by
making sure we don't continue to try to decode data once we've hit a bad
password failure.


git-svn-id: svn://10.0.0.236/trunk@148050 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-16 23:49:15 +00:00
jpierre%netscape.com
7bcb65500d Fix for bug 94413 - OCSP needs more fine tuned error messages. r=wtc
git-svn-id: svn://10.0.0.236/trunk@147449 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-30 01:18:55 +00:00
jpierre%netscape.com
e147b65161 Fix for bug 143334 : add support for GeneralizedTime in certificates and CRLs. r=wtc,nelsonb
git-svn-id: svn://10.0.0.236/trunk@147045 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-19 04:08:51 +00:00
jpierre%netscape.com
f68c317b43 Add PORT_Strpbrk macro
git-svn-id: svn://10.0.0.236/trunk@146639 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-08 23:29:14 +00:00
nelsonb%netscape.com
aef0d5736d Declare src argument to SEC_ASN1DecodeItem to be const.
git-svn-id: svn://10.0.0.236/trunk@143972 18797224-902f-48f8-a5cc-f745e15eee43
2003-06-20 01:52:19 +00:00