251 Commits

Author SHA1 Message Date
lpsolit%gmail.com
3900c1f7e8 Bug 301507: Move PutHeader and PutFooter into Template.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=justdave
git-svn-id: svn://10.0.0.236/trunk@176432 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-22 05:13:36 +00:00
lpsolit%gmail.com
2e64a08ebd Bug 301463: Move CheckFormField and CheckFormFieldDefined into Field.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@176408 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-21 20:04:27 +00:00
lpsolit%gmail.com
d0e81fb003 Bug 301458: Move url_decode out of CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@176365 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-20 21:30:58 +00:00
lpsolit%gmail.com
a68c2a62b5 Bug 301453: Move CheckEmailSyntax out of CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@176363 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-20 21:24:19 +00:00
lpsolit%gmail.com
7d9ef54063 Bug 301440: Move LogActivityEntry out of CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@176334 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-20 15:58:45 +00:00
lpsolit%gmail.com
3fc1ffb7ff Bug 285112: Move ValidateBugID out of CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@176316 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-20 11:29:33 +00:00
mkanat%kerio.com
ce34a4daea Bug 283989: CGI.pl global init code should be moved to Bugzilla::CGI
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=wurblzap, a=justdave


git-svn-id: svn://10.0.0.236/trunk@176083 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-14 06:01:35 +00:00
lpsolit%gmail.com
eeb8727424 Bug 300501: Move GetBugActivity() into Bug.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=myk
git-svn-id: svn://10.0.0.236/trunk@176064 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-14 00:02:17 +00:00
lpsolit%gmail.com
b4feb71d7f Bug 299572: Move MailPassword() from CGI.pl into BugMail.pm (and remove an unused variable) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@175906 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-11 00:40:59 +00:00
mkanat%kerio.com
9cf78bc935 Bug 292768: [PostgreSQL] COALESCE requires both arguments to be of similar types
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=glob, r=dkl, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175812 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-08 02:37:09 +00:00
lpsolit%gmail.com
d1fa0293a2 Bug 290513: Move CheckIfVotedConfirmed() out of CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=myk
git-svn-id: svn://10.0.0.236/trunk@172461 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-19 23:43:00 +00:00
lpsolit%gmail.com
b03d86aeac Bug 272623: FindWrapPoint is misplaced in process_bug.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@172442 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-19 17:55:10 +00:00
lpsolit%gmail.com
824d54714c Bug 290579: Remove unused function PasswordForLogin() from CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel a=justdave
git-svn-id: svn://10.0.0.236/trunk@172354 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-16 17:33:29 +00:00
lpsolit%gmail.com
a58231e5fb Bug 225818: %FORM, %MFORM, and %COOKIE need to go away, in favor of the CGI methods - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=LpSolit a=myk
git-svn-id: svn://10.0.0.236/trunk@171914 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-09 23:18:18 +00:00
lpsolit%gmail.com
5251cf02ed Bug 287947: Change CheckFormField/CheckFormFieldDefined subs in CGI.pl to use CGI object instead FORM hash - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=LpSolit a=myk
git-svn-id: svn://10.0.0.236/trunk@171874 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-07 23:52:20 +00:00
mkanat%kerio.com
833b2e61f6 Bug 286235: Implicit joins should be replaced by explicit joins - installment A
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@171610 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-04 21:52:06 +00:00
travis%sedsystems.ca
7351a5b76b Bug 283581 : Move UserInGroup out of globals.pl
Patch by Colin Ogilvie <colin.ogilvie@gmail.com>   r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170734 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 22:10:14 +00:00
mkanat%kerio.com
b7fd576c4c Bug 285678: NOT(integer) not supported by postgres
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=myk


git-svn-id: svn://10.0.0.236/trunk@170567 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-11 19:06:11 +00:00
mkanat%kerio.com
d29ebec588 Bug 283919: Move BugAliasToID out of CGI.pl into Bugzilla::Bug
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@170404 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-08 23:03:57 +00:00
mkanat%kerio.com
3236120a9a Bug 283924: Move ValidateComment out of CGI.pl
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170281 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-07 13:55:34 +00:00
mkanat%kerio.com
7f1a179da7 Bug 277782: _throw_error should unlock tables when tables are locked, automatically
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=travis, r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170180 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-05 00:18:48 +00:00
travis%sedsystems.ca
abce7fe4c4 Bug 119485 : Templatise editusers.cgi
Patch by Marc Schumann <wurblzap@gmail.com>   r=GavinS, mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170004 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-28 20:41:45 +00:00
mkanat%kerio.com
de89702d36 Bug 282748: uninitialized value in localtime in Format.pm
Patch By Frederic Buclin <LpSolit@gmail.com> r=wurblzap, a=myk


git-svn-id: svn://10.0.0.236/trunk@169818 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-25 03:28:02 +00:00
mkanat%kerio.com
2e945fe489 Bug 280500: Replace "DATE_FORMAT()" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=myk


git-svn-id: svn://10.0.0.236/trunk@169798 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-24 23:37:48 +00:00
travis%sedsystems.ca
81f64817cf Bug 257315 : type of delta_ts in bugs table should not be timestamp
Patch by Tomas Kopal <Tomas.Kopal@altap.cz>  r=mkanat, LpSolit   a=justdave


git-svn-id: svn://10.0.0.236/trunk@168981 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-08 16:51:03 +00:00
travis%sedsystems.ca
8a81a01901 Bug 276838 : Eliminate use of $::unconfirmedstate
Patch by Max Kanat-Alexander <mkanat@kerio.com>  r=wurblzap  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168979 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-08 16:22:26 +00:00
justdave%bugzilla.org
2541fed321 Backing out the checking from bug 257315 until it gets corrected. It prevents new bugs from being filed.
a=justdave


git-svn-id: svn://10.0.0.236/trunk@168520 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-30 04:22:28 +00:00
travis%sedsystems.ca
e652a2da94 Bug 257315 : type of delta_ts in bugs table should not be timestamp
Patch by Tomas Kopal <Tomas.Kopal@altap.cz>   r=vladd, LpSolit  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168456 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-28 19:01:28 +00:00
jocuri%softhome.net
297b1c2147 Patch for bug 103636: Support specifying a date on which a bug is expected to be resolved; patch by Alexandre Michetti Manduca <michetti@grad.icmc.usp.br>, r=jouni, a=myk.
git-svn-id: svn://10.0.0.236/trunk@167817 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 13:36:05 +00:00
travis%sedsystems.ca
02805bcb0d Bug 276473: Show_activity merges incorrectly sometimes changesets into one changeset
Patch by vladd@bugzilla.org   r=bugzilla@glob.com.au   a=justdave


git-svn-id: svn://10.0.0.236/trunk@167535 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-11 17:17:01 +00:00
jocuri%softhome.net
b8a7996c7b Patch for bug 277013: provides a fix for the SQL error that appears when a user's vote confirms a bug; patch by Frédéric Buclin <LpSolit@netscape.net>, r=wurblzap, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@167420 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-08 18:24:52 +00:00
travis%sedsystems.ca
169f4f4283 Bug 276600: checking votes in editproducts.cgi is broken (regression due to bug 271474)
Patch: LpSolit@netscape.net  r=gerv,mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@167401 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-07 21:19:26 +00:00
travis%sedsystems.ca
726917ba04 Bug 276913: Uninitialized value message from CGI.pl line 176
Patch: LpSolit@netscape.net  r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@167400 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-07 21:13:34 +00:00
gerv%gerv.net
8606b2d55d Bug 59351 - move all calls to sendmail to a central place. Patch by mkanat; r=gerv,vladd; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@167149 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-01 13:47:56 +00:00
jake%bugzilla.org
a3ab1de813 Bug 264601 - Bugzilla will now tell a user which field contained an "invalid bug number or alias."
Patch by Frédéric Buclin <LpSolit@netscape.net>
r=myk, a=justdave


git-svn-id: svn://10.0.0.236/trunk@166909 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-21 09:04:01 +00:00
justdave%bugzilla.org
6dc3e61233 [SECURITY] Bug 253544: Changes to the metadata (filename, description, mime type, review flags) on attachments which were flagged as private get displayed to users who are not members of the group allowed to see private attachments when viewing the bug activity log. This only affects sites that use the 'insidergroup' feature.
Patch by Joel Peshkin <bugreport@peshkin.net>
r=zach,justdave, a=justdave


git-svn-id: svn://10.0.0.236/trunk@164338 18797224-902f-48f8-a5cc-f745e15eee43
2004-10-25 07:34:30 +00:00
bugreport%peshkin.net
cd65dc04d7 Bug 186093: Move CanSeeBug to User.pm and make User.pm usable by templates
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160350 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-04 16:17:10 +00:00
jocuri%softhome.net
ac35b43d57 Patch for bug 253357: replace IFNULL with COALESCE for increased database compatibility; patch by Tomas Kopal <Tomas.Kopal@altap.cz>; r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@160169 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-31 08:59:16 +00:00
bugreport%peshkin.net
0e036750a7 Bug 253447: Fix unhelpful error if user enters text in "blocks" field
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160129 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-30 10:37:17 +00:00
kiko%async.com.br
f5b1cdca19 Fix for bug 236678: Clean up access to COOKIE global. Murder the last
remaining places in the tree where COOKIE is used; includes a rather
thorough cleanup of Bugzilla::Bug->user and a minor doc update. r=joel, a=justdave.


git-svn-id: svn://10.0.0.236/trunk@160015 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-29 02:45:38 +00:00
jocuri%softhome.net
6f20bad256 Fix for bug 248988: On Windows, attachments may fail due to "CGI open of tmpfile"; patch by byron jones (glob) <bugzilla@glob.com.au>; r=jouni; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@158850 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-07 08:59:44 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
kiko%async.com.br
07fca020f4 Fix for bug 67663: globals.pl and CGI.pl emit "subroutine redefined"
messages. Fudge warnings via sillyness. r=myk, chaduv. a=myk.


git-svn-id: svn://10.0.0.236/trunk@148488 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-30 01:31:58 +00:00
justdave%syndicomm.com
ec2098df1b Backing out patch from bug 108528 - failed to take i10n concerns into account
git-svn-id: svn://10.0.0.236/trunk@148034 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-16 18:26:09 +00:00
timeless%mozdev.org
72f2fe28cc Bug 108528 - knob is not defined doesn't explain to 2001110503 users what to do
patch by caduvall@glue.umd.edu r=timeless a=justdave


git-svn-id: svn://10.0.0.236/trunk@148005 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-15 22:48:12 +00:00
jocuri%softhome.net
de2a56bd48 Bug 213384: shutdownhtml login bypass via editparams.cgi is broken under suexec. r=kiko, a=justdave
git-svn-id: svn://10.0.0.236/trunk@147700 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-07 19:15:35 +00:00
bbaetz%acm.org
7d7d7e1532 Bug 208699 - Move Throw{Code,Template}Error into Error.pm
r,a=justdave


git-svn-id: svn://10.0.0.236/trunk@146857 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-14 06:05:23 +00:00
bbaetz%acm.org
726bcd99cc Bug 180635 - Enhance Bugzilla::User to store additional information
r=myk,jake


git-svn-id: svn://10.0.0.236/trunk@143228 18797224-902f-48f8-a5cc-f745e15eee43
2003-06-03 09:48:15 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
bbaetz%acm.org
6ee31579fe Bug 199813 - Make all users of ThrowUserError pass $vars in explicitly.
r=gerv
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140585 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-02 12:35:07 +00:00