45 Commits

Author SHA1 Message Date
myk%mozilla.org
095b04ff89 bug 356017: make sure folder item is selected before retrieving selected resource in bookmarks tree to avoid exception which prevents the Add Bookmarks dialog from properly creating the bookmark and closing when the user presses the Add button
r=gavin


git-svn-id: svn://10.0.0.236/trunk@213850 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-19 18:17:31 +00:00
myk%mozilla.org
7f6a2149bd ensure microsummary picker exception doesn't prevent bookmark dialogs from closing when the user cancels their bookmark changes
bug=346825
r=mconnor


git-svn-id: svn://10.0.0.236/trunk@206465 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-03 04:36:00 +00:00
gavin%gavinsharp.com
4c9d09aa4d Bug 344459: Deleting name for bookmark then selecting a microsummary doesn't enable OK button in bookmarks dialog, patch by Phil Ringnalda <philringnalda@gmail.com>, r=mconnor
git-svn-id: svn://10.0.0.236/trunk@203113 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-19 14:29:18 +00:00
myk%mozilla.org
e0897dbb35 Merge the microsummary picker with the Name field in the add bookmark and bookmark properties dialog, hiding the picker if no microsummaries are available.
bug=337825
r=mconnor
a=mconnor for checkin to 1.8 branch


git-svn-id: svn://10.0.0.236/trunk@200361 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-19 22:15:59 +00:00
myk%mozilla.org
d631c3f7de consistently display and destroy microsummary picker in the non-Places bookmarks dialogs
bug=336828
r=brettw
sr=ben
a=ben for the branch


git-svn-id: svn://10.0.0.236/trunk@196087 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-06 02:40:13 +00:00
myk%mozilla.org
e3fb608fb9 Initial support for microsummaries via a service and integration into the bookmarks UI.
bug=334471
r=brettw
a=ben for the branch


git-svn-id: svn://10.0.0.236/trunk@196058 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-05 22:46:57 +00:00
gavin%gavinsharp.com
39b3968d79 little nits to sync 1.8 branch/trunk
git-svn-id: svn://10.0.0.236/trunk@191660 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-03 03:59:44 +00:00
ben%bengoodger.com
b6bf50b454 305134 - remove feedview from firefox 1.5 and 1.6x pending architecture redesign. r=mconnor
git-svn-id: svn://10.0.0.236/trunk@179066 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-26 18:22:08 +00:00
mconnor%steelgryphon.com
9ca5e7e574 bug 304705 - Add Bookmark dialog: Bookmarks Toolbar generates error, also fix bogus contextmenu on Bookmark All Tabs menuitem r=vlad
git-svn-id: svn://10.0.0.236/trunk@178916 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-25 05:43:46 +00:00
ben%bengoodger.com
d4822994ff bug 300412 - add "Bookmark all Tabs" menu option to bookmarks menu, improves discoverability of bookmark tab groups per usability testing. patch by Grace Shih <gsshih@gmail.com> r=ben@mozilla.org
git-svn-id: svn://10.0.0.236/trunk@177611 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-12 00:42:16 +00:00
ben%bengoodger.com
73c66a13c6 303848 - integrate feedview better with firefox browser code/live bookmarking system.
this is an initial stab at implementing a design I'm working on with Mike Beltzner
here: http://wiki.mozilla.org/Firefox:1.1_RSS_Pretty_Print


git-svn-id: svn://10.0.0.236/trunk@177609 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-12 00:34:19 +00:00
mozilla.mano%sent.com
0993d71f04 Bug 290714 - Don't use reserved const names in bookmarks/content. r=mconnor, a=asa
git-svn-id: svn://10.0.0.236/trunk@172434 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-19 15:17:04 +00:00
bugzilla%arlen.demon.co.uk
b1a8c5fb5c Bug 277490 Retrieve site description from meta tag when adding bookmark
p=gavin.sharp@gmail.com r=vladimir


git-svn-id: svn://10.0.0.236/trunk@169297 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 00:17:12 +00:00
gerv%gerv.net
c9c6bdd186 Bug 236613: change to MPL/LGPL/GPL tri-license.
git-svn-id: svn://10.0.0.236/trunk@168642 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-01 17:36:54 +00:00
mozilla.mano%sent.com
55df2ed914 Bug 275405 - Add bookmark dialog - folder name fails to appear in 'create in' input field. patch by Gavin Sharp <gavin.sharp@gmail.com> r=vladimir
git-svn-id: svn://10.0.0.236/trunk@168370 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-26 23:59:32 +00:00
ben%bengoodger.com
634116d6c6 Landing the Aviary Branch (browser section only).
git-svn-id: svn://10.0.0.236/trunk@165934 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-30 08:23:02 +00:00
vladimir%pobox.com
544b331624 b=244078, live bookmarks merge from aviary branch.
git-svn-id: svn://10.0.0.236/trunk@160117 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-30 05:29:27 +00:00
mconnor%myrealbox.com
950c2ef6e9 bug 241210 - new bookmarks have a keyword of undefined, fallout from adding ability to create keyword bookmarks from search fields. patch by pike@pikey.co.uk, r=me, also relocate sizeToContent call to ensure we size properly when hiding the keyword field
git-svn-id: svn://10.0.0.236/trunk@156275 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-12 01:08:57 +00:00
ben%bengoodger.com
0a1473d5c0 241028 - should be able to create smart keywords to forms that use the http POST method.
git-svn-id: svn://10.0.0.236/trunk@155207 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-20 09:45:12 +00:00
varga%nixcorp.com
ce53bd6ec2 Fix for bug 221619. Tree widget refactoring and enhancement. r=neil sr=bryner
git-svn-id: svn://10.0.0.236/trunk@155017 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-17 05:53:38 +00:00
ben%bengoodger.com
af9057e646 provide a convenient way for adding smart keywords for web page searches by adding a context menu to form fields with HTTP-GET form actions.
git-svn-id: svn://10.0.0.236/trunk@154665 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-10 05:04:20 +00:00
chanial%noos.fr
ecd4f52cfb workaround for bug 227951: add bookmarks dialog grows everytime the expander is clicked.
Use of resizeTo instead of sizeToContent (buggy on Windows)


git-svn-id: svn://10.0.0.236/trunk@150593 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-21 04:09:02 +00:00
chanial%noos.fr
c701b042dd remove debug dumps
git-svn-id: svn://10.0.0.236/trunk@150465 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-19 03:49:16 +00:00
chanial%noos.fr
a1b99f7278 Bug 228285: make the bookmarks tree more discoverable, by adding a tooltip to the expander.
git-svn-id: svn://10.0.0.236/trunk@150379 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-16 23:57:03 +00:00
chanial%noos.fr
3aa794c192 fix several glitches, like:
- selecting a folder in the tree selects the menulist selectedItem if it is already in the dropdown
- unselect it if the folder is not in it
- make sure that a row is always selected.
- ensure that the row of a folder selected in the menulist is visible when the tree is expanded.
- cleanup, consolidate logic


git-svn-id: svn://10.0.0.236/trunk@150317 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-15 07:44:11 +00:00
chanial%noos.fr
3478ab7934 when disclosing the tree, the bookmarks root folder should always be open.
Typo in bookmarksManager.js


git-svn-id: svn://10.0.0.236/trunk@150308 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-15 00:55:22 +00:00
chanial%noos.fr
b50d67b8bd restore the line that updates the expander icon. It has been accidently removed.
Some cleanup.


git-svn-id: svn://10.0.0.236/trunk@150307 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-15 00:51:30 +00:00
chanial%noos.fr
8180176881 Bug 181033: add a "New Folder" button to the add bookmark dialog
git-svn-id: svn://10.0.0.236/trunk@150290 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-14 10:43:43 +00:00
chanial%noos.fr
d1e7c972dd fix the no more persisted "class" attribute in old profiles.
the expandable state may be persisted in the future.


git-svn-id: svn://10.0.0.236/trunk@150212 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-11 14:23:02 +00:00
chanial%noos.fr
3cae6452f6 Bug 228035: patch by Steffen, r=me
git-svn-id: svn://10.0.0.236/trunk@150188 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-10 15:05:50 +00:00
chanial%noos.fr
1507588ebe fix template, as suggested by Neil
git-svn-id: svn://10.0.0.236/trunk@150160 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-08 23:58:12 +00:00
chanial%noos.fr
2ac867e980 Landing new add bookmark dialog (bug 214527).
Featuring an expandable tree and a dropdown menu containing the last used folders.
The 'new folder' functionality has not been included, yet.
Thanks to bz for the help on nsCOMArrays.


git-svn-id: svn://10.0.0.236/trunk@150142 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-08 16:30:28 +00:00
chanial%noos.fr
fb4929d722 - fix regression 221118: Can't drag links into bookmark manager or bookmark sidebar.
- logic change: a transaction will not be performed when one of its item can not be acted on. Before, the only the valid items were processed. A LOT of simplifications have come up. I am slowly moving toward the resolution of bug 168411, by simplifying the interface that will be needed to move the transactions to the bookmarks service.
- fix bug 221550: the selection is not retained when performing an invalid transaction
- no need to restore the selection after an action that doesn't touch the datasource.
- during a batch, the bookmarks toolbar observer wasn't notified.
- much faster preUpdateTreeSelection
- various code cleanup
- DND bookmarks in tree is now significantly faster.
- still need to figure out what is the best BATCH_LIMIT value.


git-svn-id: svn://10.0.0.236/trunk@147752 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-08 09:01:48 +00:00
hyatt%mozilla.org
6b0d40ba1a Implement the Add Page button in the Web Panels sidebar.
git-svn-id: svn://10.0.0.236/trunk@145508 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-03 08:25:19 +00:00
chanial%noos.fr
c7c6082125 getting back phoenix bookmarks in sync with seamonkey
first step to clean the 'add bookmark' mess (removing a flag because we always show the dialog, and moving addBookmarkFor*Browser in browser.js where it belong)


git-svn-id: svn://10.0.0.236/trunk@141506 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-21 05:47:02 +00:00
varga%netscape.com
abacf67d41 Updating JS to the latest nsIBookmarksService API.
git-svn-id: svn://10.0.0.236/trunk@140358 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-26 22:13:13 +00:00
chanial%noos.fr
b3606d14d1 bookmark cleanup. make clear the distinction between target and selection in trees.
now, insertion on a folder doesn't append but inserts before it.
Allow multiple selection of bookmarks and folders for the home pages.


git-svn-id: svn://10.0.0.236/trunk@135268 18797224-902f-48f8-a5cc-f745e15eee43
2002-12-13 23:06:10 +00:00
chanial%noos.fr
ce6348cfa4 flush the ds after adding a bookmark
git-svn-id: svn://10.0.0.236/trunk@131943 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-14 02:14:40 +00:00
chanial%noos.fr
4c5b8169c6 delay service instanciation
git-svn-id: svn://10.0.0.236/trunk@131942 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-14 01:26:08 +00:00
blakeross%telocity.com
0a4c4a5836 Reduce timeout to 0.
git-svn-id: svn://10.0.0.236/trunk@131887 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-13 02:27:53 +00:00
blakeross%telocity.com
94340c125f Strip more licenses.
git-svn-id: svn://10.0.0.236/trunk@131753 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-11 01:27:28 +00:00
chanial%noos.fr
bda73cd8a8 temporary hack to indent the folders in the add bookmark dialog
git-svn-id: svn://10.0.0.236/trunk@131597 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-09 11:42:34 +00:00
chanial%noos.fr
c3042de8c8 bug 173145: first time, add to default root folder fails
git-svn-id: svn://10.0.0.236/trunk@131370 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-08 03:12:24 +00:00
chanial%noos.fr
da3a03da71 speeding up a bit the add bookmark dialog by QI'ing only the folders
git-svn-id: svn://10.0.0.236/trunk@131305 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-07 14:47:23 +00:00
chanial%noos.fr
65cf499018 New add bookmark dialog
git-svn-id: svn://10.0.0.236/trunk@131280 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-07 03:18:26 +00:00