341 Commits

Author SHA1 Message Date
mkanat%bugzilla.org
8eafebf36a Bug 600495: Make searching using "chfieldto" actually work again, for finding
bugs that were also updated after the particular change that's being looked
for.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@261318 18797224-902f-48f8-a5cc-f745e15eee43
2010-10-02 19:32:32 +00:00
mkanat%bugzilla.org
4211f37acd Bug 600496: Make searching on [Bug creation] work again, by implementing
creation_ts for the changedafter and changedbefore operators in Search.pm.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@261316 18797224-902f-48f8-a5cc-f745e15eee43
2010-10-02 18:47:04 +00:00
mkanat%bugzilla.org
1b8239aa5c Bug 601371: Make bug_status_type work as a search query parameter
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@261313 18797224-902f-48f8-a5cc-f745e15eee43
2010-10-02 16:32:32 +00:00
mkanat%bugzilla.org
b8deca1bdf Make content_type work as a buglist.cgi parameter, for setting the
search operator for the "content" field.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@261312 18797224-902f-48f8-a5cc-f745e15eee43
2010-10-02 16:17:04 +00:00
mkanat%bugzilla.org
1f43f2c556 Bug 583243: Add a new hook 'search_operator_field_override'.
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@261093 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-24 21:17:10 +00:00
mkanat%bugzilla.org
398bac7dca Bug 586871: Convert all Bugzilla->get_fields calls to Bugzilla->fields
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@261092 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-24 20:32:19 +00:00
mkanat%bugzilla.org
9271f2fe34 Bug 417048: (CVE-2010-2756) [SECURITY] Boolean charts let me query for users being in any given group
r=mkanat a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260972 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-04 21:35:40 +00:00
mkanat%bugzilla.org
a7f6262f2f Bug 583614: Simple Search no longer works
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260968 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-04 17:31:43 +00:00
mkanat%bugzilla.org
b36b1c69aa Bug 581327: The patch to allow commas in Product (etc.) names broke the
entering of comma-separated values in other search fields, like bug_id.
So now we split on commas in text fields, but not for <select> fields.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260931 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-01 23:01:36 +00:00
mkanat%bugzilla.org
cff5681e70 Bug 580208: Search.pm: Combine all the user search types into one search
function
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260840 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-22 00:46:42 +00:00
mkanat%bugzilla.org
038e91d709 Bug 580174: Search.pm: Move special parsing functions around, to be more
orderly
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260818 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-20 06:01:55 +00:00
mkanat%bugzilla.org
dcf37601ba Bug 579568: Search.pm: Improve the implementation and performance of
substring and "words" searches, improve the formatting of generated SQL,
and use real subselects instead of performing the subselect and using its
results in an IN.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260807 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-18 01:01:41 +00:00
mkanat%bugzilla.org
5711e7a218 Bug 67036: Allow searching for product, component, etc. names that contain
commas
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260805 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-16 22:01:43 +00:00
mkanat%bugzilla.org
c634e6e71e Bug 398308: Make Search.pm take a hashref for its "params" argument
instead of taking a CGI object.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260794 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-16 03:01:42 +00:00
mkanat%bugzilla.org
c8197e8456 Bug 577800: Finish the cleanup of Search.pm's "init" function by removing
it and having its work be done by a new "sql" accessor instead. Also adds
some comments, moves functions around into sections, and creates a new
_user accessor.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260784 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-15 11:24:27 +00:00
mkanat%bugzilla.org
a2ebe51f39 Bug 578904: Search.pm: Fully generate the FROM clause inside of an accessor
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260778 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-15 10:16:41 +00:00
mkanat%bugzilla.org
354474afad Bug 578888: Search.pm: Add and store joins as data structures instead of
raw SQL.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260777 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-15 05:46:39 +00:00
mkanat%bugzilla.org
a196f5150e Bug 578602: Search.pm: Move the parsing of boolean charts out of init
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260776 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-15 03:16:42 +00:00
mkanat%bugzilla.org
78df5f870c Bug 578308: Move the parsing of special fields and the creation of
@specialcharts out of init in Search.pm
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260768 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 05:16:31 +00:00
mkanat%bugzilla.org
9a3f7d202f Bug 578594: Search.pm: Move deadlinefrom and deadlineto parsing into a
special method
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260767 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 04:46:37 +00:00
mkanat%bugzilla.org
2d0ddb344e Bug 578531: Move the chfield stuff out of init, and make
the changedbefore/after charts include the date specified
(they previously did exclusive searches)
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260764 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 02:16:34 +00:00
mkanat%bugzilla.org
4f6d79db10 Bug 578323: Remove the special parsing of "changedin" from Search.pm.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260759 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 23:46:36 +00:00
mkanat%bugzilla.org
d00170cc62 Bug 578316: Search.pm: Move the parsing of email* fields into a method
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260744 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 11:02:11 +00:00
mkanat%bugzilla.org
9cf3dc10b0 Bug 578313: Search.pm: Move the parsing of basic fields (ones that map to
fielddefs) into methods
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260743 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 10:31:53 +00:00
mkanat%bugzilla.org
3084e8d1d5 Bug 578310: Search.pm: Move the special parsing of bug_status and resolution
out of init and into some _special_parse_* functions.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260742 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 10:16:45 +00:00
mkanat%bugzilla.org
38529a9513 Bug 578299: Search.pm: Generate the GROUP BY clause in a method
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260741 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 09:31:48 +00:00
mkanat%bugzilla.org
6a6d6ed46b Bug 578275: Search.pm: Fully generate the ORDER BY clause inside of an
accessor
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260736 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 06:02:02 +00:00
mkanat%bugzilla.org
dd8741db43 Bug 578278: Search.pm: Fully generate the SELECT clause inside of an accessor
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260735 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 05:50:30 +00:00
mkanat%bugzilla.org
48ca940e07 Bug 578266: Clean up the SPECIAL_ORDER code and make it into an accessor,
in Search.pm
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260734 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 04:01:55 +00:00
mkanat%bugzilla.org
9b87c64225 Bug 577807: Convert the hard-coded stuff that adds map_* tables to @supptables
in Search.pm into a data structure and a series of functions that parse the
data structure.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260710 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 12:46:46 +00:00
mkanat%bugzilla.org
2850470be9 Bug 577805: Make chart_fields into an accessor in Search.pm
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260709 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 11:01:47 +00:00
mkanat%bugzilla.org
08abde2503 Bug 577803 - Make multi_select_fields into an accessor in Search.pm
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260708 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 10:34:02 +00:00
mkanat%bugzilla.org
a54682ffe0 Bug 577602: Don't put multi-select fields into the GROUP BY in Search.pm,
because they are created by an aggregate. (This fixes multi-select buglist
columns on Pg.)
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260706 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 05:17:04 +00:00
mkanat%bugzilla.org
0b5e02b469 Bug 576670: Optimize Search.pm's "init" method for being called many times
in a loop
r=glob, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260692 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-09 02:16:39 +00:00
mkanat%bugzilla.org
9e50634048 Bug 577582: longdescs.isprivate "changedfrom" and "changedto" weren't
working on PostgreSQL, because Search.pm always converted the value
into 1 or 0 and passed that as a number to the database, and Pg didn't
support numeric comparison with a text column.
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260689 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-09 00:16:55 +00:00
mkanat%bugzilla.org
db394fa150 Bug 577575: If percentage_complete is a column in the buglist, remaining_time
must also be selected from the database for PostgreSQL.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260687 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 23:31:50 +00:00
mkanat%bugzilla.org
7ac03c8662 Bug 575021: Make the anyexact operator in Search.pm properly trim its
input values
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260678 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 19:03:40 +00:00
mkanat%bugzilla.org
ac502cce7f Bug 574556: Refactor Search.pm so that we're not doing $$some_var everywhere.
Instead, we pass around a hashref and update the hashref. This patch also
includes some cleanup for bugs surrounding percentage_complete,
attachments.isobsolete, attachments.ispatch, and owner_idle_time.
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260676 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 18:31:53 +00:00
mkanat%bugzilla.org
c35963979d Bug 574879: Create a test that assures the correctness of Search.pm's
boolean charts
r=glob, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260658 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-07 21:47:00 +00:00
mkanat%bugzilla.org
a079ad7712 Bug 552919: Sort group_concat results so that they sort correctly for buglists
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260654 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-07 00:16:41 +00:00
mkanat%bugzilla.org
1187b4d4da Bug 562014: Fix negative keyword searches like "contains none of the words"
to properly find bugs with *none* of the listed keywords, and also to find
bugs with no keywords at all.
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260633 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-05 23:50:55 +00:00
mkanat%bugzilla.org
9a13bbe14d Bug 545766: Figure out what columns can be reported on from the database,
instead of from a static list
r=glob, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260612 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-01 21:18:12 +00:00
mkanat%bugzilla.org
a0eb919450 One-character fix in Bugzilla::Search--in OPERATOR_FIELD_OVERRIDE,
"anyword" for keywords should have been "anywords".


git-svn-id: svn://10.0.0.236/trunk@260584 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-25 22:01:30 +00:00
mkanat%bugzilla.org
774aadd18b Bug 574566: Add "reporter" to OPERATOR_FIELD_OVERRIDE (it was missing)
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260583 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-25 21:33:05 +00:00
mkanat%bugzilla.org
ff1a36e076 Bug 309952: (CVE-2010-1204) [SECURITY] Make boolean chart searches with time
tracking fields no longer work for everybody
r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260562 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-24 17:16:32 +00:00
mkanat%bugzilla.org
e578692577 Bug 476722: Refactor Search.pm's funcdefs into a series of constants
and functions for interpreting search charts.
r=jjclark, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260465 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-12 02:17:19 +00:00
mkanat%bugzilla.org
33a07dae31 Bug 450301: What Simplify searching UI, initial improvements to the advanced search ui.
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260429 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-06 08:46:26 +00:00
mkanat%bugzilla.org
7f84eebed2 Bug 478771: Bugzilla::Search should drop invalid bug statuses from the search criteria
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260274 18797224-902f-48f8-a5cc-f745e15eee43
2010-05-07 16:46:14 +00:00
mkanat%bugzilla.org
a91662b784 Bug 180812: Make boolean charts involving both flags and attachments
limit the flag search based on the attachment criteria
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260266 18797224-902f-48f8-a5cc-f745e15eee43
2010-05-06 02:31:14 +00:00
mkanat%bugzilla.org
afa0f14813 Bug 561129: Various warnings thrown by Search.pm: Perl 5.12 complains for lc(undef) and uc(undef)
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260220 18797224-902f-48f8-a5cc-f745e15eee43
2010-04-22 18:24:07 +00:00