75 Commits

Author SHA1 Message Date
bzrmirror%bugzilla.org
c3c9d1dc34 Bug 964113: Digest::SHA 5.82 and newer always croak on wide characters, preventing saved searched from being displayed
r=dkl a=justdave


git-svn-id: svn://10.0.0.236/trunk@265210 18797224-902f-48f8-a5cc-f745e15eee43
2014-01-27 18:15:43 +00:00
bzrmirror%bugzilla.org
e5338fb372 Bug 906745 - In MySQL, tokens are not case-sensitive, reducing total entropy and allowing easier brute force
r=LpSolit,a=glob


git-svn-id: svn://10.0.0.236/trunk@265056 18797224-902f-48f8-a5cc-f745e15eee43
2013-10-16 16:57:35 +00:00
mkanat%bugzilla.org
ccca6b6569 Bug 878035: Do not disclose whether a user account exists or not when a user clicks "forgot password"
r=dkl a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264864 18797224-902f-48f8-a5cc-f745e15eee43
2013-06-06 21:01:09 +00:00
mkanat%bugzilla.org
1764f0df90 Bug 787668: Use |use parent| instead of |use base|
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264508 18797224-902f-48f8-a5cc-f745e15eee43
2012-12-01 01:31:00 +00:00
mkanat%bugzilla.org
f6af30d002 Bug 816747 - Add dummy POD for unPODded methods.
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264502 18797224-902f-48f8-a5cc-f745e15eee43
2012-11-30 14:45:59 +00:00
mkanat%bugzilla.org
8e47ba629a Bug 787529: Use |use 5.10.1| everywhere
r=wicked a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264195 18797224-902f-48f8-a5cc-f745e15eee43
2012-09-01 21:45:59 +00:00
mkanat%bugzilla.org
5811182750 Bug 767623 - Use HMAC to generate tokens and sensitive graph filenames
[r=LpSolit a=LpSolit]


git-svn-id: svn://10.0.0.236/trunk@264091 18797224-902f-48f8-a5cc-f745e15eee43
2012-07-30 21:00:53 +00:00
mkanat%bugzilla.org
aca4dbad41 Bug 349337: The time between two successive token requests should be a constant
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263679 18797224-902f-48f8-a5cc-f745e15eee43
2012-04-12 23:16:11 +00:00
mkanat%bugzilla.org
3b5e8524aa Bug 680131: Replace the MPL 1.1 license by the MPL 2.0 one in all files, and add it to files which miss one
r=kiko r=mkanat r=mrbball a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263258 18797224-902f-48f8-a5cc-f745e15eee43
2012-01-11 22:48:45 +00:00
mkanat%bugzilla.org
cd7853a286 Bug 705474 - CSRF vulnerability in createaccount.cgi allows possible unauthorized account creation e-mail request
[r=mkanat a=mkanat]


git-svn-id: svn://10.0.0.236/trunk@263160 18797224-902f-48f8-a5cc-f745e15eee43
2011-12-13 22:31:32 +00:00
mkanat%bugzilla.org
ced5c98383 Bug 677522: IssueEmailChangeToken() should get the old login name from the user object
r=timello a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@262710 18797224-902f-48f8-a5cc-f745e15eee43
2011-08-17 13:01:36 +00:00
mkanat%bugzilla.org
af736d2749 Bug 677901: Bugzilla crashes when no token is passed to token.cgi but the script expects one, because tokens are incorrectly validated
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@262660 18797224-902f-48f8-a5cc-f745e15eee43
2011-08-16 01:31:25 +00:00
mkanat%bugzilla.org
3ba4f4bff8 Bug 678959: Make GenerateUniqueToken work for all tables
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@262651 18797224-902f-48f8-a5cc-f745e15eee43
2011-08-15 12:46:19 +00:00
mkanat%bugzilla.org
7648c1850d Bug 589128: Adds a preference allowing users to choose between text or html
for bugmail.
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@262522 18797224-902f-48f8-a5cc-f745e15eee43
2011-07-25 14:32:25 +00:00
mkanat%bugzilla.org
9285e338dd Bug 602165: Change sql_interval to sql_date_math, in preparation for
MS-SQL and SQLite support.


git-svn-id: svn://10.0.0.236/trunk@261360 18797224-902f-48f8-a5cc-f745e15eee43
2010-10-07 11:02:21 +00:00
mkanat%bugzilla.org
3584a9ab78 Bug 508823: Make it so that you don't ever have to reset template_inner (like
Bugzilla->template_inner("")).
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259847 18797224-902f-48f8-a5cc-f745e15eee43
2010-03-01 01:46:32 +00:00
mkanat%bugzilla.org
0cc827bc54 Bug 527586: Use X-Forwarded-For instead of REMOTE_ADDR for trusted proxies
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259326 18797224-902f-48f8-a5cc-f745e15eee43
2009-12-31 12:53:21 +00:00
lpsolit%gmail.com
068d4cbfd6 Bug 477513: md5_hex() fails if a saved search has UTF8 characters in it - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@256165 18797224-902f-48f8-a5cc-f745e15eee43
2009-02-09 19:20:40 +00:00
lpsolit%gmail.com
a78c19e2bb Bug 26257: [SECURITY] Bugzilla should prevent malicious webpages from making bugzilla users submit changes to bugs - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@256020 18797224-902f-48f8-a5cc-f745e15eee43
2009-02-02 18:34:40 +00:00
lpsolit%gmail.com
2df7c38aa5 Bug 452519: Fix timezones in emails - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@255775 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-08 16:10:04 +00:00
lpsolit%gmail.com
03b1e7c6dd Bug 405946: Some emails are not sent in the language chosen by the addressee - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@249006 18797224-902f-48f8-a5cc-f745e15eee43
2008-04-02 17:46:56 +00:00
lpsolit%gmail.com
271436bfa9 Bug 399163: Bugzilla/*.pm should use transactions for database interaction - Patch by Emmanuel Seyman <eseyman@linagora.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@239610 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-18 20:20:54 +00:00
reed%reedloden.com
792703972c Bug 366466 - "flag notification mail has canceled spelled incorrectly" [p=reed r=timeless a=mkanat]
git-svn-id: svn://10.0.0.236/trunk@221735 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-11 04:11:18 +00:00
lpsolit%gmail.com
faede0b2e9 Fix nits about bug 316797
git-svn-id: svn://10.0.0.236/trunk@215483 18797224-902f-48f8-a5cc-f745e15eee43
2006-11-20 19:05:49 +00:00
lpsolit%gmail.com
02c1f1227b Bug 316797: Token.pm needs POD - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@215482 18797224-902f-48f8-a5cc-f745e15eee43
2006-11-20 19:03:40 +00:00
wurblzap%gmail.com
534cc8b074 Bug 340538: Insecure dependency in exec while running with -T switch at /usr/lib/perl5/site_perl/5.8.6/Mail/Mailer/sendmail.pm line 16.
Patch by Marc Schumann <wurblzap@gmail.com>,
r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@213922 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-20 18:52:24 +00:00
lpsolit%gmail.com
58b1b66792 Bug 281181: [SECURITY] It's way too easy to delete versions/components/milestones etc... - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@213652 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-14 22:02:10 +00:00
lpsolit%gmail.com
d016173598 Bug 350120: undefined value when creating a new user account - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@208453 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-25 20:14:58 +00:00
lpsolit%gmail.com
b735434f6f Bug 87795: Creating an account should send token and wait for confirmation (prevent user account abuse) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat r=bkor a=myk
git-svn-id: svn://10.0.0.236/trunk@207935 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-19 18:12:00 +00:00
mkanat%bugzilla.org
65db537715 Bug 343338: Eliminate "my" variables from the root level of modules
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@202093 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-13 21:55:43 +00:00
mkanat%bugzilla.org
520fe42625 Bug 338375: Use Bugzilla->params everywhere instead of Param().
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201503 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:42:47 +00:00
mkanat%bugzilla.org
8323e09c40 Bug 342869: Use Bugzilla->params everywhere except templates
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201499 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:26:22 +00:00
lpsolit%gmail.com
a698e74659 Bug 282121: Remove globals.pl from scripts that no longer use it - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@200489 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-21 00:44:48 +00:00
lpsolit%gmail.com
d9dd48a759 Bug 339862: Move Bugzilla::BugMail::MessageToMTA() in a separate module - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@198863 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-02 10:50:15 +00:00
lpsolit%gmail.com
1313470148 I forgot a "fix on checkin" (useless whitespaces)
git-svn-id: svn://10.0.0.236/trunk@192097 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-09 20:00:47 +00:00
lpsolit%gmail.com
93890633fa Bug 300551: Eliminate deprecated Bugzilla::DB routines from User.pm and Token.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@192076 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-09 18:19:54 +00:00
lpsolit%gmail.com
6248e4f445 Bug 119524: SECURITY: predictable sessionid (Use a token instead of logincookie) - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@186852 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-03 14:45:22 +00:00
lpsolit%gmail.com
7c3f38ad5d Bug 301062: [PostgreSQL] whine.pl fails when using PostgreSQL 8.0.x - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat r=manu a=justdave
git-svn-id: svn://10.0.0.236/trunk@184543 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-13 17:36:21 +00:00
lpsolit%gmail.com
e334b85a95 Bug 312157: Remove $::template and $::vars from globals.pl - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182927 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-24 23:11:56 +00:00
lpsolit%gmail.com
0818f9fd5f Bug 304582: Move GenerateRandomPassword() out of globals.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel a=myk
git-svn-id: svn://10.0.0.236/trunk@179507 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-01 21:39:21 +00:00
mkanat%kerio.com
0cbbdcfee7 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177695 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-13 12:27:04 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
bugreport%peshkin.net
9778732be8 Backout of bug 303669 which broke AppendComment and possibly a number
of other items.


git-svn-id: svn://10.0.0.236/trunk@177419 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 11:23:43 +00:00
mkanat%kerio.com
7bbde62ad3 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177413 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 05:59:02 +00:00
mkanat%kerio.com
595f9c7816 Bug 285695: [PostgreSQL] Username checks for login, etc. need to be case insensitive
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175810 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-08 02:31:43 +00:00
bugzilla%glob.com.au
4a74d795f2 Bug 297646: Write helper functions for Bugzilla::Token.pm
Patch by Byron Jones <bugzilla@glob.com.au> r=LpSolit,a=justdave


git-svn-id: svn://10.0.0.236/trunk@175454 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-01 01:44:19 +00:00
mkanat%kerio.com
d7c4f4e167 Bug: 284244: DATE_SUB and DATE_ADD are not ANSI SQL
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=wicked, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170128 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-03 07:19:10 +00:00
mkanat%kerio.com
4366849e89 Bug 280502: Replace "INTERVAL" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@169516 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-20 08:02:07 +00:00
mkanat%kerio.com
744343cdb5 Bug 280499: Replace "TO_DAYS()" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@169514 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-20 07:53:17 +00:00
mkanat%kerio.com
fe14d8a2d1 Bug 280497: Replace "LIMIT" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=justdave


git-svn-id: svn://10.0.0.236/trunk@169390 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 16:14:27 +00:00