47 Commits

Author SHA1 Message Date
mkanat%bugzilla.org
df52cc6ee7 Bug 502641: Fix various problems that would occur when you would log in from buglist.cgi
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@257647 18797224-902f-48f8-a5cc-f745e15eee43
2009-07-07 11:54:22 +00:00
lpsolit%gmail.com
96873e288a Bug 502498: Use of uninitialized value in string eq at Bugzilla/CGI.pm line 289 - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@257631 18797224-902f-48f8-a5cc-f745e15eee43
2009-07-05 23:01:15 +00:00
mkanat%bugzilla.org
467db45d31 Bug 501538: Make $cgi->param() also check GET variables during a POST, so that POST forms with query-string variables in the target (like the login form) work correctly.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@257629 18797224-902f-48f8-a5cc-f745e15eee43
2009-07-04 12:16:28 +00:00
mkanat%bugzilla.org
22d4b4a1bd Bug 432907: Create a JSON frontend for WebServices
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@256768 18797224-902f-48f8-a5cc-f745e15eee43
2009-03-31 06:38:02 +00:00
lpsolit%gmail.com
0c29cf31b2 Bug 38862: [SECURITY] attachments should be at a different hostname - Patch by Byron Jones <bugzilla@glob.com.au> and Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@256018 18797224-902f-48f8-a5cc-f745e15eee43
2009-02-02 18:26:26 +00:00
mkanat%bugzilla.org
5c30b2b73f Bug 431744: "Change Columns" URL contained more than 3x the characters in the base buglist.cgi URL
Patch By Michael J Tosh <michael.j.tosh@lmco.com> r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@255865 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-20 20:18:47 +00:00
mkanat%bugzilla.org
dbe3cc397f Bug 454892: Improve Bugzilla::CGI::clean_search_url to remove all the normal "default" fields
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@254238 18797224-902f-48f8-a5cc-f745e15eee43
2008-09-16 19:52:46 +00:00
dkl%redhat.com
f51ff717a8 Bug 428659 – Setting SSL param to 'authenticated sessions' only protects logins and param
doesn't protect WebService calls at all
Patch by David Lawrence <dkl@redhat.com> - r/a=LpSolit/mkanat


git-svn-id: svn://10.0.0.236/trunk@253665 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-18 04:16:14 +00:00
dkl%redhat.com
223ced6261 Backing out these patches as they cause a regression. More information
in the respective bug reports.

Bug 428659 – Setting SSL param to 'authenticated sessions' only
protects logins and param doesn't protect WebService calls at all
Patch by Dave Lawrence <dkl@redhat.com> - r/a=mkanat

Bug 445104: ssl redirects come with a 200 OK HTTP code on mod_perl
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@253320 18797224-902f-48f8-a5cc-f745e15eee43
2008-07-28 20:58:01 +00:00
mkanat%bugzilla.org
81a7b56e9b Bug 445104: ssl redirects come with a 200 OK HTTP code on mod_perl
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@253246 18797224-902f-48f8-a5cc-f745e15eee43
2008-07-24 16:03:25 +00:00
dkl%redhat.com
fe2838832f Bug 428659 – Setting SSL param to 'authenticated sessions' only protects logins and param doesn't protect WebService calls at all
Patch by Dave Lawrence <dkl@redhat.com> - r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@252948 18797224-902f-48f8-a5cc-f745e15eee43
2008-07-10 04:56:22 +00:00
lpsolit%gmail.com
5302b50e38 Bug 414002: Temporary files for uploaded attachments are not deleted on Windows - Patch by Steve Hay <SteveHay@planit.com> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@244363 18797224-902f-48f8-a5cc-f745e15eee43
2008-01-29 19:23:56 +00:00
mkanat%bugzilla.org
9c02eee8d8 Bug 407420: CGI::Carp fatalsToBrowser should happen as early as possible
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=justdave, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@242465 18797224-902f-48f8-a5cc-f745e15eee43
2008-01-06 02:53:45 +00:00
mkanat%bugzilla.org
eff047bd4f Bug 363153: Turn on the utf8 bit on all strings in Bugzilla that contain
non-ASCII data, if the utf8 parameter is on. This means that string functions
like substr() work properly on multi-byte languages, now.
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=wurblzap, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@239856 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-23 06:58:36 +00:00
timeless%mozdev.org
847afa671a Bug 345970 Avoid using the string 'the web'
patch by jhulten@tragicallyleet.com r=timeless
I've updated it to trunk r=lpsolit a=lpsolit


git-svn-id: svn://10.0.0.236/trunk@230773 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-24 18:22:02 +00:00
wurblzap%gmail.com
499fb4c722 Bug 383745: Incorrect charset specification in "please wait" screen when server push is in use.
Patch by Marc Schumann <wurblzap@gmail.com>,
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@228574 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-22 07:29:25 +00:00
mkanat%bugzilla.org
7069b5a5fe Bug 360028: Bugzilla::Search::Saved should have create() and update(), and buglist.cgi should use it
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@215190 18797224-902f-48f8-a5cc-f745e15eee43
2006-11-13 03:07:57 +00:00
mkanat%bugzilla.org
6303eb3d4e Bug 357526: buglist.cgi doesn't specify encoding as UTF-8 when the rest of Bugzilla does
Patch By John Beranek <john@redux.org.uk> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@214499 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-31 23:43:13 +00:00
mkanat%bugzilla.org
e7f63b992b Bug 349764: Errors print out a whole HTML page, even when we're not in USAGE_MODE_BROWSER
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=kevin.benton, a=myk


git-svn-id: svn://10.0.0.236/trunk@209191 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-05 18:54:06 +00:00
mkanat%bugzilla.org
5e8c48d336 Bug 173897: Fix |XXX - mod_perl| comments
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@205036 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-28 08:20:31 +00:00
mkanat%bugzilla.org
f03dd55f0c Bug 300978: bad output when a non-cgi script dies
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@203696 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-25 23:23:49 +00:00
mkanat%bugzilla.org
a008236c73 Bug 342757: searching results in "YOUR BROWSER DOESN'T SUPPORT THIS SERVER-PUSH TECHNOLOGY" warning on brower under mod_perl
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=justdave, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201920 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-12 06:05:07 +00:00
mkanat%bugzilla.org
0c4bb6821f Bug 343361: die_with_dignity is useless inside of Bugzilla::CGI
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, r=colin, a=myk


git-svn-id: svn://10.0.0.236/trunk@201625 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-05 23:33:25 +00:00
lpsolit%gmail.com
f952ed05cf Bug 304601: Bugzilla::Config's :locations exports need to be in their own module - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat for the main patch, r=myk for the patch about CGI.pm a=justdave
Bug 328637: Remove all legal_* versioncache arrays - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave

Bug 110503 - Eliminate versioncache


git-svn-id: svn://10.0.0.236/trunk@200347 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-19 20:15:18 +00:00
vladd%bugzilla.org
d279634dba Spelling in code comments patch: 'behavour' -> 'behaviour'; patch by Vlad Dascalu <vladd@bugzilla.org>.
git-svn-id: svn://10.0.0.236/trunk@200300 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-19 15:39:53 +00:00
lpsolit%gmail.com
2b93ee1757 Bug 313255: Move $::ENV{foo} and $::SIG{foo} out of globals.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@199854 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-14 00:26:27 +00:00
wurblzap%gmail.com
39518125ed Bug 306695: Boolean charts forgets "0" values.
Patch by Marc Schumann <wurblzap@gmail.com>,
r=LpSolit, bugreport, a=justdave


git-svn-id: svn://10.0.0.236/trunk@193282 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-30 22:23:07 +00:00
timeless%mozdev.org
dae7b0629a Bug 106386 Correct misspellings in source code
patch by unknown@simplemachines.org r=timeless rs=brendan


git-svn-id: svn://10.0.0.236/trunk@185282 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-25 21:57:13 +00:00
lpsolit%gmail.com
3dfa6a8d09 Bug 308876: Iff ssl is "always", whining (and other non-interactive scripts?) get a 302-moved error - Patch by A. Karl Kornel <karl@kornel.name> r=joel a=justdave
git-svn-id: svn://10.0.0.236/trunk@180802 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-22 16:57:59 +00:00
lpsolit%gmail.com
741e778b62 Bug 126266: Use UTF-8 (Unicode) charset encoding for pages and email for NEW installations - Patch by byron jones (glob) <bugzilla@glob.com.au> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@177097 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-04 11:51:25 +00:00
mkanat%kerio.com
ce34a4daea Bug 283989: CGI.pl global init code should be moved to Bugzilla::CGI
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=wurblzap, a=justdave


git-svn-id: svn://10.0.0.236/trunk@176083 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-14 06:01:35 +00:00
lpsolit%gmail.com
6ff756b877 Bug 268146: mod_security complain: Invalid cookie format: Cookie value is missing #2 - Patch by Marc Schumann <wurblzap@gmail.com> r=kiko a=justdave
git-svn-id: svn://10.0.0.236/trunk@175739 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-07 11:58:22 +00:00
jocuri%softhome.net
9fd8ff0126 Patch for bug 254351: Patch to add a cookiedomain parameter; patch by Eric Haszlakiewicz <erh+mozilla@nimenees.com>, r=kiko, a=myk.
git-svn-id: svn://10.0.0.236/trunk@167846 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 20:43:22 +00:00
jocuri%softhome.net
65b4fc04b7 Patch for bug 260682: Support redirecting to HTTPS always or for authenticated sessions only; patch by Byron Jones (glob) <bugzilla@glob.com.au>, r=vladd, a=myk.
git-svn-id: svn://10.0.0.236/trunk@167813 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 13:09:58 +00:00
travis%sedsystems.ca
50fc6a7b12 Bug 275108 : Content-disposition header is incorrect, violates RFC
Patch by byron jones (glob) <bugzilla@glob.com.au>  r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@167597 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-12 17:06:10 +00:00
justdave%bugzilla.org
83d7a8b028 Bug 265731: multipart_start in the server-push handling code wasn't honoring the $cgi->charset setting.
r=myk, a=justdave


git-svn-id: svn://10.0.0.236/trunk@164238 18797224-902f-48f8-a5cc-f745e15eee43
2004-10-23 09:05:49 +00:00
bugreport%peshkin.net
f766db8ca5 Bug 252388: Fix undef warning when Bugzilla->cgi->header() is called twice
r=jouni
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159640 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-22 07:08:46 +00:00
jocuri%softhome.net
2ffa344c24 Patch for bug 238683: fix for usage of uninitialized value in concatenation in Bugzilla/CGI.pm: remove extra $ char; patch by corporate_gadfly@hotmail.com; r=vlad; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@154290 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-26 02:07:44 +00:00
jocuri%softhome.net
b9f947e183 Tree bustage fix: eliminates the tabs that have been introduced while checking in the patch for bug 226251.
git-svn-id: svn://10.0.0.236/trunk@153214 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-25 14:06:33 +00:00
jocuri%softhome.net
55d75862cd Patch for bug 226251 (internal error when server push is enabled): Due to randomization of perl hash table functionality since 5.8.1 the 'hack' to unset the nph parameter for multipart messages is not working reliable, instead a modified clone of the original multipart_init function is setting this parameter to '0' and is ignoring the given nph parameter from buglist.cgi; patch by Stephen Reindl <sr@stephenreindl.de>; r=bbaetz; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@153087 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-22 18:52:05 +00:00
justdave%syndicomm.com
af5119d43f Bug 226027: Use the Perl CGI module to send cookies.
r=bbaetz, a=justdave


git-svn-id: svn://10.0.0.236/trunk@149650 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-23 09:48:10 +00:00
bbaetz%acm.org
bdb04b622c Bug 204592 - invalid column name error
r,a=myk


git-svn-id: svn://10.0.0.236/trunk@142256 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-09 02:32:21 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
zach%zachlipton.com
70edadec69 Fix for bug 166481 ("Spellcheck is borked"). Part one of this fix fixes
the spelling errors so tinderbox doesn't barf, part two fixes
t/006spellcheck.t and adds some more new words to check for.

Part 1 patch by myself, r=timeless
Part 2 patch by MattyT. r=zach (myself)
a=justdave


git-svn-id: svn://10.0.0.236/trunk@136179 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-10 23:51:38 +00:00
bbaetz%student.usyd.edu.au
ebae797eae Bug 173622 - Move template handling into a module. r=justdave, joel, a=justdave
git-svn-id: svn://10.0.0.236/trunk@135516 18797224-902f-48f8-a5cc-f745e15eee43
2002-12-20 07:21:43 +00:00
bbaetz%student.usyd.edu.au
f4e0651a0c Bug 179174 - renable $| = 1
r=justdave x2
a=justdave


git-svn-id: svn://10.0.0.236/trunk@133471 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-09 11:55:27 +00:00
bbaetz%student.usyd.edu.au
b8b08c22b9 Bug 147833 - start using CGI.pm
r=gerv, justdave


git-svn-id: svn://10.0.0.236/trunk@132553 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-26 01:57:09 +00:00