Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
130,152 Commits 3,986 Branches 0 Tags
Commit Graph

57 Commits

Author SHA1 Message Date
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and 
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
 2004-03-27 03:51:44 +00:00
kiko%async.com.br
36171a62bf Fix for bug 226764: Move InvalidateLogins into Bugzilla::Auth::CGI. 
Consolidates the logout code into Bugzilla::Auth::CGI, and provides
simple front-end wrappers in Bugzilla.pm for use in the CGIs we have.
r=bbaetz, joel; a=justdave.

Adds a set of constants to the logout() API which allow specifying "how
much" we should log out -- all sessions, the current session, or all
sessions but the current one.

Fixes callsites to use this new API; cleans and documents things a
bit while we're at it. Part I in the great COOKIE apocalypse.


git-svn-id: svn://10.0.0.236/trunk@154327 18797224-902f-48f8-a5cc-f745e15eee43
 2004-03-27 01:28:29 +00:00
justdave%syndicomm.com
e099454c93 Bug 192516: Moving the loose .pm files into the Bugzilla directory, where they belong. These files pre-date the Bugzilla directory, and would have gone there had it existed at the time. The four files in question were copied on the CVS server to preserve CVS history in the files. This checkin deletes them from the old location and modifies everything else to know where they are now. 
r= myk, gerv
a= justdave


git-svn-id: svn://10.0.0.236/trunk@154078 18797224-902f-48f8-a5cc-f745e15eee43
 2004-03-18 03:57:05 +00:00
gerv%gerv.net
b2aae61cda Bug 232176 - Add a preferences panel for saved searches, to allow management all in one place. Patch by gerv; r,a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@153673 18797224-902f-48f8-a5cc-f745e15eee43
 2004-03-08 08:40:17 +00:00
jocuri%softhome.net
65989a2fe9 Patch for bug 235278: eliminate %::FORM from userprefs.cgi; r=kiko, a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@153641 18797224-902f-48f8-a5cc-f745e15eee43
 2004-03-07 00:35:54 +00:00
jocuri%softhome.net
5aa4ae55e9 Patch for bug 123077; improve the ValidatePassword sub so that a password change is no longer accepted with a blank second field; r=kiko, a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@153457 18797224-902f-48f8-a5cc-f745e15eee43
 2004-03-03 05:20:43 +00:00
gerv%gerv.net
ec2f077547 Bug 179339 - Simplify and improve the stored query mechanism. Patch by gerv; r,a=myk. 
git-svn-id: svn://10.0.0.236/trunk@149043 18797224-902f-48f8-a5cc-f745e15eee43
 2003-11-08 21:49:20 +00:00
bbaetz%acm.org
726bcd99cc Bug 180635 - Enhance Bugzilla::User to store additional information 
r=myk,jake


git-svn-id: svn://10.0.0.236/trunk@143228 18797224-902f-48f8-a5cc-f745e15eee43
 2003-06-03 09:48:15 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output 
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
 2003-05-05 01:15:38 +00:00
bbaetz%acm.org
6ee31579fe Bug 199813 - Make all users of ThrowUserError pass $vars in explicitly. 
r=gerv
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140585 18797224-902f-48f8-a5cc-f745e15eee43
 2003-04-02 12:35:07 +00:00
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line 
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
 2003-03-27 00:07:02 +00:00
gerv%gerv.net
9f77460a6f Bug 170903 - Remove hard-coded titles and things. Patch B. Patch by gerv; r=bbaetz. 
git-svn-id: svn://10.0.0.236/trunk@131692 18797224-902f-48f8-a5cc-f745e15eee43
 2002-10-10 19:02:36 +00:00
gerv%gerv.net
d6fe11dfdb Bug 163114 - Templatise all calls to DisplayError. Patch D (the last one). Patch by gerv; r=burnus. 
git-svn-id: svn://10.0.0.236/trunk@131264 18797224-902f-48f8-a5cc-f745e15eee43
 2002-10-06 11:52:37 +00:00
myk%mozilla.org
af7a7c6ae3 Fixing build bustage. Incorrect usage "foreach my $foo qw(bar baz)" where the qw construct needs to be surrounded by parentheses. 
git-svn-id: svn://10.0.0.236/trunk@130678 18797224-902f-48f8-a5cc-f745e15eee43
 2002-09-28 19:14:07 +00:00
myk%mozilla.org
2fc6e203af Fixing build bustage. Incorrect usage "foreach my $foo qw(bar baz)" where the qw construct needs to be surrounded by parentheses. 
git-svn-id: svn://10.0.0.236/trunk@130677 18797224-902f-48f8-a5cc-f745e15eee43
 2002-09-28 19:12:25 +00:00
myk%mozilla.org
393a392d87 Fix for bug 98801: Implementation of the request tracker, a set of enhancements to attachment statuses. 
r=gerv,bbaetz


git-svn-id: svn://10.0.0.236/trunk@130672 18797224-902f-48f8-a5cc-f745e15eee43
 2002-09-28 18:42:54 +00:00
bugreport%peshkin.net
2194da2336 bug 157756 - Groups_20020716_Branch Tracking : > 55 groups now supported 
r=bbaetz, gerv


git-svn-id: svn://10.0.0.236/trunk@130217 18797224-902f-48f8-a5cc-f745e15eee43
 2002-09-22 17:15:13 +00:00
gerv%gerv.net
ee2413046e Bug 167978 - Fix Throw*Error l10n regressions and add a test to catch more. Patch by gerv; r=bbaetz. 
git-svn-id: svn://10.0.0.236/trunk@129434 18797224-902f-48f8-a5cc-f745e15eee43
 2002-09-12 22:51:50 +00:00
bbaetz%student.usyd.edu.au
71381b40ed Bug 76923 - Don't |use diagnostics| (its really expensive at startup time) 
r=joel x2


git-svn-id: svn://10.0.0.236/trunk@128080 18797224-902f-48f8-a5cc-f745e15eee43
 2002-08-26 06:17:26 +00:00
bbaetz%student.usyd.edu.au
e78d2d8932 Bug 160710 - Taint checking causes problem with rename function 
r=joel, preed


git-svn-id: svn://10.0.0.236/trunk@127142 18797224-902f-48f8-a5cc-f745e15eee43
 2002-08-13 06:57:03 +00:00
myk%mozilla.org
efd25a3752 Fix for bug 122900: implements email preference for unconfirmed bugs. 
r=jouni


git-svn-id: svn://10.0.0.236/trunk@124543 18797224-902f-48f8-a5cc-f745e15eee43
 2002-07-02 22:18:49 +00:00
bbaetz%student.usyd.edu.au
4403bbe04e Bug 151053, ConnectToDatabase/quietly_check_login sometimes not called 
early enough
r=mattyt, jouni


git-svn-id: svn://10.0.0.236/trunk@123428 18797224-902f-48f8-a5cc-f745e15eee43
 2002-06-17 09:39:48 +00:00
gerv%gerv.net
fc485f3bf1 Bug 140435 - Templatise GetCommandMenu. Patch by gerv; r=bbaetz, justdave. 
git-svn-id: svn://10.0.0.236/trunk@120980 18797224-902f-48f8-a5cc-f745e15eee43
 2002-05-07 21:28:52 +00:00
gerv%gerv.net
fb91a9cc16 Bug 137183 - tab names should be in the template not in the .cgi. Patch by gerv; r=afranke, myk. 
git-svn-id: svn://10.0.0.236/trunk@119766 18797224-902f-48f8-a5cc-f745e15eee43
 2002-04-24 22:21:59 +00:00
gerv%gerv.net
c8a771fb68 Bug 138588 - change to use new template structure. Patch by gerv, r=myk, afranke. 
git-svn-id: svn://10.0.0.236/trunk@119695 18797224-902f-48f8-a5cc-f745e15eee43
 2002-04-24 07:24:50 +00:00
justdave%syndicomm.com
45f5cf551d Remaining pieces of Bug 23067 from yesterday... no idea why the first commit didn't pick these up. 
git-svn-id: svn://10.0.0.236/trunk@117881 18797224-902f-48f8-a5cc-f745e15eee43
 2002-04-01 22:52:40 +00:00
dkl%redhat.com
e850553165 Fix for bug 133833. Error in templatized version of userprefs.cgi. Error 
with ExcludeSelf form variable being all lowercase. Patch by David Lawrence
<dkl@rehat.com> 2xr=gerv@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@117863 18797224-902f-48f8-a5cc-f745e15eee43
 2002-04-01 18:06:20 +00:00
myk%mozilla.org
509c6a36ee Fix for bug 128784: Eliminates redundant function call in userprefs.cgi. 
Patch by Myk Melez <myk@mozilla.org>
r=gerv x 2


git-svn-id: svn://10.0.0.236/trunk@115759 18797224-902f-48f8-a5cc-f745e15eee43
 2002-03-04 23:38:55 +00:00
myk%mozilla.org
e1a2bc2fe4 Fix for bug 128437: correctly display default values for new preferences on the "email preferences" tab. 
Fix by Myk Melez <myk@mozilla.org>.
r=jake,justdave


git-svn-id: svn://10.0.0.236/trunk@115567 18797224-902f-48f8-a5cc-f745e15eee43
 2002-03-01 13:59:59 +00:00
myk%mozilla.org
e2311b3c25 Fix for bug 128422: Fixes serious tree horkage where everyone gets email on all changes regardless of email preferences. 
Fix by Myk Melez <myk@mozilla.org>.
r=gerv@mozilla.org, waiting on second review but checking in now due to severity of bug.


git-svn-id: svn://10.0.0.236/trunk@115566 18797224-902f-48f8-a5cc-f745e15eee43
 2002-03-01 13:20:07 +00:00
gerv%gerv.net
011459ed64 Bug 117060 - templatise userprefs.cgi. We also get a nice new set of tabs and a properly-tabulated email prefs section. 
git-svn-id: svn://10.0.0.236/trunk@115456 18797224-902f-48f8-a5cc-f745e15eee43
 2002-02-28 00:14:01 +00:00
bbaetz%student.usyd.edu.au
e20fe58870 Bug 95732 - remove logincookies.cryptpassword, and invalidate cookies from 
the db when required instead.
(Also fixes bug 58242 as a side effect)

r=myk, kiko


git-svn-id: svn://10.0.0.236/trunk@113598 18797224-902f-48f8-a5cc-f745e15eee43
 2002-02-04 12:23:05 +00:00
justdave%syndicomm.com
c148fadef8 Fix for bug 108982: enable taint mode for all user-facing CGI files. 
Patch by Brad Baetz <bbaetz@student.usyd.edu.au>
r= jake, justdave


git-svn-id: svn://10.0.0.236/trunk@112490 18797224-902f-48f8-a5cc-f745e15eee43
 2002-01-20 01:44:52 +00:00
myk%mozilla.org
f128dfb46b Fix for bug 108822: Prevent any user from changing their own groupset. 
Patch by Jake <jake@acutex.net>.
r=bbaetz,myk


git-svn-id: svn://10.0.0.236/trunk@107633 18797224-902f-48f8-a5cc-f745e15eee43
 2001-11-08 00:54:15 +00:00
gerv%gerv.net
4831a02806 Bug 72177 - reword checkbox to make it consistent with the others on the page. 
git-svn-id: svn://10.0.0.236/trunk@105719 18797224-902f-48f8-a5cc-f745e15eee43
 2001-10-18 21:41:25 +00:00
timeless%mac.com
978145c42f Bugzilla Bug 51521 Broken HTML on user permissions page 
patchwork by john.beranek@pace.co.uk and kiko. r=zach, kiko, gerv


git-svn-id: svn://10.0.0.236/trunk@105009 18797224-902f-48f8-a5cc-f745e15eee43
 2001-10-10 04:47:17 +00:00
zach%zachlipton.com
dc3c9e0e97 Fix for bug 93388: Full name should be trimmed of whitespace before going 
into database.

r1=Zach Lipton <zach@zachlipton.com> r2=Andreas Franke
<afranke@ags.uni-sb.de>. Patch by Christopher Aillon
<caillon@returnzero.com>.


git-svn-id: svn://10.0.0.236/trunk@103587 18797224-902f-48f8-a5cc-f745e15eee43
 2001-09-23 17:20:50 +00:00
justdave%syndicomm.com
a32206490b Fix for bug 77473, bug 74032, and bug 85472: Passwords are no longer stored in plaintext in the database. Passwords are no longer encrypted with MySQL's ENCRYPT() function (because it doesn't work on some installs), but with Perl's crypt() function. The crypt-related routines now properly deal with salts so that they work on systems that use methods other than UNIX crypt to crypt the passwords (such as MD5). Checksetup.pl will walk through your database and re-crypt everyone's passwords based on the plaintext password entry, then drop the plaintext password column. As a consequence of no longer having a plaintext password, it is no longer possible to email someone their password, so the login screen has been changed to request a password reset instead. The user is emailed a temporary identifying token, with a link back to Bugzilla. They click on the link or paste it into their browser and Bugzilla allows them to change their password. 
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@99057 18797224-902f-48f8-a5cc-f745e15eee43
 2001-07-11 05:29:21 +00:00
justdave%syndicomm.com
107bf6572e Fix for bug 45918: the old password field on the userprefs page is now used to log you back in if you try to change your password with cookies turned off, which avoids the confusing login screen after entering your new password in which you used to have to enter your old password one more time in order to let it set your new password (yes, it used to be as confusing as that just sounded :) 
r= tara@tequilarista.org


git-svn-id: svn://10.0.0.236/trunk@97448 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-19 22:02:53 +00:00
jake%acutex.net
3cb4dd4427 Fixing typo. Attachments isn't spelled 'Attachemnts' (bug 84295). 
git-svn-id: svn://10.0.0.236/trunk@96532 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-06 14:25:18 +00:00
jake%acutex.net
6a7f347c38 Bug 71552 - Remove oldemailtech from Bugzilla 
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@95855 18797224-902f-48f8-a5cc-f745e15eee43
 2001-05-24 03:10:49 +00:00
justdave%syndicomm.com
f539fe27ee Correcting my email address in the comments 
git-svn-id: svn://10.0.0.236/trunk@92493 18797224-902f-48f8-a5cc-f745e15eee43
 2001-04-17 02:26:16 +00:00
justdave%syndicomm.com
995e39a8bf Fix for bug 71808: Can't set email preferences for voters (which caused voters to get OldEmailTech notifications. 
Patch by jake@acutex.net
r= justdave


git-svn-id: svn://10.0.0.236/trunk@91659 18797224-902f-48f8-a5cc-f745e15eee43
 2001-04-07 17:09:28 +00:00
justdave%syndicomm.com
f73644bd7c Fix for bug 71912: changes email pref for "If I'm removed from that capacity" to "If I'm added to or removed from that capacity", so you can still get mail when someone adds you to a CC. Patch by <jake@acutex.net> r= justdave 
git-svn-id: svn://10.0.0.236/trunk@91658 18797224-902f-48f8-a5cc-f745e15eee43
 2001-04-07 16:36:45 +00:00
dave%intrec.com
dfc0df6cb8 Re-fix for bug 17464: oldemailtech prefs work again. 
git-svn-id: svn://10.0.0.236/trunk@89103 18797224-902f-48f8-a5cc-f745e15eee43
 2001-03-09 06:28:59 +00:00
dmose%mozilla.org
fe2693b9e6 fix for bug found in original 17464 patch, where removal from the CC list was not generating a mail. r=donm@bluemartini.com 
git-svn-id: svn://10.0.0.236/trunk@87020 18797224-902f-48f8-a5cc-f745e15eee43
 2001-02-14 20:41:26 +00:00
dmose%mozilla.org
ee1174cf51 patch from bug 17464 to give user some control over what sorts of bug mail get sent to an account. Original patch by al_raetz@yahoo.com and lots of additional hacking by me; r=donm@bluemartini.com 
git-svn-id: svn://10.0.0.236/trunk@85444 18797224-902f-48f8-a5cc-f745e15eee43
 2001-01-24 20:26:24 +00:00
dmose%mozilla.org
e7287beca1 changes from jake@acutex.net to make it possible to toggle the default value of newemailtech for new profiles, this is set by default to be turned on (the old default was off) ; r=dmose@mozilla.org. changes from me to make newemailtech the default in all new installations, and update the verbiage in various spots to make it clear that newemailtech is now considered the one true way and the old tech will be going away. r=endico@mozilla.org,cyeh@bluemartini.com 
git-svn-id: svn://10.0.0.236/trunk@84014 18797224-902f-48f8-a5cc-f745e15eee43
 2000-12-22 23:01:30 +00:00
cyeh%bluemartini.com
956bda5f7f fix for 51521: Broken HTML on user permissions page, patch by john.beranek@pace.co.uk 
git-svn-id: svn://10.0.0.236/trunk@78937 18797224-902f-48f8-a5cc-f745e15eee43
 2000-09-13 00:09:36 +00:00
cyeh%bluemartini.com
0714929f7c add voters to text 
git-svn-id: svn://10.0.0.236/trunk@73102 18797224-902f-48f8-a5cc-f745e15eee43
 2000-06-23 22:35:38 +00:00