2625 Commits

Author SHA1 Message Date
alexei.volkov.bugs%sun.com
1d1a4044d4 [Bug 339908] 3 NULL ptr crashes when PK11_GetBestSlot returns NULL. r=nelson
git-svn-id: svn://10.0.0.236/trunk@198906 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-02 20:34:04 +00:00
wtchang%redhat.com
9d60721908 Bugzilla bug 338599: added new function SECKEY_SignatureLen and use it
instead of SECKEY_PublicKeyStrength to get ECDSA signature lengths.
Removed the 'type' member from the VFYContextStr structure because that
info is in the 'key->keyType' field.  Set error codes when functions
fail (return 0). r=nelsonb.
Modified Files:
	cryptohi/keyhi.h cryptohi/seckey.c cryptohi/secvfy.c
	nss/nss.def ssl/ssl3con.c


git-svn-id: svn://10.0.0.236/trunk@198781 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-31 23:54:52 +00:00
wtchang%redhat.com
3b03ac60dc Bugzilla Bug 338552: added StartCom CA certificate to NSS. The patch is
contributed by  Eddy Nigg, StartCom Ltd. <eddy_nigg@startcom.org>. r=wtc.
a=hecker.
Modified Files: certdata.c certdata.txt nssckbi.h


git-svn-id: svn://10.0.0.236/trunk@198747 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-31 17:18:54 +00:00
julien.pierre.bugs%sun.com
d8757a4062 Fix for bug 336477 . Fix for CERT_UncacheCRL error checking. r=nelson
git-svn-id: svn://10.0.0.236/trunk@198715 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-31 01:58:50 +00:00
alexei.volkov.bugs%sun.com
e1eb7c42f8 [Bug 337014] OOM crash [@ PORT_ArenaAlloc - PK11_PQG_ParamGenSeedLen][@ PORT_ArenaAlloc - PK11_PQG_ParamGenSeedLen] Dereferencing possibly NULL "varena". r=nelson
git-svn-id: svn://10.0.0.236/trunk@198227 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-22 23:08:04 +00:00
alexei.volkov.bugs%sun.com
d19e8381e1 [Bug 337495] Double free in CRMF_CertReqMsgSetSignaturePOP (security/nss/lib/crmf/crmfpop.c) [Attachment 222949]. r=nelson
git-svn-id: svn://10.0.0.236/trunk@198216 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-22 22:38:56 +00:00
wtchang%redhat.com
22a3ee42b4 Bugzilla Bug 320336: improved the comments for SECITEM_AllocItem in
secitem.h.  Made SECITEM_AllocItem fail (return NULL) if the allocation of
the buffer fails, as documented. r=nelsonb.
Modified files: secitem.c secitem.h


git-svn-id: svn://10.0.0.236/trunk@198213 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-22 22:24:34 +00:00
wtchang%redhat.com
69d7a0a243 Bugzilla Bug 298520: moved the RSA maximum size macros from rsa.c to
blapit.h.  Removed an out-of-date comment from blapit.h. r=nelsonb.
Modified files: blapit.h rsa.c


git-svn-id: svn://10.0.0.236/trunk@198212 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-22 22:10:40 +00:00
wtchang%redhat.com
d9dc62d685 Bugzilla Bug 298520: added a comment explain the meaning of the MAX_KEY_LEN
macro. r=nelsonb.


git-svn-id: svn://10.0.0.236/trunk@198211 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-22 22:08:40 +00:00
alexei.volkov.bugs%sun.com
b3983d98ac [Bug 337495] Double free in CRMF_CertReqMsgSetSignaturePOP (security/nss/lib/crmf/crmfpop.c). r=nelson
git-svn-id: svn://10.0.0.236/trunk@198206 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-22 21:46:14 +00:00
nelson%bolyard.com
862dbdbc05 Promote the use of curve secp192r1 for client auth, since it is faster
than most.  Bug 332350.  r=rrelyea.


git-svn-id: svn://10.0.0.236/trunk@197974 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-19 04:01:30 +00:00
nelson%bolyard.com
4da77ec812 Eliminate a crash and plug a leak in the error path for function
nssSMIMEProfile_Create. Coverity bug 337101. r=alexei.volkov.


git-svn-id: svn://10.0.0.236/trunk@197968 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-18 23:31:17 +00:00
nelson%bolyard.com
c638057736 Avoid crash if "item" pointer is NULL. Coverity bug 333555.
r=wtchang,alexei.volkov


git-svn-id: svn://10.0.0.236/trunk@197959 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-18 21:20:04 +00:00
alexei.volkov.bugs%sun.com
4af681e8ca [Bug 337008] OOM crash [@ nssList_Add - STAN_InitTokenForSlotInfo - STAN_LoadDefaultNSS3TrustDomain][@ nssList_Clone - nssList_CreateIterator - STAN_LoadDefaultNSS3TrustDomain] Dereferencing possibly NULL "(td)->tokenList". r=nelson, sr=wtc
git-svn-id: svn://10.0.0.236/trunk@197957 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-18 21:00:58 +00:00
alexei.volkov.bugs%sun.com
2c120f1527 [Bug 337010] OOM crash [@ NSC_DigestKey] Dereferencing possibly NULL "att". r=ne
lson,wtc


git-svn-id: svn://10.0.0.236/trunk@197955 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-18 20:53:29 +00:00
nelson%bolyard.com
0b6cbc463e Plug leak. Free cache. Coverity bug 338201. r=alexei.volkov
git-svn-id: svn://10.0.0.236/trunk@197951 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-18 20:47:46 +00:00
nelson%bolyard.com
d41e92d455 Fix several Coverity bugs. Bug 336982. NULL ptr check after ptr deref'ed.
Bug 337080.  Dead code.  r=alexei.volkov


git-svn-id: svn://10.0.0.236/trunk@197950 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-18 20:41:21 +00:00
nelson%bolyard.com
d9f59f5bda Remove dead old FORTEZZA KEA code. Coverity bug 337098. r=rrelyea,wtchang
git-svn-id: svn://10.0.0.236/trunk@197948 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-18 20:26:36 +00:00
alexei.volkov.bugs%sun.com
3aa9529419 [Bug 337154] Coverity 321, dead code in mozilla/security/nss/lib/pk11wrap/pk11cert.c. (second patch) r=nelson
git-svn-id: svn://10.0.0.236/trunk@197947 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-18 20:21:12 +00:00
nelson%bolyard.com
550fe83737 Don't dereference a NULL secmodprefix argument. Coverity Bug 336981.
r=alexei.volkov


git-svn-id: svn://10.0.0.236/trunk@197945 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-18 19:47:37 +00:00
nelson%bolyard.com
9e381a14e2 In SEC_PKCS12DecoderGetCerts, don't dereference p12dcx until AFTER it has
been checked for NULL. Coverity bug 336971. r=alexei.volkov


git-svn-id: svn://10.0.0.236/trunk@197944 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-18 19:39:58 +00:00
nelson%bolyard.com
cd18f85fef Add 3 assertions to satisfy coverity that tmpt is never NULL in these
places.  Bug 336995. r=akexei.volkov,wtchang


git-svn-id: svn://10.0.0.236/trunk@197941 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-18 19:32:44 +00:00
nelson%bolyard.com
4dba0c5e47 Plug leak. Free "info" in error path. Coverity bug 336475.
r=wtchang,alexei.volkov


git-svn-id: svn://10.0.0.236/trunk@197899 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-18 04:37:28 +00:00
nelson%bolyard.com
d201e5eca4 Correct the amount returned by ssl_Writev for short writes on non-blocking
sockets.  Bug 338325. patch by Chris Newman <chris.newman@sun.com>
r=nelson


git-svn-id: svn://10.0.0.236/trunk@197897 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-18 01:10:21 +00:00
wtchang%redhat.com
d6f1f43526 Bugzilla bug 338367: check that the array index params->name is within
bounds before taking an element from the ecCurve_map array.
r=doublas.stebila.


git-svn-id: svn://10.0.0.236/trunk@197896 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-17 23:58:18 +00:00
julien.pierre.bugs%sun.com
d26151d1d2 Fix for bug 222300. r=nelson,wtchang
git-svn-id: svn://10.0.0.236/trunk@197892 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-17 22:20:08 +00:00
alexei.volkov.bugs%sun.com
52fff307bc [Bug 337011] OOM crash [@ sftk_handleKeyObject][@ sftk_handleKeyParameterObject] Dereferencing possibly NULL "attribute". r=nelson
git-svn-id: svn://10.0.0.236/trunk@197887 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-17 20:52:16 +00:00
alexei.volkov.bugs%sun.com
1ec4da74b6 [Bug 337326] Leak in nsslowcert_UpdateSubjectEmailAddr (security/nss/lib/softoken/pcertdb.c). r=nelson
git-svn-id: svn://10.0.0.236/trunk@197886 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-17 20:46:59 +00:00
alexei.volkov.bugs%sun.com
8abbff7832 [Bug 337009] OOM crash [@ nssList_Count - nssTrustDomain_GetCertsFromCache] Dereferencing possibly NULL "certList". r=nelson
git-svn-id: svn://10.0.0.236/trunk@197885 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-17 20:38:59 +00:00
alexei.volkov.bugs%sun.com
710423a6bc [Bug 337332] Leak in OpenNewDB (security/nss/lib/softoken/keydb.c). r=nelson
git-svn-id: svn://10.0.0.236/trunk@197869 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-17 17:56:37 +00:00
alexei.volkov.bugs%sun.com
34fc8514b8 [Bug 336485] coverity thinks that nssPKIObject_GetInstances could return null which would lead to a crash [@ listCertsCallback]. r=nelson
git-svn-id: svn://10.0.0.236/trunk@196714 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-16 23:47:45 +00:00
wtchang%redhat.com
674b3349ea Bugzilla Bug 337025: removed more unused or trivially used variables.
r=alexei.volkov,nelson.bolyard.


git-svn-id: svn://10.0.0.236/trunk@196627 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-16 01:57:04 +00:00
wtchang%redhat.com
2beeda3cec Bug 305835: Remove NSS_ENABLE_ECC ifdefs in libssl. r=wtc,nelsonb
git-svn-id: svn://10.0.0.236/trunk@196622 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-16 01:14:43 +00:00
wtchang%redhat.com
b3035ead89 Bugzilla Bug 298506: a first cut at Solaris auditing. The patch is
contributed by Glen Beasley of Sun. r=wtc.
Modified Files:
	cmd/platlibs.mk lib/softoken/config.mk lib/softoken/fipstokn.c


git-svn-id: svn://10.0.0.236/trunk@196614 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-16 01:04:05 +00:00
julien.pierre.bugs%sun.com
13e8e05e33 Fix for bug 335036 . NSS_Shutdown() does not check that NSS is initialized. r=nelson, alexei
git-svn-id: svn://10.0.0.236/trunk@196611 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-16 00:11:25 +00:00
julien.pierre.bugs%sun.com
56763cafe5 Fix for bug 337789 . PK11_FindKeyByAnyCert doe snot work if softoken is in FIPS140-2 mode. r=wtchang, rrelyea, nelson
git-svn-id: svn://10.0.0.236/trunk@196609 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-15 23:51:01 +00:00
alexei.volkov.bugs%sun.com
1d9deeee9b [Bug 336482] crash or hopefully deadcode [@ crmf_copy_poposigningkey]
because Pointer "destPopoSignKey" dereferenced before NULL check. r=nelson


git-svn-id: svn://10.0.0.236/trunk@196597 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-15 21:05:20 +00:00
alexei.volkov.bugs%sun.com
a5a4d2f9a9 Patch contributed by jonsmirl@yahoo.com
[Bug 337154] Coverity 321, dead code in mozilla/security/nss/lib/pk11wrap/pk11cert.c. r=wtchang


git-svn-id: svn://10.0.0.236/trunk@196596 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-15 20:58:18 +00:00
alexei.volkov.bugs%sun.com
b961c522a3 Patch contributed by jonsmirl@yahoo.com
[Bug 337086] Coverity 446, dead code in mozilla/security/nss/lib/certhigh/ocsp.c. r=wtchang


git-svn-id: svn://10.0.0.236/trunk@196592 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-15 20:52:01 +00:00
alexei.volkov.bugs%sun.com
52dd25b89b Patch contributed by jonsmirl@yahoo.com
[Bug 337085] Coverity 447, dead code in mozilla/security/nss/lib/certhigh/ocsp.c
. r=wtchang


git-svn-id: svn://10.0.0.236/trunk@196588 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-15 20:44:46 +00:00
alexei.volkov.bugs%sun.com
a71a7d0dd6 Patch contributed by timeless@bemail.org
[Bug 337025] Coverity 411, dead code in mozilla/security/nss/lib/certdb/stanpcertdb.c. r=nelson


git-svn-id: svn://10.0.0.236/trunk@196582 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-15 20:39:38 +00:00
alexei.volkov.bugs%sun.com
62fbff589e Patch contributed by timeless@bemail.org
[Bug 336992] crash [@ pk11_DoKeys] "arg" Pointer dereferenced before NULL check. r=nelson


git-svn-id: svn://10.0.0.236/trunk@196447 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-13 00:46:51 +00:00
alexei.volkov.bugs%sun.com
012cd5c97b Patch contributed by timeless@bemail.org
[Bug 336972] OOM crash [@ PK11_ImportDERPrivateKeyInfoAndReturnKey] "pki" Pointer allocated by PORT_NewArena dereferenced without NULL check. r=nelson


git-svn-id: svn://10.0.0.236/trunk@196446 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-13 00:41:25 +00:00
alexei.volkov.bugs%sun.com
df555d9fd3 Patch contributed by timeless@bemail.org
[Bug 336466] oom crash [@ CERT_DecodeAuthKeyID]. r=nelson


git-svn-id: svn://10.0.0.236/trunk@196444 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-13 00:33:14 +00:00
julien.pierre.bugs%sun.com
9202c9eb23 Fix for bug 336477. Memory leak in CERT_UncacheCRL . r=nelson
git-svn-id: svn://10.0.0.236/trunk@196442 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-13 00:27:53 +00:00
alexei.volkov.bugs%sun.com
c7810f0f61 Patch contributed by jonsmirl@yahoo.com
[Bug 336935] Coverity 172, dead code in mozilla/security/nss/lib/softoken/keydb.c. r=nelson, r=alexei.volkov.bugs


git-svn-id: svn://10.0.0.236/trunk@196441 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-13 00:27:22 +00:00
alexei.volkov.bugs%sun.com
ea68cbd9e6 Patch contributed by jonsmirl@yahoo.com
[Bug 336932] Coverity 163, dead code in mozilla/security/nss/lib/ssl/ssl3con.c. r=nelson


git-svn-id: svn://10.0.0.236/trunk@196440 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-13 00:15:43 +00:00
alexei.volkov.bugs%sun.com
fd5b7fc2d2 Patch contributed by timeless@bemail.org
[Bug 336481] oom crash [@ crmf_copy_cert_req_msg]


git-svn-id: svn://10.0.0.236/trunk@196439 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-13 00:03:40 +00:00
nelson%bolyard.com
61c4af34bf Bug 337093. Remove dead code at label loser in function dbs_readBlob
Patch by Jon Smirl <jonsmirl@yahoo.com>, r=wtchang.  Coverity bug


git-svn-id: svn://10.0.0.236/trunk@196435 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-12 23:37:58 +00:00
wtchang%redhat.com
d891fb71cf Bugzilla Bug 336934: removed ununsed variable ck_id. The patch is
contributed by Jon Smirl <jonsmirl@yahoo.com>. r=nelsonb,wtc.


git-svn-id: svn://10.0.0.236/trunk@196412 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-12 20:42:13 +00:00