196 Commits

Author SHA1 Message Date
justdave%syndicomm.com
929927863c Fix for bug 39816: Anyone in CC, Reporter, QA Contact, or Asigned To fields can now be given access to view a bug even if the permissions on that bug are set to a group that would normally exclude those people.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@100906 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-13 00:46:20 +00:00
justdave%syndicomm.com
19a161bd38 Re-fix for bug 55161 - if data is partial in activity table, prepend a ? to indicate that we don't know for sure what got dropped.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@100645 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-09 06:12:18 +00:00
jake%acutex.net
b65bd37c2f Fix for bug 92713, show_activity.pl displays zeros as non-breaking spaces.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@100005 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-30 12:52:21 +00:00
jake%acutex.net
559c643f79 Fix for bugs 55161 and 12819. The activity log now stores only what's changed in multi-value fields.
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@99648 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-20 15:18:30 +00:00
justdave%syndicomm.com
b578f52ce7 Fixing minor problem caused by the original bug 77473 checkin where an SQL error was being produced if you tried to log in
with an invalid username.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@99326 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-16 19:38:34 +00:00
justdave%syndicomm.com
a32206490b Fix for bug 77473, bug 74032, and bug 85472: Passwords are no longer stored in plaintext in the database. Passwords are no longer encrypted with MySQL's ENCRYPT() function (because it doesn't work on some installs), but with Perl's crypt() function. The crypt-related routines now properly deal with salts so that they work on systems that use methods other than UNIX crypt to crypt the passwords (such as MD5). Checksetup.pl will walk through your database and re-crypt everyone's passwords based on the plaintext password entry, then drop the plaintext password column. As a consequence of no longer having a plaintext password, it is no longer possible to email someone their password, so the login screen has been changed to request a password reset instead. The user is emailed a temporary identifying token, with a link back to Bugzilla. They click on the link or paste it into their browser and Bugzilla allows them to change their password.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@99057 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-11 05:29:21 +00:00
justdave%syndicomm.com
18d9089fcc Fix for bug 87701: Invalid username in bug changes echoed back without escaping HTML data
Patch by Gervase Markham <gervase.markham@univ.ox.ac.uk>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@98634 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-04 07:06:00 +00:00
justdave%syndicomm.com
11c1fc0d98 Fix for bug 85833: show_bug.cgi (and probably others) now allow leading or trailing spaces in the bug id, to allow for user input error. This used to work, and recent bug validation changes broke it.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@97469 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-19 22:48:21 +00:00
jake%acutex.net
5743b31229 Allow '\' as a path delimiter (bug 29064)
Patch Concept by <timeless@mac.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@97370 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-18 23:13:18 +00:00
justdave%syndicomm.com
62f8abbb9a Fix for bug 15980: Password is no longer shown in the location bar on the first page you load after logging in.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96648 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-07 20:26:40 +00:00
justdave%syndicomm.com
5c9e4da69d fix typo
git-svn-id: svn://10.0.0.236/trunk@96598 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-07 01:31:51 +00:00
tara%tequilarista.org
cbb24b9172 Landing Myk's patch for bug #71767
git-svn-id: svn://10.0.0.236/trunk@96243 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-02 22:02:02 +00:00
jake%acutex.net
ce19d8c942 Bugzilla was leaking information about bugs marked secure (using bug groups). This checkin fixes bugs 39524, 39527, 39531, and 39533.
Patches by Myk Melez <myk@mozilla.org>.
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96121 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-31 15:52:25 +00:00
justdave%syndicomm.com
eee9480678 Fix for bug 38859: escape invalid email addresses for HTML before displaying to the user.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net, justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@94669 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-11 18:02:38 +00:00
justdave%syndicomm.com
d0938a0ed7 Fix for bug 38855: showvotes.cgi needs to escape (untrusted) url params
Patch by Myke Melez <myk@mozilla.org>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@94446 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-10 02:53:22 +00:00
dave%intrec.com
3b13ee4bac Attempted fix for bug 71574: footer anomoly cleanup
git-svn-id: svn://10.0.0.236/trunk@89253 18797224-902f-48f8-a5cc-f745e15eee43
2001-03-10 22:06:57 +00:00
cyeh%bluemartini.com
2cf75195a2 fix for "My Votes" floating in space like a disconnected astronaut
git-svn-id: svn://10.0.0.236/trunk@89227 18797224-902f-48f8-a5cc-f745e15eee43
2001-03-10 05:52:54 +00:00
cyeh%bluemartini.com
53f88c7858 fix for 54566: Software error generated when adding invalid dependencies
if we call PuntTryAgain(), make sure we've unlocked tables


git-svn-id: svn://10.0.0.236/trunk@87835 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-23 21:40:03 +00:00
cyeh%bluemartini.com
70e7510837 cleanup footer when not logged in and if using voting.
git-svn-id: svn://10.0.0.236/trunk@87689 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-22 22:11:27 +00:00
cyeh%bluemartini.com
44689e7095 break Find and Report links to a seperate line so that it looks cleaner
on browser windows with shorter widths. also, the second line
matches nicely with the other table cell.


git-svn-id: svn://10.0.0.236/trunk@87687 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-22 21:59:25 +00:00
cyeh%bluemartini.com
f681222363 fix for 67278: Footer lines need separation
patch submitted by shie9022@msmailhub.oulan.ou.edu (Alan Shields)
make saved queries display better


git-svn-id: svn://10.0.0.236/trunk@87621 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-22 02:20:58 +00:00
dave%intrec.com
19f8439e6f Fix for bug 32000 (and refixing bug 4928): extra newlines in comments made
with NS4-Mac


git-svn-id: svn://10.0.0.236/trunk@84962 18797224-902f-48f8-a5cc-f745e15eee43
2001-01-16 21:09:33 +00:00
cyeh%bluemartini.com
96a8252486 remove problem with newer perl spewing error messages into the CGI
git-svn-id: svn://10.0.0.236/trunk@81631 18797224-902f-48f8-a5cc-f745e15eee43
2000-10-24 00:44:21 +00:00
cyeh%bluemartini.com
ca34c0f2c8 fix for 52228: Bug list title should be name of query if running named query
patch by dave@intrec.com (Dave Miller)


git-svn-id: svn://10.0.0.236/trunk@79460 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-18 21:29:45 +00:00
dave%intrec.com
b1e000ea95 Fix for bug 51270: param for bodyhtml to allow sites to customize
background colors/image and link colors.


git-svn-id: svn://10.0.0.236/trunk@79391 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-16 14:08:37 +00:00
cyeh%bluemartini.com
813748876f fixes for 51184, 51185, 51186: allow for ldap authentication. patches
by jmrobins@tgix.com (Joe Robins). LDAP sections haven't been
tested yet, but the code is arranged such that it shouldn't disturb
existing user authentication system.


git-svn-id: svn://10.0.0.236/trunk@79347 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-15 18:35:18 +00:00
dave%intrec.com
f5079948a1 Fix for bug 51508: Unclosed <NOBR> around named queries in command menu.
Patch by john.beranek@pace.co.uk (John Beranek)


git-svn-id: svn://10.0.0.236/trunk@78349 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-07 06:22:10 +00:00
dave%intrec.com
d1299d3e29 Fix for bug 43821: PutHeader has unbalanced <TABLE> tags.
git-svn-id: svn://10.0.0.236/trunk@78098 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-04 04:10:51 +00:00
cyeh%bluemartini.com
43f18fecb9 fix for bug #44622: perl5.6 vs perl5.005 -w: more anal 5.6 causes errors.
patches by mtakacs@pacbell.net.


git-svn-id: svn://10.0.0.236/trunk@76788 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-21 19:50:41 +00:00
endico%mozilla.org
dd7c74be48 added comment to value_quote referencing bugs with quoting linebreaks
git-svn-id: svn://10.0.0.236/trunk@71296 18797224-902f-48f8-a5cc-f745e15eee43
2000-06-01 23:09:14 +00:00
cyeh%bluemartini.com
38f6aaeaf6 Validate value of $::FORM{who}. Thanks to Ed Korthof (edk@collab.net) for patch.
git-svn-id: svn://10.0.0.236/trunk@68682 18797224-902f-48f8-a5cc-f745e15eee43
2000-05-08 18:12:28 +00:00
dmose%mozilla.org
0b0b51f77a Fixed a typo that was causing Perl to abort before printing the HTML
footer when a certain database inconsistency was detected.


git-svn-id: svn://10.0.0.236/trunk@67436 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-27 23:12:44 +00:00
donm%bluemartini.com
3bfbf244d5 bug 25010 need a way to edit groups
git-svn-id: svn://10.0.0.236/trunk@67252 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-26 19:35:51 +00:00
endico%mozilla.org
8823ce2547 backing out because this has broken bugzilla.mozilla.org. the choice is no longer given in show_bug.cgi to make bugs confidential. I need to change lounge so it no longer automatically updates.
git-svn-id: svn://10.0.0.236/trunk@66391 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-19 02:14:41 +00:00
donm%bluemartini.com
861e3e08fb bug 25010 add ability to easily edit groups
git-svn-id: svn://10.0.0.236/trunk@66353 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-18 23:12:00 +00:00
dmose%mozilla.org
2d5bcbdec0 Fixed perl warning which occurs if $ENV{"CONTENT_TYPE"} is not set.
git-svn-id: svn://10.0.0.236/trunk@64645 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-30 23:56:36 +00:00
terry%mozilla.org
9f6d3ccbcd Add a bit of helpful debugging info when we get a consistancy check problem.
git-svn-id: svn://10.0.0.236/trunk@63865 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-23 18:20:34 +00:00
terry%mozilla.org
7a12dbb0f0 Removed warning.
git-svn-id: svn://10.0.0.236/trunk@62533 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-10 17:45:09 +00:00
terry%mozilla.org
6af1f6f35a Patch by Brian Duggan <bduggan@oven.com> -- security improvements.
git-svn-id: svn://10.0.0.236/trunk@62314 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-07 18:23:00 +00:00
terry%mozilla.org
58c914a7f7 Patch by Olaf Krische <krische@mbi-berlin.de> -- Fixed HTML typos.
git-svn-id: svn://10.0.0.236/trunk@62311 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-07 17:32:51 +00:00
terry%mozilla.org
5db00817f6 Make a universal routine to report errors in forms, so that we can
have a universal (and more noticable) way of displaying them.


git-svn-id: svn://10.0.0.236/trunk@61678 18797224-902f-48f8-a5cc-f745e15eee43
2000-02-25 19:32:47 +00:00
terry%mozilla.org
12b0541149 Cut down on the number of syncshadowdb processes we fork off.
git-svn-id: svn://10.0.0.236/trunk@61317 18797224-902f-48f8-a5cc-f745e15eee43
2000-02-18 21:38:23 +00:00
terry%mozilla.org
f6643e69b0 Added an optional ability to keep a read-only shadow database, so that
bug queries can be run against it, so that these slow queries won't be
able to tie up the rest of the system.


git-svn-id: svn://10.0.0.236/trunk@61227 18797224-902f-48f8-a5cc-f745e15eee43
2000-02-17 21:41:39 +00:00
terry%mozilla.org
e852b90ee9 Put the "users" link in the trailer for people who are able to tweak
the permissions of other users.


git-svn-id: svn://10.0.0.236/trunk@61202 18797224-902f-48f8-a5cc-f745e15eee43
2000-02-17 15:52:12 +00:00
terry%mozilla.org
86a0cf8cc4 Major spankage. Added a new state, UNCONFIRMED. Added new groups,
"editbugs" and "canconfirm".  People without these states are now much
more limited in what they can do.

For backwards compatability, by default all users will have the
editbugs and canconfirm bits on them.  Installing this changes as is
should only have one major visible effect -- an UNCONFIRMED state
will appear in the query page.  But no bugs will become in that state,
until you tweak some of the new voting-related parameters you'll find
when editing products.


git-svn-id: svn://10.0.0.236/trunk@61184 18797224-902f-48f8-a5cc-f745e15eee43
2000-02-17 05:15:23 +00:00
terry%mozilla.org
347c4be406 Patches by Ken Jenks <kjenks@abiblion.com> and jug@tellux.de -- make the Javascript behave under IE5 and under Netscape 3.x
git-svn-id: svn://10.0.0.236/trunk@60909 18797224-902f-48f8-a5cc-f745e15eee43
2000-02-15 18:56:31 +00:00
terry%mozilla.org
2a5a73c8a7 Make the "mail a new password" text be a param.
git-svn-id: svn://10.0.0.236/trunk@59997 18797224-902f-48f8-a5cc-f745e15eee43
2000-02-07 22:11:55 +00:00
terry%mozilla.org
982cc6b9f0 Massive stomp on the query page and buglist page. Added the ability
to use the "boolean charts" to do very powerful queries.


git-svn-id: svn://10.0.0.236/trunk@58980 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-28 01:01:40 +00:00
terry%mozilla.org
f390ae9051 Reworked preferences UI. Added ability to turn off "My bugs" link at
bottom.  Made "My bugs" show bugs you own AND bugs you submitted.
Added ability to display your named queries in the footer.  Many
random bugfixes.


git-svn-id: svn://10.0.0.236/trunk@58576 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-25 07:54:57 +00:00
terry%mozilla.org
f0fd9914f3 Very minor HTML tweaking.
git-svn-id: svn://10.0.0.236/trunk@58463 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-24 05:50:46 +00:00