travis%sedsystems.ca
3bfdd4d4f2
Bug 283139 : Zero out 'hours remaining' field on certain state transitions r.t. throwing an error saying it's not zeroed out.
...
Patch by Shane H. W. Travis <travis@sedsystems.ca> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@169998 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-28 18:55:07 +00:00
mkanat%kerio.com
de89702d36
Bug 282748: uninitialized value in localtime in Format.pm
...
Patch By Frederic Buclin <LpSolit@gmail.com> r=wurblzap, a=myk
git-svn-id: svn://10.0.0.236/trunk@169818 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-25 03:28:02 +00:00
travis%sedsystems.ca
691455c5d9
Bug 212940 : Can't use an undefined value as an ARRAY reference at /http/bugzilla/process_bug.cgi line 866.
...
Patch by Frederic Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@169646 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-23 16:53:24 +00:00
mkanat%kerio.com
fe14d8a2d1
Bug 280497: Replace "LIMIT" with Bugzilla::DB function call
...
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=justdave
git-svn-id: svn://10.0.0.236/trunk@169390 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 16:14:27 +00:00
mkanat%kerio.com
a88c76e484
Bug 280503: Replace "LOCK/UNLOCK TABLES" with Bugzilla::DB function call
...
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=myk
git-svn-id: svn://10.0.0.236/trunk@169333 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 21:57:27 +00:00
mkanat%kerio.com
98056cd489
Bug 281592: "use Bugzilla::RelationSet" in globals.pl and process_bug.cgi is dead code r=vladd, a=myk
...
git-svn-id: svn://10.0.0.236/trunk@169252 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-16 16:14:36 +00:00
travis%sedsystems.ca
81f64817cf
Bug 257315 : type of delta_ts in bugs table should not be timestamp
...
Patch by Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@168981 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-08 16:51:03 +00:00
travis%sedsystems.ca
8a81a01901
Bug 276838 : Eliminate use of $::unconfirmedstate
...
Patch by Max Kanat-Alexander <mkanat@kerio.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@168979 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-08 16:22:26 +00:00
travis%sedsystems.ca
64284ff52f
Bug 279740 : Move CountOpenDependencies out of globals.pl
...
Patch by Max Kanat-Alexander <mkanat@kerio.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@168643 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-01 17:43:26 +00:00
travis%sedsystems.ca
92492b41de
Bug 279700 : Move GetComments from globals.pl into Bugzilla::Bug
...
Patch by Max Kanat-Alexander <mkanat@kerio.com> r=vladd a=justdave
git-svn-id: svn://10.0.0.236/trunk@168550 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-31 16:32:57 +00:00
justdave%bugzilla.org
2541fed321
Backing out the checking from bug 257315 until it gets corrected. It prevents new bugs from being filed.
...
a=justdave
git-svn-id: svn://10.0.0.236/trunk@168520 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-30 04:22:28 +00:00
travis%sedsystems.ca
e652a2da94
Bug 257315 : type of delta_ts in bugs table should not be timestamp
...
Patch by Tomas Kopal <Tomas.Kopal@altap.cz> r=vladd, LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@168456 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-28 19:01:28 +00:00
travis%sedsystems.ca
cd62d4adef
Bug 218771 : The error message should be more accurate on who can change fields
...
Patch by Frederic Buclin <LpSolit@gmail.com> r=myk a=myk
git-svn-id: svn://10.0.0.236/trunk@168401 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-27 19:17:10 +00:00
travis%sedsystems.ca
b413ed388e
Bug 34488: Add a checkbox to add self to CC list
...
Patch by GavinS <bugzilla@chimpychompy.org> r=vladd, myk a=myk
git-svn-id: svn://10.0.0.236/trunk@168225 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-24 05:26:56 +00:00
travis%sedsystems.ca
0170d97491
Bug 266579 : Users without privs can confirm bugs by assigning to themselves first, without having canconfirm privs
...
Patch by LpSolit@gmail.com r=myk a=justdave
git-svn-id: svn://10.0.0.236/trunk@168095 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-20 23:22:10 +00:00
jocuri%softhome.net
297b1c2147
Patch for bug 103636: Support specifying a date on which a bug is expected to be resolved; patch by Alexandre Michetti Manduca <michetti@grad.icmc.usp.br>, r=jouni, a=myk.
...
git-svn-id: svn://10.0.0.236/trunk@167817 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 13:36:05 +00:00
jocuri%softhome.net
d11f7f6055
Patch for bug 277622: Move DiffStrings() out of globals.pl into Bugzilla/Util.pm; patch by Max K-A <mkanat@kerio.com>, r=vladd, a=myk.
...
git-svn-id: svn://10.0.0.236/trunk@167812 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 13:02:35 +00:00
travis%sedsystems.ca
32d3e62f85
Bug 277621 : Uninitialized value message when changing timetracking fields
...
Patch by Marc Schumann <wurblzap@gmail.com> r=justdave a=justdave
git-svn-id: svn://10.0.0.236/trunk@167734 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-14 16:32:15 +00:00
jake%bugzilla.org
a3ab1de813
Bug 264601 - Bugzilla will now tell a user which field contained an "invalid bug number or alias."
...
Patch by Frédéric Buclin <LpSolit@netscape.net>
r=myk, a=justdave
git-svn-id: svn://10.0.0.236/trunk@166909 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-21 09:04:01 +00:00
jocuri%softhome.net
22e4b3570a
Patch for bug 274236: Variable component overlaps in ThrowCodeError; patch by me, r=wurblzap (Marc), a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@166689 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-14 01:59:59 +00:00
jocuri%softhome.net
aecbadf98b
Patch for bug 271797: avoid making target_milestone empty if usetargetmilestone=1; patch by Frédéric Buclin <LpSolit@netscape.net>, r=justdave, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@166484 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-09 10:49:53 +00:00
jocuri%softhome.net
930f674f5e
Patch for bug 258711: move.pl should honour emailsuffix; patch by Marc Schumann <wurblzap@gmail.com>, r=justdave, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@166321 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-06 17:08:20 +00:00
jocuri%softhome.net
3be7f3bfa1
Patch for bug 267560: CheckCanChangeField in process_bug.cgi shouldn't request the bug owner, QA contact and reporter too many times; patch by Frédéric Buclin <LpSolit@netscape.net>, r=justdave, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@165543 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-20 12:31:04 +00:00
jocuri%softhome.net
8610d5bf4e
Patch for bug 267774: Remove unused variable in process_bug.cgi; patch by Frédéric Buclin <LpSolit@netscape.net>; r=kiko, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@164995 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-05 08:58:03 +00:00
justdave%bugzilla.org
4da516c042
[SECURITY] Bug 252638: It is possible to send a carefully crafted HTTP POST message to process_bug.cgi which will remove keywords from a bug even if you don't have permissions to edit all bug fields (the "editbugs" permission). Such changes are reported in "bug changed" email notifications, so they are easily detected and reversed if someone abuses it.
...
Patch by Myk Melez <myk@mozilla.org>
r=gerv, a=justdave
git-svn-id: svn://10.0.0.236/trunk@164336 18797224-902f-48f8-a5cc-f745e15eee43
2004-10-25 07:20:59 +00:00
justdave%bugzilla.org
46e9d71358
Bug 254498: Check for comment required for time validation was too late.
...
Patch by Tiago R. Mello <tiago@async.com.br>
r=kiko, a=justdave
git-svn-id: svn://10.0.0.236/trunk@164324 18797224-902f-48f8-a5cc-f745e15eee43
2004-10-25 04:49:32 +00:00
bugreport%peshkin.net
cd65dc04d7
Bug 186093: Move CanSeeBug to User.pm and make User.pm usable by templates
...
r=kiko
a=justdave
git-svn-id: svn://10.0.0.236/trunk@160350 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-04 16:17:10 +00:00
jocuri%softhome.net
2336c8c696
Patch for bug 253604: When commit a bug, validate timetracking before user match; patch by Tiago R. Mello <tiago@async.com.br>; r=kiko, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@160268 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-03 06:23:25 +00:00
jocuri%softhome.net
23204eca2d
Patch for bug 253360: replace IF() with CASE WHEN for database compatibility; patch by Tomas Kopal <Tomas.Kopal@altap.cz>; r=vladd, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@160170 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-31 09:36:18 +00:00
kiko%async.com.br
e3ff662f81
Fix for bug 216008: Time Tracking: default values cause change bug
...
errors. Check if the time values haven't actually changed by using integer comparison (instead of string comparison). r=jouni, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@160020 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-29 03:09:10 +00:00
kiko%async.com.br
a89fa3803a
Fix for bug 252789: Empty timetrackinggroup causes error "hours worked
...
needs to be positive" when changing bug. Sanitizing the AddComment bits
in process_bug.cgi to only touch work_time if user is in
timetrackinggroup. Fixes regression introduced in bug 252159.
r=jouni,joel; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@160017 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-29 02:59:11 +00:00
kiko%async.com.br
ce412f90e2
Fix for bug 252159: centralize time validation. Adds a ValidateTime
...
function to Bugzilla::Bug and uses it in relevant callsites. Patch by
Alexandre Michetti Manduca <michetti@grad.icmc.usp.br>. r=kiko, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@159666 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-22 17:48:37 +00:00
kiko%async.com.br
f1789c492a
Fix for bug 251935: Remove $COOKIE from process_bug.cgi. r=joel, a=myk.
...
git-svn-id: svn://10.0.0.236/trunk@159553 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-20 21:25:33 +00:00
gerv%gerv.net
76b9955c30
Bug 240093 - get canconfirm working again. Patch by gerv; r=joel, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@159396 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-17 16:09:28 +00:00
jocuri%softhome.net
15cc92865e
Patch for bug 242161: make process_bug.cgi contain patchviewer ("diff") link like show_bug.cgi; patch by GavinS <bugzilla@chimpychompy.org>; r=vladd; a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@157231 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-01 12:53:27 +00:00
gerv%gerv.net
0ee626b3f2
Bug 237838 - make sure CheckCanChangeField() always gets correct resolution. Patch by gerv and Tom Karzes; r, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@155604 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-27 22:28:06 +00:00
timeless%mozdev.org
50995530ac
Bug 192571 Empty default owner (assignee or QA) causes "Reassign bug to owner and QA contact of selected component to NOOP
...
r=justdave a=justdave
git-svn-id: svn://10.0.0.236/trunk@155330 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-22 14:42:14 +00:00
kiko%async.com.br
319f68a68e
Fix for bug 234175: Remove deprecated ConnectToDatabase() and
...
quietly_check_login()/confirm_login() calls. Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.
git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
justdave%syndicomm.com
f32788afb7
Bug 24496: Adds a parameter "noresolveonopenblockers" which when enabled, prevents bugs from being closed if there are any bugs blocking it which are still open.
...
Patch by Andreas Höfler <andreas.hoefler@bearingpoint.com>
r= justdave, a= myk
git-svn-id: svn://10.0.0.236/trunk@154079 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-18 05:55:41 +00:00
justdave%syndicomm.com
e099454c93
Bug 192516: Moving the loose .pm files into the Bugzilla directory, where they belong. These files pre-date the Bugzilla directory, and would have gone there had it existed at the time. The four files in question were copied on the CVS server to preserve CVS history in the files. This checkin deletes them from the old location and modifies everything else to know where they are now.
...
r= myk, gerv
a= justdave
git-svn-id: svn://10.0.0.236/trunk@154078 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-18 03:57:05 +00:00
gerv%gerv.net
b1374b038a
Bug 233645 - fix a number of 'undef' warnings which were killing performance for multiple bug change. Patch by gerv; r,a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@152765 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-13 20:24:51 +00:00
jocuri%softhome.net
75fce9c684
Bug 219475: The check for null db entries in process_bug.cgi is wrong; patch by Chuck Duvall <caduvall@glue.umd.edu>; r=bbaetz; a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@148968 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-07 08:05:01 +00:00
jocuri%softhome.net
a0d7e28441
Bug 223854: masscc on change several bugs doesn't honor usermatchmode; patch by Jon <kniht@us.ibm.com>; r=myk; a=myk.
...
git-svn-id: svn://10.0.0.236/trunk@148459 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-28 06:37:40 +00:00
jocuri%softhome.net
312fe61923
Bug 218977: "Table 'namedqueries' was not locked with LOCK TABLES" on ThrowUserError('product_edit_denied'); r=bbaetz; a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@148125 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-19 08:46:39 +00:00
justdave%syndicomm.com
82642e719e
Correcting the previous backout attempt, apparrently typoed a version number last time
...
git-svn-id: svn://10.0.0.236/trunk@148053 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-17 02:07:55 +00:00
justdave%syndicomm.com
ec2098df1b
Backing out patch from bug 108528 - failed to take i10n concerns into account
...
git-svn-id: svn://10.0.0.236/trunk@148034 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-16 18:26:09 +00:00
timeless%mozdev.org
72f2fe28cc
Bug 108528 - knob is not defined doesn't explain to 2001110503 users what to do
...
patch by caduvall@glue.umd.edu r=timeless a=justdave
git-svn-id: svn://10.0.0.236/trunk@148005 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-15 22:48:12 +00:00
jocuri%softhome.net
925257fbb9
Bug 220034: empty form after changing bug details; patch by wicked@etlicon.fi (Teemu Mannermaa); r=kiko, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@147923 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-13 21:38:13 +00:00
timeless%mozdev.org
396a5751e1
Bug 221264 Making no changes shouldn't affect Last modified
...
r=joel a=justdave
git-svn-id: svn://10.0.0.236/trunk@147671 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-07 05:59:30 +00:00
bbaetz%acm.org
7d7d7e1532
Bug 208699 - Move Throw{Code,Template}Error into Error.pm
...
r,a=justdave
git-svn-id: svn://10.0.0.236/trunk@146857 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-14 06:05:23 +00:00