100 Commits

Author SHA1 Message Date
lpsolit%gmail.com
9915b17fce Bug 307524: Templatise the updategroupcontrols bit of editproducts.cgi (and tidy up templatisation) - Original patch by André Batosti <batosti@async.com.br> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@180403 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-16 16:14:18 +00:00
lpsolit%gmail.com
529ea73dda Bug 304696: Replace UserInGroup() by $user->in_group() when checking user privs in edit*.cgi files - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@180314 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-15 22:01:56 +00:00
lpsolit%gmail.com
71b4387eec Bug 308150: admin/products/deleted.html.tmpl doesn't include admin/products/footer.html.tmpl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=GavinS a=justdave
git-svn-id: svn://10.0.0.236/trunk@180042 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-12 19:10:48 +00:00
lpsolit%gmail.com
22d6af2664 Bug 306757: Templatize the 'new' section of editproducts.cgi - Patch by Gabriel Sales de Oliveira <gabriel@async.com.br> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@180024 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-12 13:50:42 +00:00
lpsolit%gmail.com
4feec5cf41 Bug 306242: Templatize the 'update product' bit of editproducts.cgi - Patch by GavinS <bugzilla@chimpychompy.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@179850 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-08 16:58:57 +00:00
lpsolit%gmail.com
214b8ddb06 Bug 302370: Remove the EmitFormElements() routine from editproducts.cgi and templatize that code - Patch by Gabriel Sales de Oliveira <gabriel@async.com.br> r=LpSolit a=myk
git-svn-id: svn://10.0.0.236/trunk@179505 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-01 21:33:07 +00:00
lpsolit%gmail.com
8aefebbbf6 Bug 306060: Adding a new product should make it clear that a component is also required to enter bugs - Patch by Greg Hendricks <ghendricks@novell.com> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@179091 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-26 20:13:07 +00:00
lpsolit%gmail.com
8b488047d1 Bug 303366: Possible locking tables conflict when voting for bugs - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@178680 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-23 12:17:17 +00:00
mkanat%kerio.com
0cbbdcfee7 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177695 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-13 12:27:04 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
bugreport%peshkin.net
9778732be8 Backout of bug 303669 which broke AppendComment and possibly a number
of other items.


git-svn-id: svn://10.0.0.236/trunk@177419 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 11:23:43 +00:00
mkanat%kerio.com
7bbde62ad3 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177413 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 05:59:02 +00:00
lpsolit%gmail.com
3900c1f7e8 Bug 301507: Move PutHeader and PutFooter into Template.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=justdave
git-svn-id: svn://10.0.0.236/trunk@176432 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-22 05:13:36 +00:00
lpsolit%gmail.com
0fe0eea8c8 Bug 300699: Remove dead code from editproducts.cgi and messages.html.tmpl - Patch by Marc Schumann <wurblzap@gmail.com> r=LpSolit a=myk
git-svn-id: svn://10.0.0.236/trunk@176065 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-14 00:11:59 +00:00
lpsolit%gmail.com
56d8a3ec04 Bug 300620: Deletion of a product yields "Insecure dependency in parameter 3" when useclassification is on - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=myk
git-svn-id: svn://10.0.0.236/trunk@176018 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-13 17:58:00 +00:00
lpsolit%gmail.com
75110cc6d4 Bug 289580: Templatize the 'confirm delete' bit of editproducts.cgi - Patch by Tiago R. Mello <timello@async.com.br> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@175784 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-07 21:03:05 +00:00
lpsolit%gmail.com
2f9cff6fac Bug 252214: Allow max of zero votes per bug - Patch by Alfred Karl Kornel <kornel.1@osu.edu> r=vladd a=justdave
git-svn-id: svn://10.0.0.236/trunk@174177 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-06 21:42:02 +00:00
lpsolit%gmail.com
42b8d67eb5 Bug 294368: Wrong tense used in sentence in delete components/products - Patch by Tiago R. Mello <tiago@async.com.br> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@173491 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-16 23:39:17 +00:00
lpsolit%gmail.com
070811f7c3 Bug 287136: Missing validations in editproducts.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel a=justdave
git-svn-id: svn://10.0.0.236/trunk@172996 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-03 18:32:58 +00:00
mkanat%kerio.com
f816662428 Bug 289043: Implicit joins should be replaced by explicit joins - installment C
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@172957 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-02 18:52:02 +00:00
lpsolit%gmail.com
559a76b023 Bug 290511: Move RemoveVotes() out of globals.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@172352 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-16 17:17:06 +00:00
lpsolit%gmail.com
4b4bec4feb Bug 289373: Remove %FORM from editproducts.cgi - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@171900 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-08 23:51:02 +00:00
lpsolit%gmail.com
9e4a52fdf0 Bug 86328: Deleting bugs doesn't delete dependent records properly - Patch by Frederic Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@171752 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-06 00:19:56 +00:00
lpsolit%gmail.com
8e17f9e364 Bug 272321: action should default to edit in editproducts.cgi if a product is passed without an action - Patch by Frederic Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@171072 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-23 21:24:19 +00:00
lpsolit%gmail.com
4789b84732 Bug 282384: Templatize the 'select classification' bit of editproducts - Patch by GavinS <bugzilla@chimpychompy.org> r=LpSolit, a=justdave
git-svn-id: svn://10.0.0.236/trunk@170838 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-17 14:47:06 +00:00
mkanat%kerio.com
fda3b0dd8f Bug 174295: ANSI SQL requires all columns in SELECT to be in GROUP BY, unless they are in "aggregate" functions
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@170751 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-16 00:27:15 +00:00
travis%sedsystems.ca
7351a5b76b Bug 283581 : Move UserInGroup out of globals.pl
Patch by Colin Ogilvie <colin.ogilvie@gmail.com>   r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170734 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 22:10:14 +00:00
mkanat%kerio.com
1194a36cb5 Bug 285692: lastdiffed should use NULL instead of the "beginning of time"
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=glob, a=myk


git-svn-id: svn://10.0.0.236/trunk@170574 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-11 19:45:03 +00:00
mkanat%kerio.com
b7fd576c4c Bug 285678: NOT(integer) not supported by postgres
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=myk


git-svn-id: svn://10.0.0.236/trunk@170567 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-11 19:06:11 +00:00
mkanat%kerio.com
64adf228bd Bug 284975: Any code after Throw*Error is a dead code.
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@170414 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-09 00:26:39 +00:00
mkanat%kerio.com
c8f7e44c64 Bug 280494: Replace "SELECT LAST_INSERT_ID()" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@169387 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 16:01:48 +00:00
mkanat%kerio.com
a88c76e484 Bug 280503: Replace "LOCK/UNLOCK TABLES" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=myk


git-svn-id: svn://10.0.0.236/trunk@169333 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 21:57:27 +00:00
mkanat%kerio.com
e38433402f Bug 280412: Templatize the 'list products' bit of editproducts
Patch By Gavin Shelly <bugzilla@chimpychompy.org> r=wurblzap, a=myk


git-svn-id: svn://10.0.0.236/trunk@169269 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-16 18:05:06 +00:00
travis%sedsystems.ca
81f64817cf Bug 257315 : type of delta_ts in bugs table should not be timestamp
Patch by Tomas Kopal <Tomas.Kopal@altap.cz>  r=mkanat, LpSolit   a=justdave


git-svn-id: svn://10.0.0.236/trunk@168981 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-08 16:51:03 +00:00
travis%sedsystems.ca
8a81a01901 Bug 276838 : Eliminate use of $::unconfirmedstate
Patch by Max Kanat-Alexander <mkanat@kerio.com>  r=wurblzap  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168979 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-08 16:22:26 +00:00
justdave%bugzilla.org
2541fed321 Backing out the checking from bug 257315 until it gets corrected. It prevents new bugs from being filed.
a=justdave


git-svn-id: svn://10.0.0.236/trunk@168520 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-30 04:22:28 +00:00
travis%sedsystems.ca
e652a2da94 Bug 257315 : type of delta_ts in bugs table should not be timestamp
Patch by Tomas Kopal <Tomas.Kopal@altap.cz>   r=vladd, LpSolit  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168456 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-28 19:01:28 +00:00
jocuri%softhome.net
6e30566dcd Patch for bug 265898: edit*.cgi files should all use ThrowUserError(); patch by Frédéric Buclin <LpSolit@gmail.com>, r=vladd, a=myk.
git-svn-id: svn://10.0.0.236/trunk@167820 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 14:07:31 +00:00
jocuri%softhome.net
e149a69487 Patch for bug 240250: Shouldn't receive an unfriendly error when editing groupset for a product that doesn't exist; patch by Frédéric Buclin <LpSolit@netscape.net>, r=mkanat, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@167419 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-08 18:15:46 +00:00
jocuri%softhome.net
7e6d611422 Patch for bug 271474: Fix SQL syntax error when updating max votes per bug in editproducts.cgi and questionable activity log entries when an admin changes the votes-to-confirm setting to a lower value and bugs get confirmed by popular vote; patch by Nick.Barnes@pobox.com, r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@166602 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-11 13:34:03 +00:00
jocuri%softhome.net
abed40a375 Patch for bug 254729: fix editproducts.cgi generated warnings in the error log when creating new products; patch by GavinS <bugzilla@chimpychompy.org>; r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@161947 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-08 22:53:39 +00:00
gerv%gerv.net
7633e9d6ae Bug 225687 - add group controls to charts, along with various other cleanups. Patch by gerv; r=joel, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@161457 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-29 21:29:36 +00:00
bugreport%peshkin.net
967204e8ec Bug 224208 Add a higher level of categorization (.ie departments, locations, etc.)
patch by Albert Ting
r=joel, glob
a=myk


git-svn-id: svn://10.0.0.236/trunk@161078 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-20 21:49:20 +00:00
bugreport%peshkin.net
1b0c07d9df Bug 251837: Extend group_group_map to control which groups can see each other
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159914 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-27 16:33:41 +00:00
bugreport%peshkin.net
3f5ac54b70 Bug 252450: Unlock tables in edit*.cgi before sending trailer
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159908 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-27 15:13:48 +00:00
jouni%heikniemi.net
1f1c51ed9a Bug 86051: Enable changing product name case.
Patch by GavinS <bugzilla@chimpychompy.org>
r=jouni, a=justdave


git-svn-id: svn://10.0.0.236/trunk@159529 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-20 05:06:18 +00:00
bugreport%peshkin.net
a39ec3024b Bug 251484: Fix taint error on series create when creating a new product
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159379 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-17 01:57:14 +00:00
jocuri%softhome.net
23cded33da Patch for bug 250265: fix taint issues with vote fields when editing products; patch by GavinS <bugzilla@chimpychompy.org> slightly updated by me; r=joel; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@158925 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-08 20:08:55 +00:00
jocuri%softhome.net
466224da90 Patch for bug 250259: Fix taint error on disallownew field in editproducts.cgi; patch by GavinS <bugzilla@chimpychompy.org>; r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@158881 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-07 23:49:41 +00:00
bugreport%peshkin.net
1462c2bf7e Bug 243463 Use a param to protect new charts from leaking information
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@158775 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-06 01:12:29 +00:00