Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
167,522 Commits 3,986 Branches 0 Tags
436e15359e923239ba25260f30f8009827e2dbb8
Commit Graph

22 Commits

Author SHA1 Message Date
benjamin%smedbergs.us
0be7f89d03 Resubmitting this patch, which adds a editing for livemark URIs as well 
as fixing a few small livemark bugs, now that I've fixed a couple reference
leaks in nsLivemarkService (see bugs 333764 and 333784).

NOTE: I expect this to cause an increase in allocations on branch balsa,
since it causes nsLivemarkService to be instantiated to set up the menus.
(nsLivemarkService previously wasn't used in the balsa bloat test)

bug=330063
r=annie.sullivan@gmail.com
sr=ben@mozilla.org

Original committer: joe%retrovirus.com
Original revision: 1.22
Original date: 2006/04/13 17:19:18


git-svn-id: svn://10.0.0.236/trunk@202474 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:19:08 +00:00
benjamin%smedbergs.us
161d64f12d Bug 332143 r=brettw sr=beng (checkin for pamg) New livemarks don't get proper icon in toolbar. 
Original committer: brettw%gmail.com
Original revision: 1.21
Original date: 2006/04/13 16:35:49


git-svn-id: svn://10.0.0.236/trunk@202473 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:18:45 +00:00
benjamin%smedbergs.us
b6d2816e7a Adds a nsCOMArray version of a function in the annotation service, and 
changes some code in nsLivemarkService::Init to use it, which gets rid
of a handful of nsSimpleURI reference leaks when using the LivemarkService.

bug=333784
r=brettw@google.com
sr=bryner@brianryner.com

Original committer: joe%retrovirus.com
Original revision: 1.20
Original date: 2006/04/13 03:05:50


git-svn-id: svn://10.0.0.236/trunk@202472 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:18:22 +00:00
benjamin%smedbergs.us
8f5f7fff90 Fixed some leaked references in nsLivemarkService by changing leaky pointers 
to member nsCOMPtrs, updated usage in nsBookmarksFeedHandler.
(Note that Annie copied this code from the non-Places livemark code,
 so this problem likely still exists there.)

bug=333764
r=darin@meer.net
sr=bryner@brianryner.com

Original committer: joe%retrovirus.com
Original revision: 1.19
Original date: 2006/04/12 20:47:30


git-svn-id: svn://10.0.0.236/trunk@202471 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:17:59 +00:00
benjamin%smedbergs.us
daa25871af Bug 333754 r=annie.sullivan Comment out untested parts of the container API so we aren't stuck with it if it never gets coverage. If a need arises, we can uncomment and test. 
Original committer: brettw%gmail.com
Original revision: 1.18
Original date: 2006/04/12 20:22:39


git-svn-id: svn://10.0.0.236/trunk@202470 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:17:36 +00:00
benjamin%smedbergs.us
3b8d9a3cb4 Backing out patch from bug 330063 to see if it's responsible for the 
branch balsa allocation increases, and if so, fix before resubmitting.

Original committer: joe%retrovirus.com
Original revision: 1.17
Original date: 2006/04/08 17:58:16


git-svn-id: svn://10.0.0.236/trunk@202469 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:17:13 +00:00
benjamin%smedbergs.us
39819ee8be * Added ability to edit Live Bookmark feed & site URIs in Bookmark Properties dialog 
* Fixed a setFeedURI bug in the LivemarkService
* Fixed problems that broke the toolbar when a live bookmark had no site URI
* Converted some browser UI code to use LivemarkService methods rather than manipulating the annotations directly

bug=330063
r=annie.sullivan@gmail.com
sr=ben@mozilla.org

Original committer: joe%retrovirus.com
Original revision: 1.16
Original date: 2006/04/06 23:25:36


git-svn-id: svn://10.0.0.236/trunk@202468 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:16:50 +00:00
benjamin%smedbergs.us
19f9ed9e95 Adds some livemark-handling functions to nsILivemarkService, fixes a bug 
on moving a livemark that doesn't have a site URI.

bug=332617
r=brettw
sr=darin

Original committer: joe%retrovirus.com
Original revision: 1.15
Original date: 2006/04/05 02:22:23


git-svn-id: svn://10.0.0.236/trunk@202467 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:16:27 +00:00
benjamin%smedbergs.us
b55d2cef51 followup patch for bug 329634 "folder IDs are 64-bit integers" patch by pamg, r=darin 
Original committer: darin%meer.net
Original revision: 1.14
Original date: 2006/04/04 01:57:38


git-svn-id: svn://10.0.0.236/trunk@202466 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:16:04 +00:00
benjamin%smedbergs.us
e43be5ffdc fixes bug 329634 "No apparent way to Reload Live Bookmark (or update livemarks)" patch by pamg, r=annie, sr=beng 
Original committer: darin%meer.net
Original revision: 1.13
Original date: 2006/04/04 00:32:33


git-svn-id: svn://10.0.0.236/trunk@202465 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:15:41 +00:00
benjamin%smedbergs.us
c49fa451b7 329169 - leaked livemark service on shutdown... break cycle with load channels by canceling loads on xpcom-shutdown rather than in the livemark service's dtor, which will never fire due to circular references. r=bryner 
Original committer: beng%bengoodger.com
Original revision: 1.12
Original date: 2006/03/03 05:14:34


git-svn-id: svn://10.0.0.236/trunk@202464 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:15:18 +00:00
benjamin%smedbergs.us
3ad6ab8764 Fixed icon uris broken in browser shim removal. bug=328543 r=ben@mozilla.org 
Original committer: annie.sullivan%gmail.com
Original revision: 1.11
Original date: 2006/02/28 22:43:46


git-svn-id: svn://10.0.0.236/trunk@202463 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:14:55 +00:00
benjamin%smedbergs.us
c477cae2a9 Bug 326432, r=annie.sullivan Bookmarks batches are transactions, livemarks 
performance bug fixes.

Original committer: brettw%gmail.com
Original revision: 1.10
Original date: 2006/02/08 21:07:59


git-svn-id: svn://10.0.0.236/trunk@202462 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:14:32 +00:00
benjamin%smedbergs.us
6f55a75703 Bug 325161 r=annie.sullivan Make all nsINavHistoryResultNodes support URI attribute, remove nsINavHistoryURIResultNode. 
Original committer: brettw%gmail.com
Original revision: 1.9
Original date: 2006/02/07 01:56:36


git-svn-id: svn://10.0.0.236/trunk@202461 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:14:09 +00:00
benjamin%smedbergs.us
9d1ee3fbb8 bug=325169 r=brettw@gmail.com keywords=fixed1.8.1 Fix Livemark icons 
Original committer: annie.sullivan%gmail.com
Original revision: 1.8
Original date: 2006/02/01 02:13:33


git-svn-id: svn://10.0.0.236/trunk@202460 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:13:46 +00:00
benjamin%smedbergs.us
a9017f7f51 Adds an annotation to livemarked uris. 
bug=324556 r=brettw

Original committer: annie.sullivan%gmail.com
Original revision: 1.7
Original date: 2006/01/27 00:56:11


git-svn-id: svn://10.0.0.236/trunk@202459 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:13:23 +00:00
benjamin%smedbergs.us
2e38120f83 Bug 324553, r=bryner. Finish remote container API plus manay misc fixes and cleanup. 
Original committer: brettw%gmail.com
Original revision: 1.6
Original date: 2006/01/26 20:24:25


git-svn-id: svn://10.0.0.236/trunk@202458 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:13:00 +00:00
benjamin%smedbergs.us
f8afa86cd6 Fix crashes when adding livemarks due to the stream listener referencing freed memory. This changes the LivemarkInfo objects to be refcounted and heap-allocated, and also adds a loadgroup for each channel so that we can reliably cancel the loads. Also, null check the site URI since this field is optional. Bug 323472, r=annie sr=darin 
Original committer: bryner%brianryner.com
Original revision: 1.5
Original date: 2006/01/25 22:59:53


git-svn-id: svn://10.0.0.236/trunk@202457 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:12:37 +00:00
benjamin%smedbergs.us
2613ed6888 Make read-onlyness of a folder's children be determined by the nsIBookmarksContainer that's responsible for the folder, not necessarily by a per-folder annotation. Bug 320667, r=annie.sullivan. 
Original committer: bryner%brianryner.com
Original revision: 1.4
Original date: 2006/01/04 20:49:30


git-svn-id: svn://10.0.0.236/trunk@202456 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:12:14 +00:00
benjamin%smedbergs.us
4f5e2fad4c Made OnContainerMoved() return NS_OK; 
Original committer: annie.sullivan%gmail.com
Original revision: 1.3
Original date: 2005/12/16 01:15:00


git-svn-id: svn://10.0.0.236/trunk@202455 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:11:51 +00:00
benjamin%smedbergs.us
521127e414 Fixed compile error on linux (scope when declaring a var inside a for loop) 
Original committer: annie.sullivan%gmail.com
Original revision: 1.2
Original date: 2005/12/15 23:02:04


git-svn-id: svn://10.0.0.236/trunk@202454 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:11:29 +00:00
benjamin%smedbergs.us
6adcdfc49d Added nsIBookmarksContainer interface which allows custom bookmarks types. 
Implemented nsILivemarksService as a nsIBookmarksContainer.
bug=317837 r=beng sr=bryner

This file was copied in CVS from the following location:
mozilla/browser/components/places/src/nsLivemarkService.cpp
Original committer: annie.sullivan%gmail.com
Original revision: 1.1
Original date: 2005/12/15 20:56:18


git-svn-id: svn://10.0.0.236/trunk@202453 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-18 15:11:06 +00:00