Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
152,674 Commits 3,986 Branches 0 Tags
484b5f6acb271fec79ff3fa5ecc2262dfeeb87b8
Commit Graph

43 Commits

Author SHA1 Message Date
relyea%netscape.com
493a0a3758 Bug 225034 Certificate Manager Crashes Mozilla [@ nsCertTree::CmpByCrit] 
sr=brendan r=wtc a=dbaron

The issue is the use of the PL_DHash* functions. It's possible that a given call
to PL_DHashOperate which adds a new entry may cause the hash table to expand,
and all the existing entries to be reallocated. PL_DHash does this by allocating
new memory, then copying the entries.

getCacheEntry() returns one of these hash entries. CmpBy() makes two consecutive
calls to getCacheEntry, then uses the returned entries for it's comparisons. If
the second entry call causes a new entry to be added to the table, and causes
the hash table to expand, the pointer to the first entry we retrieved will point
to freed memory.

The fix is to make the usable entry a pointer in the hashtable entry, and return
that pointer. When the hashtable rebuilds it's entries, the pointer will be
copied to the new entry and not be disturbed.


git-svn-id: svn://10.0.0.236/trunk@177782 18797224-902f-48f8-a5cc-f745e15eee43
 2005-08-15 21:23:51 +00:00
timeless%mozdev.org
d45261fa03 Bug 225034 Certificate Manager Crashes Mozilla [@ nsCertTree::CmpByCrit] 
patch by kaie r=timeless sr=darin a=shaver


git-svn-id: svn://10.0.0.236/trunk@174710 18797224-902f-48f8-a5cc-f745e15eee43
 2005-06-16 17:27:17 +00:00
dbaron%dbaron.org
5f5aef599f Clean up loop a little. b=225034 r=kaie sr=roc 
git-svn-id: svn://10.0.0.236/trunk@169664 18797224-902f-48f8-a5cc-f745e15eee43
 2005-02-23 20:09:52 +00:00
gerv%gerv.net
43cb9e1492 Bug 236613: change to MPL/LGPL/GPL tri-license. 
git-svn-id: svn://10.0.0.236/trunk@155484 18797224-902f-48f8-a5cc-f745e15eee43
 2004-04-25 15:03:26 +00:00
varga%nixcorp.com
ce53bd6ec2 Fix for bug 221619. Tree widget refactoring and enhancement. r=neil sr=bryner 
git-svn-id: svn://10.0.0.236/trunk@155017 18797224-902f-48f8-a5cc-f745e15eee43
 2004-04-17 05:53:38 +00:00
jgmyers%speakeasy.net
f750abe8b1 Clean up string stuff: bug 232812 r=ssaux sr=jag 
git-svn-id: svn://10.0.0.236/trunk@153266 18797224-902f-48f8-a5cc-f745e15eee43
 2004-02-26 04:07:23 +00:00
timeless%mozdev.org
8af9844c8a Bug 220106 @mozilla.org/security/nsCertTree;1 doesn't null check mTreeArray 
r=kaie sr=bz


git-svn-id: svn://10.0.0.236/trunk@148027 18797224-902f-48f8-a5cc-f745e15eee43
 2003-10-16 15:33:56 +00:00
timeless%mozdev.org
b031ecd7d5 Bug 211291 void nsCertTree::InitCompareHash doesn't check the return value of PL_DHashTableInit 
r=kaie sr=bz


git-svn-id: svn://10.0.0.236/trunk@146710 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-11 01:59:21 +00:00
neil%parkwaycc.co.uk
6593e9b14e Bug 211695 Fix bugs in nsCertTree.cpp r=varga sr=alecf moa=kaie a=asa 
git-svn-id: svn://10.0.0.236/trunk@145909 18797224-902f-48f8-a5cc-f745e15eee43
 2003-08-12 11:20:50 +00:00
brendan%mozilla.org
95220b5330 Add shared DHashTableOps for [const] char *key use-cases, clean up dhash API abusages (214839, r=dougt, sr=dbaron). 
git-svn-id: svn://10.0.0.236/trunk@145624 18797224-902f-48f8-a5cc-f745e15eee43
 2003-08-05 20:09:21 +00:00
kaie%netscape.com
f94f02d55a b=189205 Implement early shutdown of NSS resources 
r=javi sr=darin


git-svn-id: svn://10.0.0.236/trunk@136592 18797224-902f-48f8-a5cc-f745e15eee43
 2003-01-18 14:03:00 +00:00
dbaron%dbaron.org
186eca206d Bug 178643: Remove uses of NS_INIT_ISUPPORTS, since it is no longer needed. r=timeless sr=jag 
git-svn-id: svn://10.0.0.236/trunk@136023 18797224-902f-48f8-a5cc-f745e15eee43
 2003-01-08 22:45:23 +00:00
kaie%netscape.com
5715a6d3b9 b=168450 Cleanup some PSM code and add JavaDoc documentation to all freeze candidates 
r=javi sr=alecf


git-svn-id: svn://10.0.0.236/trunk@133794 18797224-902f-48f8-a5cc-f745e15eee43
 2002-11-14 00:50:02 +00:00
kaie%netscape.com
ff49f29e4b b=170562 Some CA's are blank lines 
r=javi sr=alecf


git-svn-id: svn://10.0.0.236/trunk@131009 18797224-902f-48f8-a5cc-f745e15eee43
 2002-10-02 18:54:21 +00:00
kaie%netscape.com
f7f78f3d94 b=170438 Crash opening cert manager 
r=javi sr=alecf


git-svn-id: svn://10.0.0.236/trunk@130322 18797224-902f-48f8-a5cc-f745e15eee43
 2002-09-24 03:00:37 +00:00
kaie%netscape.com
9ab7f38615 b=169932 Replace wstring with AString in IDL 
r=darin sr=alecf


git-svn-id: svn://10.0.0.236/trunk@130278 18797224-902f-48f8-a5cc-f745e15eee43
 2002-09-23 20:17:16 +00:00
kaie%netscape.com
49287355c4 b=168448 PSM embedding freeze/ step 1/ move stuff & change data types 
r=javi sr=alecf


git-svn-id: svn://10.0.0.236/trunk@129797 18797224-902f-48f8-a5cc-f745e15eee43
 2002-09-17 18:51:22 +00:00
kaie%netscape.com
f37c10c5f5 b=121906 Other People's certs not sorted 
r=javi sr=jag


git-svn-id: svn://10.0.0.236/trunk@128340 18797224-902f-48f8-a5cc-f745e15eee43
 2002-08-28 13:49:52 +00:00
kaie%netscape.com
26c4795231 b=161915 Combine verified and purposes column in certificate manager 
r=javi sr=jag


git-svn-id: svn://10.0.0.236/trunk@128142 18797224-902f-48f8-a5cc-f745e15eee43
 2002-08-26 20:16:25 +00:00
kaie%netscape.com
a3c72acc3c b=157927 Fix memory leaks in nsNSSCertificate.cpp, fix some compiler warnings, do some cleanup. 
r=javi sr=jag


git-svn-id: svn://10.0.0.236/trunk@127939 18797224-902f-48f8-a5cc-f745e15eee43
 2002-08-23 10:40:27 +00:00
kaie%netscape.com
9b3bd6cc32 b=124037 Decrease cert manager loading time. 
r=rangansen/jkeiser sr=alecf


git-svn-id: svn://10.0.0.236/trunk@126509 18797224-902f-48f8-a5cc-f745e15eee43
 2002-08-06 13:25:23 +00:00
kaie%netscape.com
cb90967539 b=74339 Support import of SSL, S/MIME, and CA certs 
r=javi sr=alecf


git-svn-id: svn://10.0.0.236/trunk@126506 18797224-902f-48f8-a5cc-f745e15eee43
 2002-08-06 13:11:15 +00:00
kaie%netscape.com
368f1596b1 b=129067 Deleted certs still appear in Cert Manager. 
r=javi sr=alecf


git-svn-id: svn://10.0.0.236/trunk@121600 18797224-902f-48f8-a5cc-f745e15eee43
 2002-05-16 04:03:19 +00:00
kaie%netscape.com
6057d8ceae b=129067 Backing out unreliable patch. 
See bugzilla for details.
Better patch will be checked in a minute.


git-svn-id: svn://10.0.0.236/trunk@121599 18797224-902f-48f8-a5cc-f745e15eee43
 2002-05-16 03:59:36 +00:00
kaie%netscape.com
e526af6b60 b=129067 Deleted certs still appear in Cert Manager, uses slow workaround, which should get removed once bug 138626 is fixed. 
r=javi sr=alecf


git-svn-id: svn://10.0.0.236/trunk@119664 18797224-902f-48f8-a5cc-f745e15eee43
 2002-04-24 00:51:33 +00:00
kaie%netscape.com
2d7ad41f06 b=139349 Need to use dont_AddRef with GetCertAtIndex 
r=bryner sr=alecf


git-svn-id: svn://10.0.0.236/trunk@119661 18797224-902f-48f8-a5cc-f745e15eee43
 2002-04-24 00:35:05 +00:00
hewitt%netscape.com
7fd03a3524 bugs 110156, 110155 
Removing support for <outliner> tags
Removing <tree> layout code and moving <tree> tags to outliner layout
Convert all usage of <outliner> to tree tags
Convert all usage of <tree> tags to new <tree> syntax or <listbox>
r=cmanske,varga sr=hyatt,sspitzer a=asa

Also includes fixes by Jan Varga (varga@utcruk.sk) for bugs 132020, 133451, 131393, 115894, and 129327


git-svn-id: svn://10.0.0.236/trunk@117710 18797224-902f-48f8-a5cc-f745e15eee43
 2002-03-29 02:46:01 +00:00
alecf%netscape.com
f4ad21ae3a a further nsString api reduction: remove the last case-insensitive PRUnichar*-to-PRUnichar* comparisons, moving to new API, and remove old methods from nsString. r=dougt, sr=jag a=scc 
git-svn-id: svn://10.0.0.236/trunk@116842 18797224-902f-48f8-a5cc-f745e15eee43
 2002-03-19 06:46:56 +00:00
kaie%netscape.com
85f633cd64 b=117148 S/MIME tool fails to find certificate while signing 
r=javi sr=alecf


git-svn-id: svn://10.0.0.236/trunk@112300 18797224-902f-48f8-a5cc-f745e15eee43
 2002-01-16 04:30:55 +00:00
bryner%netscape.com
c540a1d8bf Bug 116499 - convert nsIOutlinerView::GetCellText to return an nsAString, so we can avoid copying strings. r=blake, sr=jag. 
git-svn-id: svn://10.0.0.236/trunk@111160 18797224-902f-48f8-a5cc-f745e15eee43
 2001-12-29 22:05:16 +00:00
javi%netscape.com
c366aafefa Patch for Bug 11080, r=kaie, sr=jag 
Checking in for timeless.  Don't use the negation form of the NS_SUCCEEDED
NS_FAILED macros.


git-svn-id: svn://10.0.0.236/trunk@110411 18797224-902f-48f8-a5cc-f745e15eee43
 2001-12-13 01:17:49 +00:00
rangansen%netscape.com
8598aceb0b r=javi ; sr = hewitt ; bug# 89827 ; adding serial number col to cert manager window 
git-svn-id: svn://10.0.0.236/trunk@107153 18797224-902f-48f8-a5cc-f745e15eee43
 2001-11-03 00:49:35 +00:00
ddrinan%netscape.com
bc18e5bd3c Bug 105526 - Initial landing of PSM S/MIME. Mailnews will land separately. See bug 106507 for that. r=javi, sr=blizzard 
git-svn-id: svn://10.0.0.236/trunk@106745 18797224-902f-48f8-a5cc-f745e15eee43
 2001-10-30 23:52:01 +00:00
jaggernaut%netscape.com
2e1bfd5e94 Fix for bug 75572. Separator support in outliner. patch by Jan Varga <varga@utcru.sk>, r=waterson, sr=hyatt 
git-svn-id: svn://10.0.0.236/trunk@104404 18797224-902f-48f8-a5cc-f745e15eee43
 2001-10-02 05:19:46 +00:00
jaggernaut%netscape.com
51e0dc7a6c Bug 100476: Convert uses of member functions ToNewUnicode, ToNewCString and ToNewUTF8String to their global versions and remove support from nsCString and nsString. r=dbaron, rs=scc 
git-svn-id: svn://10.0.0.236/trunk@104212 18797224-902f-48f8-a5cc-f745e15eee43
 2001-09-29 08:28:41 +00:00
ddrinan%netscape.com
eab52123ee Check in for rangansen. Bug 91453 - double click on cert container text. r=ddrinan,sr=hewitt,a=dbaron 
git-svn-id: svn://10.0.0.236/trunk@102053 18797224-902f-48f8-a5cc-f745e15eee43
 2001-08-31 02:10:00 +00:00
javi%netscape.com
b63ad051c1 Fix for Bug 87654 r=ddrinan sr=blizzard 
Turn off OCSP when painting the Cert Manager because painting
the certificate manager becomes painfully slow whenever OCSP is on.


git-svn-id: svn://10.0.0.236/trunk@100700 18797224-902f-48f8-a5cc-f745e15eee43
 2001-08-10 01:05:57 +00:00
javi%netscape.com
a61bba87d5 Fix for bug 82886, Checking in for Kai Engert 
r=mcgreer, sr=blizzard

Remove unused/confusing column from the Cert Manager.


git-svn-id: svn://10.0.0.236/trunk@100526 18797224-902f-48f8-a5cc-f745e15eee43
 2001-08-07 21:18:10 +00:00
ddrinan%netscape.com
fc606418e1 Fix double free in PSM. Bug#82359, r=javi@netscape.com,sr=blizzard@mozilla.org,a=blizzard@mozilla.org 
git-svn-id: svn://10.0.0.236/trunk@96201 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-01 23:48:53 +00:00
ddrinan%netscape.com
864fce5c40 Get PSM to build under OS/2. Bug #72693 r=ddrinan@netscape.com,r=javi@netscape.com,r=wtc@netscape.com,sr=blizzard@mozilla.org 
git-svn-id: svn://10.0.0.236/trunk@95696 18797224-902f-48f8-a5cc-f745e15eee43
 2001-05-22 21:19:31 +00:00
mcgreer%netscape.com
f977c76e9c fix for bug #80356, certs should be grouped by issuer org 
r=javi, sr=blizzard


git-svn-id: svn://10.0.0.236/trunk@95021 18797224-902f-48f8-a5cc-f745e15eee43
 2001-05-15 19:12:44 +00:00
pinkerton%netscape.com
63b80b371a fix up view with new methods for drag/drop 
git-svn-id: svn://10.0.0.236/trunk@94561 18797224-902f-48f8-a5cc-f745e15eee43
 2001-05-11 02:29:56 +00:00
mcgreer%netscape.com
b0661d4dd5 Checkin for bug #75123. Improves the cert manager to make it look more like the mock-up. Implementation of nsIOutlinerView to improve cert listings. 
r=javi, sr=blizzard


git-svn-id: svn://10.0.0.236/trunk@93577 18797224-902f-48f8-a5cc-f745e15eee43
 2001-05-01 23:23:23 +00:00