2196 Commits

Author SHA1 Message Date
mkanat%bugzilla.org
fd470cc2f7 Bug 583690: (CVE-2010-2759) [SECURITY][PostgreSQL] Bugzilla crashes when viewing a bug if a comment contains 'bug <num>' or 'attachment <num>' where <num> is greater than the max allowed integer
r=mkanat a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260976 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-04 22:22:01 +00:00
mkanat%bugzilla.org
dd954efe6f Bug 450013: (CVE-2010-2757) [SECURITY] Can sudo a user without sending email
r=glob a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260974 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-04 21:52:54 +00:00
mkanat%bugzilla.org
9271f2fe34 Bug 417048: (CVE-2010-2756) [SECURITY] Boolean charts let me query for users being in any given group
r=mkanat a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260972 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-04 21:35:40 +00:00
mkanat%bugzilla.org
a7f6262f2f Bug 583614: Simple Search no longer works
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260968 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-04 17:31:43 +00:00
mkanat%bugzilla.org
2e044913df Bug 584036: _sync_fulltext() not called when (un)setting an existing comment as private
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260965 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-04 00:49:23 +00:00
mkanat%bugzilla.org
10a748cb5c Bug 584021: FILTER txt should also remove &nbsp;
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260962 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-04 00:31:36 +00:00
mkanat%bugzilla.org
4d379c9205 Bug 583287: Some fields should not be displayed in bugmail for new bugs
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260944 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-02 23:31:47 +00:00
mkanat%bugzilla.org
6b00d3908f Bug 583165: Un(setting) a comment as private doesn't update bugs.delta_ts
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260941 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-02 23:17:59 +00:00
mkanat%bugzilla.org
f5fe917583 Bug 553884: Quicksearch incorrectly treats "-" in quotes as negation
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260940 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-02 02:19:36 +00:00
mkanat%bugzilla.org
bee431048b Bug 583622: email_in.pl doesn't let me set timetracking fields
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260939 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-02 01:49:26 +00:00
mkanat%bugzilla.org
7765f561eb Bug 578494: We can't use "shellwords" to split words for sql_fulltext on Pg,
because it doesn't work with unbalanced single quotes. So we just do a hack
to make Quicksearch work right, for Pg.
r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260938 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-02 01:34:28 +00:00
mkanat%bugzilla.org
f09b813e00 Bug 583645: Make $dbh->quote always detaint its output, even on DBDs that
don't normally detaint output from $dbh->quote.
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260936 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-02 01:02:01 +00:00
mkanat%bugzilla.org
632fbbf4c8 Bug 577956: Bugs which were never confirmed cannot be reopened as UNCONFIRMED
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260935 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-01 23:37:33 +00:00
mkanat%bugzilla.org
4a086c29fb Bug 581622: When a quicksearch includes the "content" field, it is limited to 200 bugs
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260934 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-01 23:37:32 +00:00
mkanat%bugzilla.org
b36b1c69aa Bug 581327: The patch to allow commas in Product (etc.) names broke the
entering of comma-separated values in other search fields, like bug_id.
So now we split on commas in text fields, but not for <select> fields.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260931 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-01 23:01:36 +00:00
mkanat%bugzilla.org
c0fa695e18 Bug 396558: Dependency change e-mails should only include status changes that happened right now
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260899 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-28 17:16:46 +00:00
mkanat%bugzilla.org
0c76febfc2 Bug 581311: Bring the documentation of various hooks in Bugzilla::Hook
up to date
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260861 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-23 11:52:16 +00:00
mkanat%bugzilla.org
35bc85bc38 Bug 578240 - Re-add "owner" as a quicksearch alias for searching for "assigned_to"
[r=mkanat a=mkanat]


git-svn-id: svn://10.0.0.236/trunk@260852 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-23 02:09:13 +00:00
mkanat%bugzilla.org
066b0d12b4 Bug 578494: When doing a QuickSearch on a phrase, pass the phrase quoted
to the fulltext engine, so that it knows it's a phrase.
r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260851 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-23 02:07:49 +00:00
mkanat%bugzilla.org
029b234c64 Bug 577054: ChoiceInterface was denying the deletion of any value if
the field had *any* value-controlling values.
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260849 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-23 01:49:27 +00:00
mkanat%bugzilla.org
bd62b217d9 Bug 556579: Back out the patch from bug 554819, because it caused special
characters in quoted strings to be interpreted instead of passed along.
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260847 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-23 01:34:43 +00:00
mkanat%bugzilla.org
679581987b Bug 398701: Replace |FILTER url_quote| by |FILTER uri|
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260844 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-22 23:01:57 +00:00
mkanat%bugzilla.org
cff5681e70 Bug 580208: Search.pm: Combine all the user search types into one search
function
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260840 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-22 00:46:42 +00:00
mkanat%bugzilla.org
f98a0d8a34 Bug 428313: Properly expire the browser's CSS and JS cache when there
are new versions of those files. This also eliminates single-file skins
and should also allow Extensions to have skins.
r=glob, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260830 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-21 03:48:22 +00:00
mkanat%bugzilla.org
fd32004814 Bug 579514: Make Bug.attachments also return attachment data
r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260827 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-20 22:03:21 +00:00
mkanat%bugzilla.org
e7c68db0e1 Bug 579797: Restore ValidateGroupName in Bugzilla::Group, because it is
still in use by the whining system
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260825 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-20 21:31:49 +00:00
mkanat%bugzilla.org
dd5ffc6198 Bug 575475: ANSI coloring of error messages was hiding template compilation
errors
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260819 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-20 06:04:54 +00:00
mkanat%bugzilla.org
038e91d709 Bug 580174: Search.pm: Move special parsing functions around, to be more
orderly
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260818 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-20 06:01:55 +00:00
mkanat%bugzilla.org
a77eb64833 Bug 119703: Create an attachment by pasting it into a text field
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260809 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-18 17:31:54 +00:00
mkanat%bugzilla.org
dcf37601ba Bug 579568: Search.pm: Improve the implementation and performance of
substring and "words" searches, improve the formatting of generated SQL,
and use real subselects instead of performing the subselect and using its
results in an IN.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260807 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-18 01:01:41 +00:00
mkanat%bugzilla.org
5711e7a218 Bug 67036: Allow searching for product, component, etc. names that contain
commas
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260805 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-16 22:01:43 +00:00
mkanat%bugzilla.org
6a9394375f Bug 578335: The "Show next bug in my list" user pref either doesn't display the next bug or display one from the wrong buglist
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260799 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-16 10:04:35 +00:00
mkanat%bugzilla.org
c634e6e71e Bug 398308: Make Search.pm take a hashref for its "params" argument
instead of taking a CGI object.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260794 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-16 03:01:42 +00:00
mkanat%bugzilla.org
d9437423f7 Bug 521416: Some web servers fail to set the QUERY_STRING parameter
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260786 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-15 17:34:25 +00:00
mkanat%bugzilla.org
c8197e8456 Bug 577800: Finish the cleanup of Search.pm's "init" function by removing
it and having its work be done by a new "sql" accessor instead. Also adds
some comments, moves functions around into sections, and creates a new
_user accessor.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260784 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-15 11:24:27 +00:00
mkanat%bugzilla.org
a2ebe51f39 Bug 578904: Search.pm: Fully generate the FROM clause inside of an accessor
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260778 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-15 10:16:41 +00:00
mkanat%bugzilla.org
354474afad Bug 578888: Search.pm: Add and store joins as data structures instead of
raw SQL.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260777 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-15 05:46:39 +00:00
mkanat%bugzilla.org
a196f5150e Bug 578602: Search.pm: Move the parsing of boolean charts out of init
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260776 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-15 03:16:42 +00:00
mkanat%bugzilla.org
c501f77423 Bug 578739: Instead of removing REFERENCES from _bz_real_schema and then
populating FKs from _bz_schema at the end of checksetup, store REFERENCES
in _bz_real_schema with a special "created => 0" key that tells us that
we still need to create the FK.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260775 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 22:46:37 +00:00
mkanat%bugzilla.org
ff2c251501 Bug 578587: Make checksetup be way quieter when creating a new install
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260772 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 19:01:37 +00:00
mkanat%bugzilla.org
78df5f870c Bug 578308: Move the parsing of special fields and the creation of
@specialcharts out of init in Search.pm
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260768 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 05:16:31 +00:00
mkanat%bugzilla.org
9a3f7d202f Bug 578594: Search.pm: Move deadlinefrom and deadlineto parsing into a
special method
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260767 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 04:46:37 +00:00
mkanat%bugzilla.org
844f51805e The changes to accept positional parameters in XML-RPC meant that sometimes
$params wouldn't just be undef, but actually missing, so validate() was
getting @keys where $params should have been.


git-svn-id: svn://10.0.0.236/trunk@260766 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 04:04:43 +00:00
mkanat%bugzilla.org
2d0ddb344e Bug 578531: Move the chfield stuff out of init, and make
the changedbefore/after charts include the date specified
(they previously did exclusive searches)
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260764 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 02:16:34 +00:00
mkanat%bugzilla.org
4f6d79db10 Bug 578323: Remove the special parsing of "changedin" from Search.pm.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260759 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 23:46:36 +00:00
mkanat%bugzilla.org
3f376a9401 Bug 577765: Allow XML-RPC to accept multiple positional parameters
r=ghendricks, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260758 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 23:27:05 +00:00
mkanat%bugzilla.org
51d426d529 Remove some errors from WS_ERROR_CODE that don't exist on trunk.
git-svn-id: svn://10.0.0.236/trunk@260755 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 23:16:45 +00:00
mkanat%bugzilla.org
1e9ece0681 Bug 578324: The "Hours Worked" field in show_bug.cgi rejects all values passed to it if it would make the Remaining Time negative
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260750 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 23:05:56 +00:00
mkanat%bugzilla.org
4d8362abd8 Bug 412074: Ability to add attachments to a bug via the WebService
(Bug.add_attachment)
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260748 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 22:48:31 +00:00
mkanat%bugzilla.org
d00170cc62 Bug 578316: Search.pm: Move the parsing of email* fields into a method
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260744 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 11:02:11 +00:00