roc+%cs.cmu.edu
5486ff00e1
Bug 326944. Remove nsIComboboxControlFrame. r+sr=roc, patch by Marc Liddell
...
git-svn-id: svn://10.0.0.236/trunk@191291 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-27 02:33:26 +00:00
timeless%mozdev.org
faf573a28d
Bug 298277 remove useless references to nsVoidArray
...
r=dbaron sr=dbaron
git-svn-id: svn://10.0.0.236/trunk@191016 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-23 10:30:59 +00:00
sharparrow1%yahoo.com
1cf59a7435
Bug 326843 DeCOMtaminate some of nsComboboxControlFrame. Patch by marcldl+mozbugs@gmail.com. r+sr=roc.
...
git-svn-id: svn://10.0.0.236/trunk@190470 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-18 01:52:03 +00:00
bzbarsky%mit.edu
1b13fa7226
More usage of already_AddRefed. Fix leaks too. Bug 325378, r=sicking, sr=jst
...
git-svn-id: svn://10.0.0.236/trunk@189480 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-09 16:23:32 +00:00
roc+%cs.cmu.edu
df8627e29b
Bug 317375. Reorganize frame painting and mouse event targeting around frame display lists. Some review from dbaron, lots of testing help from Martijn, Julien and others
...
git-svn-id: svn://10.0.0.236/trunk@188202 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-26 02:29:17 +00:00
roc+%cs.cmu.edu
74858f37ce
Bug 254755. deCOMtaminate nsIFormControlFrame. patch by jpl24, r+sr=roc
...
git-svn-id: svn://10.0.0.236/trunk@185977 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-12 23:53:06 +00:00
bzbarsky%mit.edu
510247e8b6
Remove no longer needed event hack. Bug 146399, patch by Vidar Haarr
...
<vhaarr+bmo@gmail.com>, r=dbaron, sr=rbs
git-svn-id: svn://10.0.0.236/trunk@185782 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-08 01:44:30 +00:00
neil%parkwaycc.co.uk
ee9ce4336b
Bug 317937 Get rid of some unnecessary CIDs and change some possibly unsafe nsCOMPtr usage into the equivalently unsafe static casts r=darin sr=jst
...
git-svn-id: svn://10.0.0.236/trunk@185568 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-02 12:02:44 +00:00
timeless%mozdev.org
a05383ef1b
Bug 106386 Correct misspellings in source code
...
patch by mats.palmgren@bredband.net r=dbaron sr=dbaron
git-svn-id: svn://10.0.0.236/trunk@185018 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-20 22:05:24 +00:00
bzbarsky%mit.edu
d490f00b7b
Remove the dummy frame stuff from selects. Replace it with smarter focus rect
...
painting and sizing for empty selects. Bug 314879, r+sr=dbaron
git-svn-id: svn://10.0.0.236/trunk@184162 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-04 23:36:27 +00:00
roc+%cs.cmu.edu
c4e0410c6e
Bug 313817. DeCOMtaminate more NS_New*Frame functions. r+sr=roc, patch by Marc Liddell
...
git-svn-id: svn://10.0.0.236/trunk@184129 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-04 02:38:33 +00:00
cvshook%sicking.cc
b26f9f52fb
Bug 311827: Make GetAttr return a bool rather then an nsresult.
...
r/sr=bz
git-svn-id: svn://10.0.0.236/trunk@183185 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-28 11:25:24 +00:00
bzbarsky%mit.edu
ebec986940
Fix bug 313498 -- no need for aPresContext in GetOptionsContainer. r+sr=roc.
...
git-svn-id: svn://10.0.0.236/trunk@182852 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-23 22:11:27 +00:00
dbaron%dbaron.org
1f59103dc8
Indentation fixes needed after s/nsIPresContext/nsPresContext/. Whitespace changes only.
...
git-svn-id: svn://10.0.0.236/trunk@182299 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-15 04:08:04 +00:00
peterv%propagandism.org
86ac4d2e8f
Fix for bug 27382 (ownerDocument of orphan text and attr nodes is null). Patch by sicking, updated by peterv, r=bz, sr=peterv.
...
git-svn-id: svn://10.0.0.236/trunk@180911 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-24 18:43:15 +00:00
aaronleventhal%moonset.net
246dcdf544
Bug 306437. Onchange events fired twice for option selection via mouseclick. r=dbaron, sr=neil
...
git-svn-id: svn://10.0.0.236/trunk@179630 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-04 18:20:56 +00:00
bzbarsky%mit.edu
00bdd69268
Make sure kepress handlers are not affected by Caps Lock state. Bug 295228,
...
patch by Dainis Jonitis <Dainis_Jonitis@swh-t.lv>, r=neil, sr=bzbarsky
git-svn-id: svn://10.0.0.236/trunk@179325 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-30 18:13:48 +00:00
bzbarsky%mit.edu
d1afb179ba
Make nsIPresShell::GetPrimaryFrameFor return nsIFrame* instead of using an out
...
param. Bug 303779, patch by Bastiaan Jacques <b.jacques@planet.nl>, r+sr=bzbarsky
git-svn-id: svn://10.0.0.236/trunk@178642 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-22 22:24:29 +00:00
timeless%mozdev.org
3f10fd35d8
Bug 302356 Crash when drag-scrolling combobox [@ nsIFrame::HasView][@ nsIFrame::GetOffsetTo]
...
r=roc sr=roc a=bsmedberg
git-svn-id: svn://10.0.0.236/trunk@177290 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-07 14:35:45 +00:00
bzbarsky%mit.edu
1e551c09f1
Fix leaks on any page with a <select> by using already_AddRefed instead of a
...
raw addrefed return so that callers can't screw up as easily. Bug 300833,
r+sr=roc, a=bsmedberg
git-svn-id: svn://10.0.0.236/trunk@176770 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-28 16:23:22 +00:00
roc+%cs.cmu.edu
5bae01caf2
Bug 301439. Don't update scrollbars when we do first-pass layout of a listbox. r+sr=dbaron,a=bsmedberg
...
git-svn-id: svn://10.0.0.236/trunk@176582 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-25 23:23:53 +00:00
mats.palmgren%bredband.net
1e9e7aa193
Consider height of <OPTGROUP> labels when calculating visible height. b=300474 r+sr=bzbarsky a=benjamin
...
git-svn-id: svn://10.0.0.236/trunk@176490 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-24 01:02:15 +00:00
aaronleventhal%moonset.net
3613b3e8e8
Bug 290354. Support multiple selection. r=timeless, sr=bryner, a=asa
...
git-svn-id: svn://10.0.0.236/trunk@176088 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-14 14:20:21 +00:00
roc+%cs.cmu.edu
05ec7ecdef
Bug 291443. Capture the mouse if the user clicks on an item in a showed drop-down list. r+sr=bzbarsky,a=asa
...
git-svn-id: svn://10.0.0.236/trunk@175903 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-10 23:46:56 +00:00
mats.palmgren%bredband.net
f1ffae0752
Stop trying to observe content changes for the selected option, instead rely on getting a combobox reflow if it changed. b=297389 r+sr=roc a=asa
...
git-svn-id: svn://10.0.0.236/trunk@174908 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-21 00:00:14 +00:00
roc+%cs.cmu.edu
6ca1377728
Bug 290428. Don't change listbox selection when the cursor is over the listbox border and we're not capturing the mouse. r+sr=bzbarsky,a=asa
...
git-svn-id: svn://10.0.0.236/trunk@174749 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-17 02:44:31 +00:00
roc+%cs.cmu.edu
76beaa2809
Bug 296803. Don't start list item selection prematurely when the combobox pops up above the select control. r+sr=me, patch by Jan Darmochwal, a=asa
...
git-svn-id: svn://10.0.0.236/trunk@174593 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-14 22:15:53 +00:00
roc+%cs.cmu.edu
a6a3537c81
Bug 290428. When the mouse drags above or below the end of a listbox/comboboxdropdown, select the first or last option. Also, for comboboxes, start listbox selection as soon as the mouse moves to or below the top padding-edge of the dropdown list, and don't stop listbox selection even if the mouse moves back above that edge. r+sr=bzbarsky,a=shaver
...
git-svn-id: svn://10.0.0.236/trunk@174046 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-02 09:00:48 +00:00
jst%mozilla.jstenback.com
ebed1ee784
Fixing bug 289940. Make chrome event handlers only receive trusted events by default. r=jonas@sicking.cc, sr=peterv@propagandism.org, a=chofmann@mozilla.org
...
git-svn-id: svn://10.0.0.236/trunk@172848 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-28 23:48:28 +00:00
roc+%cs.cmu.edu
037ed527e7
Bug 291443. Listboxes should always direct mouse capture to their scrolled frame, to ensure that events reach the DOM event listener. r+sr=bzbarsky,a=chofmann
...
git-svn-id: svn://10.0.0.236/trunk@172722 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-26 03:14:38 +00:00
roc+%cs.cmu.edu
3b6fa5f822
Bug 287338. Free up unused frame state bit NS_SYNC_FRAME_AND_VIEW. r+sr=bzbarsky
...
git-svn-id: svn://10.0.0.236/trunk@171281 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-28 21:08:22 +00:00
ginn.chen%sun.com
d4a631b933
Bug 262236 Can't select listitems which are not next to.
...
patch=neo.liu at sun.com, r=aaronleventhal sr=neil
git-svn-id: svn://10.0.0.236/trunk@170356 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-08 03:05:03 +00:00
jst%mozilla.jstenback.com
07f72886c9
Fixing bug 283531. Fix confusingly named argument to nsIEventStateManager::DispatchNewEvent() that has caused confusing event handling code (also fixed) to creap into the tree. r=bzbarsky@mit.edu, sr=bryner@brianryner.com
...
git-svn-id: svn://10.0.0.236/trunk@170153 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-04 02:01:54 +00:00
bzbarsky%mit.edu
952aaf5063
Setting selectedIndex should clear all "previous value" state so that onchange
...
won't fire unless the user actually changes the value from the one set by
setting selectedIndex. r=mats, sr=roc, a=roc
git-svn-id: svn://10.0.0.236/trunk@169304 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 04:29:37 +00:00
smfr%smfr.org
981d5897ee
Fix bug 281732: event handling in camino's native popup got broken when screen-relative coordinates in Cocoa widget were fixed (bug 281470), which caused the nsComboboxControlFrame/nsListControlFrame code to start doing mouse capture, and showing the XUL popup. So add a static method, ToolkitHasNativePopup(), and query that (rather than #ifdeffing). r/sr=roc, a=dbaron.
...
git-svn-id: svn://10.0.0.236/trunk@169230 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-16 05:13:16 +00:00
aaronleventhal%moonset.net
a41619de7b
Bug 280871. Fix various problems with how we expose HTML and XUL combo boxes via accessibility APIs
...
git-svn-id: svn://10.0.0.236/trunk@168937 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-07 23:11:30 +00:00
mats.palmgren%bredband.net
571aea44de
Make assignments to DOM 'selectedIndex' change the focused index for lists/comboboxes. b=279868 r+sr=bzbarsky
...
git-svn-id: svn://10.0.0.236/trunk@168819 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-04 22:56:13 +00:00
mats.palmgren%bredband.net
9c18d9f96a
Add NS_FRAME_INDEPENDENT_SELECTION to ListControlFrame (and children) and skip such frames (TextControlFrame also) in GetContentAndOffsetsFromPoint() when the point is only "near" (not inside) the frame. b=268497 r=bzbarsky sr=dbaron
...
git-svn-id: svn://10.0.0.236/trunk@167833 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 18:44:01 +00:00
bmlk%gmx.de
adcb976e59
remove unused prescontext from PlaceFrameView, PlaceChildsView, ConsiderChildOverflow bug 276092 r/sr=dbaron
...
git-svn-id: svn://10.0.0.236/trunk@167045 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-27 15:05:18 +00:00
bmlk%gmx.de
e547c59f49
remove unused prescontext argument from GetOffsetFromView bug 276015 r/sr=dbaron
...
git-svn-id: svn://10.0.0.236/trunk@167037 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-26 19:48:54 +00:00
robin.lu%sun.com
8cb04f0a83
back out patch for bug 262236 on request
...
git-svn-id: svn://10.0.0.236/trunk@166779 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-16 06:40:04 +00:00
robin.lu%sun.com
b6bc6746a6
fix bug 262236 can't select incontinuous list items. patched by nian.liu@sun.com r=aaron sr=neil
...
git-svn-id: svn://10.0.0.236/trunk@166652 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-13 07:34:54 +00:00
bzbarsky%mit.edu
f53f98f7f3
Create an api for easily converting between the coordinate systems of two
...
frames or two views. Use this to fix the auto-positioning of abs pos boxes to
work no matter how their containing block and the block their placeholder lives
in are related, and convert various other callers to the new API. Bug 266968,
r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@164857 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-03 16:16:57 +00:00
neil%parkwaycc.co.uk
7903ea1651
Don't use QueryInterface to get a view from a scrollable view b=258521 r+sr=roc
...
git-svn-id: svn://10.0.0.236/trunk@162561 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-20 22:25:07 +00:00
roc+%cs.cmu.edu
d9025f99fb
Bug 257916. Move history scroll position save and restore from nsScrollBoxFrame to nsHTML/XULScrollFrame. +sr=dbaron(rubber-stamp)
...
git-svn-id: svn://10.0.0.236/trunk@162190 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-13 02:10:29 +00:00
roc+%cs.cmu.edu
25c92b6a90
Bug 254039. deCOMtaminate nsIScrollableFrame. r+sr=roc, patch by Will Levine
...
git-svn-id: svn://10.0.0.236/trunk@161806 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-06 02:44:43 +00:00
bryner%brianryner.com
4bbe6bddf6
Update the displayed text when closing a combobox with the keyboard causes a new option to be selected. Bug 257572, r=mkaply, sr=jst.
...
git-svn-id: svn://10.0.0.236/trunk@161677 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-02 21:10:40 +00:00
bzbarsky%mit.edu
e481ad27f2
Relanding bug 108817, since it did not cause the Tp problem. r+sr=still roc
...
git-svn-id: svn://10.0.0.236/trunk@160650 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-11 04:49:05 +00:00
bzbarsky%mit.edu
b9de4e9489
Backing out patch for bug 108817 to test whether it causes the Tp regression.
...
git-svn-id: svn://10.0.0.236/trunk@160638 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-10 23:37:43 +00:00
bzbarsky%mit.edu
f7785eac83
Remove the timer stuff in nsListControlFrame and replace it with a simple
...
boolean that's set as needed if the options change and checked in DidReflow()
to decide whether to scroll the list. Also eliminate the mPresContext member.
Bug 108817, r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@160629 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-10 22:21:03 +00:00