100 Commits

Author SHA1 Message Date
mkanat%bugzilla.org
5af9c75cfe Bug 604522: t/012throwables.t doesn't catch new user errors correctly
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@261404 18797224-902f-48f8-a5cc-f745e15eee43
2010-10-15 00:21:59 +00:00
mkanat%bugzilla.org
9be0c2c2f4 Bug 575947: Users with passwords length less than 6 characters can't login after migration from 3.4.x or older to 3.6 or newer
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@261395 18797224-902f-48f8-a5cc-f745e15eee43
2010-10-14 00:53:22 +00:00
mkanat%bugzilla.org
9285e338dd Bug 602165: Change sql_interval to sql_date_math, in preparation for
MS-SQL and SQLite support.


git-svn-id: svn://10.0.0.236/trunk@261360 18797224-902f-48f8-a5cc-f745e15eee43
2010-10-07 11:02:21 +00:00
mkanat%bugzilla.org
594bcd76eb Bug 550732: Allow read-only JSON-RPC methods to be called with GET
r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260221 18797224-902f-48f8-a5cc-f745e15eee43
2010-04-22 19:01:59 +00:00
mkanat%bugzilla.org
c723e8517c Bug 553770: Make the JSON-RPC WebService throw a proper error when you don't
provide login credentials on a LOGIN_REQUIRED page. (Before this, it was
attempting to display the HTML login page to JSON-RPC clients.)
r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260024 18797224-902f-48f8-a5cc-f745e15eee43
2010-03-23 23:21:19 +00:00
lpsolit%gmail.com
b9168f54ae Bug 467992: Login fails if the user's LDAP account is denied search in LDAP - Patch by Adam Batkin <adam@batkin.net> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@259335 18797224-902f-48f8-a5cc-f745e15eee43
2010-01-05 08:32:54 +00:00
mkanat%bugzilla.org
0cc827bc54 Bug 527586: Use X-Forwarded-For instead of REMOTE_ADDR for trusted proxies
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259326 18797224-902f-48f8-a5cc-f745e15eee43
2009-12-31 12:53:21 +00:00
lpsolit%gmail.com
e945361ed0 Bug 385606: Logincookies are recreated at each HTTP request when using the 'Env' auth method - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@259322 18797224-902f-48f8-a5cc-f745e15eee43
2009-12-31 12:18:06 +00:00
mkanat%bugzilla.org
15546c7c25 Bug 355283: Lock out a user account on a particular IP for 30 minutes if they fail to log in 5 times from that IP.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259208 18797224-902f-48f8-a5cc-f745e15eee43
2009-12-13 20:46:28 +00:00
mkanat%bugzilla.org
98a5bbf59c Bug 430014: Re-write the code hooks system so that it uses modules instead of individual .pl files
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> (module owner) a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259069 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-24 06:09:55 +00:00
mkanat%bugzilla.org
0dfd6e55e2 Bug 525734: Allow WebService clients to authenticate using Bugzilla_login and Bugzilla_password
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@258941 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-09 19:15:30 +00:00
lpsolit%gmail.com
c89b589751 Bug 399073: Remove the 'loginnetmask' parameter - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@258717 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-18 23:35:01 +00:00
mkanat%bugzilla.org
c70c2cf9ff Bug 514913: Eliminate ssl="authenticated sessions"
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@258645 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-09 04:31:13 +00:00
mkanat%bugzilla.org
e417a47487 Bug 488467: Verify and Login auth methods were being called in a random order, causing sudo sessions to frequently not need the user to re-enter their password.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@256954 18797224-902f-48f8-a5cc-f745e15eee43
2009-04-17 21:57:19 +00:00
mkanat%bugzilla.org
2845ec790e Bug 121601: Have logout display index.cgi, not just a message on relogin.cgi.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@256377 18797224-902f-48f8-a5cc-f745e15eee43
2009-03-01 23:42:55 +00:00
mkanat%bugzilla.org
3c1cae0914 Bug 134022: PERFORMANCE: deleting old login cookies locks login checks
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@255864 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-20 20:10:08 +00:00
mkanat%bugzilla.org
36dafcc096 Bug 211006: Make Bugzilla use SHA-256 instead of crypt() to store hashed passwords in the database
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@255694 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-02 09:11:51 +00:00
dkl%redhat.com
d2cc34e014 Bug 455584 - Use bz_crypt everywhere instead of the crypt() function
Patch by David Lawrence <dkl@redhat.com> = r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@254732 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-22 21:54:59 +00:00
lpsolit%gmail.com
eec25e0428 Bug 460770: Incorrect regexp when parsing the list of LDAP servers - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@254682 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-20 18:37:38 +00:00
lpsolit%gmail.com
79e1610288 Partial backout of bug 183665. It's responsible for bug 457719
git-svn-id: svn://10.0.0.236/trunk@254530 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-04 20:04:50 +00:00
dkl%redhat.com
36109e6138 Bug 453767 - Passwords containing wide characters causes system error
Patch by David Lawrence <dkl@redhat.com> - a/r=mkanat


git-svn-id: svn://10.0.0.236/trunk@254181 18797224-902f-48f8-a5cc-f745e15eee43
2008-09-12 15:10:14 +00:00
lpsolit%gmail.com
e62e028333 Bug 449984: Login cookies should be created as SSL-only on installations that require SSL - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@253851 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-27 01:10:33 +00:00
reed%reedloden.com
d379f34dfc Bug 368502 - "Bugzilla_logincookie should not be accessible via javascript" [p=reed r+a=mkanat]
git-svn-id: svn://10.0.0.236/trunk@253792 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-22 23:39:41 +00:00
dkl%redhat.com
f51ff717a8 Bug 428659 – Setting SSL param to 'authenticated sessions' only protects logins and param
doesn't protect WebService calls at all
Patch by David Lawrence <dkl@redhat.com> - r/a=LpSolit/mkanat


git-svn-id: svn://10.0.0.236/trunk@253665 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-18 04:16:14 +00:00
mkanat%bugzilla.org
fd276d6f66 Bug 438435: Need code hooks for authentication
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@253408 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-06 23:38:31 +00:00
dkl%redhat.com
223ced6261 Backing out these patches as they cause a regression. More information
in the respective bug reports.

Bug 428659 – Setting SSL param to 'authenticated sessions' only
protects logins and param doesn't protect WebService calls at all
Patch by Dave Lawrence <dkl@redhat.com> - r/a=mkanat

Bug 445104: ssl redirects come with a 200 OK HTTP code on mod_perl
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@253320 18797224-902f-48f8-a5cc-f745e15eee43
2008-07-28 20:58:01 +00:00
dkl%redhat.com
fe2838832f Bug 428659 – Setting SSL param to 'authenticated sessions' only protects logins and param doesn't protect WebService calls at all
Patch by Dave Lawrence <dkl@redhat.com> - r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@252948 18797224-902f-48f8-a5cc-f745e15eee43
2008-07-10 04:56:22 +00:00
mkanat%bugzilla.org
210431c009 Bug 408384: Set extern_id when using LDAP auth
Patch By Emmanuel Seyman <eseyman@linagora.com> r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@241264 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-14 18:17:29 +00:00
mkanat%bugzilla.org
622bfbeb7e Bug 229049: Make LDAP authentication work when there are multiple mail= attributes for an account.
Patch By Emmanuel Seyman <eseyman@linagora.com> r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@241262 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-14 17:40:57 +00:00
lpsolit%gmail.com
702b8f6c80 Bug 183665: Accessing post_bug.cgi directly gives a weird error message and should redirect to enter_bug.cgi instead - Patch by Matt Tasker <mtasker@gmail.com> (based on the original patch from victory <spam@bmo2007.rsz.jp>) r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@239399 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-14 22:50:25 +00:00
wurblzap%gmail.com
2ae6da445f Bug 380187 – Bugzilla should support RADIUS authentication.
Patch by Marc Schumann <wurblzap@gmail.com>;
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@231372 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-02 22:38:53 +00:00
ghendricks%novell.com
31139ea5a0 Bug 380928 – Bugzilla::Auth::Verify::create_or_update_user can return stale Bugzilla::User object
patch by vrb@novell.com r=mkanat a=mkanat


git-svn-id: svn://10.0.0.236/trunk@226890 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-23 18:05:49 +00:00
mkanat%bugzilla.org
048f8af926 Bug 367480: [LDAP] Try a list of servers in order until we connect successfully
Patch By Tony Bajan <firefox@tonyb.me.uk> r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@221469 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-07 20:43:43 +00:00
wurblzap%gmail.com
534cc8b074 Bug 340538: Insecure dependency in exec while running with -T switch at /usr/lib/perl5/site_perl/5.8.6/Mail/Mailer/sendmail.pm line 16.
Patch by Marc Schumann <wurblzap@gmail.com>,
r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@213922 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-20 18:52:24 +00:00
mkanat%bugzilla.org
8aa56fc69e Bug 349349: Use ->create from Bugzilla::Object instead of insert_new_user for Bugzilla::User
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@208468 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-25 22:10:39 +00:00
wurblzap%gmail.com
a8bd7c9398 Bug 224577: Bugzilla could use a web services interface.
Patch by Marc Schumann <wurblzap@gmail.com>;
r=mkanat; a=myk


git-svn-id: svn://10.0.0.236/trunk@207931 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-19 17:20:25 +00:00
mkanat%bugzilla.org
906f961cc4 Bug 346245: attribute parameter 'johndoe@company.tld' is not a hash ref at Bugzilla/Auth/Verify.pm line 112
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=wurblzap, a=myk


git-svn-id: svn://10.0.0.236/trunk@205081 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-28 20:35:10 +00:00
lpsolit%gmail.com
c0028bf425 Bug 339731: [LDAP] URI-parsing code duplicated with Net::LDAP - Patch by guillomovitch@zarb.org r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@201857 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-11 00:42:58 +00:00
lpsolit%gmail.com
0c350b72a5 Bug 340967: The login form appears twice when trying to add an attachment (due to two consecutive calls to Bugzilla->login) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@201628 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-05 23:42:47 +00:00
mkanat%bugzilla.org
520fe42625 Bug 338375: Use Bugzilla->params everywhere instead of Param().
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201503 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:42:47 +00:00
mkanat%bugzilla.org
8323e09c40 Bug 342869: Use Bugzilla->params everywhere except templates
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201499 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:26:22 +00:00
vladd%bugzilla.org
7c5ec076c2 Spelling in code comments patch: 'cokie' -> 'cookie'; patch by Vlad Dascalu <vladd@bugzilla.org>.
git-svn-id: svn://10.0.0.236/trunk@200286 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-19 14:40:38 +00:00
lpsolit%gmail.com
d2d8d03d4d Bug 340104: Move Bugzilla::Auth::get_netaddr() in Util.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=justdave
git-svn-id: svn://10.0.0.236/trunk@198934 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-03 12:23:13 +00:00
lpsolit%gmail.com
757ecbfffe Bug 282687: LDAP: TLS Support - Patch by guillomovitch@zarb.org r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@198866 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-02 11:52:49 +00:00
lpsolit%gmail.com
a86e18ff63 Bug 339858: Remove useless module dependencies in Bugzilla::Auth::* - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@198782 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-01 00:19:36 +00:00
mkanat%bugzilla.org
cc5b211d4e Bug 338573: Auth could throw an insecure dependency error if username is tainted
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@198684 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-30 21:19:09 +00:00
mkanat%bugzilla.org
7da2224511 Bug 320751: LDAP: Ability to have Bugzilla use the LDAP username directly as the Bugzilla username
Patch By guillomovitch@zarb.org r=mkanat, a=myk


git-svn-id: svn://10.0.0.236/trunk@198683 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-30 21:17:34 +00:00
lpsolit%gmail.com
6ebf297b90 Bug 337661: LDAP user login failure: Can't locate object method "realname" via package "Bugzilla::User" - Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@196529 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-15 16:13:02 +00:00
mkanat%bugzilla.org
caee2e9858 Bug 300410: Bugzilla::Auth needs to be restructured to not require a BEGIN block
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@196368 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-12 02:41:22 +00:00
jocuri%softhome.net
eeffbbf891 Patch for bug 216902: support LDAPS connections; patch by Christian Krause <chkr@plauener.de>, r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@191769 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-04 12:08:31 +00:00