2980 Commits

Author SHA1 Message Date
ian%hixie.ch
be9b893e79 Fixes a copy-paste error in the help line. r=timeless; b=123708
git-svn-id: svn://10.0.0.236/trunk@113892 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-07 08:36:23 +00:00
ian%hixie.ch
085da4328c Lets the invite command accept the more natural syntax 'invite user in #channel' rather than just 'invite user channel'. r=zach; b=72949
git-svn-id: svn://10.0.0.236/trunk@113891 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-07 08:33:17 +00:00
justdave%syndicomm.com
d8baf36515 Fix for bug 122897: Comments entered on the bug form are now added to the bug before it is closed and moved when moving a bug
to another Bugzilla install.
Patch by Dave Miller <justdave@syndicomm.com>
r= timeless, bbaetz


git-svn-id: svn://10.0.0.236/trunk@113760 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-06 04:34:10 +00:00
justdave%syndicomm.com
c4c291a120 Fix for bug 119005: The instructions in editgroups.cgi incorrectly state that you can't use spaces in a group name. You in
fact can.
Patch by Christian Reis <kiko@async.com.br>
r= bbaetz x 2


git-svn-id: svn://10.0.0.236/trunk@113741 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-06 02:54:08 +00:00
justdave%syndicomm.com
686d81fb26 Fix for bug 117055: Emails were being truncated if they contained a line with nothing but a period on them. We now pass -i to
sendmail and its clones to tell it to ignore periods (since we close the pipe when we're done, rather than signalling it with
a period).  Has been tested with sendmail and postfix.
Patch by Dave Miller <justdave@syndicomm.com>
r= afranke, bugzilla@bkor.dhs.org, jake


git-svn-id: svn://10.0.0.236/trunk@113739 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-06 02:47:00 +00:00
bbaetz%student.usyd.edu.au
8ec543447a Bug 119715 - strictvaluechecks should always be enabled
r=justdave, gerv


git-svn-id: svn://10.0.0.236/trunk@113648 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-05 00:20:09 +00:00
bbaetz%student.usyd.edu.au
2c81615c9a Bug 122418 pt2 - obsoleting a patch from the create attachment screen gave
a taint error.


git-svn-id: svn://10.0.0.236/trunk@113647 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-05 00:11:48 +00:00
gerv%gerv.net
2a14c2e071 Remove JS strict warning.
git-svn-id: svn://10.0.0.236/trunk@113636 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 22:47:26 +00:00
bbaetz%student.usyd.edu.au
d2945c40c2 bug 122418 - setting attachment status fails taint checks. Just needed to
detaint after checking.
r=gerv,kiko


git-svn-id: svn://10.0.0.236/trunk@113632 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 22:16:18 +00:00
gerv%gerv.net
4711cd34e5 show_bug.cgi templatisation.
git-svn-id: svn://10.0.0.236/trunk@113629 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 21:17:17 +00:00
zach%zachlipton.com
137895e51f Fix for bug 87398: checksetup.pl should warn if not run as root. Patch
adds a warning if the user has webservergroup set but does not run
checksetup.pl as root.

r1=kiko, r2=justdave


git-svn-id: svn://10.0.0.236/trunk@113610 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 16:38:33 +00:00
bbaetz%student.usyd.edu.au
e20fe58870 Bug 95732 - remove logincookies.cryptpassword, and invalidate cookies from
the db when required instead.
(Also fixes bug 58242 as a side effect)

r=myk, kiko


git-svn-id: svn://10.0.0.236/trunk@113598 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 12:23:05 +00:00
justdave%syndicomm.com
40ab41ff77 Fix for bug 14461: QA contact is no longer required. You can still leave it blank in editing and creating components if you
want, even if it's enabled now.  This is consistant with the behavior of this field everywhere else in Bugzilla now.
Eventually this will be a per-product setting whether to enforce having one or not.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave x 2


git-svn-id: svn://10.0.0.236/trunk@113584 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 00:41:40 +00:00
myk%mozilla.org
f89a91a9e4 Fix for bug 121747: Stops every script before it does anything else if Bugzilla is currently shut down. Also adds global template
instantiation code to globals.pl.
Patch by Myk Melez <myk@mozilla.org>.
r=gerv,kiko


git-svn-id: svn://10.0.0.236/trunk@113573 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-03 09:28:48 +00:00
myk%mozilla.org
75dca718c9 Fix for bug 98021: Cleans up "edit attachment" interface on NS4.x by removing text of buttons that do not work in that browser.
Patch by Myk Melez <myk@mozilla.org>.
r=kiko x 2


git-svn-id: svn://10.0.0.236/trunk@113430 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 17:50:00 +00:00
jake%acutex.net
18e6a3ea4d Bug 122154 part 2 - Eliminiate the use of the "usetms" Javascript cache variable.
Patch by Christian Reis <kiko@async.com.br>
r= bbaetz, jake


git-svn-id: svn://10.0.0.236/trunk@113420 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 14:52:37 +00:00
jake%acutex.net
7efb764af7 Bug 121636 - Provide support for cvsgraph (requires the cvsgraph binary, see bug 121636 for more information).
r= kiko


git-svn-id: svn://10.0.0.236/trunk@113417 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 14:32:55 +00:00
timeless%mac.com
e73045e569 Bug 109138 platform detection not working on macintosh
r=bbaetz r=gerv
adds another regexp for MacOSX


git-svn-id: svn://10.0.0.236/trunk@113412 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 10:05:04 +00:00
ian%hixie.ch
3e9ca21d73 * Added getGroupMembers() to the User data source.
* Fixed a bug in the MySQL implementation of User data source's getGroupName() method. It treated 'row' as an array ref instead of a normal array.
* Made the MySQL User data source automatically add a group with ID 1, named 'Administrators'.
* Special-cased the group with ID 1 in the user object so that if a user is in that group, he automatically is assumed to have all rights.
* Fixed a bug with the saving of the original groups in the user object (the backup object was simply a reference to the original object, which was later changed in place, causing the backup to change too).
* Fixed the handling of rights in the user object constructor to simply set the rights in one line instead of using indirection.
* Fixed the invalidateRights() method of the user object to correctly re-set the rights (previously it was not turning the generated array into a hashref).
* Added a setup.install implementation to the login component. It now queries the user for an administration username and creates the relevant user and puts it in the magic group 1.
* Fixed a call to checkAddress() in the login component.


git-svn-id: svn://10.0.0.236/trunk@113408 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 06:48:02 +00:00
ian%hixie.ch
78a5b28737 Commented out the call to Net::SMTP's verify() method and replaced it with a generic regexp sanity check. It appears that VRFY is not correctly implemented on all servers. (I may be mistaken on this; it might just be a bug somewhere in the PLIF code that is messing something up, but I couldn't find it if so.)
git-svn-id: svn://10.0.0.236/trunk@113407 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 06:38:55 +00:00
ian%hixie.ch
bcf3696b25 Added a check that ensures that the configuration file is not readable or writable by anyone except the user running the script. This closes a potential security hole on shared machines. Changed the umask during the creation of the configuration file so that the permission bits are set that way too. Added a comment to clarify the superficially recursive nature of the configuration database and the configuration data source.
git-svn-id: svn://10.0.0.236/trunk@113405 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 06:36:27 +00:00
ian%hixie.ch
d36a91026e Another change that should be done at some point: Move PLIF/DataSource/*/MySQL.pm to PLIF/DataSource/MySQL/*.pm
git-svn-id: svn://10.0.0.236/trunk@113404 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 06:32:17 +00:00
bbaetz%student.usyd.edu.au
37e83dae0b Bug 122744 - charting fails taint checks
r=daa@distributed.net, gerv


git-svn-id: svn://10.0.0.236/trunk@113380 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 23:51:38 +00:00
bbaetz%student.usyd.edu.au
af02b7487d Fix up "used only once" warning from kiko's checkin.
r=kiko x 2.


git-svn-id: svn://10.0.0.236/trunk@113379 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 23:46:51 +00:00
jake%acutex.net
11e4684e5b Bug 122636 - Templatise colchange.cgi
Patch by David Lawrence <dkl@redhat.com> and Christian Reis <kiko@async.com.br>
r= kiko, jake


git-svn-id: svn://10.0.0.236/trunk@113349 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 20:12:50 +00:00
ian%hixie.ch
cd94938f2b Removed an erroneous comment, which should be the last traces of the old problem of the lack of a configuration file being a fatal error.
git-svn-id: svn://10.0.0.236/trunk@113325 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 18:30:21 +00:00
ian%hixie.ch
095dfaa67a Theoretical nit: call inherited constructor just in case at some point in the future it does something useful...
git-svn-id: svn://10.0.0.236/trunk@113324 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 17:35:52 +00:00
jake%acutex.net
0b5e8f4c53 Bug 122589 -- Update gnats conversion script to newer schema of 2.14.
Patch by Andrea Dell'Amico <adellam@link.it>


git-svn-id: svn://10.0.0.236/trunk@113311 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 14:29:21 +00:00
mcafee%netscape.com
fa6cde4e30 adding mocha to dns
git-svn-id: svn://10.0.0.236/trunk@113297 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 05:25:08 +00:00
timeless%mac.com
2dc16480de Bug 122518 Speed up the showbuilds.cgi redirect on http://tinderbox.mozilla.org
patch by netdemonz@yahoo.com r=mcafee


git-svn-id: svn://10.0.0.236/trunk@113288 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 04:22:39 +00:00
myk%mozilla.org
278c5a5f14 Fix for bug 109480: Removes createattachment.cgi from CVS.
Removed by Myk Melez <myk@mozilla.org>.
r=bbaetz x 2


git-svn-id: svn://10.0.0.236/trunk@113213 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-30 18:08:01 +00:00
myk%mozilla.org
3bad919c98 Fix for bug 104521: Removes old attachment interface in favor of new attachment tracker.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,kiko


git-svn-id: svn://10.0.0.236/trunk@113204 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-30 14:14:12 +00:00
bbaetz%student.usyd.edu.au
65d995cd1d Bug 122154 - change arrays to numeric, and clean up query.atml js
patch by kiko@async.com.br, r=caillon,bbaetz


git-svn-id: svn://10.0.0.236/trunk@113203 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-30 13:43:11 +00:00
gerv%gerv.net
4c6b3e1925 Bug 117509 - createaccount.cgi templatisation.
git-svn-id: svn://10.0.0.236/trunk@113165 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-29 23:26:37 +00:00
kestes%walrus.com
e4389162d5 added some thoughts on how this should work. I still need to debug it.
git-svn-id: svn://10.0.0.236/trunk@113140 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-29 21:11:59 +00:00
kestes%walrus.com
8b2e024267 many bug fixes. it still will not work, I need a few more hours to finish
debugging this.


git-svn-id: svn://10.0.0.236/trunk@113116 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-29 11:38:55 +00:00
kestes%walrus.com
600694ee91 fix comment.
git-svn-id: svn://10.0.0.236/trunk@113080 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-29 01:11:10 +00:00
kestes%walrus.com
54fa661fc0 regularize $last_cvs_data to be $last_vc_data this is clearer and matches
perforce.pm.  Also fix comments about the function call names to match
new naming system.


git-svn-id: svn://10.0.0.236/trunk@113077 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-29 01:09:15 +00:00
kestes%walrus.com
5658f562ac this is a first draft. I need to debug this before it will work,
but you can see the logic of it and it will not take long to get it
to work.


git-svn-id: svn://10.0.0.236/trunk@113076 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-29 01:06:26 +00:00
mcafee%netscape.com
ddede4a56a adding mocha to pageload list
git-svn-id: svn://10.0.0.236/trunk@113029 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-28 08:05:46 +00:00
mcafee%netscape.com
a947b91a39 graph size wasn't preserving average setting
git-svn-id: svn://10.0.0.236/trunk@113025 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-28 06:51:22 +00:00
zach%zachlipton.com
063a9d3b5e Fix for bug 121735: Perl warning running checksetup.pl if a module has a
non-numeric version number. Patch sets checksetup.pl to use a string
compare instead of a numeric one.

Patch by Dave Miller. r1=Bradley Baetz and r2=Gerv


git-svn-id: svn://10.0.0.236/trunk@113002 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-27 18:59:38 +00:00
gerv%gerv.net
e9fcac9dcb Removing new_comment.cgi - all part of quips.cgi now.
git-svn-id: svn://10.0.0.236/trunk@112894 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-25 22:41:37 +00:00
gerv%gerv.net
32d50f0d78 quips.cgi rewrite and templatisation.
git-svn-id: svn://10.0.0.236/trunk@112893 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-25 22:40:04 +00:00
ian%hixie.ch
8e82e0ec2a Fix a minor typo in some SQL code which was causing an error during the creation of the user table.
git-svn-id: svn://10.0.0.236/trunk@112824 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-25 03:18:15 +00:00
ian%hixie.ch
4612fcaf55 Moved the DBI module over to thew new more generic settings getting/saving API and removed the old DBI-specific one. Fixed an assert() call to check for the values being defined and not non-zero/non-blank. Fixed the password field to allow blank values (by making a blank value the default). Also fixed the calls to getArgument to not ever pass an undefined value as the default.
git-svn-id: svn://10.0.0.236/trunk@112822 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-25 03:17:05 +00:00
ian%hixie.ch
26b7d82370 More things that need doing on the long (and not so long) run.
git-svn-id: svn://10.0.0.236/trunk@112821 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-25 03:12:26 +00:00
bbaetz%student.usyd.edu.au
4deb648921 Bug 93037 - use YYYY-MM-DD HH:MM formatting for attachment dates
r=gerv,myk


git-svn-id: svn://10.0.0.236/trunk@112546 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-23 00:24:31 +00:00
bbaetz%student.usyd.edu.au
c53115e19f Bug 120543 - Software error when entering a bug when not logged in & only
one product.
r=caillon,jake


git-svn-id: svn://10.0.0.236/trunk@112535 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-22 22:23:21 +00:00
bbaetz%student.usyd.edu.au
7f8c1e8eec Bug 121074 - taint error after changing bug
r=daa@distributed.net,jake


git-svn-id: svn://10.0.0.236/trunk@112518 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-22 15:12:11 +00:00