1273 Commits

Author SHA1 Message Date
justdave%syndicomm.com
d8baf36515 Fix for bug 122897: Comments entered on the bug form are now added to the bug before it is closed and moved when moving a bug
to another Bugzilla install.
Patch by Dave Miller <justdave@syndicomm.com>
r= timeless, bbaetz


git-svn-id: svn://10.0.0.236/trunk@113760 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-06 04:34:10 +00:00
justdave%syndicomm.com
c4c291a120 Fix for bug 119005: The instructions in editgroups.cgi incorrectly state that you can't use spaces in a group name. You in
fact can.
Patch by Christian Reis <kiko@async.com.br>
r= bbaetz x 2


git-svn-id: svn://10.0.0.236/trunk@113741 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-06 02:54:08 +00:00
justdave%syndicomm.com
686d81fb26 Fix for bug 117055: Emails were being truncated if they contained a line with nothing but a period on them. We now pass -i to
sendmail and its clones to tell it to ignore periods (since we close the pipe when we're done, rather than signalling it with
a period).  Has been tested with sendmail and postfix.
Patch by Dave Miller <justdave@syndicomm.com>
r= afranke, bugzilla@bkor.dhs.org, jake


git-svn-id: svn://10.0.0.236/trunk@113739 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-06 02:47:00 +00:00
bbaetz%student.usyd.edu.au
8ec543447a Bug 119715 - strictvaluechecks should always be enabled
r=justdave, gerv


git-svn-id: svn://10.0.0.236/trunk@113648 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-05 00:20:09 +00:00
bbaetz%student.usyd.edu.au
2c81615c9a Bug 122418 pt2 - obsoleting a patch from the create attachment screen gave
a taint error.


git-svn-id: svn://10.0.0.236/trunk@113647 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-05 00:11:48 +00:00
gerv%gerv.net
2a14c2e071 Remove JS strict warning.
git-svn-id: svn://10.0.0.236/trunk@113636 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 22:47:26 +00:00
bbaetz%student.usyd.edu.au
d2945c40c2 bug 122418 - setting attachment status fails taint checks. Just needed to
detaint after checking.
r=gerv,kiko


git-svn-id: svn://10.0.0.236/trunk@113632 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 22:16:18 +00:00
gerv%gerv.net
4711cd34e5 show_bug.cgi templatisation.
git-svn-id: svn://10.0.0.236/trunk@113629 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 21:17:17 +00:00
zach%zachlipton.com
137895e51f Fix for bug 87398: checksetup.pl should warn if not run as root. Patch
adds a warning if the user has webservergroup set but does not run
checksetup.pl as root.

r1=kiko, r2=justdave


git-svn-id: svn://10.0.0.236/trunk@113610 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 16:38:33 +00:00
bbaetz%student.usyd.edu.au
e20fe58870 Bug 95732 - remove logincookies.cryptpassword, and invalidate cookies from
the db when required instead.
(Also fixes bug 58242 as a side effect)

r=myk, kiko


git-svn-id: svn://10.0.0.236/trunk@113598 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 12:23:05 +00:00
justdave%syndicomm.com
40ab41ff77 Fix for bug 14461: QA contact is no longer required. You can still leave it blank in editing and creating components if you
want, even if it's enabled now.  This is consistant with the behavior of this field everywhere else in Bugzilla now.
Eventually this will be a per-product setting whether to enforce having one or not.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave x 2


git-svn-id: svn://10.0.0.236/trunk@113584 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 00:41:40 +00:00
myk%mozilla.org
f89a91a9e4 Fix for bug 121747: Stops every script before it does anything else if Bugzilla is currently shut down. Also adds global template
instantiation code to globals.pl.
Patch by Myk Melez <myk@mozilla.org>.
r=gerv,kiko


git-svn-id: svn://10.0.0.236/trunk@113573 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-03 09:28:48 +00:00
myk%mozilla.org
75dca718c9 Fix for bug 98021: Cleans up "edit attachment" interface on NS4.x by removing text of buttons that do not work in that browser.
Patch by Myk Melez <myk@mozilla.org>.
r=kiko x 2


git-svn-id: svn://10.0.0.236/trunk@113430 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 17:50:00 +00:00
jake%acutex.net
18e6a3ea4d Bug 122154 part 2 - Eliminiate the use of the "usetms" Javascript cache variable.
Patch by Christian Reis <kiko@async.com.br>
r= bbaetz, jake


git-svn-id: svn://10.0.0.236/trunk@113420 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 14:52:37 +00:00
timeless%mac.com
e73045e569 Bug 109138 platform detection not working on macintosh
r=bbaetz r=gerv
adds another regexp for MacOSX


git-svn-id: svn://10.0.0.236/trunk@113412 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 10:05:04 +00:00
bbaetz%student.usyd.edu.au
37e83dae0b Bug 122744 - charting fails taint checks
r=daa@distributed.net, gerv


git-svn-id: svn://10.0.0.236/trunk@113380 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 23:51:38 +00:00
bbaetz%student.usyd.edu.au
af02b7487d Fix up "used only once" warning from kiko's checkin.
r=kiko x 2.


git-svn-id: svn://10.0.0.236/trunk@113379 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 23:46:51 +00:00
jake%acutex.net
11e4684e5b Bug 122636 - Templatise colchange.cgi
Patch by David Lawrence <dkl@redhat.com> and Christian Reis <kiko@async.com.br>
r= kiko, jake


git-svn-id: svn://10.0.0.236/trunk@113349 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 20:12:50 +00:00
jake%acutex.net
0b5e8f4c53 Bug 122589 -- Update gnats conversion script to newer schema of 2.14.
Patch by Andrea Dell'Amico <adellam@link.it>


git-svn-id: svn://10.0.0.236/trunk@113311 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 14:29:21 +00:00
myk%mozilla.org
278c5a5f14 Fix for bug 109480: Removes createattachment.cgi from CVS.
Removed by Myk Melez <myk@mozilla.org>.
r=bbaetz x 2


git-svn-id: svn://10.0.0.236/trunk@113213 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-30 18:08:01 +00:00
myk%mozilla.org
3bad919c98 Fix for bug 104521: Removes old attachment interface in favor of new attachment tracker.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,kiko


git-svn-id: svn://10.0.0.236/trunk@113204 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-30 14:14:12 +00:00
bbaetz%student.usyd.edu.au
65d995cd1d Bug 122154 - change arrays to numeric, and clean up query.atml js
patch by kiko@async.com.br, r=caillon,bbaetz


git-svn-id: svn://10.0.0.236/trunk@113203 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-30 13:43:11 +00:00
gerv%gerv.net
4c6b3e1925 Bug 117509 - createaccount.cgi templatisation.
git-svn-id: svn://10.0.0.236/trunk@113165 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-29 23:26:37 +00:00
zach%zachlipton.com
063a9d3b5e Fix for bug 121735: Perl warning running checksetup.pl if a module has a
non-numeric version number. Patch sets checksetup.pl to use a string
compare instead of a numeric one.

Patch by Dave Miller. r1=Bradley Baetz and r2=Gerv


git-svn-id: svn://10.0.0.236/trunk@113002 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-27 18:59:38 +00:00
gerv%gerv.net
e9fcac9dcb Removing new_comment.cgi - all part of quips.cgi now.
git-svn-id: svn://10.0.0.236/trunk@112894 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-25 22:41:37 +00:00
gerv%gerv.net
32d50f0d78 quips.cgi rewrite and templatisation.
git-svn-id: svn://10.0.0.236/trunk@112893 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-25 22:40:04 +00:00
bbaetz%student.usyd.edu.au
4deb648921 Bug 93037 - use YYYY-MM-DD HH:MM formatting for attachment dates
r=gerv,myk


git-svn-id: svn://10.0.0.236/trunk@112546 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-23 00:24:31 +00:00
bbaetz%student.usyd.edu.au
c53115e19f Bug 120543 - Software error when entering a bug when not logged in & only
one product.
r=caillon,jake


git-svn-id: svn://10.0.0.236/trunk@112535 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-22 22:23:21 +00:00
bbaetz%student.usyd.edu.au
7f8c1e8eec Bug 121074 - taint error after changing bug
r=daa@distributed.net,jake


git-svn-id: svn://10.0.0.236/trunk@112518 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-22 15:12:11 +00:00
bbaetz%student.usyd.edu.au
34d34e045d Bug 98368 - dbi connect doesn't use db_port option.
Patch by gene.stuckey@tellabs.com, r=bbaetz,justdave


git-svn-id: svn://10.0.0.236/trunk@112517 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-22 06:49:22 +00:00
bbaetz%student.usyd.edu.au
aa693e532f Bug 121170 - template outputs empty <style> tag
r=justdave,timeless


git-svn-id: svn://10.0.0.236/trunk@112512 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-22 05:08:09 +00:00
jake%acutex.net
186ffc081a Bug 113438 - The DTD from Bugzilla's XML output was not correct, so any attempts to validate the output were futile.
Patch by Jan <tamino_xml@yahoo.com>
r= jake


git-svn-id: svn://10.0.0.236/trunk@112494 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-21 13:39:54 +00:00
justdave%syndicomm.com
c148fadef8 Fix for bug 108982: enable taint mode for all user-facing CGI files.
Patch by Brad Baetz <bbaetz@student.usyd.edu.au>
r= jake, justdave


git-svn-id: svn://10.0.0.236/trunk@112490 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-20 01:44:52 +00:00
jake%acutex.net
664c6941a1 Remove files no longer needed after the latest changes to the docs
git-svn-id: svn://10.0.0.236/trunk@112484 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-19 14:34:40 +00:00
jake%acutex.net
d84d21016e Latest version of compiled docs (picking up recent SGML changes).
git-svn-id: svn://10.0.0.236/trunk@112476 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-18 23:27:01 +00:00
dkl%redhat.com
9a7a02ee28 Fix for bug 120817 - Log Out and %commandmenu% in bannerhtml, r=justdave,dkl
git-svn-id: svn://10.0.0.236/trunk@112446 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-18 20:04:32 +00:00
dkl%redhat.com
8d6ec47425 Fix for bug 119060 - Use of Template.pm filters for url and html encoding. r=jake,dkl
git-svn-id: svn://10.0.0.236/trunk@112436 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-18 16:50:08 +00:00
jake%acutex.net
069219670c Bug 120081 - Bugzilla now requires version 2.06 of the Template Toolkit.
r= bbaetz, justdave


git-svn-id: svn://10.0.0.236/trunk@112371 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-17 01:57:24 +00:00
justdave%syndicomm.com
6438794986 Fix for bug 99608: dependency mails are no longer sent if the dependent bug can't be seen by the would-be recipient of the email.
Patch by Jake Steenhagen and David Kilzer
r= gerv, justdave


git-svn-id: svn://10.0.0.236/trunk@112288 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-16 03:25:52 +00:00
zach%zachlipton.com
d10de70251 Additional fix for bug 112914: "Test should not cat $file" Previous
patch fixed the problem, but this patch stops once it finds strict so
it will not take as long to run.

Patch by ddkilzer@theracingworld.com. R=zach@zachlipton.com though review
is not required for tests.


git-svn-id: svn://10.0.0.236/trunk@111930 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-11 03:53:18 +00:00
myk%mozilla.org
c8355dadaf Fix for bug 113383: Add a link to the dependent bug in emails about a dependent bug changing state.
Patch by Myk Melez <myk@mozilla.org>.
r=caillon,jake


git-svn-id: svn://10.0.0.236/trunk@111854 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-10 21:47:04 +00:00
jake%acutex.net
df47257748 Bug 113975 - Changing only cc on mass change page incorrectly gives an error that you didn't select anything to change.
r= myk x2


git-svn-id: svn://10.0.0.236/trunk@111447 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-06 14:36:00 +00:00
jake%acutex.net
00a0bd35b2 Bug 112914 - This test was relying on the existance of the unix "cat" command instead of using perl's standard open() function. This caused a test failed when running the tinderbox script on win32.
git-svn-id: svn://10.0.0.236/trunk@111359 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-04 16:04:09 +00:00
justdave%syndicomm.com
8320024dd1 SECURITY FIX for bug 109679: It was possible to send arbitrary SQL to buglist.cgi by altering the HTML form before submitting.
Patch by Dave Miller <justdave@syndicomm.com>
r= dkl, gerv


git-svn-id: svn://10.0.0.236/trunk@111175 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-30 05:46:24 +00:00
myk%mozilla.org
5d240532a4 Fix for bug 97784: Wrap comments properly on "edit attachment" page.
Fix by Myk Melez <myk@mozilla.org>.
r=kiko,justdave


git-svn-id: svn://10.0.0.236/trunk@111071 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-26 17:25:32 +00:00
jake%acutex.net
a95f433eab Re-fixing bug 37339 - Checking an undefined variable for a specific value didn't work in Netscape 4 (and was probably a strict warning everywhere else).
Fix by Christian Reis <kiko@async.com.br>
r= afranke, jake


git-svn-id: svn://10.0.0.236/trunk@111060 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-24 22:24:35 +00:00
timeless%mac.com
21c081c8bc Bugzilla Bug 106386 rid source of these misspellings: persistant persistance priviledge protocal editting editted targetted targetting
r='s from many people. sr=jst


git-svn-id: svn://10.0.0.236/trunk@111049 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-23 23:23:41 +00:00
timeless%mac.com
0597ad741b Bug 98080 ask for an attachment number when no params are given
r=dkl r=justdave


git-svn-id: svn://10.0.0.236/trunk@110929 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-20 23:42:28 +00:00
zach%zachlipton.com
78c6d67164 Fix for bug 113646, midair when changing assignee gives error. Fix changes sub trim() in globals.pl not to use $_ so as not to conflict with $_ values allready
set.

Patch by myk@mozilla.org, r1=bbaetz, r2=dave.


git-svn-id: svn://10.0.0.236/trunk@110600 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-17 01:29:52 +00:00
justdave%syndicomm.com
f7d2ddd8f0 Fix for bug 102487: If you had "comment on product change required" turned on in your installation, Bugzilla would warn you of
a forgotten comment AFTER allowing you to choose new components, versions, and milestones, forcing you to hit your back button
TWICE to correct your mistake.  This checkin corrects that.
Patch by David Kilzer <ddkilzer@theracingworld.com>
r= caillon, gerv


git-svn-id: svn://10.0.0.236/trunk@110556 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-16 00:05:54 +00:00