Some cleanup, use of "class" instead of "id" for the "open in tabs" menuitem and menuseparator, because the latter are supposed to be unique in the document.
git-svn-id: svn://10.0.0.236/trunk@150459 18797224-902f-48f8-a5cc-f745e15eee43
Bug 210910: Right-clicking a file within a bookmarks folder in the bookmarks menu or toolbar makes that folder inaccessible
I added the bm command controller to the menubar bookmark menu, to deal with hidden bookmarks toolbar.
git-svn-id: svn://10.0.0.236/trunk@150417 18797224-902f-48f8-a5cc-f745e15eee43
Also remove the bookmark edit command (ex: cmd_bm_paste) and use the edit ones instead (ex: cmd_paste)
git-svn-id: svn://10.0.0.236/trunk@147945 18797224-902f-48f8-a5cc-f745e15eee43
- logic change: a transaction will not be performed when one of its item can not be acted on. Before, the only the valid items were processed. A LOT of simplifications have come up. I am slowly moving toward the resolution of bug 168411, by simplifying the interface that will be needed to move the transactions to the bookmarks service.
- fix bug 221550: the selection is not retained when performing an invalid transaction
- no need to restore the selection after an action that doesn't touch the datasource.
- during a batch, the bookmarks toolbar observer wasn't notified.
- much faster preUpdateTreeSelection
- various code cleanup
- DND bookmarks in tree is now significantly faster.
- still need to figure out what is the best BATCH_LIMIT value.
git-svn-id: svn://10.0.0.236/trunk@147752 18797224-902f-48f8-a5cc-f745e15eee43
an additional fix is included: if no ...#BookmarksToolbarFolder arc is found, then search for an (obsolete) resource "NC:PersonalToolbarFolder" (221410).
When none of them is found, then a new btf is created (only once!).
git-svn-id: svn://10.0.0.236/trunk@147747 18797224-902f-48f8-a5cc-f745e15eee43
- remove unused functions. Note that RDF commands were already broken, so deleteBookmarkItem and insertBookmarkItem (that were not used) may come back, but in another form.
- remove the "New Bookmark Folder" and "New Search Folder"
- refactor the "html" serializer to avoid some duplicated code.
- remove the use of the profile name for the bookmarks root.
- enforce synthax "aArgument" in some random places.
git-svn-id: svn://10.0.0.236/trunk@147534 18797224-902f-48f8-a5cc-f745e15eee43
Bug 205378 - Meta bug for changes in bookmarks sorting code
r=jag, sr=sspitzer, a=sspitzer,asa
The CloneResource() has been back ported from Firebird, originally
implemented by Pierre Chanial.
git-svn-id: svn://10.0.0.236/trunk@142814 18797224-902f-48f8-a5cc-f745e15eee43
2) no context menus on the static menu items. (original patch by Chu Alan)
git-svn-id: svn://10.0.0.236/trunk@141527 18797224-902f-48f8-a5cc-f745e15eee43
first step to clean the 'add bookmark' mess (removing a flag because we always show the dialog, and moving addBookmarkFor*Browser in browser.js where it belong)
git-svn-id: svn://10.0.0.236/trunk@141506 18797224-902f-48f8-a5cc-f745e15eee43
bug 168504: de-XBLify the bookmarks toolbar
bug 172328, 172291: various DND problems
bug 192028: add context menus to the bookmark menu and the bookmarks toolbar.
git-svn-id: svn://10.0.0.236/trunk@138306 18797224-902f-48f8-a5cc-f745e15eee43
