179 Commits

Author SHA1 Message Date
myk%mozilla.org
3bad919c98 Fix for bug 104521: Removes old attachment interface in favor of new attachment tracker.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,kiko


git-svn-id: svn://10.0.0.236/trunk@113204 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-30 14:14:12 +00:00
gerv%gerv.net
4c6b3e1925 Bug 117509 - createaccount.cgi templatisation.
git-svn-id: svn://10.0.0.236/trunk@113165 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-29 23:26:37 +00:00
bbaetz%student.usyd.edu.au
c53115e19f Bug 120543 - Software error when entering a bug when not logged in & only
one product.
r=caillon,jake


git-svn-id: svn://10.0.0.236/trunk@112535 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-22 22:23:21 +00:00
justdave%syndicomm.com
c148fadef8 Fix for bug 108982: enable taint mode for all user-facing CGI files.
Patch by Brad Baetz <bbaetz@student.usyd.edu.au>
r= jake, justdave


git-svn-id: svn://10.0.0.236/trunk@112490 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-20 01:44:52 +00:00
justdave%syndicomm.com
17f6281e23 SECURITY FIX bug 54901: If you were using LDAP authentication it would let you log in as anyone if you left the password
blank.
Patch by David Crowe <crow@waveset.com>
r= jmrobins, justdave


git-svn-id: svn://10.0.0.236/trunk@110128 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-09 15:56:23 +00:00
jake%acutex.net
acaebc81a5 Bug 108312 - The mid-air collision page was only showing the most recent changes if two people comitted changes to a bug while you were viewing it.
r=louie, myk


git-svn-id: svn://10.0.0.236/trunk@109001 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-27 15:04:52 +00:00
gerv%gerv.net
f2a3c7158a Bug 98707. Query.cgi rewrite. Patch by me, layout by mpt and others, r=justdave, mattyt. Wahey!
git-svn-id: svn://10.0.0.236/trunk@108457 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 22:23:31 +00:00
matty%chariot.net.au
ca6d7f14fc Moving a comment to the right place, in order to be able to make a comment about my previous check in that accidentally got checked in without a comment, and hence didn't show up on Tinderbox I think.
It was a change to CGI.pl, a fix for bug 105812: Rename "Components" link in sub GetCommandMenu() to "Products".

The patch was by James A Laska <jlaska@us.ibm.com>.


git-svn-id: svn://10.0.0.236/trunk@108420 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 03:54:54 +00:00
matty%chariot.net.au
067fbac069 *** empty log message ***
git-svn-id: svn://10.0.0.236/trunk@108419 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 03:22:50 +00:00
myk%mozilla.org
b5c6611091 Fix test bustage by removing tabs.
git-svn-id: svn://10.0.0.236/trunk@106762 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-31 00:21:28 +00:00
myk%mozilla.org
dc4c583cd4 Fix for bug 98602: re-implementation of "create attachment" page.
Patch by Myk Melez <myk@mozilla.org>.
r=gerv@mozilla.org,jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@106739 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-30 23:42:22 +00:00
jake%acutex.net
d377a74d28 Bug 105879 - Footer links have an extra | by Sanity Check
Patch by Matthew Tuck <matty@chariot.net.au>
r= dkl@redhat.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@106377 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-26 18:49:33 +00:00
bbaetz%cs.mcgill.ca
cced8d8047 Bug 97469 - Assignee/QA/Reporter/CC don't get email on restricted bugs.
Also fixes seeing bugs in the buglist (bug 95024), dependancy lists,
tooltips, duplicates, and everywhere else I could see which checked group
bugs.groupset == 0.

Also fxed bug 101560, by clearing BASH_ENV

r=myk,justdave


git-svn-id: svn://10.0.0.236/trunk@106051 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-23 15:44:53 +00:00
jake%acutex.net
71b60e4071 Bug 105480 - Use the friendly name from the fielddefs table when reporting strictvalue errors if it's available.
Patch by James A. Laska <jlaska@us.ibm.com>
r= justdave@syndicomm.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@105860 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-20 00:50:27 +00:00
gerv%gerv.net
0aa19e6335 Bug 104105 - cosmetic change to make it obvious that you can create an account.
git-svn-id: svn://10.0.0.236/trunk@105399 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-15 03:59:19 +00:00
justdave%syndicomm.com
d27f46ad1e Fix for bug 104516: No code changes in this patch, all this checkin does is remove all tabs from the bugzilla source and replace it with the appropriate number of spaces (in most cases 8) to line up with existing code. This is part of the effort to bring the existing codebase up to par with our style guidelines.
Patch by Jake Steehagen <jake@acutex.net>
r= justdave x2


git-svn-id: svn://10.0.0.236/trunk@105335 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-13 01:36:17 +00:00
justdave%syndicomm.com
defa1bc955 Fix for bug 19910: Bugzilla installs on the same server would interfere with each others' cookies. Cookies now have a path value that can be set to indicate which bugzilla install they belong to. Browsers will only send the cookie to the appropriate installation. The path can be set in the 'cookiepath' parameter in editparams.cgi.
Patch by Dave Lawrence <dkl@redhat.com>
r= myk, justdave


git-svn-id: svn://10.0.0.236/trunk@105325 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-13 00:40:41 +00:00
justdave%syndicomm.com
25caa8b542 Fix for bug 101056: multiple form values of the same name were not getting correctly stashed if the user had to log in as part
of a form submit.
Patch by Myk Melez <myk@mozilla.org>
r= gerv, justdave


git-svn-id: svn://10.0.0.236/trunk@105295 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-12 21:33:21 +00:00
gerv%gerv.net
0ab43dc59d Bug 100490 - better error message with no JavaScript for QuickSearch. Patch by afranke, r=kiko, gerv.
git-svn-id: svn://10.0.0.236/trunk@105284 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-12 20:54:26 +00:00
jake%acutex.net
fff7589bc3 Fix for bug 104180 - &nbsp; should only be used in the display for a saved query w/a space, not in the URL.
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@105189 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-11 19:51:33 +00:00
jake%acutex.net
40a00dee48 Fix for bug 104117 - The editkeywords.cgi link was broken as a result of the fix for bug 103554.
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@105185 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-11 19:07:00 +00:00
justdave%syndicomm.com
c7e784100c Fix for bug 103554: HTML generated by the PutHeader and GetCommandMenu subroutines now validates as HTML 4.01 at W3C.
Patch by Christian Reis <kiko@async.com.br>
r= caillon, gerv, justdave


git-svn-id: svn://10.0.0.236/trunk@105115 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-10 23:36:29 +00:00
jake%acutex.net
58d1809148 Fix for bug 65164 - Bugzilla wasn't sending </html> at the end of its pages.
Patch by Christian Reis <kiko@async.com.br>
r= gerv@mozilla.org, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@105030 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-10 13:26:28 +00:00
timeless%mac.com
c21ee7ffe6 Bugzilla Bug 97185 make_select should add a newline after each option
patch by kiko. r=zach, gerv


git-svn-id: svn://10.0.0.236/trunk@105011 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-10 04:52:09 +00:00
myk%mozilla.org
4d5caedf91 Fix for bug 76714: correctly nests the FORM and TABLE elements.
Patch by Gerv Markham <gerv@mozilla.org>.
r=myk@mozilla.org, no second review needed.


git-svn-id: svn://10.0.0.236/trunk@104697 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-06 00:03:00 +00:00
myk%mozilla.org
ec02ad7ac1 Fix for bug 73959: Make buglist.cgi display the "Show Votes" link at the bottom of the screen.
Patch by Jake <jake@acutex.net>.
r=myk@mozilla.org, no second review needed.


git-svn-id: svn://10.0.0.236/trunk@104117 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-28 19:17:27 +00:00
gerv%gerv.net
86fd0a166e Make Bugzilla support <link> tag for buglists. Bug 87818. r=jake, caillon.
git-svn-id: svn://10.0.0.236/trunk@102665 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-10 21:26:05 +00:00
justdave%syndicomm.com
9dabccd718 Fix for bug 69616: If you have tweakparams privs, the "Sanity check" link was listed with a group of items that said "Edit" so
it appeared as if you were going to edit the sanity checks if you clicked on it, when in fact you were going to run them.
This patch rewords the links so Sanity check is in a group by itself in the block of links on the right.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave x2


git-svn-id: svn://10.0.0.236/trunk@102371 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-06 02:19:04 +00:00
myk%mozilla.org
9f3ec3f125 Fix for bug 84338: initial implementation of attachment tracker, which lets users flag attachments with statuses.
Patch by Myk Melez <myk@mozilla.org>
r=justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@102065 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-31 03:54:37 +00:00
jake%acutex.net
ca886b1282 Bug 96085 - bypassing group security checks using duplicate bugs
Patch by Christopher Aillon <christopher@aillon.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@101811 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-26 18:51:45 +00:00
myk%mozilla.org
063c2aa355 Fix for bug 96085: don't allow unauthorized users to access restricted bugs that do not have a QA contact.
Patch by Myk Melez <myk@mozilla.org>
r=Jake <jake@acutex.net>


git-svn-id: svn://10.0.0.236/trunk@101433 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-20 20:36:10 +00:00
justdave%syndicomm.com
77273a9a7b Fix for bug 87779: thanks to the new password reset code, there was no clear way to create a new Bugzilla account from the login screen. There is now a link to createaccount.cgi from the login screen, and the text around the password reset button has been edited so it doesn't sound like you can get a new account by using it (because you can't)
Patch by Dave Miller <justdave@syndicomm.com>
r= myk@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@101193 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-16 06:43:21 +00:00
jake%acutex.net
8d75bc0860 Fix for bug 95082 - Param('shutdownhtml') doesn't completely shut down bugzilla.
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@100921 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-13 19:11:35 +00:00
justdave%syndicomm.com
929927863c Fix for bug 39816: Anyone in CC, Reporter, QA Contact, or Asigned To fields can now be given access to view a bug even if the permissions on that bug are set to a group that would normally exclude those people.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@100906 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-13 00:46:20 +00:00
justdave%syndicomm.com
19a161bd38 Re-fix for bug 55161 - if data is partial in activity table, prepend a ? to indicate that we don't know for sure what got dropped.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@100645 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-09 06:12:18 +00:00
jake%acutex.net
b65bd37c2f Fix for bug 92713, show_activity.pl displays zeros as non-breaking spaces.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@100005 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-30 12:52:21 +00:00
jake%acutex.net
559c643f79 Fix for bugs 55161 and 12819. The activity log now stores only what's changed in multi-value fields.
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@99648 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-20 15:18:30 +00:00
justdave%syndicomm.com
b578f52ce7 Fixing minor problem caused by the original bug 77473 checkin where an SQL error was being produced if you tried to log in
with an invalid username.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@99326 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-16 19:38:34 +00:00
justdave%syndicomm.com
a32206490b Fix for bug 77473, bug 74032, and bug 85472: Passwords are no longer stored in plaintext in the database. Passwords are no longer encrypted with MySQL's ENCRYPT() function (because it doesn't work on some installs), but with Perl's crypt() function. The crypt-related routines now properly deal with salts so that they work on systems that use methods other than UNIX crypt to crypt the passwords (such as MD5). Checksetup.pl will walk through your database and re-crypt everyone's passwords based on the plaintext password entry, then drop the plaintext password column. As a consequence of no longer having a plaintext password, it is no longer possible to email someone their password, so the login screen has been changed to request a password reset instead. The user is emailed a temporary identifying token, with a link back to Bugzilla. They click on the link or paste it into their browser and Bugzilla allows them to change their password.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@99057 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-11 05:29:21 +00:00
justdave%syndicomm.com
18d9089fcc Fix for bug 87701: Invalid username in bug changes echoed back without escaping HTML data
Patch by Gervase Markham <gervase.markham@univ.ox.ac.uk>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@98634 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-04 07:06:00 +00:00
justdave%syndicomm.com
11c1fc0d98 Fix for bug 85833: show_bug.cgi (and probably others) now allow leading or trailing spaces in the bug id, to allow for user input error. This used to work, and recent bug validation changes broke it.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@97469 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-19 22:48:21 +00:00
jake%acutex.net
5743b31229 Allow '\' as a path delimiter (bug 29064)
Patch Concept by <timeless@mac.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@97370 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-18 23:13:18 +00:00
justdave%syndicomm.com
62f8abbb9a Fix for bug 15980: Password is no longer shown in the location bar on the first page you load after logging in.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96648 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-07 20:26:40 +00:00
justdave%syndicomm.com
5c9e4da69d fix typo
git-svn-id: svn://10.0.0.236/trunk@96598 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-07 01:31:51 +00:00
tara%tequilarista.org
cbb24b9172 Landing Myk's patch for bug #71767
git-svn-id: svn://10.0.0.236/trunk@96243 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-02 22:02:02 +00:00
jake%acutex.net
ce19d8c942 Bugzilla was leaking information about bugs marked secure (using bug groups). This checkin fixes bugs 39524, 39527, 39531, and 39533.
Patches by Myk Melez <myk@mozilla.org>.
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96121 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-31 15:52:25 +00:00
justdave%syndicomm.com
eee9480678 Fix for bug 38859: escape invalid email addresses for HTML before displaying to the user.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net, justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@94669 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-11 18:02:38 +00:00
justdave%syndicomm.com
d0938a0ed7 Fix for bug 38855: showvotes.cgi needs to escape (untrusted) url params
Patch by Myke Melez <myk@mozilla.org>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@94446 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-10 02:53:22 +00:00
dave%intrec.com
3b13ee4bac Attempted fix for bug 71574: footer anomoly cleanup
git-svn-id: svn://10.0.0.236/trunk@89253 18797224-902f-48f8-a5cc-f745e15eee43
2001-03-10 22:06:57 +00:00
cyeh%bluemartini.com
2cf75195a2 fix for "My Votes" floating in space like a disconnected astronaut
git-svn-id: svn://10.0.0.236/trunk@89227 18797224-902f-48f8-a5cc-f745e15eee43
2001-03-10 05:52:54 +00:00