Commit Graph

205 Commits

Author SHA1 Message Date
chanial%noos.fr
29b34a142a removing comm.jar dependencies in the bookmarks component. Escape close the window and fix for bug 168412.
Also remove the bookmark edit command (ex: cmd_bm_paste) and use the edit ones instead (ex: cmd_paste)


git-svn-id: svn://10.0.0.236/trunk@147945 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-14 05:20:35 +00:00
chanial%noos.fr
8a748c3787 Undo overzealous commenting (bug 221692)
git-svn-id: svn://10.0.0.236/trunk@147798 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-09 15:04:42 +00:00
chanial%noos.fr
19b7d720d7 fix regression from last checkin (bug 221667)
git-svn-id: svn://10.0.0.236/trunk@147796 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-09 12:08:44 +00:00
chanial%noos.fr
fb4929d722 - fix regression 221118: Can't drag links into bookmark manager or bookmark sidebar.
- logic change: a transaction will not be performed when one of its item can not be acted on. Before, the only the valid items were processed. A LOT of simplifications have come up. I am slowly moving toward the resolution of bug 168411, by simplifying the interface that will be needed to move the transactions to the bookmarks service.
- fix bug 221550: the selection is not retained when performing an invalid transaction
- no need to restore the selection after an action that doesn't touch the datasource.
- during a batch, the bookmarks toolbar observer wasn't notified.
- much faster preUpdateTreeSelection
- various code cleanup
- DND bookmarks in tree is now significantly faster.
- still need to figure out what is the best BATCH_LIMIT value.


git-svn-id: svn://10.0.0.236/trunk@147752 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-08 09:01:48 +00:00
chanial%noos.fr
21d5f7a905 checking in back the fix for bug 172113.
an additional fix is included: if no ...#BookmarksToolbarFolder arc is found, then search for an (obsolete) resource "NC:PersonalToolbarFolder" (221410).
When none of them is found, then a new btf is created (only once!).


git-svn-id: svn://10.0.0.236/trunk@147747 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-08 08:17:23 +00:00
chanial%noos.fr
9ae0c6a598 For the next cycles: backing out the changes for bug 172113 to investigate perf because I landed them just after the tinderbox went down and also because large landings occurred before it went up.
git-svn-id: svn://10.0.0.236/trunk@147740 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-08 04:45:29 +00:00
chanial%noos.fr
25c51f48de - bug 172113: rewrite the way we handle the bookmarks toolbar folder. Now, there is no more 2 ways to characterize the BTF: by an arc to the resource "...#BookmarksToolbarFolder" that points to the literal "true". As a consequence, the resource NC:PersonalToolbarFolder and "...#folderType" are dead.
- remove unused functions. Note that RDF commands were already broken, so deleteBookmarkItem and insertBookmarkItem (that were not used) may come back, but in another form.
- remove the "New Bookmark Folder" and "New Search Folder"
- refactor the "html" serializer to avoid some duplicated code.
- remove the use of the profile name for the bookmarks root.
- enforce synthax "aArgument" in some random places.


git-svn-id: svn://10.0.0.236/trunk@147534 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-03 20:30:14 +00:00
chanial%noos.fr
d58dde0628 - code level cleaning up of bookmarksProperties.js
- fixing a potential crash in nsBookmarksService::GetTarget (when the RDF resource is null)
- remove unused function isChildOfContainer and GetResource in bookmarks.js though we may need later the latter.


git-svn-id: svn://10.0.0.236/trunk@147460 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-30 16:16:56 +00:00
chanial%noos.fr
d9972c787c fixing bustage by putting back placeholders for AddBookmarkImmediately and IsBookmarked since they are used in nsInternetSearchResult.cpp.
I'll fix later these useless callers.


git-svn-id: svn://10.0.0.236/trunk@147459 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-30 15:56:16 +00:00
chanial%noos.fr
2c309d455c - adding bookmark/separator in the bookmark manager now calls the property dialog for consistency with the folders.
- fix the use of the immutable bookmarks.
- remove unused methods: GetLastCharset and AddBookmarkImmediately
- porting several small fixes mainly from Jan's work
- more prototyping for BookmarkTransaction


git-svn-id: svn://10.0.0.236/trunk@147445 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-29 21:43:11 +00:00
bryner%brianryner.com
260b09f147 Fix build on gcc 3.4 by removing extra semicolons (bug 218551). r/sr=dbaron, a=brendan.
git-svn-id: svn://10.0.0.236/trunk@146613 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-07 21:37:51 +00:00
blakeross%telocity.com
583f9b7c15 Hacky workaround for bug 210910 -- to be removed after 0.7.
git-svn-id: svn://10.0.0.236/trunk@146390 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-27 19:03:27 +00:00
chanial%noos.fr
1f11a84028 port textbox fix for bug 197486:
callback method in textbox is no more, use oncommand instead for the same functionality.


git-svn-id: svn://10.0.0.236/trunk@146131 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-17 11:17:00 +00:00
chanial%noos.fr
a709ad371b porting fixes from seamonkey:
bug 201381/205129: Auto-importing IE favorites with directory entries may take a very long time, CPU usage 100% (by ssu)
bug 179084: Bookmark Export uses Unix carriage returns on all platforms (by Frank Wein, mcsmurf@gmx.net)
bug 210541: Bookmarks now crash if nsIProfile impl is not present. (by ccarlen)
bug 203992: Bookmark's Notify/schedule fail to prompt user when change has occured (by varga)


git-svn-id: svn://10.0.0.236/trunk@146075 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-16 00:24:23 +00:00
hyatt%mozilla.org
539151a004 Fix Open in Tabs on Mac with a hacky JS workaround.
git-svn-id: svn://10.0.0.236/trunk@145829 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-10 01:50:05 +00:00
noririty%jcom.home.ne.jp
c2ada7156d Fix 213787 - Add an id for 'Open in Tabs' menuseparator. Patch by logan@dct.com.
git-svn-id: svn://10.0.0.236/trunk@145749 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-08 14:42:01 +00:00
noririty%jcom.home.ne.jp
3d7cffca2f Fix 212188 - Increase accessibility to set homepage from bookmark.
git-svn-id: svn://10.0.0.236/trunk@145745 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-08 14:08:57 +00:00
blakeross%telocity.com
23e2800bee Fixing some description-related issues.
git-svn-id: svn://10.0.0.236/trunk@145655 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-06 09:14:03 +00:00
blakeross%telocity.com
30e7e2a62a Minor cleanup.
git-svn-id: svn://10.0.0.236/trunk@145653 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-06 08:40:04 +00:00
blakeross%telocity.com
8db3d16e6b Hide webpanels checkbox for folders/separators.
git-svn-id: svn://10.0.0.236/trunk@145644 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-06 02:58:52 +00:00
hyatt%mozilla.org
24dfd9146a Make cmd+click work to open new tabs. Make cmd+number work to switch tabs. Mac OS X only.
git-svn-id: svn://10.0.0.236/trunk@145609 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-05 09:31:32 +00:00
hyatt%mozilla.org
be959c309a Slight simplifcation to the way open in tabs works.
git-svn-id: svn://10.0.0.236/trunk@145606 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-05 08:59:45 +00:00
ben%bengoodger.com
f26e2fe8fb components/bookmarks/content/selectBookmark.xul
components/bookmarks/locale/bookmarks.dtd
- Make dialog a bit wider, add some explanatory text for Start Groups and polish.


git-svn-id: svn://10.0.0.236/trunk@145559 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-04 22:37:16 +00:00
hyatt%mozilla.org
c3b1369976 Separate the Page Holder concept from sidebar bookmarks.
git-svn-id: svn://10.0.0.236/trunk@145523 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-04 03:40:27 +00:00
noririty%jcom.home.ne.jp
c96af621ca Bug 180156 - fix overlap chevron, patch (mostly) by dkoppenh@null.net
git-svn-id: svn://10.0.0.236/trunk@145515 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-03 14:49:27 +00:00
hyatt%mozilla.org
6b0d40ba1a Implement the Add Page button in the Web Panels sidebar.
git-svn-id: svn://10.0.0.236/trunk@145508 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-03 08:25:19 +00:00
hyatt%mozilla.org
dd62007e24 Implement support for Web Panel bookmarks.
git-svn-id: svn://10.0.0.236/trunk@145503 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-03 01:58:52 +00:00
hyatt%mozilla.org
f1754432bd Hook up the web panels property in the bookmark properties dialog. Next step will be to make all the bookmarks access points honor this property and actually load the bookmark in the web panel.
git-svn-id: svn://10.0.0.236/trunk@145502 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-02 21:35:54 +00:00
hyatt%mozilla.org
f22850a13d Impl the webpanels property in the bookmarks service. Remove the bogo text from the bookmark properties dialog.
git-svn-id: svn://10.0.0.236/trunk@145497 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-02 20:12:35 +00:00
noririty%jcom.home.ne.jp
ba2224f002 Fix 212412 - remove unused findbookmark function
git-svn-id: svn://10.0.0.236/trunk@145057 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-22 14:17:24 +00:00
kerz%mozillazine.org
db22ee4007 New theme update from Arvid, giddy up.
git-svn-id: svn://10.0.0.236/trunk@144680 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-10 06:49:54 +00:00
bzbarsky%mit.edu
e81d4cb336 Move to the double-'::' notation for -moz-tree-* pseudo-elements in browser/.
Bug 211657, r+sr=dbaron


git-svn-id: svn://10.0.0.236/trunk@144539 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-07 22:18:42 +00:00
mkaply%us.ibm.com
87a5ad436c fix for bug 206379:
- combine nsICharsetConverterManager2 and nsICharsetConverterManager
- get rid of nsIAtom in most of the methods
- provide versions of getUnicodeDecoder/Encoder which don't do alias resolution
- change all charset types to ASCII strings
- clean up some other i18n APIs which could be simplified
- fix all consumers of all changed i18n interfaces
r=jshin, smontagu
rs=sfraser


git-svn-id: svn://10.0.0.236/trunk@143595 18797224-902f-48f8-a5cc-f745e15eee43
2003-06-11 19:31:48 +00:00
bryner%netscape.com
adffb36a08 Removing CFM build files.
git-svn-id: svn://10.0.0.236/trunk@143555 18797224-902f-48f8-a5cc-f745e15eee43
2003-06-11 00:28:11 +00:00
varga%netscape.com
c1c2acd6b5 Landing bookmarks changes.
Bug 205378 - Meta bug for changes in bookmarks sorting code
r=jag, sr=sspitzer, a=sspitzer,asa

The CloneResource() has been back ported from Firebird, originally
implemented by Pierre Chanial.


git-svn-id: svn://10.0.0.236/trunk@142814 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-23 12:03:40 +00:00
ben%netscape.com
2e153994a8 Wiping hyatt's ass. Back out web panels for MF0.6 :-)
git-svn-id: svn://10.0.0.236/trunk@142553 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-16 19:22:12 +00:00
chanial%noos.fr
b33eabd169 bug 68541: unchecked toolbar menuitem in the bookmark manager.
Clean up in utilityOverlay.js
- in goToggleToolbar: use of properties instead of attributes
- in getBrowserURL: don't use 'browser.chrome' pref.
Some dependency work in bookmarksManager.xul. More to be done.


git-svn-id: svn://10.0.0.236/trunk@141954 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-30 00:21:48 +00:00
chanial%noos.fr
6e65b9cb42 Landing Arvid's new icons and animations
git-svn-id: svn://10.0.0.236/trunk@141803 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-25 08:15:34 +00:00
chanial%noos.fr
03837e0a60 remove safe guard and allow now to copy a bookmark in the folder in which it is contained.
git-svn-id: svn://10.0.0.236/trunk@141767 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-24 22:07:17 +00:00
chanial%noos.fr
88582fb263 bug 200480: cut/paste doesn't work on folders and separators
git-svn-id: svn://10.0.0.236/trunk@141763 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-24 21:46:55 +00:00
chanial%noos.fr
d2465b826e re-hook the undo/redo menu listeners
git-svn-id: svn://10.0.0.236/trunk@141702 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-23 18:08:25 +00:00
chanial%noos.fr
85f55566c9 Don't scroll to row=1 in the bookmarks manager
git-svn-id: svn://10.0.0.236/trunk@141700 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-23 17:57:26 +00:00
chanial%noos.fr
08b24718db keep the selection active after a DND in the bookmark manager
git-svn-id: svn://10.0.0.236/trunk@141698 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-23 17:29:05 +00:00
chanial%noos.fr
eaf5d01d31 dropping folder group support
git-svn-id: svn://10.0.0.236/trunk@141695 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-23 15:05:10 +00:00
chanial%noos.fr
401b35e3b4 bug 202879: importing and exporting bookmarks are broken + code clean up
git-svn-id: svn://10.0.0.236/trunk@141693 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-23 14:10:49 +00:00
chanial%noos.fr
20126ee452 fixing middle click in menus
git-svn-id: svn://10.0.0.236/trunk@141630 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-22 23:12:25 +00:00
chanial%noos.fr
f790315977 adding missing title for the bookmarks manager
git-svn-id: svn://10.0.0.236/trunk@141629 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-22 23:00:41 +00:00
chanial%noos.fr
8a6ef3a30e porting bug 174197, font error when link bookmarked
git-svn-id: svn://10.0.0.236/trunk@141566 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-22 02:59:58 +00:00
chanial%noos.fr
54ca88ecde fixing 'open in tabs' and commenting
git-svn-id: svn://10.0.0.236/trunk@141565 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-22 02:55:55 +00:00
chanial%noos.fr
bb48f9fed0 1) porting back in phoenix a refactoring I made in seamonkey wrt loading bookmarks
2) no context menus on the static menu items. (original patch by Chu Alan)


git-svn-id: svn://10.0.0.236/trunk@141527 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-21 20:11:58 +00:00