59 Commits

Author SHA1 Message Date
kiko%async.com.br
6501e204df Fix for bug 252378: Remove $COOKIE from attachment.cgi. r=bugreport,
a=justdave.


git-svn-id: svn://10.0.0.236/trunk@159593 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-21 17:53:34 +00:00
jouni%heikniemi.net
7fd5078c36 Bug 223878: Flag system dies when changing a deleted flag.
r=joel, justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@158788 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-06 07:08:02 +00:00
jouni%heikniemi.net
f50a2c60a3 Bug 223541: Make flags show up correctly in "View all attachments" mode.
r=joel
a=justdave


git-svn-id: svn://10.0.0.236/trunk@157124 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-30 15:52:13 +00:00
justdave%bugzilla.org
964fef73ac Bug 204042: taint issues in perl 5.6.0 that were causing an Internal Error to ocurr after adding an attachment.
r= joel, a= justdave


git-svn-id: svn://10.0.0.236/trunk@156202 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-10 16:57:11 +00:00
justdave%syndicomm.com
ba5cacd09f Bug 234540: "Take bug" on create attachment screen missed an API change to BugMail which caused it not to mail the previous bug owner about the change.
r=gerv, a=justdave


git-svn-id: svn://10.0.0.236/trunk@155563 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-27 03:58:55 +00:00
kiko%async.com.br
9a7a2515e4 Additional fix for bug 87770: attachment.cgi should work with no
parameters. Use <button> tags to allow for localization of the labels.
r=myk, a=myk.

I padded the Edit button with &nbsp;s to ensure it has the same width as
the View button; it may not be kosher but passes as visually agreeable,
at least.


git-svn-id: svn://10.0.0.236/trunk@154822 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-13 20:31:27 +00:00
jocuri%softhome.net
35e0719e5b Patch for bug 87770: make attachment.cgi work with no parameters; patch by GavinS <bugzilla@chimpychompy.org>; r=kiko; a=myk.
git-svn-id: svn://10.0.0.236/trunk@154676 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-10 15:08:21 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
myk%mozilla.org
a43046ca7d Fix for bug 127995: shows the size of attachments in the show bug and attachment interfaces.
Patch by Dave Swegen <dswegen@software.plasmon.com>
r=myk
a=myk


git-svn-id: svn://10.0.0.236/trunk@152379 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-05 18:14:11 +00:00
justdave%syndicomm.com
9bcc60146c Bug 232993: Quote the filenames in the Content-disposition header when downloading attachments. This allows spaces to be used in filenames, and fixes compliance with RFCs 2183, 2045, and 822.
r= myk, a= justdave


git-svn-id: svn://10.0.0.236/trunk@152265 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-04 01:52:20 +00:00
gerv%gerv.net
a2ea623db1 Bug 219358 - Make attachments with all supported MIME types viewable in the edit page. Patch by gerv; r=kiko, r,a=justdave.
git-svn-id: svn://10.0.0.236/trunk@149275 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-13 23:44:07 +00:00
justdave%syndicomm.com
a99d8be27f Bug 111522: Provide ability to specify MIME type of attachment when downloading - correction of url parameter name to avoid usage conflicts with other parts of Bugzilla
Patch by Alex Vincent <ajvincent@juno.com>
r= justdave, a= justdave


git-svn-id: svn://10.0.0.236/trunk@148719 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-02 07:36:10 +00:00
kiko%async.com.br
5ab620388e Fix for bug 111522: Provide ability to specify MIME type of attachment
when downloading. Adds a 'ctype' argument to attachment.cgi which allows
one to override the content-type when viewing an attachment. Original
patch by Alex Vincent <ajvincent@juno.com>; I changed it a tiny bit.
r=kiko, myk. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@148470 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-29 01:58:13 +00:00
bbaetz%acm.org
7d7d7e1532 Bug 208699 - Move Throw{Code,Template}Error into Error.pm
r,a=justdave


git-svn-id: svn://10.0.0.236/trunk@146857 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-14 06:05:23 +00:00
jkeiser%netscape.com
1b7dc26697 Check for PatchReader as a part of the installation and disable the "Diff"
links if it is not there (bug 215268)


git-svn-id: svn://10.0.0.236/trunk@146209 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-20 00:45:43 +00:00
jkeiser%netscape.com
682632fc0b Patch Viewer, a pretty way of viewing and manipulating patches (bug 174942). Requires PatchIterator to be installed, classes uploaded to that bug and will be soon in CPAN.
git-svn-id: svn://10.0.0.236/trunk@145390 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-30 20:05:04 +00:00
bbaetz%acm.org
726bcd99cc Bug 180635 - Enhance Bugzilla::User to store additional information
r=myk,jake


git-svn-id: svn://10.0.0.236/trunk@143228 18797224-902f-48f8-a5cc-f745e15eee43
2003-06-03 09:48:15 +00:00
jkeiser%netscape.com
6de391d6bb Make attachment view work again (bug 204964), r=myk@mozilla.org
git-svn-id: svn://10.0.0.236/trunk@142255 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-09 02:12:16 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
myk%mozilla.org
6d65c0a8ff Fix for bug 179510: takes group restrictions into account when sending request notifications
r=bbaetz,jpreed
a=justdave


git-svn-id: svn://10.0.0.236/trunk@141792 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-25 05:41:29 +00:00
bbaetz%acm.org
6ee31579fe Bug 199813 - Make all users of ThrowUserError pass $vars in explicitly.
r=gerv
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140585 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-02 12:35:07 +00:00
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-27 00:07:02 +00:00
preed%sigkill.com
017bee49ea Bug 124174 - make processmail a package (Bugzilla::BugMail), r=gerv, r=jth, a=justdave
git-svn-id: svn://10.0.0.236/trunk@137613 18797224-902f-48f8-a5cc-f745e15eee43
2003-02-09 22:04:25 +00:00
jouni%heikniemi.net
55524ed0b0 Bug 156169: Bug number styling issues in attachment viewer/editor. r=joel, a=justdave
git-svn-id: svn://10.0.0.236/trunk@136295 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-14 06:36:12 +00:00
gerv%gerv.net
03bc3977c4 Bug 116819 - Attach and Reassign in one fell swoop. Patch by gerv; r,a=justdave.
git-svn-id: svn://10.0.0.236/trunk@135317 18797224-902f-48f8-a5cc-f745e15eee43
2002-12-15 09:01:15 +00:00
bugreport%peshkin.net
a99e419a4f Bug 184256 Canedit group_control_map entry does not prevent making attachments
r=bbaetz
a=justdave


git-svn-id: svn://10.0.0.236/trunk@135085 18797224-902f-48f8-a5cc-f745e15eee43
2002-12-11 00:41:19 +00:00
jake%bugzilla.org
62306f0779 Bug 67077 - We now include the timezone (as configured in editparams.cgi) on every time we display.
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@134534 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-27 16:00:44 +00:00
myk%mozilla.org
3d5623ee1c Fix for bug 179876: Labels the "Requestee" field to reduce confusion about its purpose.
r=bbaetz
a=myk


git-svn-id: svn://10.0.0.236/trunk@134062 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-19 01:15:01 +00:00
myk%mozilla.org
b0160244f2 Fix for bug 179334: updates the setter consistently. also fixes numerous other bugs in the RT code.
r=bbaetz
a=myk


git-svn-id: svn://10.0.0.236/trunk@133564 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-11 12:36:27 +00:00
myk%mozilla.org
af7b895494 Fix for bug 171505: shows disabled flags in the UI
r=bbaetz
a=justdave


git-svn-id: svn://10.0.0.236/trunk@133451 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-09 01:58:51 +00:00
myk%mozilla.org
e458425ecb Fix for bug 178841: removes full paths from filenames in attachments table and prevents them from appearing again
r=gerv,bbaetz
a=justdave


git-svn-id: svn://10.0.0.236/trunk@133445 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-09 01:23:07 +00:00
myk%mozilla.org
dae89726c5 Fix for bug 172518: makes the request tracker use the generic user matching code
r=not_erik,joel
a=justdave


git-svn-id: svn://10.0.0.236/trunk@133353 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-08 01:35:46 +00:00
bbaetz%student.usyd.edu.au
b8b08c22b9 Bug 147833 - start using CGI.pm
r=gerv, justdave


git-svn-id: svn://10.0.0.236/trunk@132553 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-26 01:57:09 +00:00
myk%mozilla.org
393a392d87 Fix for bug 98801: Implementation of the request tracker, a set of enhancements to attachment statuses.
r=gerv,bbaetz


git-svn-id: svn://10.0.0.236/trunk@130672 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-28 18:42:54 +00:00
justdave%syndicomm.com
061444b7f3 Fix for bug 171296: changing Content-disposition header in attachment.cgi to use 'inline' instead of 'attachment' so that it
doesn't *force* you to download it.
r= bbaetz, bzbarsky


git-svn-id: svn://10.0.0.236/trunk@130641 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-28 04:10:27 +00:00
bugreport%peshkin.net
2194da2336 bug 157756 - Groups_20020716_Branch Tracking : > 55 groups now supported
r=bbaetz, gerv


git-svn-id: svn://10.0.0.236/trunk@130217 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-22 17:15:13 +00:00
justdave%syndicomm.com
15d5370c4f Fix for bug 63601: Recommend filename when downloading attachments (except in IE4, which chokes on the Content-Disposition header)
Patch by Daniel Raichle <draichle@gmx.net> and Dave Miller <justdave@syndicomm.com>
r= bbaetz, gerv


git-svn-id: svn://10.0.0.236/trunk@130205 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-21 16:57:12 +00:00
gerv%gerv.net
e0d54ace02 Bug 163114 - Templatise all calls to DisplayError. First patch - attachment.cgi. Patch by gerv; r=burnus.
git-svn-id: svn://10.0.0.236/trunk@130181 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-20 22:26:14 +00:00
gerv%gerv.net
ee2413046e Bug 167978 - Fix Throw*Error l10n regressions and add a test to catch more. Patch by gerv; r=bbaetz.
git-svn-id: svn://10.0.0.236/trunk@129434 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-12 22:51:50 +00:00
bbaetz%student.usyd.edu.au
71381b40ed Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
r=joel x2


git-svn-id: svn://10.0.0.236/trunk@128080 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-26 06:17:26 +00:00
bugreport%peshkin.net
a203208d86 Fixed merge problem from checkin of 143826 - No bug
git-svn-id: svn://10.0.0.236/trunk@128044 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-24 14:51:27 +00:00
gerv%gerv.net
12f6d8cb39 Bug 143286 - Add support for Insiders, Private comments, Private Attachments. Patch by bugreport@peshkin.net; r=gerv.
git-svn-id: svn://10.0.0.236/trunk@127640 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-19 21:17:28 +00:00
bbaetz%student.usyd.edu.au
28c5771cf0 Bug 153578 - Attachment modified date is meant to be attachment creation
date
r=preed, joel


git-svn-id: svn://10.0.0.236/trunk@127260 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-14 13:42:33 +00:00
bbaetz%student.usyd.edu.au
1c2ecdc9c2 Bug 43600 - Convert products/components to use ids instead of names.
Initial attempt by jake@bugzilla.org, updated by me
r=joel, preed


git-svn-id: svn://10.0.0.236/trunk@127057 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-12 05:43:05 +00:00
jouni%heikniemi.net
7a90a48d77 Bug 62000: File attachments don't work on Windows. Note: only the code from the patch was checked in, the
documentation issue was split to bug 155743.
2xr=bbaetz


git-svn-id: svn://10.0.0.236/trunk@124673 18797224-902f-48f8-a5cc-f745e15eee43
2002-07-04 09:12:33 +00:00
gerv%gerv.net
c8a771fb68 Bug 138588 - change to use new template structure. Patch by gerv, r=myk, afranke.
git-svn-id: svn://10.0.0.236/trunk@119695 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-24 07:24:50 +00:00
myk%mozilla.org
b4d3313c3d Fix for bug 72184: prevents users from entering too-large comments/descriptions that get rejected by MySQL's MAX_PACKET_SIZE restrictions.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,gerv


git-svn-id: svn://10.0.0.236/trunk@116320 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-11 07:33:03 +00:00
bbaetz%student.usyd.edu.au
54006577b8 Bug 97729 - uploaders need to be able to obsolete their own attachments
r=jake, justdave


git-svn-id: svn://10.0.0.236/trunk@115358 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-26 06:13:35 +00:00
bbaetz%student.usyd.edu.au
8018723bcc Bug 100094 - use generic template handling code
r=mattyt, afranke


git-svn-id: svn://10.0.0.236/trunk@114368 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 02:27:24 +00:00
bbaetz%student.usyd.edu.au
2c81615c9a Bug 122418 pt2 - obsoleting a patch from the create attachment screen gave
a taint error.


git-svn-id: svn://10.0.0.236/trunk@113647 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-05 00:11:48 +00:00