54 Commits

Author SHA1 Message Date
bzrmirror%bugzilla.org
84c5be6eb5 Bug 996893: Perl 5.18 and newer throw tons of warnings about deprecated modules
r=dkl a=sgreen


git-svn-id: svn://10.0.0.236/trunk@265490 18797224-902f-48f8-a5cc-f745e15eee43
2014-08-13 11:01:07 +00:00
mkanat%bugzilla.org
73121c5630 Bug 676844: Replace ThrowCodeError() by ThrowUserError() when the error is not triggered by the code itself
r=glob a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264418 18797224-902f-48f8-a5cc-f745e15eee43
2012-11-12 18:00:45 +00:00
mkanat%bugzilla.org
8e47ba629a Bug 787529: Use |use 5.10.1| everywhere
r=wicked a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264195 18797224-902f-48f8-a5cc-f745e15eee43
2012-09-01 21:45:59 +00:00
mkanat%bugzilla.org
3b5e8524aa Bug 680131: Replace the MPL 1.1 license by the MPL 2.0 one in all files, and add it to files which miss one
r=kiko r=mkanat r=mrbball a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263258 18797224-902f-48f8-a5cc-f745e15eee43
2012-01-11 22:48:45 +00:00
mkanat%bugzilla.org
de47b867f3 Bug 570567: The 'keyword deleted' page does not mention the deleted keyword
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260622 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-05 01:34:38 +00:00
mkanat%bugzilla.org
ecf0f13ce8 Bug 565879: Merge ThrowCodeError("action_unrecognized"), ThrowUserError("no_valid_action") and ThrowCodeError("unknown_action")
r=ghendricks a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260347 18797224-902f-48f8-a5cc-f745e15eee43
2010-05-20 15:46:29 +00:00
mkanat%bugzilla.org
54635db72b Bug 526146: Use remove_from_db to delete keywords in editkeywords.cgi
Patch by Frank Becker <Frank@Frank-Becker.de> r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@258942 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-09 19:51:58 +00:00
lpsolit%gmail.com
9c7acd42c6 Bug 466692: [SECURITY] keywords and unused flag types can be deleted by bypassing the token check - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@256026 18797224-902f-48f8-a5cc-f745e15eee43
2009-02-02 19:04:33 +00:00
mkanat%bugzilla.org
8eacc9bd1f Bug 460293: Implement Bugzilla::Object::set_all and have editkeywords.cgi use it
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@254654 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-18 16:30:21 +00:00
lpsolit%gmail.com
262b269991 Bug 325487: Admin pages should require less "clicks" (remove useless confirmation pages) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=justdave r=mkanat a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@244165 18797224-902f-48f8-a5cc-f745e15eee43
2008-01-27 23:14:26 +00:00
mkanat%bugzilla.org
d7e641858a Bug 399954: Make Bugzilla able to hold its dependencies in a local directory
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@237891 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-19 06:46:19 +00:00
lpsolit%gmail.com
58b1b66792 Bug 281181: [SECURITY] It's way too easy to delete versions/components/milestones etc... - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@213652 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-14 22:02:10 +00:00
mkanat%bugzilla.org
9cd61530a5 Bug 351098: Make Bugzilla::Object able to update objects in the database, and make Bugzilla::Keyword use it
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@209194 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-05 19:18:27 +00:00
mkanat%bugzilla.org
2983474837 Bug 348529: Editing keywords results in a "Software Error"
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@207343 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-14 18:10:13 +00:00
mkanat%bugzilla.org
c5501442b1 Bug 347061: Create Bugzilla::Object->create and make Bugzilla::Keyword use it
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=bkor, a=myk


git-svn-id: svn://10.0.0.236/trunk@207060 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-10 17:53:08 +00:00
mkanat%bugzilla.org
983b9691a4 Bug 343248: SQL query to get all keywords with bug count is duplicated in editkeywords.cgi and describekeywords.cgi
Patch By Remi Zara <remi_zara@mac.com> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201426 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-01 16:45:54 +00:00
lpsolit%gmail.com
a698e74659 Bug 282121: Remove globals.pl from scripts that no longer use it - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@200489 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-21 00:44:48 +00:00
lpsolit%gmail.com
f952ed05cf Bug 304601: Bugzilla::Config's :locations exports need to be in their own module - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat for the main patch, r=myk for the patch about CGI.pm a=justdave
Bug 328637: Remove all legal_* versioncache arrays - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave

Bug 110503 - Eliminate versioncache


git-svn-id: svn://10.0.0.236/trunk@200347 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-19 20:15:18 +00:00
vladd%bugzilla.org
5e7716d947 Spelling patch: 'valididy' -> 'validity'; patch by Vlad Dascalu <vladd@bugzilla.org>.
git-svn-id: svn://10.0.0.236/trunk@200314 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-19 16:31:13 +00:00
lpsolit%gmail.com
c630732145 Bug 319089: editkeywords.cgi throws an error when action="edit" or "delete" and the "id" parameter is invalid - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@185943 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-12 02:47:10 +00:00
lpsolit%gmail.com
a2f6cdb3f9 Bug 313603: The keyword_already_exists error has an undefined variable - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=myk
git-svn-id: svn://10.0.0.236/trunk@182991 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-25 19:16:39 +00:00
lpsolit%gmail.com
e334b85a95 Bug 312157: Remove $::template and $::vars from globals.pl - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182927 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-24 23:11:56 +00:00
lpsolit%gmail.com
529ea73dda Bug 304696: Replace UserInGroup() by $user->in_group() when checking user privs in edit*.cgi files - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@180314 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-15 22:01:56 +00:00
lpsolit%gmail.com
268e3be166 Bug 303705: Eliminate deprecated Bugzilla::DB routines from editkeywords.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=jouni a=justdave
git-svn-id: svn://10.0.0.236/trunk@179632 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-04 18:35:05 +00:00
mkanat%kerio.com
0cbbdcfee7 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177695 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-13 12:27:04 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
bugreport%peshkin.net
9778732be8 Backout of bug 303669 which broke AppendComment and possibly a number
of other items.


git-svn-id: svn://10.0.0.236/trunk@177419 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 11:23:43 +00:00
mkanat%kerio.com
7bbde62ad3 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177413 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 05:59:02 +00:00
mkanat%kerio.com
fda3b0dd8f Bug 174295: ANSI SQL requires all columns in SELECT to be in GROUP BY, unless they are in "aggregate" functions
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@170751 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-16 00:27:15 +00:00
travis%sedsystems.ca
7351a5b76b Bug 283581 : Move UserInGroup out of globals.pl
Patch by Colin Ogilvie <colin.ogilvie@gmail.com>   r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170734 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 22:10:14 +00:00
mkanat%kerio.com
64adf228bd Bug 284975: Any code after Throw*Error is a dead code.
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@170414 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-09 00:26:39 +00:00
jocuri%softhome.net
6e30566dcd Patch for bug 265898: edit*.cgi files should all use ThrowUserError(); patch by Frédéric Buclin <LpSolit@gmail.com>, r=vladd, a=myk.
git-svn-id: svn://10.0.0.236/trunk@167820 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 14:07:31 +00:00
jocuri%softhome.net
c8e5c19ce5 Patch for bug 239576: make sure detaint_natural is always called with a defined value in editkeywords.cgi; r=timeless; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@154505 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-05 01:32:43 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
jocuri%softhome.net
6d77a5b9f2 Patch for bug 234879: remove %FORM from editkeywords.cgi; r=kiko, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@153615 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-06 09:04:33 +00:00
jocuri%softhome.net
93c36a6260 Bug 190223: Complete templatization for editkeywords.cgi; reviewed by kiko, jth, gerv; r/a=justdave.
git-svn-id: svn://10.0.0.236/trunk@150181 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-09 23:12:40 +00:00
bbaetz%acm.org
8fabd677ea Bug 208604 - Make data/template dir locations configurable
git-svn-id: svn://10.0.0.236/trunk@149624 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-22 03:50:42 +00:00
jocuri%softhome.net
89c38b83fc Bug 225703: Partial templatization for editkeywords.cgi; r=jouni; r=gerv; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@149610 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-21 10:00:54 +00:00
justdave%syndicomm.com
80801cd4e8 [SECURITY] Bug 219044: A user with 'editkeywords' privileges (i.e. usually an administrator) can inject arbitrary SQL via the URL used to edit an existing keyword.
Patch by Joel Peshkin <bugreport@peshkin.net>
r= justdave, zach  a= justdave


git-svn-id: svn://10.0.0.236/trunk@148737 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-03 03:31:30 +00:00
kiko%async.com.br
ad61d77b76 Bug 65316: Typos on edit*.cgi. Change use of PutTrailer() (and the
default output, in certain cases) in the edit pages. Patch by Vlad
Dascalu <jocuri@softhome.net>, r=kiko, a=justdave


git-svn-id: svn://10.0.0.236/trunk@147351 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-26 23:47:07 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-27 00:07:02 +00:00
bbaetz%student.usyd.edu.au
71381b40ed Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
r=joel x2


git-svn-id: svn://10.0.0.236/trunk@128080 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-26 06:17:26 +00:00
gerv%gerv.net
d81b80bc41 Bug 95426 - remove $onebug cruft. Patch by gerv; 2xr=timeless.
git-svn-id: svn://10.0.0.236/trunk@125554 18797224-902f-48f8-a5cc-f745e15eee43
2002-07-21 21:47:43 +00:00
bbaetz%student.usyd.edu.au
4403bbe04e Bug 151053, ConnectToDatabase/quietly_check_login sometimes not called
early enough
r=mattyt, jouni


git-svn-id: svn://10.0.0.236/trunk@123428 18797224-902f-48f8-a5cc-f745e15eee43
2002-06-17 09:39:48 +00:00
dkl%redhat.com
a0a2dde0c5 Bug 141326 - broken hyperlink in editkeywords.cgi. Fix by dkl@redhat.com. 2xr=Gerv
git-svn-id: svn://10.0.0.236/trunk@120340 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-30 22:15:52 +00:00
gerv%gerv.net
33a5971d2a Bug 140784 - edit*.cgi need a use lib "." on Win32/IIS w/ taint. Patch by jouni@heikniemi.net; r=bbaetz, gerv.
git-svn-id: svn://10.0.0.236/trunk@120207 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-29 19:32:29 +00:00
cyeh%bluemartini.com
1eb8f5b435 stupid lamo fix for 69621: Keyword cache not updated on keyword rename/delete.
now give warning to admin that keyword cache should be rebuilt after any keyword
edit or deletion.


git-svn-id: svn://10.0.0.236/trunk@88026 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-26 23:25:22 +00:00
tara%tequilarista.org
260f66bb3f Landing Jon Robertson's for bug #41913
git-svn-id: svn://10.0.0.236/trunk@74764 18797224-902f-48f8-a5cc-f745e15eee43
2000-07-25 22:09:20 +00:00
terry%mozilla.org
44682785ae Patch by Klaas Freitag <freitag@suse.de>, with modifications by me --
don't generate HTML tables with more than 50 lines, as browsers generally
can't cope with huge tables.


git-svn-id: svn://10.0.0.236/trunk@58402 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-22 16:51:49 +00:00