166 Commits

Author SHA1 Message Date
bzrmirror%bugzilla.org
f5c9a6502e Bug 978070: Do not use document.write() to insert HTML code
r/a=justdave


git-svn-id: svn://10.0.0.236/trunk@265301 18797224-902f-48f8-a5cc-f745e15eee43
2014-03-26 19:30:50 +00:00
bzrmirror%bugzilla.org
b96e324a0a Bug 770073 - Hardcode "Bugzilla" in templates when it's not related to a specific Bugzilla installation
r=dkl,a=justdave


git-svn-id: svn://10.0.0.236/trunk@265169 18797224-902f-48f8-a5cc-f745e15eee43
2014-01-07 20:45:51 +00:00
bzrmirror%bugzilla.org
8737d78640 Bug 920681: Remove the cellspacing and cellpadding attributes from tables
r/a=justdave


git-svn-id: svn://10.0.0.236/trunk@265157 18797224-902f-48f8-a5cc-f745e15eee43
2013-12-31 13:00:56 +00:00
bzrmirror%bugzilla.org
37f0c2ad4b Bug 952793: Remove HTML4 elements which are obsolete in HTML5
r/a=justdave


git-svn-id: svn://10.0.0.236/trunk@265154 18797224-902f-48f8-a5cc-f745e15eee43
2013-12-22 20:30:45 +00:00
bzrmirror%bugzilla.org
e5338fb372 Bug 906745 - In MySQL, tokens are not case-sensitive, reducing total entropy and allowing easier brute force
r=LpSolit,a=glob


git-svn-id: svn://10.0.0.236/trunk@265056 18797224-902f-48f8-a5cc-f745e15eee43
2013-10-16 16:57:35 +00:00
mkanat%bugzilla.org
73121c5630 Bug 676844: Replace ThrowCodeError() by ThrowUserError() when the error is not triggered by the code itself
r=glob a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264418 18797224-902f-48f8-a5cc-f745e15eee43
2012-11-12 18:00:45 +00:00
mkanat%bugzilla.org
4e0a81d204 Bug 604388 - Filenames used to store data for Old Charts should be based on product IDs, not names (avoid dataloss when renaming products).
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264346 18797224-902f-48f8-a5cc-f745e15eee43
2012-10-16 18:30:44 +00:00
mkanat%bugzilla.org
6a16d3f8bf Bug 749074: Throw an error message instead of syntax error on invalid search type operators
r=LpSolit,a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263768 18797224-902f-48f8-a5cc-f745e15eee43
2012-04-30 06:46:06 +00:00
mkanat%bugzilla.org
39b18a3637 Bug 745197: Add a hook in Bugzilla::Error::_throw_error() so that extensions can control the way to throw errors
r=dkl a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263699 18797224-902f-48f8-a5cc-f745e15eee43
2012-04-17 19:01:32 +00:00
mkanat%bugzilla.org
913aa611ef Bug 696387: Remove useless calls to field-descs.none.tmpl
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263489 18797224-902f-48f8-a5cc-f745e15eee43
2012-02-26 00:01:36 +00:00
mkanat%bugzilla.org
d22395cdef Bug 319953: Missing real email syntax check
r=glob a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263298 18797224-902f-48f8-a5cc-f745e15eee43
2012-01-23 16:17:04 +00:00
mkanat%bugzilla.org
3b5e8524aa Bug 680131: Replace the MPL 1.1 license by the MPL 2.0 one in all files, and add it to files which miss one
r=kiko r=mkanat r=mrbball a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263258 18797224-902f-48f8-a5cc-f745e15eee43
2012-01-11 22:48:45 +00:00
mkanat%bugzilla.org
f350d018e6 Bug 714664: The content of the "emailregexpdesc" parameter is not escaped when displayed to the user
r=dkl a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263228 18797224-902f-48f8-a5cc-f745e15eee43
2012-01-06 00:34:01 +00:00
mkanat%bugzilla.org
2d9314b413 Fix missing-space bugs in error messages. a=LpSolit.
git-svn-id: svn://10.0.0.236/trunk@263032 18797224-902f-48f8-a5cc-f745e15eee43
2011-11-01 17:32:33 +00:00
mkanat%bugzilla.org
683700f670 Bug 288049: "internal error" from ThrowCodeError is confusing. Reword it
r=justdave a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@262613 18797224-902f-48f8-a5cc-f745e15eee43
2011-08-07 01:17:04 +00:00
mkanat%bugzilla.org
c74dbd937f Bug 676237: The traceback in code-error.html.tmpl is displayed on a single line
r=glob a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@262575 18797224-902f-48f8-a5cc-f745e15eee43
2011-08-04 11:02:40 +00:00
mkanat%bugzilla.org
828bb54e29 Bug 647466: Allow Search.pm to take the new URL syntax for custom search
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@262132 18797224-902f-48f8-a5cc-f745e15eee43
2011-04-02 19:02:29 +00:00
mkanat%bugzilla.org
7090d28190 Allow extensions to add new Jobs. r,a=mkanat.
git-svn-id: svn://10.0.0.236/trunk@261708 18797224-902f-48f8-a5cc-f745e15eee43
2011-01-05 12:01:59 +00:00
mkanat%bugzilla.org
6baae2406b Bug 622105 - Misspelling in setting_info_invalid error message
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@261702 18797224-902f-48f8-a5cc-f745e15eee43
2010-12-30 16:46:44 +00:00
mkanat%bugzilla.org
bf65c495ef Another unused error tag
git-svn-id: svn://10.0.0.236/trunk@261446 18797224-902f-48f8-a5cc-f745e15eee43
2010-10-22 14:18:28 +00:00
mkanat%bugzilla.org
0f6811ce30 Bug 590334: Change Bug.pm to use the comment object (Bugzilla::Comment)
when creating or updating bug comment
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@261388 18797224-902f-48f8-a5cc-f745e15eee43
2010-10-13 23:37:31 +00:00
mkanat%bugzilla.org
a77eb64833 Bug 119703: Create an attachment by pasting it into a text field
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260809 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-18 17:31:54 +00:00
mkanat%bugzilla.org
061024e4b6 Bug 578258: Calling votes.cgi with no arguments should either display the user's votes, or give a better error message if the extension is disabled
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260797 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-16 09:46:34 +00:00
mkanat%bugzilla.org
3a3bb31f75 Remove unsused error tag left by bug 578904
git-svn-id: svn://10.0.0.236/trunk@260780 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-15 10:46:42 +00:00
mkanat%bugzilla.org
c501f77423 Bug 578739: Instead of removing REFERENCES from _bz_real_schema and then
populating FKs from _bz_schema at the end of checksetup, store REFERENCES
in _bz_real_schema with a special "created => 0" key that tells us that
we still need to create the FK.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260775 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 22:46:37 +00:00
mkanat%bugzilla.org
ac502cce7f Bug 574556: Refactor Search.pm so that we're not doing $$some_var everywhere.
Instead, we pass around a hashref and update the hashref. This patch also
includes some cleanup for bugs surrounding percentage_complete,
attachments.isobsolete, attachments.ispatch, and owner_idle_time.
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260676 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 18:31:53 +00:00
mkanat%bugzilla.org
f7fcd61887 Bug 490930: Always store attachments locally if they are over X size (and below some threshold!), don't ever display "Big File" checkbox
r=mkanat a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260674 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 17:03:37 +00:00
mkanat%bugzilla.org
a3d7656f23 Bug 556422: Move the existing bug-moving functionality into an extension
called OldBugMove.
r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260491 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-18 21:16:53 +00:00
mkanat%bugzilla.org
29d1c47764 Bug 567303: Implement a working algorithm for sorting fields based on
VALIDATOR_DEPENDENCIES in Bugzilla::Object. (The previous code did not
actually sort fields correctly.)
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260370 18797224-902f-48f8-a5cc-f745e15eee43
2010-05-24 23:01:27 +00:00
mkanat%bugzilla.org
ecf0f13ce8 Bug 565879: Merge ThrowCodeError("action_unrecognized"), ThrowUserError("no_valid_action") and ThrowCodeError("unknown_action")
r=ghendricks a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260347 18797224-902f-48f8-a5cc-f745e15eee43
2010-05-20 15:46:29 +00:00
mkanat%bugzilla.org
265b1534e0 Bug 565899: Make the html_linebreak filter safe by having it first call the
"html" filter
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260339 18797224-902f-48f8-a5cc-f745e15eee43
2010-05-19 17:33:03 +00:00
mkanat%bugzilla.org
b92943e7da Need to do FILTER html FILTER html_linebreak to actually have a safe filter.
git-svn-id: svn://10.0.0.236/trunk@260311 18797224-902f-48f8-a5cc-f745e15eee43
2010-05-14 14:46:22 +00:00
mkanat%bugzilla.org
557a8ef428 Bug 372537: Improve CodeErrors: show the traceback (without function
arguments)
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260307 18797224-902f-48f8-a5cc-f745e15eee43
2010-05-14 14:16:24 +00:00
mkanat%bugzilla.org
24a1aa979c Bug 565880: Do not throw an error when obsoleting an already obsolete attachment
a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260306 18797224-902f-48f8-a5cc-f745e15eee43
2010-05-14 13:46:25 +00:00
mkanat%bugzilla.org
1283f228a8 Bug 565881: 'flag_status_invalid' and 'request_queue_group_invalid' should be user errors, not code errors
a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260303 18797224-902f-48f8-a5cc-f745e15eee43
2010-05-14 13:31:27 +00:00
mkanat%bugzilla.org
a7a8f13d61 Bug 554986: Add a "notmatches" search type, which allows the minus sign
operator to start working for bare words in Quicksearch again
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260094 18797224-902f-48f8-a5cc-f745e15eee43
2010-03-29 21:16:23 +00:00
mkanat%bugzilla.org
96dac4dc29 Fix bustage (unused error tag)
git-svn-id: svn://10.0.0.236/trunk@259802 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-24 17:32:02 +00:00
mkanat%bugzilla.org
e714a3b2bd Move the no_open_bug_status code error into the Voting extension.
git-svn-id: svn://10.0.0.236/trunk@259710 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-16 00:01:42 +00:00
mkanat%bugzilla.org
c6376a2cf8 Bug 515568: handle_login() doesn't check $@ after eval
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259634 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-06 18:02:40 +00:00
lpsolit%gmail.com
b9168f54ae Bug 467992: Login fails if the user's LDAP account is denied search in LDAP - Patch by Adam Batkin <adam@batkin.net> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@259335 18797224-902f-48f8-a5cc-f745e15eee43
2010-01-05 08:32:54 +00:00
mkanat%bugzilla.org
4af90d4d96 Bug 452919: Allow the "created an attachment" message in comments to be localized
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259167 18797224-902f-48f8-a5cc-f745e15eee43
2009-12-04 14:28:49 +00:00
lpsolit%gmail.com
f0aaf685c2 Fix bustage: the 'extension_invalid' error tag is no longer used
git-svn-id: svn://10.0.0.236/trunk@259072 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-24 08:25:51 +00:00
mkanat%bugzilla.org
53ff949198 Fix test failures caused by check-in of bug 430014.
git-svn-id: svn://10.0.0.236/trunk@259071 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-24 06:34:17 +00:00
mkanat%bugzilla.org
98a5bbf59c Bug 430014: Re-write the code hooks system so that it uses modules instead of individual .pl files
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> (module owner) a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259069 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-24 06:09:55 +00:00
lpsolit%gmail.com
3e2b29299a Bug 529495: The open bracket is missing for a directive in global/code-error.html.tmpl - Patch by A.A. Shimono (himorin) <shimono+bug@gmail.com> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@259018 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-18 14:34:04 +00:00
mkanat%bugzilla.org
66337c4c5d Bug 519142: Replace IF/ELSE statements about bug_status/resolution with just a display_value call, and use display_value in more places to translate field values.
Patch by Vitaly Fedrushkov <vitaly.fedrushkov@gmail.com> r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259009 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-18 07:05:01 +00:00
lpsolit%gmail.com
66ba27983a Bug 460742: The type should be mandatory to create a custom field - Patch by Nitish Bezzala <nbezzala@yahoo.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@258823 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-30 01:14:12 +00:00
mkanat%bugzilla.org
bc7313feed Bug 520948: Use Bugzilla->feature and feature_enabled everywhere instead of checking if modules are installed
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@258771 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-24 05:21:11 +00:00
mkanat%bugzilla.org
4f5ccb8607 Bug 509053: Implement Bugzilla->feature (feature_enabled in the templates), and use it to detect when PatchReader is available.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@258543 18797224-902f-48f8-a5cc-f745e15eee43
2009-09-30 22:39:32 +00:00
mkanat%bugzilla.org
5dac8a0993 Bug 512623: Change get_status and get_resolution to display_value everywhere.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@258542 18797224-902f-48f8-a5cc-f745e15eee43
2009-09-30 22:35:47 +00:00