54 Commits

Author SHA1 Message Date
vladd%bugzilla.org
f8f03ad352 Spelling in code comments patch: 'extention' -> 'extension' in duplicates.cgi; patch by Vlad Dascalu <vladd@bugzilla.org>.
git-svn-id: svn://10.0.0.236/trunk@200265 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-19 12:16:22 +00:00
lpsolit%gmail.com
eba2e330c1 Bug 338796: Remove get_product_* from globals.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@200219 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-17 23:12:36 +00:00
lpsolit%gmail.com
695eb8839f Bug 330698: Remove $::components, @::enterable_products and $::classifications (and some others) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@193396 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-02 19:07:14 +00:00
lpsolit%gmail.com
25b150c3ca Bug 313695: buglist.cgi and some other scripts do not use the shadow DB anymore - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=justdave
git-svn-id: svn://10.0.0.236/trunk@184545 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-13 17:50:47 +00:00
lpsolit%gmail.com
64f1a95f02 Bug 304075: Eliminate use of $::userid from Bugzilla - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@183259 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-30 21:31:29 +00:00
lpsolit%gmail.com
71b92a32ff Bug 303693: Eliminate deprecated Bugzilla::DB routines from describe*.cgi, duplicates.cgi, quips.cgi, report.cgi, request.cgi and showdependency*.cgi - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=LpSolit a=myk
git-svn-id: svn://10.0.0.236/trunk@183054 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-26 16:15:50 +00:00
lpsolit%gmail.com
e334b85a95 Bug 312157: Remove $::template and $::vars from globals.pl - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182927 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-24 23:11:56 +00:00
lpsolit%gmail.com
25b4d9f717 Bug 286158: Remove GetSelectableProducts() from globals.pl and use Bugzilla::User::get_selectable_products() instead - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel,kiko a=justdave
git-svn-id: svn://10.0.0.236/trunk@179575 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-02 21:12:10 +00:00
lpsolit%gmail.com
75150a5a61 Bug 208761: Move GetFormat() from globals.pl into Bugzilla::Template - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@178944 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-25 14:02:41 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
bugreport%peshkin.net
73743f82c5 Bug 234825: Keep duplicates.cgi from revealing products user doesnt have access to
r,a=justdave


git-svn-id: svn://10.0.0.236/trunk@158974 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-10 07:17:02 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
jocuri%softhome.net
fbb3f67f56 Patch for bug 237369: implement relatively simple changes from %FORM to $cgi->param variable; patch by Teemu Mannermaa <wicked@etlicon.fi>; r=kiko, justdave; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@154313 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-26 21:00:11 +00:00
bbaetz%acm.org
8fabd677ea Bug 208604 - Make data/template dir locations configurable
git-svn-id: svn://10.0.0.236/trunk@149624 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-22 03:50:42 +00:00
gerv%gerv.net
bbabf0eed3 Bug 186130 - collectstats.pl doesn't work if 'requirelogin' set. Patch by gerv; r=bbaetz, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@149030 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-08 00:26:41 +00:00
jocuri%softhome.net
82648d036a Bug 221900: duplicates.cgi query fails if more than one product selected; patch by chaduv <caduvall@glue.umd.edu>; r=gerv; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@148400 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-26 14:01:04 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
burnus%gmx.de
a88e744506 Bug 200198 - user-error.html.tmpl's use [% changedsince %] instead of $changedsince
r=gerv, a=justdave


git-svn-id: svn://10.0.0.236/trunk@141897 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-28 18:29:37 +00:00
justdave%syndicomm.com
8b2db2db3d Bug 192677: Add new test to flag failure-to-filter situations in the templates, and correct the XSS holes that were discovered as a
result of it.
Patch by Gervase Markham <gerv@mozilla.org>
r= myk, bbaetz, justdave
a= justdave


git-svn-id: svn://10.0.0.236/trunk@141754 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-24 20:49:52 +00:00
bbaetz%acm.org
6ee31579fe Bug 199813 - Make all users of ThrowUserError pass $vars in explicitly.
r=gerv
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140585 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-02 12:35:07 +00:00
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-27 00:07:02 +00:00
bbaetz%acm.org
eaa2d33a5a Bug 191863 - Clean up Bugzilla.pm
r=gerv, justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@137528 18797224-902f-48f8-a5cc-f745e15eee43
2003-02-07 07:19:15 +00:00
bbaetz%student.usyd.edu.au
583c1c6256 Bug 163290 - move DB handling code into a module
r=justdave, myk, joel, preed
a=justdave


git-svn-id: svn://10.0.0.236/trunk@136312 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-14 20:00:11 +00:00
bbaetz%student.usyd.edu.au
18684acf40 Bug 176599, Improve performance of duplicates.cgi
original patch iteration by gerv, change to use Bugzilla:Search by me
r=myk, a=justdave


git-svn-id: svn://10.0.0.236/trunk@133520 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-10 02:50:39 +00:00
myk%mozilla.org
3b7adf5ab7 Fix for bug 178776: Eliminates warning in duplicates.cgi.
git-svn-id: svn://10.0.0.236/trunk@133359 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-08 02:05:20 +00:00
myk%mozilla.org
1e4cfb771d Fix for bug 156548: XUL implementation of duplicates report.
git-svn-id: svn://10.0.0.236/trunk@132978 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-05 01:54:15 +00:00
gerv%gerv.net
2ef1dd25a6 Bug 173808 - Use of uninitialized value in subtraction (-) at duplicates.cgi line 133. Patch by gerv; r=bbaetz.
git-svn-id: svn://10.0.0.236/trunk@131785 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-11 06:30:09 +00:00
bugreport%peshkin.net
2194da2336 bug 157756 - Groups_20020716_Branch Tracking : > 55 groups now supported
r=bbaetz, gerv


git-svn-id: svn://10.0.0.236/trunk@130217 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-22 17:15:13 +00:00
gerv%gerv.net
241f6ae46e Bug 146495 - clean up format ambiguities. We now have separate "format" and "ctype" parameters. Also fixes bug 140513, bug 143604, and bug 148133. Patch by gerv; r=myk.
git-svn-id: svn://10.0.0.236/trunk@129841 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-17 23:28:24 +00:00
gerv%gerv.net
ee2413046e Bug 167978 - Fix Throw*Error l10n regressions and add a test to catch more. Patch by gerv; r=bbaetz.
git-svn-id: svn://10.0.0.236/trunk@129434 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-12 22:51:50 +00:00
bbaetz%student.usyd.edu.au
71381b40ed Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
r=joel x2


git-svn-id: svn://10.0.0.236/trunk@128080 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-26 06:17:26 +00:00
gerv%gerv.net
c069c70dfc Bug 162068 - Fix callers of ThrowUserError to use messages.html.tmpl. Patch by gerv; r=bbaetz.
git-svn-id: svn://10.0.0.236/trunk@127416 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-15 22:57:21 +00:00
bbaetz%student.usyd.edu.au
1c2ecdc9c2 Bug 43600 - Convert products/components to use ids instead of names.
Initial attempt by jake@bugzilla.org, updated by me
r=joel, preed


git-svn-id: svn://10.0.0.236/trunk@127057 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-12 05:43:05 +00:00
gerv%gerv.net
0d47ee3f81 Bug 155584 - Opening duplicates.cgi with no frequent bugs causes SQL syntax error. Patch by gerv; r=bbaetz.
git-svn-id: svn://10.0.0.236/trunk@126991 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-10 09:53:32 +00:00
gerv%gerv.net
426eb6f081 Bug 151281 - change duplicates.cgi to make one query instead of several thousand. Patch by gerv; r=myk, bbaetz.
git-svn-id: svn://10.0.0.236/trunk@124293 18797224-902f-48f8-a5cc-f745e15eee43
2002-06-28 20:02:09 +00:00
gerv%gerv.net
4d7de54334 Bug 138994 - split up duplicates.html.tmpl. Patch by gerv; r=myk, bbaetz.
git-svn-id: svn://10.0.0.236/trunk@120032 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-26 23:18:57 +00:00
gerv%gerv.net
c8a771fb68 Bug 138588 - change to use new template structure. Patch by gerv, r=myk, afranke.
git-svn-id: svn://10.0.0.236/trunk@119695 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-24 07:24:50 +00:00
bbaetz%student.usyd.edu.au
bab19bde2c Bug 125427 - Taint error in duplicates.cgi with perl < 5.6
r=gerv, myk


git-svn-id: svn://10.0.0.236/trunk@119093 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-16 08:25:52 +00:00
gerv%gerv.net
9f63585fa5 Bug 199635 - templatise duplicates.cgi. Patch by gerv, r=myk, bbaetz.
git-svn-id: svn://10.0.0.236/trunk@118660 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-10 22:30:00 +00:00
justdave%syndicomm.com
c148fadef8 Fix for bug 108982: enable taint mode for all user-facing CGI files.
Patch by Brad Baetz <bbaetz@student.usyd.edu.au>
r= jake, justdave


git-svn-id: svn://10.0.0.236/trunk@112490 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-20 01:44:52 +00:00
bbaetz%cs.mcgill.ca
cced8d8047 Bug 97469 - Assignee/QA/Reporter/CC don't get email on restricted bugs.
Also fixes seeing bugs in the buglist (bug 95024), dependancy lists,
tooltips, duplicates, and everywhere else I could see which checked group
bugs.groupset == 0.

Also fxed bug 101560, by clearing BASH_ENV

r=myk,justdave


git-svn-id: svn://10.0.0.236/trunk@106051 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-23 15:44:53 +00:00
gerv%gerv.net
ad1e86251d Bug 96063 - the old method of doing this barfed on long URL strings.
git-svn-id: svn://10.0.0.236/trunk@101444 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-21 00:36:54 +00:00
justdave%syndicomm.com
0f73ab08c8 Fix for bug 95304: Add a buglist link to the top of duplicates.cgi
Patch by Gervase Markham <gerv@mozilla.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@101172 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-16 02:54:49 +00:00
justdave%syndicomm.com
33da69e9ae Fix silly syntax error I missed.
git-svn-id: svn://10.0.0.236/trunk@100907 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-13 00:48:45 +00:00
justdave%syndicomm.com
c23c8e23f0 Fix for bug 95008: duplicates page no longer ignores verified INVALID/WONTFIX bugs
Patch by Gervase Markham <gervase.markham@univ.ox.ac.au>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@100905 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-13 00:19:37 +00:00
gerv%gerv.net
cc60bb0e89 Add strikethrough to resolved bug numbers. Bug 79816. r=jake.
git-svn-id: svn://10.0.0.236/trunk@98411 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-01 20:17:28 +00:00
tara%tequilarista.org
c05fe93661 Bullshit checkin to add the fact that the previous changes also include the final fix for bug 72721. I am a buckethead
git-svn-id: svn://10.0.0.236/trunk@92737 18797224-902f-48f8-a5cc-f745e15eee43
2001-04-19 17:35:23 +00:00
tara%tequilarista.org
71888475f0 landing final patch for bug 76261
git-svn-id: svn://10.0.0.236/trunk@92733 18797224-902f-48f8-a5cc-f745e15eee43
2001-04-19 17:19:07 +00:00
justdave%syndicomm.com
b25a71e200 Fix for bug 72721 (duplicates.cgi performs poorly with lots of bugs) and bug 69054 (DB_File not portable): dependence on DB_File removed, now uses AnyDBM_File which comes standard with Perl. Duplicates.cgi now runs its queries against the shadow database if it's available, among many other improvements.
Patch by gervase.markham@univ.ox.ac.uk (Gervase Markham)
r= justdave


git-svn-id: svn://10.0.0.236/trunk@91585 18797224-902f-48f8-a5cc-f745e15eee43
2001-04-06 18:19:47 +00:00
endico%mozilla.org
575073abd0 Checking in Jake's <jake@acutex.net> interim patches from bug 30694. Bugzilla was showing bug summaries to everyone, even if they didn't have permission to view the bug. Jake's quick solution is to not display the bug at all if it is in a group no matter who is viewing it. The correct solution would be display the summary if the viewer had the proper permissions.
git-svn-id: svn://10.0.0.236/trunk@89378 18797224-902f-48f8-a5cc-f745e15eee43
2001-03-12 22:35:51 +00:00