129 Commits

Author SHA1 Message Date
sspitzer%mozilla.org
f577577691 fix for bug #375677: Deleting 5 or more bookmarks at once in Bookmarks Manager seriously messes up the bookmark handling.
fix by Todd Agulnick <toddsf@gmail.com>.

r=sspitzer


git-svn-id: svn://10.0.0.236/trunk@225597 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-04 19:30:40 +00:00
sspitzer%mozilla.org
ad2f3218b9 fix for regression bug #364018
cannot drag and drop url from location bar or webpage to bookmark toolbar.

r=mano


git-svn-id: svn://10.0.0.236/trunk@217483 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-27 21:51:06 +00:00
sayrer%gmail.com
eba310c07d Bug 361030. Bookmarks refresh problem due to JS error code. r=sspitzer/jminta
git-svn-id: svn://10.0.0.236/trunk@216833 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-10 22:40:39 +00:00
sspitzer%mozilla.org
12df9d9a2e fix for bug #342930: "You have asked to open [lots of] tabs at once" should read "You are about to open..."
backporting the fix from the MOZILLA_1_8_BRANCH to work on the trunk (both with places enabled and without)

r=dietrich, original patch r=mconnor, ui-r=beltzner


git-svn-id: svn://10.0.0.236/trunk@213472 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-10 23:19:01 +00:00
myk%mozilla.org
90c982b4f5 bug 346818: make sure microsummary bookmark records in the bookmarks datastore really exist (i.e. they aren't for cut or deleted bookmarks, which don't get completely removed from the datastore until restart) so we don't hit an error when trying to update them; also, trap errors when updating microsummary bookmarks, so an exception for one update doesn't hork the rest of them; finally, add microsummary properties to the bookmark transaction manager, so they get saved and restored the way they are supposed to be saved and restored when bookmarks are cut and pasted
r=mconnor


git-svn-id: svn://10.0.0.236/trunk@208360 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-24 22:30:07 +00:00
gavin%gavinsharp.com
27872df3d4 Bug 346447: loadFolderAndReplace=false ignores "loading" tabs, patch by Pablo Greco <pablo@fliagreco.com.ar>, r=mano
git-svn-id: svn://10.0.0.236/trunk@206773 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-07 23:01:32 +00:00
sspitzer%mozilla.org
af287a53ef fix for bug #344040: when warning on "opening too many tabs", only count non-deleted bookmarks (and not folders or separators)
the places version of this fix has already been checked in.  this is the RDF bookmarks version, to keep the trunk in sync with the branch.

r=ben


git-svn-id: svn://10.0.0.236/trunk@204954 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-27 18:17:11 +00:00
jminta%gmail.com
1923b801b9 Bug 342110 crash when copying and pasting bookmark folder [@ nsBookmarksService::UpdateBookmarkForwardProxy], r=sspitzer, sr=mconnor
git-svn-id: svn://10.0.0.236/trunk@200895 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-26 18:32:22 +00:00
gavin%gavinsharp.com
53476811b7 Bug 339368: Copying a live bookmark copies the (random) location/href rather than the feedurl, patch by Phil Ringnalda <philringnalda@gmail.com>, r=mano
git-svn-id: svn://10.0.0.236/trunk@200801 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-24 13:24:35 +00:00
myk%mozilla.org
27bc917bd1 declare some variables before assigning them to avoid JS warnings
patch by Simon Bünzli
bug=342458
r=myk


git-svn-id: svn://10.0.0.236/trunk@200672 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-23 05:55:20 +00:00
myk%mozilla.org
42e259abec add a bookmarks context menu item for refreshing a microsummary; bug=341555; r=mconnor; a=mconnor for 1.8 branch
git-svn-id: svn://10.0.0.236/trunk@200370 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-19 23:16:27 +00:00
jminta%gmail.com
27166e0dfd Bug 168411 Move bookmarks transactions into a JS service (adding a bookmark leaks the Add Bookmark dialog) r=sspitzer, sr+a=mconnor
git-svn-id: svn://10.0.0.236/trunk@200050 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-15 21:58:43 +00:00
sspitzer%mozilla.org
8125eb6ae0 keep trunk in sync with the 1.8 branch
fix bug #333734 (Protect against opening too many tabs at once, r=ben)
fix bug #339290 (unable to paste links into the organize bookmarks dialog, r=mconnor)
fix bug #336488 (search bookmarks broken, r=gavin)


git-svn-id: svn://10.0.0.236/trunk@200014 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-15 18:30:57 +00:00
myk%mozilla.org
35b16d7a9a Work around XUL template builder regression on trunk and possibly marginally improve performance.
bug=336857
r=enndeakin
sr=ben
a=mconnor for checkin to 1.8 branch


git-svn-id: svn://10.0.0.236/trunk@198184 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-22 19:25:20 +00:00
gavin%gavinsharp.com
b3f630168f Small whitespace change to sync 1.8 branch/trunk
git-svn-id: svn://10.0.0.236/trunk@198084 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-20 16:33:43 +00:00
roc+%cs.cmu.edu
e9fd34c810 Bug 331522. By default, do not allow keyword searches when navigating to URLs; modify browser UI code to enable keyword searches only on selected URL input mechanisms (e.g., typed into the URL bar). r+sr=darin,r=mconnor
git-svn-id: svn://10.0.0.236/trunk@193458 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-03 23:17:51 +00:00
cbiesinger%web.de
86be7ed52e bug 325177 r=darin sr=bz
- add a "request" parameter to nsIContentSniffer
- make the unknowndecoder implement nsIContentSniffer
- make nsBaseChannel do type detection via nsIContentSniffer rather than a
  stream converter


git-svn-id: svn://10.0.0.236/trunk@190362 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-17 16:54:27 +00:00
beng%bengoodger.com
1f171ff718 308396 - UE improvements for tabbed browsing in response to usability studies conducted. In particular, add close buttons to tabs, improve the reselection behavior of new tabs opened especially in single window mode, simplify the preferences available for tabs, and improve the visual appearance of keyboard-focused tabs. r=mconnor.
git-svn-id: svn://10.0.0.236/trunk@187925 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-20 23:04:26 +00:00
gavin%gavinsharp.com
9cb6d8f5e1 Removing old comment, no bug, r=mano over IRC
git-svn-id: svn://10.0.0.236/trunk@185019 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-20 22:08:00 +00:00
mozilla.mano%sent.com
01b991f2ac Bug 301048 - Copying a single bookmark should not append a new line to the end of the URL. patch from Adam Guthrie <ispiked@gmail.com>, r=me.
git-svn-id: svn://10.0.0.236/trunk@181451 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-02 21:47:26 +00:00
vladimir%pobox.com
ee805b144f b=222883, get rid of manage folder, r=mconnor
git-svn-id: svn://10.0.0.236/trunk@180662 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-20 20:00:15 +00:00
mozilla.mano%sent.com
fec7abbdba Bug 243235 - Remove Expand / Collapse bookmark folders UI. r=mconnor.
git-svn-id: svn://10.0.0.236/trunk@180627 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-20 02:03:16 +00:00
mozilla.mano%sent.com
7e30946c61 Bug 308888 - Alt+clicking bookmark in sidebar gives 'Error: saveURL is not defined'. r=mconnor.
git-svn-id: svn://10.0.0.236/trunk@180476 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-17 23:03:12 +00:00
gavin%gavinsharp.com
364a5b9987 Bug 276506: Extra blank tabs not removed when opening bookmark folder in background, patch by Phil Ringnalda <bugzilla@philringnalda.com>, r=vlad
git-svn-id: svn://10.0.0.236/trunk@179607 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-03 02:01:58 +00:00
ben%bengoodger.com
b6bf50b454 305134 - remove feedview from firefox 1.5 and 1.6x pending architecture redesign. r=mconnor
git-svn-id: svn://10.0.0.236/trunk@179066 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-26 18:22:08 +00:00
ben%bengoodger.com
73c66a13c6 303848 - integrate feedview better with firefox browser code/live bookmarking system.
this is an initial stab at implementing a design I'm working on with Mike Beltzner
here: http://wiki.mozilla.org/Firefox:1.1_RSS_Pretty_Print


git-svn-id: svn://10.0.0.236/trunk@177609 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-12 00:34:19 +00:00
aaronleventhal%moonset.net
3dc65e9b9a Bug 249136. Focus and key navigation broken for links opened in new tabs. r=mconnor, r=timeless, a=bsmedberg
git-svn-id: svn://10.0.0.236/trunk@177231 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-06 04:20:13 +00:00
vladimir%pobox.com
4ff59921cf b=255255, make bookmarks search results editable, r=vladimir,a=mconnor
git-svn-id: svn://10.0.0.236/trunk@176219 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-18 21:06:43 +00:00
mozilla.mano%sent.com
171de242f0 Bug 297945 (Firefox keeps loading favicon.... forever). patch from Christian Schmidt <bugzilla.mozilla.org@chsc.dk>, r=vlad, a=asa.
git-svn-id: svn://10.0.0.236/trunk@175163 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-27 05:28:28 +00:00
timeless%mozdev.org
7ed382b9d2 Bug 297668 Javascript strict warnings in bookmarks.js
patch by r.bezut@laposte.net r=mconnor a=asa


git-svn-id: svn://10.0.0.236/trunk@174673 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-16 04:12:46 +00:00
mozilla.mano%sent.com
7ed8963464 Bug 287885 - Error: redeclaration of const ADD_BM_DIALOG_FEATURES. r=mconnor, a=asa
git-svn-id: svn://10.0.0.236/trunk@172539 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-21 09:29:59 +00:00
mozilla.mano%sent.com
0993d71f04 Bug 290714 - Don't use reserved const names in bookmarks/content. r=mconnor, a=asa
git-svn-id: svn://10.0.0.236/trunk@172434 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-19 15:17:04 +00:00
mozilla.mano%sent.com
c2aa877a84 Bug 287924 - Bookmarks > Manage Bookmarks > Move does not work. r=mconnor
git-svn-id: svn://10.0.0.236/trunk@171252 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-27 20:28:48 +00:00
bsmedberg%covad.net
f4f72beaa1 Bug 282057 - brand.dtd/properties live in the wrong chrome package... xulrunner apps cannot provide these files, which means they can't use various toolkit features r=darin moa=Neil (seamonkey)
git-svn-id: svn://10.0.0.236/trunk@170499 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-10 04:38:35 +00:00
cbiesinger%web.de
af30395567 181938 allow any protocol to support redirection, using a new
nsIChannelEventSink interface.
r=darin sr=bz


git-svn-id: svn://10.0.0.236/trunk@170312 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-07 19:46:06 +00:00
mozilla.mano%sent.com
fb6e034de3 Bug 227526 - open in tabs menu item doesn't work when no windows are open
git-svn-id: svn://10.0.0.236/trunk@169478 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-19 07:15:09 +00:00
mozilla.mano%sent.com
398c3d0ac5 Bug 228165 - Add Bookmark dialog should be shown as a sheet on Mac OS X. r=vladimir
git-svn-id: svn://10.0.0.236/trunk@169475 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-19 06:16:18 +00:00
bugzilla%arlen.demon.co.uk
b1a8c5fb5c Bug 277490 Retrieve site description from meta tag when adding bookmark
p=gavin.sharp@gmail.com r=vladimir


git-svn-id: svn://10.0.0.236/trunk@169297 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 00:17:12 +00:00
gerv%gerv.net
c9c6bdd186 Bug 236613: change to MPL/LGPL/GPL tri-license.
git-svn-id: svn://10.0.0.236/trunk@168642 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-01 17:36:54 +00:00
timeless%mozdev.org
0d16db2f34 Bug 240947 use content instead of _content
r=mconnor based on r=neil sr=dveditz for the original pass


git-svn-id: svn://10.0.0.236/trunk@168443 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-28 16:06:56 +00:00
ben%bengoodger.com
634116d6c6 Landing the Aviary Branch (browser section only).
git-svn-id: svn://10.0.0.236/trunk@165934 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-30 08:23:02 +00:00
vladimir%pobox.com
7e43ce265c b=255151/262304, landing changes that got half-merged to trunk from aviary; smoketest fix; r=vladimir,a=ben
git-svn-id: svn://10.0.0.236/trunk@163329 18797224-902f-48f8-a5cc-f745e15eee43
2004-10-07 00:11:25 +00:00
p_ch%verizon.net
185171bdfc Bug 241987 followup including reviewer comment.
p=Daniel Lindkvist <gorgias@home.se>, r=vlad, sr=ben.


git-svn-id: svn://10.0.0.236/trunk@161836 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-07 00:08:20 +00:00
p_ch%verizon.net
e096bdea6f Bug 241987: Export bookmarks doesn't save the bookmarks to a file like bookmarks.html
p=Daniel Lindkvist <gorgias@home.se>, r=vlad, sr=ben


git-svn-id: svn://10.0.0.236/trunk@161833 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-06 20:28:38 +00:00
kyle.yuan%sun.com
5653c696d2 Bug 241731 bookmarks sidebar creates empty contextmenu when no items are selected
r=mconnor
do not popup context menu when selection is undefined.


git-svn-id: svn://10.0.0.236/trunk@161565 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-01 02:59:05 +00:00
p_ch%verizon.net
c30703c9a5 Bug 235243: Need drag and drop feedback for toolbar bookmarks (and menuitem bookmarks for gtk2).
In addition to the DND feedback, this patch:
- introduces a new var 'BookmarksInsertion' that 'encapsulates' DND feedback
display.
- rewrite the rtl handling related to DND. BookmarksInsertion deals with this
subtleties and the "public" feedback orientation ("before"|"on"|"after")
returned by BookmarksInsertion.getOrientation refers now to the DOM.
- paste and copy commands on the menus now insert after the rclicked element.
The hack that appended everything at the end of the container has been removed
or more accurately replaced by another one that is at least invisible to the
user and we already used for DND. The problem is due a problem with the content
building of containers with siblings (open in tabs stuff) not generated by the
bookmarks template.
- usual small glitch fixing.


git-svn-id: svn://10.0.0.236/trunk@161271 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-25 20:24:14 +00:00
steffen.wilberg%web.de
8f6ad1b8ed Bug 255877: right-clicking an expanded bookmarks folder shows 'Collapse(X)'. r=mconnor, a/chofmann
git-svn-id: svn://10.0.0.236/trunk@161049 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-20 10:26:34 +00:00
vladimir%pobox.com
ea73dbe550 b=255931, favicons should validate content type before saving, a=ben
git-svn-id: svn://10.0.0.236/trunk@160873 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-17 22:27:04 +00:00
ben%bengoodger.com
7930972a4e 245984 - bookmarks context menu lacks mnemonics.. patch from Asaf Romano, r+a=ben@mozilla.org
git-svn-id: svn://10.0.0.236/trunk@160581 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-10 00:38:31 +00:00
vladimir%pobox.com
63de84a60f bookmarks fixes merged from aviary branch:
192624 - empty bookmark folder should show "(Empty)"
202798 - customizing toolbar in fullscreen mode breaks menus (bandaid)
221482 - bookmarks toolbar temporarily cleared when clicking restore default set in customize
232089 - bookmarks 'create in' shouldn't persist
234089 - bookmarks toolbar folder shouldn't be deletable with C-x (crasher)
238661 - moving a bookmark folder to itself deletes the folder
250179 - bookmarks toolbar wonky after customization
250820 - toolbar icon state/context menu/etc. broken after returning from fullscreen mode
251988 - livemark menu doesn't work after going to page without livemark and clicking
251335 - bookmarks toolbar folder has different context menu from other bookmark folders
251802 - refresh livemark doesn't work from toolbar/menu
252053 - make bookmarks use SafeOutputStream (dwitte)
252133 - new bookmarks items should be added below selected items, not above
252792 - livemark context menu contains active new folder menu item
252870 - context menu of empty personal toolbar folder has inconsistent items
252875 - bookmarks root name not localizable


git-svn-id: svn://10.0.0.236/trunk@160122 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-30 06:25:41 +00:00