60 Commits

Author SHA1 Message Date
mkanat%bugzilla.org
8323e09c40 Bug 342869: Use Bugzilla->params everywhere except templates
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201499 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:26:22 +00:00
vladd%bugzilla.org
7c5ec076c2 Spelling in code comments patch: 'cokie' -> 'cookie'; patch by Vlad Dascalu <vladd@bugzilla.org>.
git-svn-id: svn://10.0.0.236/trunk@200286 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-19 14:40:38 +00:00
lpsolit%gmail.com
d2d8d03d4d Bug 340104: Move Bugzilla::Auth::get_netaddr() in Util.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=justdave
git-svn-id: svn://10.0.0.236/trunk@198934 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-03 12:23:13 +00:00
lpsolit%gmail.com
757ecbfffe Bug 282687: LDAP: TLS Support - Patch by guillomovitch@zarb.org r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@198866 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-02 11:52:49 +00:00
lpsolit%gmail.com
a86e18ff63 Bug 339858: Remove useless module dependencies in Bugzilla::Auth::* - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@198782 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-01 00:19:36 +00:00
mkanat%bugzilla.org
cc5b211d4e Bug 338573: Auth could throw an insecure dependency error if username is tainted
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@198684 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-30 21:19:09 +00:00
mkanat%bugzilla.org
7da2224511 Bug 320751: LDAP: Ability to have Bugzilla use the LDAP username directly as the Bugzilla username
Patch By guillomovitch@zarb.org r=mkanat, a=myk


git-svn-id: svn://10.0.0.236/trunk@198683 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-30 21:17:34 +00:00
lpsolit%gmail.com
6ebf297b90 Bug 337661: LDAP user login failure: Can't locate object method "realname" via package "Bugzilla::User" - Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@196529 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-15 16:13:02 +00:00
mkanat%bugzilla.org
caee2e9858 Bug 300410: Bugzilla::Auth needs to be restructured to not require a BEGIN block
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@196368 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-12 02:41:22 +00:00
jocuri%softhome.net
eeffbbf891 Patch for bug 216902: support LDAPS connections; patch by Christian Krause <chkr@plauener.de>, r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@191769 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-04 12:08:31 +00:00
jocuri%softhome.net
ee5d7dbef6 Patch for bug 161369: Strip trailing whitespace from login usernames; patch by Paul <pdemarco@zoominternet.net>, r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@191689 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-03 12:29:07 +00:00
jocuri%softhome.net
3ce2403dba Fix invalid POD formatting (patch for fixing broken tree - runtests.pl, test 11).
git-svn-id: svn://10.0.0.236/trunk@191397 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-28 15:23:32 +00:00
lpsolit%gmail.com
32a389539f Bug 327355: Email preferences are not set correctly when the user account is created by Env.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel a=justdave
git-svn-id: svn://10.0.0.236/trunk@190693 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-21 16:19:57 +00:00
lpsolit%gmail.com
aef27fd4d2 Bug 322620: Logging in with 'Remember my Login' deselected gives: Use of uninitialized value in string eq at Bugzilla/Auth/Login/WWW/CGI.pm line 83 - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@187180 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-09 19:09:46 +00:00
lpsolit%gmail.com
ce5afec6fe Bug 322244: Cookies are incorrectly detainted when logging out - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@186983 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-05 15:14:06 +00:00
lpsolit%gmail.com
6248e4f445 Bug 119524: SECURITY: predictable sessionid (Use a token instead of logincookie) - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@186852 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-03 14:45:22 +00:00
lpsolit%gmail.com
6ebfd36516 Bug 279716: Users have to relogin when changing their own password - Patch by Marc Schumann <wurblzap@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@185073 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-21 19:39:09 +00:00
lpsolit%gmail.com
64f1a95f02 Bug 304075: Eliminate use of $::userid from Bugzilla - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@183259 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-30 21:31:29 +00:00
bugreport%peshkin.net
205c3f3402 Bug 304583: Remove all remaining need to rederive inherited groups
Patch by Joel Peshkin <bugreport@peshkin.net>
r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@178200 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-18 20:09:37 +00:00
lpsolit%gmail.com
1483ae9789 Bug 300403: New Charts errors out, creates new 'add' user, when Env auth method is used - Patch by A. Karl Kornel <karl@kornel.name> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@176615 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-26 14:57:04 +00:00
lpsolit%gmail.com
4fe5766722 Bug 301967: Some .pm files have invalid POD syntax - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@176610 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-26 14:09:48 +00:00
mkanat%kerio.com
7e57a969dd Bug 300336: Bugzilla::Auth should not contain any exported subroutines
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175984 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-13 03:57:02 +00:00
mkanat%kerio.com
9f4486aacc Bug 298659: setting authentication to LDAP,DB fails
Patch By A. Karl Kornel <karl@kornel.name> r=glob, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175821 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-08 04:48:47 +00:00
mkanat%kerio.com
595f9c7816 Bug 285695: [PostgreSQL] Username checks for login, etc. need to be case insensitive
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175810 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-08 02:31:43 +00:00
lpsolit%gmail.com
6ff756b877 Bug 268146: mod_security complain: Invalid cookie format: Cookie value is missing #2 - Patch by Marc Schumann <wurblzap@gmail.com> r=kiko a=justdave
git-svn-id: svn://10.0.0.236/trunk@175739 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-07 11:58:22 +00:00
mkanat%kerio.com
4ffb7300db Bug 287436: [SECURITY] After having logged in, links to change the report type contain username and password
Patch By Marc Schumann <wurblzap@gmail.com> r=gerv, a=justdave


git-svn-id: svn://10.0.0.236/trunk@173308 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-12 01:54:08 +00:00
lpsolit%gmail.com
78c8efc253 Bug 290570: Bugzilla::Auth::WWW:Env uses bitwise OR - Patch by Simon Wilkinson <simon@sxw.org.uk> r=kiko a=justdave
git-svn-id: svn://10.0.0.236/trunk@172351 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-16 17:08:32 +00:00
lpsolit%gmail.com
00fb1c2cdd Bug 238877: remove %FORM from Bugzilla/Auth/Login/WWW/CGI.pm - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@171881 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-08 00:54:16 +00:00
lpsolit%gmail.com
4860e803bd Bug 258515: Errors when accessing Bugzilla over IPv6 - Patch by Marc Schumann <wurblzap@gmail.com> r=joel, a=justdave
git-svn-id: svn://10.0.0.236/trunk@171011 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-22 22:41:07 +00:00
jake%bugzilla.org
156daabf73 Bug 83044 - Any page is now capable of being a login page simply by adding the ?GoAheadAndLogin=1 option to the URL. All links have been changed to make index.cgi the default login page instead of query.cgi.
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170601 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-12 21:51:17 +00:00
mkanat%kerio.com
7f1a179da7 Bug 277782: _throw_error should unlock tables when tables are locked, automatically
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=travis, r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170180 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-05 00:18:48 +00:00
mkanat%kerio.com
744343cdb5 Bug 280499: Replace "TO_DAYS()" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@169514 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-20 07:53:17 +00:00
mkanat%kerio.com
c8f7e44c64 Bug 280494: Replace "SELECT LAST_INSERT_ID()" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@169387 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 16:01:48 +00:00
travis%sedsystems.ca
b63354eba2 Bug 280994 : Move ValidateNewUser out of globals.pl
Patch by Max Kanat-Alexander <mkanat@kerio.com>  r=vladd  a=justdave


git-svn-id: svn://10.0.0.236/trunk@169041 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-09 06:42:43 +00:00
travis%sedsystems.ca
0abffd8846 Bug 280124 : Move InsertNewUser to Bugzilla::User
Patch by Max Kanat-Alexander <mkanat@kerio.com>   r=vladd  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168579 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-31 21:04:12 +00:00
travis%sedsystems.ca
6427625246 Bug 278792 : Move Crypt() to Bugzilla::Auth
Patch by Max Kanat-Alexander <mkanat@kerio.com>   r=vladd  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168559 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-31 19:26:01 +00:00
jocuri%softhome.net
65b4fc04b7 Patch for bug 260682: Support redirecting to HTTPS always or for authenticated sessions only; patch by Byron Jones (glob) <bugzilla@glob.com.au>, r=vladd, a=myk.
git-svn-id: svn://10.0.0.236/trunk@167813 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 13:09:58 +00:00
jocuri%softhome.net
0eb3d9faf3 Patch for bug 232155: Remove uninitialized value warning from Pperl's Cookie.pm and unify code by removing redundancy; patch by Christian Reis <kiko@async.com.br> backported to 2.18 by Rob Siklos <rsiklos@adexa.com>; r=vladd,kiko, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@164116 18797224-902f-48f8-a5cc-f745e15eee43
2004-10-20 20:58:59 +00:00
jocuri%softhome.net
a45d30a5bb Patch for bug 257303: convert lastused field in logincookies from timestamp to datetime; patch by Tomas Kopal <Tomas.Kopal@altap.cz>; r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@161950 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-08 23:29:08 +00:00
bugreport%peshkin.net
9d0e5a4575 Bug 241903: Add Environment Variable Authentication for apache auth and SSO
patch by erik
r=joel
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160665 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-11 13:53:46 +00:00
bugreport%peshkin.net
9f826706c4 Bug 253588: Change Bugzilla->user to be usable even for a logged-out user
patch by erik,joel
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160163 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-31 02:27:26 +00:00
kiko%async.com.br
6196d928d3 Missing bits of fix for bug 236678: Clean up access to COOKIE global.
Murder the last remaining places in the tree where COOKIE is used;
includes a rather thorough cleanup of Bugzilla::Bug->user and a minor
doc update. r=joel, a=justdave.


git-svn-id: svn://10.0.0.236/trunk@160018 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-29 03:02:05 +00:00
kiko%async.com.br
f5b1cdca19 Fix for bug 236678: Clean up access to COOKIE global. Murder the last
remaining places in the tree where COOKIE is used; includes a rather
thorough cleanup of Bugzilla::Bug->user and a minor doc update. r=joel, a=justdave.


git-svn-id: svn://10.0.0.236/trunk@160015 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-29 02:45:38 +00:00
bugreport%peshkin.net
ba7b83aa6f Bug 241900: Allow Bugzilla::Auth to have multiple login and validation styles
patch by erik
r=joel, kiko
a=myk


git-svn-id: svn://10.0.0.236/trunk@159556 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-20 22:41:22 +00:00
bugreport%peshkin.net
dd7434d263 Backing out bug 241900
git-svn-id: svn://10.0.0.236/trunk@159043 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-12 03:48:48 +00:00
bugreport%peshkin.net
864d1bce45 Bug 241900: Allow Bugzilla::Auth to have multiple login and validation styles
patch by erik
r=joel
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159037 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-11 23:36:53 +00:00
kiko%async.com.br
93e2995ef4 Fix for bug 226754: Move InvalidateLogins into Bugzilla::Auth::CGI. Consolidates the logout code into Bugzilla::Auth::CGI, and provides
simple front-end wrappers in Bugzilla.pm for use in the CGIs we have.
r=bbaetz, joel; a=justdave.

Adds a set of constants to the logout() API which allow specifying "how
much" we should log out -- all sessions, the current session, or all
sessions but the current one.

Fixes callsites to use this new API; cleans and documents things a
bit while we're at it. Part I in the great COOKIE apocalypse.


git-svn-id: svn://10.0.0.236/trunk@154328 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 01:31:00 +00:00
justdave%syndicomm.com
4b6207788f Bug 237864: clean up leftovers from the bug 192516 checkin (some occurances of Token got missed)
r= gerv, a= justdave


git-svn-id: svn://10.0.0.236/trunk@154085 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-18 09:01:35 +00:00
kiko%async.com.br
b1230b72c2 Fix for bug 90468: Bugzilla does not log out automatically when closing
the session. Patch by toms@myrealbox.com (Toms Baugis), with minor
cleanups by me. r=kiko, a=myk.


git-svn-id: svn://10.0.0.236/trunk@151438 18797224-902f-48f8-a5cc-f745e15eee43
2004-01-16 22:46:31 +00:00
kiko%async.com.br
8ab2a9501a Fix for bug 226982: Move password change code into Bugzilla::Auth (part
1). Factored code out from Bugzilla::Auth::DB->authenticate() into
separate methods so we can use them externally. Add extra API to DB.pm,
which is currently used only internally (pending part 2). r=bbaetz, a=justdave


git-svn-id: svn://10.0.0.236/trunk@150115 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-07 02:11:00 +00:00